1. 11 Dec, 2007 7 commits
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.1-ateam · 223e57de
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      
      sql/sql_table.cc:
        Auto merged
      223e57de
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-axmrg · 961e5d3d
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      
      mysql-test/r/func_misc.result:
        Auto merged
      mysql-test/t/func_misc.test:
        Auto merged
      961e5d3d
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.1-bug30273 · 82af0276
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      
      sql/lock.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      82af0276
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.1-amain · 19c7e2c9
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      
      mysql-test/t/disabled.def:
        Auto merged
      sql/partition_info.cc:
        Auto merged
      storage/csv/ha_tina.cc:
        Auto merged
      mysql-test/r/func_misc.result:
        SCCS merged
      mysql-test/t/func_misc.test:
        SCCS merged
      19c7e2c9
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-amain · cd34354e
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.0-axmrg
      
      
      mysql-test/r/func_misc.result:
        Manual merge
      mysql-test/t/func_misc.test:
        Manual merge
      cd34354e
    • unknown's avatar
      Bug#30273 - merge tables: Can't lock file (errno: 155) · e223c320
      unknown authored
      The patch for Bug 26379 (Combination of FLUSH TABLE and
      REPAIR TABLE corrupts a MERGE table) fixed this bug too.
      However it revealed a new bug that crashed the server.
      
      Flushing a merge table at the moment when it is between open
      and attach of children crashed the server.
      
      The flushing thread wants to abort locks on the flushed table.
      It calls ha_myisammrg::lock_count() and ha_myisammrg::store_lock()
      on the TABLE object of the other thread.
      
      Changed ha_myisammrg::lock_count() and ha_myisammrg::store_lock()
      to accept non-attached children. ha_myisammrg::lock_count() returns
      the number of MyISAM tables in the MERGE table so that the memory
      allocation done by get_lock_data() is done correctly, even if the
      children become attached before ha_myisammrg::store_lock() is
      called. ha_myisammrg::store_lock() will not return any lock if the
      children are not attached.
      
      This is however a change in the handler interface. lock_count()
      can now return a higher number than store_lock() stores locks.
      This is more safe than the reverse implementation would be.
      get_lock_data() in the SQL layer is adjusted accordingly. It sets
      MYSQL_LOCK::lock_count based on the number of locks returned by
      the handler::store_lock() calls, not based on the numbers returned
      by the handler::lock_count() calls. The latter are only used for
      allocation of memory now.
      
      No test case. The test suite cannot reliably run FLUSH between
      lock_count() and store_lock() of another thread. The bug report
      contains a program that can repeat the problem with some
      probability.
      
      
      include/myisammrg.h:
        Bug#30273 - merge tables: Can't lock file (errno: 155)
        Added mutex to struct st_myrg_info (MYRG_INFO).
      sql/handler.h:
        Bug#30273 - merge tables: Can't lock file (errno: 155)
        Extended comments for handler::lock_count() and
        handler::store_lock().
      sql/lock.cc:
        Bug#30273 - merge tables: Can't lock file (errno: 155)
        Changed get_lock_data() so that the final lock_count is taken
        from the number of locks returned from handler::store_lock()
        instead of from handler::lock_count().
      sql/sql_base.cc:
        Fixed a purecov comment. (unrelated to the rest of the changeset)
      storage/myisammrg/ha_myisammrg.cc:
        Bug#30273 - merge tables: Can't lock file (errno: 155)
        Changed ha_myisammrg::lock_count() and ha_myisammrg::store_lock()
        to accept non-attached children.
        Protected ha_myisammrg::store_lock() by MYRG_INFO::mutex.
      storage/myisammrg/myrg_close.c:
        Bug#30273 - merge tables: Can't lock file (errno: 155)
        Added MYRG_INFO::mutex destruction to myrg_parent_close().
      storage/myisammrg/myrg_open.c:
        Bug#30273 - merge tables: Can't lock file (errno: 155)
        Added MYRG_INFO::mutex initialization to myrg_parent_open().
        Protected myrg_attach_children() and myrg_detach_children()
        by MYRG_INFO::mutex.
        Fixed a purecov comment. (unrelated to the rest of the changeset)
      e223c320
    • unknown's avatar
      Merge witty.:/Users/mattiasj/clones/mysql-5.1-bug32948 · 499b57fc
      unknown authored
      into  witty.:/Users/mattiasj/clones/51_push32948
      
      
      499b57fc
  2. 10 Dec, 2007 8 commits
  3. 08 Dec, 2007 1 commit
  4. 07 Dec, 2007 18 commits
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/bk/maint/50 · 7d734a87
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/maint/51
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      7d734a87
    • unknown's avatar
      Add a way to remove options which mysql-test-run.pl no longer uses. · f77684f3
      unknown authored
      
      mysql-test/mysql-test-run.pl:
        Add a way to remove options which mysql-test-run.pl no longer uses.  Since
        mysql-test-run.pl passes unrecognized options through to mysqld directly,
        it is not possible to just remove an option.  Otherwise it would be given
        to mysqld, which probably will not recognize it and will fail to start.
        
        Instead, we now explicitly ignore the option, and print a warning to
        the user.
      f77684f3
    • unknown's avatar
      Merge five.local.lan:/work/merge/mysql-5.1-build · 5708df55
      unknown authored
      into  five.local.lan:/work/merge/mysql-5.1-build-parts
      
      
      5708df55
    • unknown's avatar
      Merge trift2.:/MySQL/M51/embedtest-5.1 · 2f14c7d3
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      
      2f14c7d3
    • unknown's avatar
      Makefile.am · b82b0da9
      unknown authored
          Makefile syntax error, comment should precede the whole target.
      
      
      Makefile.am:
        Makefile syntax error, comment should precede the whole target.
      b82b0da9
    • unknown's avatar
      Merge trift2.:/MySQL/M50/push-5.0 · 1751e036
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      
      1751e036
    • unknown's avatar
      Merge trift2.:/MySQL/M50/mysql-5.0 · e12dbcde
      unknown authored
      into  trift2.:/MySQL/M50/push-5.0
      
      
      e12dbcde
    • unknown's avatar
      Merge trift2.:/MySQL/M51/embedtest-5.1 · 3e3d092e
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      
      3e3d092e
    • unknown's avatar
      Merge trift2.:/MySQL/M51/mysql-5.1 · f53d881e
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      
      mysql-test/t/disabled.def:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      f53d881e
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/bk/maint/50 · cba3ed19
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/maint/51
      
      
      sql/sql_table.cc:
        Auto merged
      cba3ed19
    • unknown's avatar
      Merge tsmith@bk-internal.mysql.com:/home/bk/mysql-5.1 · 284cb0e5
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/maint/51
      
      
      sql/sql_acl.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      mysql-test/r/grant.result:
        Manual merge
      mysql-test/t/grant.test:
        Manual merge
      284cb0e5
    • unknown's avatar
      Makefile.am · 128a754f
      unknown authored
          In the "test-bt" target, replace the call "$(MAKE) test-embedded" by the actions of that target.
      
      
      Makefile.am:
        In the "test-bt" target, replace the call "$(MAKE) test-embedded" by the actions of that target.
        
        Reason:
        For release builds, we run the tests in a tree that contains just a binary installation.
        So the Makefile is not in the test tree, and we explicitly address it in the build tree.
        This explicit path is not kept by "make", so it is missing in the sub-make.
        There seems to be no way to solve this with (portable!) "make" features -
        we could add a new variable and use it in the sub-make, but it is easier to duplicate these few lines.
      128a754f
    • unknown's avatar
      Merge tsmith@bk-internal.mysql.com:/home/bk/mysql-5.0 · a4df2210
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/maint/50
      
      
      sql/sql_table.cc:
        Auto merged
      a4df2210
    • unknown's avatar
      BUG#32817 - though CSV is marked as supported create table is rejected · 0fdc16bd
      unknown authored
                  with error 1005.
      
      CSV doesn't support nullable fields. Report descriptive error if create
      table with nullable field is requested.
      
      
      mysql-test/r/csv.result:
        A test case for BUG#32817.
      mysql-test/t/csv.test:
        A test case for BUG#32817.
      storage/csv/ha_tina.cc:
        CSV doesn't support nullable fields. Report descriptive error if create
        table with nullable field is requested.
      0fdc16bd
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/bk/maint/50 · 6e776686
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/maint/51-merge
      
      
      mysql-test/t/grant.test:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      strings/ctype-simple.c:
        Auto merged
      mysql-test/r/grant.result:
        Manual merge
      6e776686
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/bk/maint/41 · 8c033250
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/maint/50
      
      
      strings/ctype-simple.c:
        use local (null merge)
      8c033250
    • unknown's avatar
      Make tests more robust (clean up better after grant.test) · 7d3a61e1
      unknown authored
      
      mysql-test/r/grant.result:
        Update test results to .test changes
      mysql-test/t/grant.test:
        Drop users when done with them, to avoid skewing results of later tests.
        
        For example, running some test which examines the cardinality of the
        mysql.user table would fail if run right after this test, due to the
        extra users.
      7d3a61e1
    • unknown's avatar
      Move the test case for bug #20901 from create.test to grant.test, so · 20bbe71d
      unknown authored
      testing embedded server works correctly.
      
      
      mysql-test/r/create.result:
        Move one test from create.test to grant.test, because it actually tests
        privileges (and thus doesn't work with embedded server).
      mysql-test/r/grant.result:
        Move one test from create.test to grant.test, because it actually tests
        privileges (and thus doesn't work with embedded server).
      mysql-test/t/create.test:
        Move one test from create.test to grant.test, because it actually tests
        privileges (and thus doesn't work with embedded server).
      mysql-test/t/grant.test:
        Move one test from create.test to grant.test, because it actually tests
        privileges (and thus doesn't work with embedded server).
      20bbe71d
  5. 06 Dec, 2007 4 commits
    • unknown's avatar
      Fix compiler warning about wrong integer size (probably harmless) · 2632dbf6
      unknown authored
      
      sql/sql_select.cc:
        Fix compiler warning (probably harmless, wrong integer size)
      2632dbf6
    • unknown's avatar
      ctype-simple.c: Backport quick fix to remove Windows compiler warnings · 18d14b3a
      unknown authored
      
      strings/ctype-simple.c:
        Backport quick fix to remove Windows compiler warnings.
      18d14b3a
    • unknown's avatar
      Fix for · 6a4d2423
      unknown authored
         Bug#32856 testsuite parts: partition_basic_myisam fails 
                                    in pushbuild
      Skip test if symlink support is missing.
      
      
      mysql-test/suite/parts/t/partition_basic_myisam.test:
        Skip test if running on a server with disabled symlinking.
      6a4d2423
    • unknown's avatar
      Bug#32948: FKs allowed to reference partitioned table · c3fceb40
      unknown authored
      Problem: when alter to partitioned table,
      it does not see it as change of engine.
      
      Solution: If alter includes partitioning, check if it is possible
      to change engines (eg. is the table referenced by a FK)
      
      
      mysql-test/r/partition_innodb.result:
        Bug#32948: FKs allowed to reference partitioned table
        test result
      mysql-test/t/partition_innodb.test:
        Bug#32948: FKs allowed to reference partitioned table
        test case
      sql/sql_table.cc:
        Bug#32948: FKs allowed to reference partitioned table
        
        if alter to partitioning, it is the same as changing engine.
      c3fceb40
  6. 05 Dec, 2007 2 commits
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/bk/maint/50 · 80360321
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/maint/51-merge
      
      
      client/mysqldump.c:
        Auto merged
      include/my_sys.h:
        Auto merged
      libmysql/CMakeLists.txt:
        Auto merged
      libmysql/Makefile.shared:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/r/ctype_ucs.result:
        Auto merged
      mysql-test/r/func_misc.result:
        Auto merged
      mysql-test/suite/binlog/t/binlog_killed.test:
        Auto merged
      mysql-test/t/cast.test:
        Auto merged
      mysql-test/t/ctype_ucs.test:
        Auto merged
      mysql-test/t/func_misc.test:
        Auto merged
      mysql-test/t/variables.test:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/item_strfunc.h:
        Auto merged
      sql/item_timefunc.cc:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/set_var.h:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      storage/myisam/ft_boolean_search.c:
        Auto merged
      storage/myisam/ha_myisam.cc:
        Auto merged
      storage/myisam/sort.c:
        Auto merged
      strings/ctype-simple.c:
        Auto merged
      80360321
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/bk/maint/41 · a9383147
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/maint/50
      
      
      mysql-test/r/ctype_ucs.result:
        Auto merged
      mysql-test/t/ctype_ucs.test:
        Auto merged
      sql/set_var.cc:
        Auto merged
      a9383147