- 15 Oct, 2007 1 commit
-
-
kostja@bodhi.(none) authored
of the stored procedure cursors (materialized on disk).
-
- 12 Oct, 2007 3 commits
-
-
davi@moksha.com.br authored
into moksha.com.br:/Users/davi/mysql/mysql-5.1-runtime
-
davi@moksha.com.br authored
into moksha.com.br:/Users/davi/mysql/mysql-5.1-runtime
-
davi@moksha.com.br authored
If mysql_lock_tables fails because the lock was aborted, we need to reset thd->some_tables_delete, otherwise we might loop indefinitely because handler's tables are not closed in a standard way, meaning that close_thread_tables() (which resets some_tables_deleted) is not used. This patch fixes sporadical failures of handler_myisam/innodb tests which were introduced by previous fix for this bug.
-
- 11 Oct, 2007 7 commits
-
-
malff/marcsql@weblab.(none) authored
into weblab.(none):/home/marcsql/TREE/mysql-5.1-27858-b
-
malff/marcsql@weblab.(none) authored
Before this patch, failures to write to the log tables (mysql.slow_log and mysql.general_log) were improperly printed (the time was printed twice), or not printed at all. With this patch, failures to write to the log tables is reported in the error log, for all cases of failures.
-
davi@moksha.com.br authored
"DECLARE CURSOR FOR SHOW ..." is a syntax that currently appears to work, but is untested for some SHOW commands and does not work for other SHOW commands. Since this is an un-intended feature that leaked as a result of a coding bug (in the parser grammar), the correct fix is to fix the grammar to not accept this construct. In other words, "DECLARE CURSOR FOR SHOW <other commands that don't work>" is not considered a bug, and we will not implement other features to make all the SHOW commands usable inside a cursor just because someone exploited a bug.
-
anozdrin/alik@station. authored
mysql_change_user(). The problem was that THD::ull was not reset in THD::cleanup(). The fix is to reset it.
-
davi@moksha.com.br authored
-
davi@moksha.com.br authored
into moksha.com.br:/Users/davi/mysql/bugs/31409-5.1
-
davi@moksha.com.br authored
static but it's still used by another compilation unit. Remove static qualifier from do_command definition.
-
- 10 Oct, 2007 11 commits
-
-
davi@moksha.com.br authored
into moksha.com.br:/Users/davi/mysql/mysql-5.1-runtime
-
davi@moksha.com.br authored
into moksha.com.br:/Users/davi/mysql/mysql-5.1-runtime
-
davi@moksha.com.br authored
into moksha.com.br:/Users/davi/mysql/mysql-5.1-runtime
-
davi@moksha.com.br authored
into moksha.com.br:/Users/davi/mysql/mysql-5.1-runtime
-
davi@moksha.com.br authored
into moksha.com.br:/Users/davi/mysql/mysql-5.1-runtime
-
davi@moksha.com.br authored
-
davi@moksha.com.br authored
into moksha.com.br:/Users/davi/mysql/bugs/21587-5.1
-
anozdrin/alik@station. authored
of SQL_BIG_SELECTS. The bug was that SQL_BIG_SELECTS was not properly set in COM_CHANGE_USER. The fix is to update SQL_BIG_SELECTS properly.
-
anozdrin/alik@station. authored
-
anozdrin/alik@station. authored
into station.:/mnt/raid/alik/MySQL/devel/5.1-rt-merged
-
malff@lambda.hsd1.co.comcast.net. authored
-
- 09 Oct, 2007 5 commits
-
-
davi@moksha.com.br authored
into moksha.com.br:/Users/davi/mysql/push/bugs/31409-5.0
-
davi@moksha.local authored
This deadlock occurs when a client issues a HANDLER ... OPEN statement that tries to open a table that has a pending name-lock on it by another client that also needs a name-lock on some other table which is already open and associated to a HANDLER instance owned by the first client. The deadlock happens because the open_table() function will back-off and wait until the name-lock goes away, causing a circular wait if some other name-lock is also pending for one of the open HANDLER tables. Such situation, for example, can be easily repeated by issuing a RENAME TABLE command in such a way that the existing table is already open as a HANDLER table by another client and this client tries to open a HANDLER to the new table name. The solution is to allow handler tables with older versions (marked for flush) to be closed before waiting for the name-lock completion. This is safe because no other name-lock can be issued between the flush and the check for pending name-locks. The test case for this bug is going to be committed into 5.1 because it requires a test feature only avaiable in 5.1 (wait_condition).
-
davi@moksha.local authored
into moksha.local:/Users/davi/mysql/push/mysql-5.1-runtime
-
anozdrin/alik@station. authored
-
anozdrin/alik@station. authored
into station.:/mnt/raid/alik/MySQL/devel/5.1-rt-merged
-
- 08 Oct, 2007 3 commits
-
-
malff@lambda.hsd1.co.comcast.net. authored
-
anozdrin/alik@station. authored
-
anozdrin/alik@station. authored
-
- 07 Oct, 2007 2 commits
-
-
kostja@bodhi.(none) authored
into bodhi.(none):/opt/local/work/mysql-5.0-runtime
-
kostja@bodhi.(none) authored
into bodhi.(none):/opt/local/work/mysql-5.1-runtime
-
- 05 Oct, 2007 2 commits
-
-
msvensson@pilot.mysql.com authored
into pilot.mysql.com:/data/msvensson/mysql/my50-r-bug30992
-
anozdrin/alik@station. authored
when used in a VIEW. The problem was that wrong function (create_tmp_from_item()) was used to create a temporary field for Item_func_sp. The fix is to use create_tmp_from_field().
-
- 04 Oct, 2007 6 commits
-
-
davi@moksha.local authored
into moksha.local:/Users/davi/mysql/push/mysql-5.0-runtime
-
davi@moksha.local authored
This bug is a symptom of the way handler's tables are managed. The most different aspect, compared to the conventional behavior, is that the handler's tables are long lived, meaning that their lifetimes are not bounded by the duration of the command that opened them. For this effect the handler code uses its own list (handler_tables instead of open_tables) to hold open handler tables so that the tables won't be closed at the end of the command/statement. Besides the handler_tables list, there is a hash (handler_tables_hash) which is used to associate handler aliases to tables and to refresh the tables upon demand (flush tables). The current implementation doesn't work properly with refreshed tables -- more precisely when flush commands are issued by other initiators. This happens because when a handler open or read statement is being processed, the associated table has to be opened or locked and, for this matter, the open_tables and handler_tables lists are swapped so that the new table being opened is inserted into the handler_tables list. But when opening or locking the table, if the refresh version is different from the thread refresh version then all used tables in the open_tables list (now handler_tables) are refreshed. In the "refreshing" process the handler tables are flushed (closed) without being properly unlinked from the handler hash. The current implementation also fails to properly discard handlers of dropped tables, but this and other problems are going to be addressed in the fixes for bugs 31397 and 31409. The chosen approach tries to properly save and restore the table state so that no table is flushed during the table open and lock operations. The logic is almost the same as before with the list swapping, but with a working glue code. The test case for this bug is going to be committed into 5.1 because it requires a test feature only avaiable in 5.1 (wait_condition).
-
joerg@trift2. authored
into trift2.:/MySQL/M51/push-5.1
-
joerg@trift2. authored
into trift2.:/MySQL/M50/push-5.0
-
anozdrin/alik@station. authored
This actually, fix for the patch for bug-27354. The problem with the patch was that Item_func_sp::used_tables() was updated, but Item_func_sp::const_item() was not. So, for Item_func_sp, we had the following inconsistency: - used_tables() returned RAND_TABLE, which means that the item can produce "random" results; - but const_item() returned TRUE, which means that the item is a constant one. The fix is to change Item_func_sp::const_item() behaviour: it must return TRUE (an item is a constant one) only if a stored function is deterministic and each of its arguments (if any) is a constant item.
-
jperkin@production.mysql.com authored
into production.mysql.com:/usersnfs/jperkin/bk/build/5.1
-