1. 11 Oct, 2007 1 commit
    • unknown's avatar
      Fix for bug #31154: field.h:1649: virtual int Field_bit::cmp(const uchar*, const uchar*): Assertion · 24a567e9
      unknown authored
      Problem: GROUP_CONCAT(DISTINCT BIT_FIELD...) uses a tree to store keys;
      which are constructed using a temporary table fields,
      see Item_func_group_concat::setup().
      As a) we don't store null bits in the tree where the bit fields store parts 
      of their data and b) there's no method to properly compare two table records
      we've got problem.
      
      Fix: convert BIT fields to INT in the temporary table used.
      
      
      mysql-test/r/func_gconcat.result:
        Fix for bug #31154: field.h:1649: virtual int Field_bit::cmp(const uchar*, const uchar*): Assertion
          - test result.
      mysql-test/t/func_gconcat.test:
        Fix for bug #31154: field.h:1649: virtual int Field_bit::cmp(const uchar*, const uchar*): Assertion
          - test case.
      sql/item_sum.cc:
        Fix for bug #31154: field.h:1649: virtual int Field_bit::cmp(const uchar*, const uchar*): Assertion
          - force the create_tmp_table() to convert BIT columns to INT 
            in order to be able to compare records containing BIT fields.
      24a567e9
  2. 09 Oct, 2007 6 commits
    • unknown's avatar
      metadata test of bug # 31249: problem with convert(..., datetime) removed · 5a6b519a
      unknown authored
      as PS protocol gives slightly different metadata.
      
      
      5a6b519a
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-maint · 7d05e7e9
      unknown authored
      into  zippy.cornsilk.net:/home/cmiller/work/mysql/mysql-5.0-maint
      
      
      7d05e7e9
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-5.0-maint · d28ce157
      unknown authored
      into  mysql.com:/home/ram/work/b31249/b31249.5.0
      
      
      mysql-test/r/type_datetime.result:
        manual merge
      mysql-test/t/type_datetime.test:
        manual merge
      d28ce157
    • unknown's avatar
      Fix for bug #31249: Assertion `!table || (!table->write_set || · 1a5f13a1
      unknown authored
      bitmap_is_set(table->write_set, fiel
      
      Problem: creating a temporary table we allocate the group buffer if needed
      followed by table bitmaps (see create_tmp_table()). Reserving less memory for 
      the group buffer than actually needed (used) for values retrieval may lead 
      to overlapping with followed bitmaps in the memory pool that in turn leads 
      to unpredictable consequences.
      
      As we use Item->max_length sometimes to calculate group buffer size,
      it must be set to proper value. In this particular case 
      Item_datetime_typecast::max_length is too small.
      
      Another problem is that we use max_length to calculate the group buffer
      key length for items represented as DATE/TIME fields which is superfluous.
      
      Fix: set Item_datetime_typecast::max_length properly,
      accurately calculate the group buffer key length for items 
      represented as DATE/TIME fields in the buffer.
      
      
      mysql-test/r/type_datetime.result:
        Fix for bug #31249: Assertion `!table || (!table->write_set || 
        bitmap_is_set(table->write_set, fiel
          - test result.
      mysql-test/t/type_datetime.test:
        Fix for bug #31249: Assertion `!table || (!table->write_set || 
        bitmap_is_set(table->write_set, fiel
          - test case.
      sql/item_timefunc.h:
        Fix for bug #31249: Assertion `!table || (!table->write_set || 
        bitmap_is_set(table->write_set, fiel
          - set Item_datetime_typecast::max_length properly.
      sql/sql_select.cc:
        Fix for bug #31249: Assertion `!table || (!table->write_set || 
        bitmap_is_set(table->write_set, fiel
          - the group buffer key length for items represented as 
        DATE/TIME fields in the buffer should be calculated using
        the maximum pack length of such fields (== 8), using 
        max_length here is redundant.
      1a5f13a1
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-maint · 715da32e
      unknown authored
      into  alf.(none):/src/bug28774/my50-bug28774
      
      
      715da32e
    • unknown's avatar
      Bug#28774 mysql_upgrade creates tempfiles in root-dir (C:\) and · d0204889
      unknown authored
      doesn't clean them up
      - Make sure to cleanup temporary files after use.
      
      
      client/mysql_upgrade.c:
        Bug#28774 mysql_upgrade creates tempfiles in root-dir (C:\) and 
        doesn't clean them up
        - Close file handle and delete temporary file when write fails.
      d0204889
  3. 06 Oct, 2007 1 commit
  4. 05 Oct, 2007 13 commits
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.0-maint · 66fd9a34
      unknown authored
      into  sin.intern.azundris.com:/home/tnurnberg/19828/50-19828
      
      
      mysql-test/r/grant.result:
        Auto merged
      66fd9a34
    • unknown's avatar
      Merge pilot.mysql.com:/data/msvensson/mysql/bug27789/my50-bug27789 · 7b985391
      unknown authored
      into  pilot.mysql.com:/data/msvensson/mysql/mysql-5.0-maint
      
      
      7b985391
    • unknown's avatar
      Fixed Bug #27789 "Wrong permissions of sql/share/language directories" · dc025672
      unknown authored
      
      extra/comp_err.c:
        Override my_mkdir() umask setting. The default is 0700 which perfectly 
        makes sense for the server but leads to Bug #27789 when applied to comp_err
        generated directories in the souce tree. Generated directories and the
        files within won't be accessible to other users, sometimes including root 
        if on a non-local filesystem, making "sudo make install" fail.
      dc025672
    • unknown's avatar
      Merge msvensson2.mysql.internal:mysql/mysql-5.0-maint · 79b4d29f
      unknown authored
      into  pilot.mysql.com:/data/msvensson/mysql/mysql-5.0-maint
      
      
      79b4d29f
    • unknown's avatar
    • unknown's avatar
      Bug#27753 enable mysql-test-run.pl to ignore tests based on wildcard · 574dbd8b
      unknown authored
      
      mysql-test/lib/mtr_cases.pl:
        Allow --skip-test and --do-test to take a perl regex
      mysql-test/mysql-test-run.pl:
        Update usage for --skip-test and --do-test
      574dbd8b
    • unknown's avatar
      Change URLs. · 6f2c2dc8
      unknown authored
      Our web server has been restructured several times, and references
      to it in our source code has stayed the same.  This patch from Paul
      DuBois updates all URLs to modern semantics.
      
      
      debian/po/ca.po:
        Change URLs.
      debian/po/cs.po:
        Change URLs.
      debian/po/da.po:
        Change URLs.
      debian/po/gl.po:
        Change URLs.
      debian/po/ja.po:
        Change URLs.
      debian/po/pt_BR.po:
        Change URLs.
      debian/po/sv.po:
        Change URLs.
      debian/po/tr.po:
        Change URLs.
      mysql-test/lib/mtr_report.pl:
        Change URLs.
      mysql-test/mysql-test-run-shell.sh:
        Change URLs.
      ndb/include/ndbapi/Ndb.hpp:
        Change URLs.
      netware/mysql_test_run.c:
        Change URLs.
      scripts/mysqld_safe.sh:
        Change URLs.
      sql/mysqld.cc:
        Change URLs.
      6f2c2dc8
    • unknown's avatar
      Bug#30560 Valgrind option to mysql-test-run with spaces in cause strange error · 9419cb42
      unknown authored
      
      mysql-test/mysql-test-run.pl:
        Just pass the $opt_valgrind_options to mtr_add_arg - it does a
        "push(@$args, sprintf($format, @fargs));" behind the scenes
      9419cb42
    • unknown's avatar
      Bug#31398 problems with mysql-test-run, part2 · b07a4abc
      unknown authored
      Write .reject file to r/ if it's writable else use opt_logdir 
      
      
      client/mysqltest.c:
        Write .reject file to r/ if it's writable else use opt_logdir
      b07a4abc
    • unknown's avatar
      Bug#31398 problems with mysql-test-run · 133bd811
      unknown authored
       - "mysqld --verbose --help" need to be started in a writable directory 
      
      
      mysql-test/mysql-test-run.pl:
        Create a tmpdir where mysqld can peform it's lowercase or uppercase test
      133bd811
    • unknown's avatar
      Bug #31253: crash comparing datetime to double · 2e8ca84e
      unknown authored
      convert(<invalid time>, datetime) in WHERE caused crash as function
      returned (void*)NULL, but did not flag SQL NULL. It does now.
      
      
      mysql-test/r/type_datetime.result:
        show that convert() to datetime in a WHERE-clause will no longer crash
        the server on invalid input.
      mysql-test/t/type_datetime.test:
        show that convert() to datetime in a WHERE-clause will no longer crash
        the server on invalid input.
      sql/item.cc:
        When failing to process time values, do not just return (void*)NULL,
        but flag SQL NULL as well so no caller will try to process the 0x0L.
        This makes behaviour for Item::Item::val_decimal_from_date() and
        Item::Item::val_decimal_from_time() identical.
      2e8ca84e
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.0-maint · 28232df2
      unknown authored
      into  sin.intern.azundris.com:/home/tnurnberg/31227/50-31227
      
      
      28232df2
    • unknown's avatar
      Bug#31227: memory overrun with decimal (6,6) and zerofill and group_concat · 1b3d25d5
      unknown authored
      Reserve the space for the leading 0 (before the decimal point) in DECIMAL(a,a) ZEROFILL.
      
      
      mysql-test/r/type_decimal.result:
        show that we allocate a large enough buffer for output of DECIMAL(a,a) [ZEROFILL].
      mysql-test/t/type_decimal.test:
        show that we allocate a large enough buffer for output of DECIMAL(a,a) [ZEROFILL].
        without patch for bug#31227, valgrind will complain here; so will a
        debug build.
      sql/my_decimal.cc:
        Reserve the space for the leading 0 (before the decimal point) in DECIMAL(a,a) ZEROFILL.
        Doxygenise preamble of my_decimal2string().
      1b3d25d5
  5. 04 Oct, 2007 11 commits
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.0-maint · e96d5364
      unknown authored
      into  sin.intern.azundris.com:/home/tnurnberg/30444/50-30444
      
      
      e96d5364
    • unknown's avatar
      Merge ssh://bk-internal.mysql.com//home/bk/mysql-5.0-maint · ea46c116
      unknown authored
      into  polly.(none):/home/kaa/src/maint/mysql-5.0-maint
      
      
      ea46c116
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/maint/bug5731/my50-bug5731 · 227bf9ad
      unknown authored
      into  polly.(none):/home/kaa/src/maint/mysql-5.0-maint
      
      
      227bf9ad
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-5.0-maint · 698e9b4f
      unknown authored
      into  mysql.com:/home/ram/work/b31070/b31070.5.0
      
      
      698e9b4f
    • unknown's avatar
      Issue a warning if a user sets an option or a variable to a value that is... · 78348d4e
      unknown authored
      Issue a warning if a user sets an option or a variable to a value that is greater than a defined maximum for the option/variable.
      
      This is for bug #29446 "Specifying a myisam_sort_buffer > 4GB on 64 bit machines not possible". Support for myisam_sort_buffer_size > 4 GB on 64-bit Windows will be looked at later in 5.2.
      
      
      mysql-test/r/variables.result:
        Fixed the test.
      mysql-test/t/variables.test:
        Fixed the test.
      mysys/my_getopt.c:
        Print a warning to the error log if a user sets an option to a value greater than the option's maximum value.
      sql/set_var.cc:
        Issue an SQL warning if a user assignes a value greater than the variable's maximum value.
      78348d4e
    • unknown's avatar
      merging: results adjusted · 6dc4dfb3
      unknown authored
      6dc4dfb3
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.0-maint · 66fed4ae
      unknown authored
      into  sin.intern.azundris.com:/home/tnurnberg/30444/50-30444
      
      
      client/mysqldump.c:
        Auto merged
      66fed4ae
    • unknown's avatar
      Merge sin.intern.azundris.com:/home/tnurnberg/30444/41-30444 · fd7d1354
      unknown authored
      into  sin.intern.azundris.com:/home/tnurnberg/30444/50-30444
      
      
      client/mysqldump.c:
        Auto merged
      fd7d1354
    • unknown's avatar
      Bug #30444: 5.0 mysqldump silently allows wrong backup to be taken against a 4.0 database · 3f4eaf57
      unknown authored
      The combination of --single-transaction and --master-data requires
      START TRANSACTION WITH CONSISTENT SNAPSHOT which is available from
      mysqld 4.1 on. When trying this against an older server, print
      diagnostic, then, if --force is not given, abort.
      
      No test-case given since it would require a mysqld < 4.1.
      
      
      client/mysqldump.c:
        Bug #30444: 5.0 mysqldump silently allows wrong backup to be taken against a 4.0 database
        
        The combination of --single-transaction and --master-data requires
        START TRANSACTION WITH CONSISTENT SNAPSHOT which is available from
        mysqld 4.1 on. When trying this against an older server, print
        diagnostic, then, if --force is not given, abort.
      3f4eaf57
    • unknown's avatar
      Merge mysql.com:/home/ram/work/b31070/b31070.4.1 · 19810085
      unknown authored
      into  mysql.com:/home/ram/work/b31070/b31070.5.0
      
      
      mysql-test/r/ctype_big5.result:
        Auto merged
      mysql-test/r/ctype_gbk.result:
        Auto merged
      mysql-test/r/ctype_uca.result:
        Auto merged
      strings/ctype-big5.c:
        Auto merged
      strings/ctype-euc_kr.c:
        Auto merged
      strings/ctype-gb2312.c:
        Auto merged
      strings/ctype-sjis.c:
        Auto merged
      BitKeeper/deleted/.del-ctype-cp932.c:
        Auto merged
      19810085
    • unknown's avatar
      Fix for bug #31069: crash in 'sounds like' · db2d3104
      unknown authored
      and for bug #31070: crash during conversion of charsets
      
      Problem: passing a 0 byte length string to some my_mb_wc_XXX() 
      functions leads to server crash due to improper argument check.
      
      Fix: properly check arguments passed to my_mb_wc_XXX() functions.
      
      
      mysql-test/include/ctype_common.inc:
        Fix for bug #31069: crash in 'sounds like'
        and bug #31070: crash during conversion of charsets
          - test case.
      mysql-test/r/ctype_big5.result:
        Fix for bug #31069: crash in 'sounds like'
        and bug #31070: crash during conversion of charsets
          - test result.
      mysql-test/r/ctype_euckr.result:
        Fix for bug #31069: crash in 'sounds like'
        and bug #31070: crash during conversion of charsets
          - test result.
      mysql-test/r/ctype_gb2312.result:
        Fix for bug #31069: crash in 'sounds like'
        and bug #31070: crash during conversion of charsets
          - test result.
      mysql-test/r/ctype_gbk.result:
        Fix for bug #31069: crash in 'sounds like'
        and bug #31070: crash during conversion of charsets
          - test result.
      mysql-test/r/ctype_uca.result:
        Fix for bug #31069: crash in 'sounds like'
        and bug #31070: crash during conversion of charsets
          - test result.
      strings/ctype-big5.c:
        Fix for bug #31069: crash in 'sounds like'
        and bug #31070: crash during conversion of charsets
          - check the string length before testing its first byte.
      strings/ctype-cp932.c:
        Fix for bug #31069: crash in 'sounds like'
        and bug #31070: crash during conversion of charsets
          - check the string length before testing its first byte.
      strings/ctype-euc_kr.c:
        Fix for bug #31069: crash in 'sounds like'
        and bug #31070: crash during conversion of charsets
          - check the string length before testing its first byte.
      strings/ctype-gb2312.c:
        Fix for bug #31069: crash in 'sounds like'
        and bug #31070: crash during conversion of charsets
          - check the string length before testing its first byte.
      strings/ctype-sjis.c:
        Fix for bug #31069: crash in 'sounds like'
        and bug #31070: crash during conversion of charsets
          - check the string length before testing its first byte.
      db2d3104
  6. 03 Oct, 2007 1 commit
  7. 02 Oct, 2007 5 commits
  8. 28 Sep, 2007 1 commit
  9. 27 Sep, 2007 1 commit