- 11 Oct, 2007 1 commit
-
-
unknown authored
Problem: GROUP_CONCAT(DISTINCT BIT_FIELD...) uses a tree to store keys; which are constructed using a temporary table fields, see Item_func_group_concat::setup(). As a) we don't store null bits in the tree where the bit fields store parts of their data and b) there's no method to properly compare two table records we've got problem. Fix: convert BIT fields to INT in the temporary table used. mysql-test/r/func_gconcat.result: Fix for bug #31154: field.h:1649: virtual int Field_bit::cmp(const uchar*, const uchar*): Assertion - test result. mysql-test/t/func_gconcat.test: Fix for bug #31154: field.h:1649: virtual int Field_bit::cmp(const uchar*, const uchar*): Assertion - test case. sql/item_sum.cc: Fix for bug #31154: field.h:1649: virtual int Field_bit::cmp(const uchar*, const uchar*): Assertion - force the create_tmp_table() to convert BIT columns to INT in order to be able to compare records containing BIT fields.
-
- 09 Oct, 2007 6 commits
-
-
unknown authored
as PS protocol gives slightly different metadata.
-
unknown authored
into zippy.cornsilk.net:/home/cmiller/work/mysql/mysql-5.0-maint
-
unknown authored
into mysql.com:/home/ram/work/b31249/b31249.5.0 mysql-test/r/type_datetime.result: manual merge mysql-test/t/type_datetime.test: manual merge
-
unknown authored
bitmap_is_set(table->write_set, fiel Problem: creating a temporary table we allocate the group buffer if needed followed by table bitmaps (see create_tmp_table()). Reserving less memory for the group buffer than actually needed (used) for values retrieval may lead to overlapping with followed bitmaps in the memory pool that in turn leads to unpredictable consequences. As we use Item->max_length sometimes to calculate group buffer size, it must be set to proper value. In this particular case Item_datetime_typecast::max_length is too small. Another problem is that we use max_length to calculate the group buffer key length for items represented as DATE/TIME fields which is superfluous. Fix: set Item_datetime_typecast::max_length properly, accurately calculate the group buffer key length for items represented as DATE/TIME fields in the buffer. mysql-test/r/type_datetime.result: Fix for bug #31249: Assertion `!table || (!table->write_set || bitmap_is_set(table->write_set, fiel - test result. mysql-test/t/type_datetime.test: Fix for bug #31249: Assertion `!table || (!table->write_set || bitmap_is_set(table->write_set, fiel - test case. sql/item_timefunc.h: Fix for bug #31249: Assertion `!table || (!table->write_set || bitmap_is_set(table->write_set, fiel - set Item_datetime_typecast::max_length properly. sql/sql_select.cc: Fix for bug #31249: Assertion `!table || (!table->write_set || bitmap_is_set(table->write_set, fiel - the group buffer key length for items represented as DATE/TIME fields in the buffer should be calculated using the maximum pack length of such fields (== 8), using max_length here is redundant.
-
unknown authored
into alf.(none):/src/bug28774/my50-bug28774
-
unknown authored
doesn't clean them up - Make sure to cleanup temporary files after use. client/mysql_upgrade.c: Bug#28774 mysql_upgrade creates tempfiles in root-dir (C:\) and doesn't clean them up - Close file handle and delete temporary file when write fails.
-
- 06 Oct, 2007 1 commit
-
-
unknown authored
into sin.intern.azundris.com:/home/tnurnberg/31253/50-31253
-
- 05 Oct, 2007 13 commits
-
-
unknown authored
into sin.intern.azundris.com:/home/tnurnberg/19828/50-19828 mysql-test/r/grant.result: Auto merged
-
unknown authored
into pilot.mysql.com:/data/msvensson/mysql/mysql-5.0-maint
-
unknown authored
extra/comp_err.c: Override my_mkdir() umask setting. The default is 0700 which perfectly makes sense for the server but leads to Bug #27789 when applied to comp_err generated directories in the souce tree. Generated directories and the files within won't be accessible to other users, sometimes including root if on a non-local filesystem, making "sudo make install" fail.
-
unknown authored
into pilot.mysql.com:/data/msvensson/mysql/mysql-5.0-maint
-
unknown authored
-
unknown authored
mysql-test/lib/mtr_cases.pl: Allow --skip-test and --do-test to take a perl regex mysql-test/mysql-test-run.pl: Update usage for --skip-test and --do-test
-
unknown authored
Our web server has been restructured several times, and references to it in our source code has stayed the same. This patch from Paul DuBois updates all URLs to modern semantics. debian/po/ca.po: Change URLs. debian/po/cs.po: Change URLs. debian/po/da.po: Change URLs. debian/po/gl.po: Change URLs. debian/po/ja.po: Change URLs. debian/po/pt_BR.po: Change URLs. debian/po/sv.po: Change URLs. debian/po/tr.po: Change URLs. mysql-test/lib/mtr_report.pl: Change URLs. mysql-test/mysql-test-run-shell.sh: Change URLs. ndb/include/ndbapi/Ndb.hpp: Change URLs. netware/mysql_test_run.c: Change URLs. scripts/mysqld_safe.sh: Change URLs. sql/mysqld.cc: Change URLs.
-
unknown authored
mysql-test/mysql-test-run.pl: Just pass the $opt_valgrind_options to mtr_add_arg - it does a "push(@$args, sprintf($format, @fargs));" behind the scenes
-
unknown authored
Write .reject file to r/ if it's writable else use opt_logdir client/mysqltest.c: Write .reject file to r/ if it's writable else use opt_logdir
-
unknown authored
- "mysqld --verbose --help" need to be started in a writable directory mysql-test/mysql-test-run.pl: Create a tmpdir where mysqld can peform it's lowercase or uppercase test
-
unknown authored
convert(<invalid time>, datetime) in WHERE caused crash as function returned (void*)NULL, but did not flag SQL NULL. It does now. mysql-test/r/type_datetime.result: show that convert() to datetime in a WHERE-clause will no longer crash the server on invalid input. mysql-test/t/type_datetime.test: show that convert() to datetime in a WHERE-clause will no longer crash the server on invalid input. sql/item.cc: When failing to process time values, do not just return (void*)NULL, but flag SQL NULL as well so no caller will try to process the 0x0L. This makes behaviour for Item::Item::val_decimal_from_date() and Item::Item::val_decimal_from_time() identical.
-
unknown authored
into sin.intern.azundris.com:/home/tnurnberg/31227/50-31227
-
unknown authored
Reserve the space for the leading 0 (before the decimal point) in DECIMAL(a,a) ZEROFILL. mysql-test/r/type_decimal.result: show that we allocate a large enough buffer for output of DECIMAL(a,a) [ZEROFILL]. mysql-test/t/type_decimal.test: show that we allocate a large enough buffer for output of DECIMAL(a,a) [ZEROFILL]. without patch for bug#31227, valgrind will complain here; so will a debug build. sql/my_decimal.cc: Reserve the space for the leading 0 (before the decimal point) in DECIMAL(a,a) ZEROFILL. Doxygenise preamble of my_decimal2string().
-
- 04 Oct, 2007 11 commits
-
-
unknown authored
into sin.intern.azundris.com:/home/tnurnberg/30444/50-30444
-
ssh://bk-internal.mysql.com//home/bk/mysql-5.0-maintunknown authored
into polly.(none):/home/kaa/src/maint/mysql-5.0-maint
-
unknown authored
into polly.(none):/home/kaa/src/maint/mysql-5.0-maint
-
unknown authored
into mysql.com:/home/ram/work/b31070/b31070.5.0
-
unknown authored
Issue a warning if a user sets an option or a variable to a value that is greater than a defined maximum for the option/variable. This is for bug #29446 "Specifying a myisam_sort_buffer > 4GB on 64 bit machines not possible". Support for myisam_sort_buffer_size > 4 GB on 64-bit Windows will be looked at later in 5.2. mysql-test/r/variables.result: Fixed the test. mysql-test/t/variables.test: Fixed the test. mysys/my_getopt.c: Print a warning to the error log if a user sets an option to a value greater than the option's maximum value. sql/set_var.cc: Issue an SQL warning if a user assignes a value greater than the variable's maximum value.
-
unknown authored
-
unknown authored
into sin.intern.azundris.com:/home/tnurnberg/30444/50-30444 client/mysqldump.c: Auto merged
-
unknown authored
into sin.intern.azundris.com:/home/tnurnberg/30444/50-30444 client/mysqldump.c: Auto merged
-
unknown authored
The combination of --single-transaction and --master-data requires START TRANSACTION WITH CONSISTENT SNAPSHOT which is available from mysqld 4.1 on. When trying this against an older server, print diagnostic, then, if --force is not given, abort. No test-case given since it would require a mysqld < 4.1. client/mysqldump.c: Bug #30444: 5.0 mysqldump silently allows wrong backup to be taken against a 4.0 database The combination of --single-transaction and --master-data requires START TRANSACTION WITH CONSISTENT SNAPSHOT which is available from mysqld 4.1 on. When trying this against an older server, print diagnostic, then, if --force is not given, abort.
-
unknown authored
into mysql.com:/home/ram/work/b31070/b31070.5.0 mysql-test/r/ctype_big5.result: Auto merged mysql-test/r/ctype_gbk.result: Auto merged mysql-test/r/ctype_uca.result: Auto merged strings/ctype-big5.c: Auto merged strings/ctype-euc_kr.c: Auto merged strings/ctype-gb2312.c: Auto merged strings/ctype-sjis.c: Auto merged BitKeeper/deleted/.del-ctype-cp932.c: Auto merged
-
unknown authored
and for bug #31070: crash during conversion of charsets Problem: passing a 0 byte length string to some my_mb_wc_XXX() functions leads to server crash due to improper argument check. Fix: properly check arguments passed to my_mb_wc_XXX() functions. mysql-test/include/ctype_common.inc: Fix for bug #31069: crash in 'sounds like' and bug #31070: crash during conversion of charsets - test case. mysql-test/r/ctype_big5.result: Fix for bug #31069: crash in 'sounds like' and bug #31070: crash during conversion of charsets - test result. mysql-test/r/ctype_euckr.result: Fix for bug #31069: crash in 'sounds like' and bug #31070: crash during conversion of charsets - test result. mysql-test/r/ctype_gb2312.result: Fix for bug #31069: crash in 'sounds like' and bug #31070: crash during conversion of charsets - test result. mysql-test/r/ctype_gbk.result: Fix for bug #31069: crash in 'sounds like' and bug #31070: crash during conversion of charsets - test result. mysql-test/r/ctype_uca.result: Fix for bug #31069: crash in 'sounds like' and bug #31070: crash during conversion of charsets - test result. strings/ctype-big5.c: Fix for bug #31069: crash in 'sounds like' and bug #31070: crash during conversion of charsets - check the string length before testing its first byte. strings/ctype-cp932.c: Fix for bug #31069: crash in 'sounds like' and bug #31070: crash during conversion of charsets - check the string length before testing its first byte. strings/ctype-euc_kr.c: Fix for bug #31069: crash in 'sounds like' and bug #31070: crash during conversion of charsets - check the string length before testing its first byte. strings/ctype-gb2312.c: Fix for bug #31069: crash in 'sounds like' and bug #31070: crash during conversion of charsets - check the string length before testing its first byte. strings/ctype-sjis.c: Fix for bug #31069: crash in 'sounds like' and bug #31070: crash during conversion of charsets - check the string length before testing its first byte.
-
- 03 Oct, 2007 1 commit
-
-
unknown authored
into pilot.mysql.com:/data/msvensson/mysql/mysql-5.0-maint
-
- 02 Oct, 2007 5 commits
-
-
unknown authored
- "on" -> "restore" to avoid warning in MSVC when compiling with debug mysys/my_init.c: Fix spelling error that cause MSVC to throw a warning when compiling with debug. Use "restore" instaed of "on" to turn runtime checks back on
-
unknown authored
into polly.(none):/home/kaa/src/maint/mysql-5.0-maint sql/mysqld.cc: Auto merged
-
unknown authored
into polly.(none):/home/kaa/src/maint/bug5731/my50-bug5731 sql/mysqld.cc: Auto merged
-
unknown authored
into polly.(none):/home/kaa/src/maint/bug5731/my50-bug5731 include/my_global.h: Auto merged sql/mysqld.cc: Auto merged
-
unknown authored
into polly.(none):/home/kaa/src/maint/bug5731/my50-bug5731
-
- 28 Sep, 2007 1 commit
-
-
unknown authored
into ramayana.hindu.god:/home/tsmith/m/bk/maint/50 configure.in: Auto merged scripts/mysql_config.sh: Auto merged libmysql/libmysql.c: Manual merge
-
- 27 Sep, 2007 1 commit
-
-
unknown authored
into pilot.(none):/data/msvensson/mysql/mysql-5.0-maint libmysql/libmysql.c: Auto merged
-