- 20 Oct, 2007 1 commit
-
-
mats@kindahl-laptop.dnsalias.net authored
When replicating an update pair (before image, after image) under row-based replication, and the before image is not found on the slave, the after image was not discared, and was hence read as a before image for the next row. Eventually, this lead to an after image being read outside the block of rows in the event, causing an assertion to fire. This patch fixes this by reading the after image in the event that the row was not found on the slave, adds some extra debug assertion to catch future errors earlier, and also adds a few non-debug checks to prevent reading outside the block of the event.
-
- 17 Oct, 2007 3 commits
-
-
mats@kindahl-laptop.dnsalias.net authored
-
mats@kindahl-laptop.dnsalias.net authored
into kindahl-laptop.dnsalias.net:/home/bk/b29549-mysql-5.1-target-5.1.22
-
mats@kindahl-laptop.dnsalias.net authored
storage engines do not set the unused null bits (i.e., the filler bits and the X bit) correctly. Also adding some casts to debug printouts to eliminate compiler warnings.
-
- 16 Oct, 2007 4 commits
-
-
-
bar@mysql.com/bar.myoffice.izhnet.ru authored
Adjusting SHOW CREATE TABLE output from 5.0 to 5.1 format
-
bar@bar.myoffice.izhnet.ru authored
into mysql.com:/home/bar/mysql-work/mysql-5.1.b31081
-
bar@bar.myoffice.izhnet.ru authored
into mysql.com:/home/bar/mysql-work/mysql-5.0.b31081
-
- 15 Oct, 2007 1 commit
-
-
bar@bar.myoffice.izhnet.ru authored
into mysql.com:/home/bar/mysql-work/mysql-5.1.b27287
-
- 13 Oct, 2007 3 commits
-
-
aelkin/elkin@koti.dsl.inet.fi authored
-
aelkin/elkin@koti.dsl.inet.fi authored
into koti.dsl.inet.fi:/home/elkin/MySQL/merge-5.1
-
aelkin/elkin@koti.dsl.inet.fi authored
similar to bug_27716, but it was stressed on in the synopsis on that there is another side of the artifact affecting behaviour in transaction. Fixed with deploying multi_delete::send_error() - otherwise never called - and refining its logic to perform binlogging job if needed. The changeset includes the following side effects: - added tests to check bug_23333's scenarios on the mixture of tables for multi_update; - fixes bug@30763 with two-liner patch and a test coinciding to one added for bug_23333.
-
- 12 Oct, 2007 3 commits
-
-
mats@kindahl-laptop.dnsalias.net authored
Post-merge fixes. Setting write bit before calling Field::store() since the function asserts that the write bit has been set.
-
mats@kindahl-laptop.dnsalias.net authored
into kindahl-laptop.dnsalias.net:/home/bkroot/mysql-5.1-rpl
-
mats@kindahl-laptop.dnsalias.net authored
into kindahl-laptop.dnsalias.net:/home/bk/b29549-mysql-5.1-target-5.1.22
-
- 11 Oct, 2007 1 commit
-
-
mats@kindahl-laptop.dnsalias.net authored
Refactoring code to add parameter to pack() and unpack() functions with purpose of indicating if data should be packed in little-endian or native order. Using new functions to always pack data for binary log in little-endian order. The purpose of this refactoring is to allow proper implementation of endian-agnostic pack() and unpack() functions. Eliminating several versions of virtual pack() and unpack() functions in favor for one single virtual function which is overridden in subclasses. Implementing pack() and unpack() functions for some field types that packed data in native format regardless of the value of the st_table_share::db_low_byte_first flag. The field types that were packed in native format regardless are: Field_real, Field_decimal, Field_tiny, Field_short, Field_medium, Field_long, Field_longlong, and Field_blob. Before the patch, row-based logging wrote the rows incorrectly on big-endian machines where the storage engine defined its own low_byte_first() to be FALSE on big-endian machines (the default is TRUE), while little-endian machines wrote the fields in correct order. The only known storage engine that does this is NDB. In effect, this means that row-based replication from or to a big-endian machine where the table was using NDB as storage engine failed if the other engine was either non-NDB or on a little-endian machine. With this patch, row-based logging is now always done in little-endian order, while ORDER BY uses the native order if the storage engine defines low_byte_first() to return FALSE for big-endian machines. In addition, the max_data_length() function available in Field_blob was generalized to the entire Field hierarchy to give the maximum number of bytes that Field::pack() will write.
-
- 10 Oct, 2007 1 commit
-
-
sven@murkla.(none) authored
Problem: rpl_stm_mystery22 is unstable. Reason: At one place, the test case *should* wait until the SQL thread on the slave receives an error, but instead it waits until the SQL thread stops. The SQL thread may stop before the error flag is set, so that when the test case continues to execute, the error flag is not set. Fix: Introduce the subroutine mysql-test/include/wait_for_slave_sql_error.inc, which waits until there is an error in the sql thread of the slave. Re-commit: fixed one logical error and two smaller things noted by Mats.
-
- 09 Oct, 2007 1 commit
-
-
bar@mysql.com/bar.myoffice.izhnet.ru authored
Performance improvements made. ExtractValue for large XML values is now much faster (about 2000 times faster of 1Mb-long XML values).
-
- 05 Oct, 2007 1 commit
-
-
bar@mysql.com/bar.myoffice.izhnet.ru authored
Problem: The "regex" library written by Henry Spencer does not support tricky character sets like UCS2. Fix: convert tricky character sets to UTF8 before calling regex functions.
-
- 04 Oct, 2007 5 commits
-
-
aelkin/elkin@koti.dsl.inet.fi authored
into koti.dsl.inet.fi:/home/elkin/MySQL/TEAM/FIXES/5.0/bug29309-wrong_master_timestamp
-
aelkin/elkin@koti.dsl.inet.fi authored
Report claims that Seconds_behind_master behaves unexpectedly. Code analysis shows that there is an evident flaw in that treating of FormatDescription event is wrong so that after FLUSH LOGS on slave the Seconds_behind_master's calculation slips and incorrect value can be reported to SHOW SLAVE STATUS. Even worse is that the gap between the correct and incorrect deltas grows with time. Fixed with prohibiting changes to rpl->last_master_timestamp by artifical events (any kind of). suggestion as comments is added how to fight with lack of info on the slave side by means of new heartbeat feature coming. The test can not be done ealily fully determistic.
-
aelkin/elkin@koti.dsl.inet.fi authored
-
aelkin/elkin@koti.dsl.inet.fi authored
into koti.dsl.inet.fi:/home/elkin/MySQL/TEAM/5.1-merge
-
bar@mysql.com/bar.myoffice.izhnet.ru authored
Fix: ignore BOM marker in the first line.
-
- 03 Oct, 2007 5 commits
-
-
aelkin/elkin@koti.dsl.inet.fi authored
into koti.dsl.inet.fi:/home/elkin/MySQL/TEAM/FIXES/5.0/bug26000_show_slave_status_when_no_active_mi
-
aelkin/elkin@koti.dsl.inet.fi authored
into koti.dsl.inet.fi:/home/elkin/MySQL/TEAM/FIXES/5.0/bug26000_show_slave_status_when_no_active_mi
-
sven@murkla.(none) authored
Problem: one thread could read uninitialized memory from (the stack of) another thread. Fix: swapped order of initializing the memory and making it available to the other thread. Fix: put lock around the statement that makes the memory available to the other thread. Fix: all fields of the struct are now initialized in the constructor, to avoid future problems.
-
bar@bar.myoffice.izhnet.ru authored
into mysql.com:/home/bar/mysql-work/mysql-5.1-new-rpl
-
bar@bar.myoffice.izhnet.ru authored
into mysql.com:/home/bar/mysql-work/mysql-5.0-rpl
-
- 02 Oct, 2007 3 commits
-
-
bar@bar.myoffice.izhnet.ru authored
into mysql.com:/home/bar/mysql-work/mysql-5.1-new-rpl
-
bar@mysql.com/bar.myoffice.izhnet.ru authored
Removing redundant initialization.
-
bar@mysql.com/bar.myoffice.izhnet.ru authored
-
- 01 Oct, 2007 6 commits
-
-
bar@mysql.com/bar.myoffice.izhnet.ru authored
Problem: some valid euc-kr characters were rejected because condition checking multi-byte tail didn't allow multi-byte characters having the second byte in the ranges [0x41..0x5A] and [0x61..0x7A]. Fix: allow these byte ranges for mb tails
-
lars/lthalmann@dl145k.mysql.com authored
into mysql.com:/nfsdisk1/lars/MERGE/mysql-5.1-merge
-
lars/lthalmann@dl145j.mysql.com authored
into mysql.com:/nfsdisk1/lars/MERGE/mysql-5.0-merge
-
lars/lthalmann@dl145h.mysql.com authored
into mysql.com:/nfsdisk1/lars/MERGE/mysql-5.1-merge
-
lars/lthalmann@dl145h.mysql.com authored
into mysql.com:/nfsdisk1/lars/MERGE/mysql-5.0-merge
-
into mysql.com:/nfsdisk1/lars/MERGE/mysql-4.1-merge
-
- 26 Sep, 2007 1 commit
-
-
aelkin/elkin@koti.dsl.inet.fi authored
active_mi has been reset (shutdown) at the time of quering with SHOW SLAVE STATUS so that at handling of SHOW an attempt to read its members segfaults. Fixed with checking the value of active_mi before to call show_master_info() Merely send_ok() is invoked when active_mi does not exist. A test can not be easiely written. Notice, there are more analogical cases in the code which require a similar treatment (to be reported as a bug separately).
-
- 25 Sep, 2007 1 commit
-
-
df@pippilotta.erinye.com authored
into pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.1-build
-