1. 20 Oct, 2007 1 commit
    • mats@kindahl-laptop.dnsalias.net's avatar
      Bug#31702 (Missing row on slave causes assertion failure under row-based replication): · 24ea15a2
      mats@kindahl-laptop.dnsalias.net authored
      When replicating an update pair (before image, after image) under row-based
      replication, and the before image is not found on the slave, the after image
      was not discared, and was hence read as a before image for the next row.
      Eventually, this lead to an after image being read outside the block of rows
      in the event, causing an assertion to fire.
      
      This patch fixes this by reading the after image in the event that the row
      was not found on the slave, adds some extra debug assertion to catch future
      errors earlier, and also adds a few non-debug checks to prevent reading
      outside the block of the event.
      24ea15a2
  2. 17 Oct, 2007 3 commits
  3. 16 Oct, 2007 4 commits
  4. 15 Oct, 2007 1 commit
  5. 13 Oct, 2007 3 commits
  6. 12 Oct, 2007 3 commits
  7. 11 Oct, 2007 1 commit
    • mats@kindahl-laptop.dnsalias.net's avatar
      BUG#29549 (Endians: test failures on Solaris): · c4298a3f
      mats@kindahl-laptop.dnsalias.net authored
      Refactoring code to add parameter to pack() and unpack() functions with
      purpose of indicating if data should be packed in little-endian or
      native order. Using new functions to always pack data for binary log
      in little-endian order. The purpose of this refactoring is to allow
      proper implementation of endian-agnostic pack() and unpack() functions.
      
      Eliminating several versions of virtual pack() and unpack() functions
      in favor for one single virtual function which is overridden in
      subclasses.
      
      Implementing pack() and unpack() functions for some field types that
      packed data in native format regardless of the value of the
      st_table_share::db_low_byte_first flag.
      
      The field types that were packed in native format regardless are:
      Field_real, Field_decimal, Field_tiny, Field_short, Field_medium,
      Field_long, Field_longlong, and Field_blob.
      
      Before the patch, row-based logging wrote the rows incorrectly on
      big-endian machines where the storage engine defined its own
      low_byte_first() to be FALSE on big-endian machines (the default
      is TRUE), while little-endian machines wrote the fields in correct
      order. The only known storage engine that does this is NDB. In effect,
      this means that row-based replication from or to a big-endian
      machine where the table was using NDB as storage engine failed if the
      other engine was either non-NDB or on a little-endian machine.
      
      With this patch, row-based logging is now always done in little-endian
      order, while ORDER BY uses the native order if the storage engine
      defines low_byte_first() to return FALSE for big-endian machines.
      
      In addition, the max_data_length() function available in Field_blob
      was generalized to the entire Field hierarchy to give the maximum
      number of bytes that Field::pack() will write.
      c4298a3f
  8. 10 Oct, 2007 1 commit
    • sven@murkla.(none)'s avatar
      BUG#29046: rpl_stm_mystery22 unstable · c302f74d
      sven@murkla.(none) authored
      Problem: rpl_stm_mystery22 is unstable.
      
      Reason: At one place, the test case *should* wait until the SQL thread on the
      slave receives an error, but instead it waits until the SQL thread stops. The
      SQL thread may stop before the error flag is set, so that when the test case
      continues to execute, the error flag is not set.
      
      Fix: Introduce the subroutine mysql-test/include/wait_for_slave_sql_error.inc,
      which waits until there is an error in the sql thread of the slave.
      
      Re-commit: fixed one logical error and two smaller things noted by Mats.
      c302f74d
  9. 09 Oct, 2007 1 commit
  10. 05 Oct, 2007 1 commit
  11. 04 Oct, 2007 5 commits
  12. 03 Oct, 2007 5 commits
  13. 02 Oct, 2007 3 commits
  14. 01 Oct, 2007 6 commits
  15. 26 Sep, 2007 1 commit
    • aelkin/elkin@koti.dsl.inet.fi's avatar
      Bug #26000 SHOW SLAVE STATUS can crash mysqld during shutdown process · 5dc3fbf1
      aelkin/elkin@koti.dsl.inet.fi authored
      active_mi has been reset (shutdown) at the time of quering with 
      SHOW SLAVE STATUS so that 
      at handling of SHOW an attempt to read its members segfaults.
      
      Fixed with checking the value of active_mi before to call show_master_info()
      Merely send_ok() is invoked when active_mi does not exist.
      A test can not be easiely written.
      
      Notice, there are more analogical cases in the code which require a similar
      treatment (to be reported as a bug separately). 
      5dc3fbf1
  16. 25 Sep, 2007 1 commit