1. 30 Oct, 2006 3 commits
    • unknown's avatar
      A cleanup. · 26770e3a
      unknown authored
      
      sql/sql_parse.cc:
        ALTER TABLE should not be affected by DONT_ALLOW_SHOW_COMMANDS
        (a bug that's there since version 1.1)
      26770e3a
    • unknown's avatar
      Cleanup. · f6e92be9
      unknown authored
      
      sql/sql_table.cc:
        Remove unused code (it's also made obsolete by work in 5.1)
      f6e92be9
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · d17fd8c9
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.0-runtime
      
      
      d17fd8c9
  2. 27 Oct, 2006 2 commits
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.0 · aa137976
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.0-bug22584
      
      
      mysql-test/r/view.result:
        Manual merge.
      mysql-test/t/view.test:
        Manual merge.
      aa137976
    • unknown's avatar
      BUG#22584: last_insert_id not updated after inserting a record through · 532735e6
      unknown authored
      a updatable view.
      
      When there's a VIEW on a base table that have AUTO_INCREMENT column, and
      this VIEW doesn't provide an access such column, after INSERT to such
      VIEW LAST_INSERT_ID() did not return the value just generated.
      
      This behaviour is intended and correct, because if the VIEW doesn't list
      some columns then these columns are effectively hidden from the user,
      and so any side effects of inserting default values to them.
      
      However, there was a bug that such statement inserting into a view would
      reset LAST_INSERT_ID() instead of leaving it unchanged.
      
      This patch restores the original value of LAST_INSERT_ID() instead of
      resetting it to zero.
      
      
      mysql-test/r/view.result:
        Add result for bug#22584: last_insert_id not updated after inserting
        a record through a updatable view.
      mysql-test/t/view.test:
        Add test case for bug#22584: last_insert_id not updated after inserting
        a record through a updatable view.
      sql/sql_parse.cc:
        When we have inserted into a view, and AUTO_INCREMENT column is not
        accessed from this view, instead of setting LAST_INSERT_ID to zero set
        it to the value it had before this statement was executed.
      532735e6
  3. 25 Oct, 2006 4 commits
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.0 · 853fb1eb
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.0-bug18819
      
      
      mysql-test/r/innodb_mysql.result:
        Auto merged
      mysql-test/t/innodb_mysql.test:
        Auto merged
      sql/sql_delete.cc:
        Auto merged
      853fb1eb
    • unknown's avatar
      Fix after manual merge. · 6137ef86
      unknown authored
      6137ef86
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-4.1-bug18819 · e171a36e
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.0-bug18819
      
      
      mysql-test/r/innodb_mysql.result:
        Manual merge.
      mysql-test/t/innodb_mysql.test:
        Manual merge.
      sql/sql_delete.cc:
        Manual merge.
      e171a36e
    • unknown's avatar
      BUG#18819: DELETE IGNORE hangs on foreign key parent delete · e3d49f0c
      unknown authored
      If the error happens during DELETE IGNORE, nothing could be send to the
      client, thus leaving it frozen expecting the reply.
      
      The problem was that if some error occurred, it wouldn't be reported to
      the client because of IGNORE, but neither success would be reported.
      
      MySQL 4.1 would not freeze the client, but will report
      
        ERROR 1105 (HY000): Unknown error
      
      instead, which is also a bug.
      
      The solution is to report success if we are in DELETE IGNORE and some
      non-fatal error has happened.
      
      
      mysql-test/r/innodb_mysql.result:
        Add result for bug#18819: DELETE IGNORE hangs on foreign key parent
        delete.
      mysql-test/t/innodb_mysql.test:
        Add test case for bug#18819: DELETE IGNORE hangs on foreign key parent
        delete.
      sql/sql_delete.cc:
        Report success if we have got an error, but we are in DELETE IGNORE, and
        the error is not fatal (if it is, it would be reported to the client).
      e3d49f0c
  4. 24 Oct, 2006 1 commit
  5. 23 Oct, 2006 2 commits
    • unknown's avatar
      A post-merge fix. · 6831ea7d
      unknown authored
      6831ea7d
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 07cf5b9b
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.0-runtime-merge
      
      
      mysql-test/t/func_gconcat.test:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      mysql-test/r/view.result:
        Manual merge.
      mysql-test/t/view.test:
        Manual merge.
      07cf5b9b
  6. 21 Oct, 2006 1 commit
  7. 20 Oct, 2006 10 commits
    • unknown's avatar
      configure.in: · 71fee03e
      unknown authored
        Raised version number to 5.0.28
      
      
      configure.in:
        Raised version number to 5.0.28
      71fee03e
    • unknown's avatar
      Merge mysql.com:/Users/kent/mysql/bk/mysql-5.0.27-release · c416425e
      unknown authored
      into  mysql.com:/Users/kent/mysql/bk/mysql-5.0
      
      
      configure.in:
        Auto merged
      c416425e
    • unknown's avatar
      make_win_bin_dist: · 644dcbf2
      unknown authored
        Copy udf examples and raid.h
        Create target "include" directory before copying files to it
      CMakeLists.txt:
        Only compile in bdb if configured
      configure.in:
        Raised version number to 5.0.27
      
      
      scripts/make_win_bin_dist:
        Copy udf examples and raid.h
        Create target "include" directory before copying files to it
      CMakeLists.txt:
        Only compile in bdb if configured
      configure.in:
        Raised version number to 5.0.27
      644dcbf2
    • unknown's avatar
      Bug #23427: incompatible ABI change in 5.0.26? · a71a524e
      unknown authored
      Revert 1 June change enough to restore ABI compatibility with previous
      versions.
      
      
      include/mysql.h:
        Revert patch that breaks ABI compatibility
      libmysqld/lib_sql.cc:
        Remove useless assignment.
      a71a524e
    • unknown's avatar
      Instance Manager polishing. · 8db4dc3f
      unknown authored
      
      server-tools/instance-manager/guardian.cc:
        1. Removed unused stop_instances_arg from request_shutdown() and
        stop_instances() methods.
        
        2. Changed log-output statements so that instance name is passed
        correctly (char *, not LEX_STRING)
      server-tools/instance-manager/guardian.h:
        Removed unused stop_instances_arg from request_shutdown() and
        stop_instances() methods.
      server-tools/instance-manager/instance.cc:
        Removed unused stop_instances_arg from request_shutdown() and
        stop_instances() methods.
      server-tools/instance-manager/listener.cc:
        Be more verbose in log.
      server-tools/instance-manager/manager.cc:
        Removed unused stop_instances argument.
      8db4dc3f
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-runtime · a6273e6d
      unknown authored
      into  mockturtle.local:/home/dlenev/src/mysql-5.0-bg15228-2
      
      
      sql/sql_trigger.cc:
        Auto merged
      sql/sql_view.cc:
        Auto merged
      a6273e6d
    • unknown's avatar
      Fix for bug#15228 "'invalid access to non-static data member' · 1a793de9
      unknown authored
      warnings in sql_trigger.cc and sql_view.cc".
      
      According to the current version of C++ standard offsetof() macro
      can't be used for non-POD types. So warnings were emitted when we
      tried to use this macro for TABLE_LIST and Table_triggers_list
      classes. Note that despite of these warnings it was probably safe
      thing to do.
      
      This fix tries to circumvent this limitation by implementing
      custom version of offsetof() macro to be used with these
      classes. This hack should go away once we will refactor
      File_parser class.
      
      Alternative approaches such as disabling this warning for
      sql_trigger.cc/sql_view.cc or for the whole server were
      considered less explicit. Also I was unable to find a way
      to disable particular warning for particular _part_ of
      file in GCC.
      
      
      sql/parse_file.h:
        Introduced auxillary macro which can be used instead of offsetof()
        to get offsets of members in class for non-POD types without getting
        warnings (assuming that all instances of the class has same offsets
        for same members).
      sql/sql_trigger.cc:
        Use my_offsetof() macro instead of standard offsetof() macro with
        Table_triggers_list class in order to avoid warnings (offsetof()
        cannot be used for non-POD types according to the standard).
      sql/sql_view.cc:
        Use my_offsetof() macro instead of standard offsetof() macro with
        TABLE_LIST class in order to avoid warnings (offsetof() cannot
        be used for non-POD types according to the standard).
      1a793de9
    • unknown's avatar
      Merge dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-4.1-opt · ab133655
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.0-opt
      
      
      sql/sql_base.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      ab133655
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0 · 8cc48091
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.0-opt
      
      
      mysql-test/r/myisam.result:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      8cc48091
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.1 · 0153d67e
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-4.1-opt
      
      
      sql/sql_base.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      0153d67e
  8. 19 Oct, 2006 15 commits
    • unknown's avatar
      Bug#20028 (Function with select return no data) · 5bd58f3e
      unknown authored
      This patch reverts a change introduced by Bug 6951, which incorrectly
      set thd->abort_on_warning for stored procedures.
      
      As per internal discussions about the SQL_MODE=TRADITIONAL,
      the correct behavior is to *not* abort on warnings even inside an INSERT/UPDATE
      trigger.
      
      Tests for Stored Procedures, Stored Functions, Triggers involving SQL_MODE
      have been included or revised, to reflect the intended behavior.
      
      (reposting approved patch, to work around source control issues, no review needed)
      
      
      mysql-test/include/sp-vars.inc:
        Tests for SQL_MODE='TRADITIONAL'
      mysql-test/r/sp-vars.result:
        Tests for SQL_MODE='TRADITIONAL'
      mysql-test/r/sp.result:
        Tests for SQL_MODE='TRADITIONAL'
      mysql-test/r/trigger.result:
        Tests for SQL_MODE='TRADITIONAL'
      mysql-test/t/sp-vars.test:
        Tests for SQL_MODE='TRADITIONAL'
      mysql-test/t/sp.test:
        Tests for SQL_MODE='TRADITIONAL'
      mysql-test/t/trigger.test:
        Tests for SQL_MODE='TRADITIONAL'
      sql/sp_head.cc:
        For SQL_MODE='TRADITIONAL',
        thd->abort_on_warning should be set only when assigning a *column*
      5bd58f3e
    • unknown's avatar
      After merge fix. · 3ad2baa1
      unknown authored
      3ad2baa1
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/engines/mysql-4.1-engines · baacb8a1
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/engines/mysql-5.0-engines
      
      
      myisam/sort.c:
        Auto merged
      mysql-test/r/repair.result:
        Auto merged
      mysql-test/t/repair.test:
        Auto merged
      sql/sql_base.cc:
        Use local.
      baacb8a1
    • unknown's avatar
      Merge dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-4.1-opt · 5e1fe0f8
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.0-opt
      
      
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/olap.result:
        SCCS merged
      5e1fe0f8
    • unknown's avatar
      Merge dl145s.mysql.com:/data/bk/team_tree_merge/mysql-5.0 · d3018677
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.0-opt
      
      
      mysql-test/r/merge.result:
        Auto merged
      mysql-test/r/myisam.result:
        Auto merged
      mysql-test/r/select.result:
        Auto merged
      mysql-test/r/view.result:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/opt_range.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      sql/table.cc:
        Auto merged
      d3018677
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/BUG23175/mysql-4.1-engines · 2576c4c0
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/engines/mysql-4.1-engines
      
      
      mysql-test/r/repair.result:
        Manual merge.
      mysql-test/t/repair.test:
        Manual merge.
      2576c4c0
    • unknown's avatar
      Merge dl145s.mysql.com:/data/bk/team_tree_merge/mysql-4.1 · 9bfaab57
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-4.1-opt
      
      
      sql/sql_select.cc:
        Auto merged
      9bfaab57
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/BUG22562/mysql-4.1-engines · f841b546
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/engines/mysql-4.1-engines
      
      
      f841b546
    • unknown's avatar
      Bug#21476 - Lost Database Connection During Query · 862d8bab
      unknown authored
      Backport from 5.1.
      Raised STACK_MIN_SIZE for Debian GNU/Linux Sid,
      Linux kernel 2.6.16,
      gcc version 3.3.6 (Debian 1:3.3.6-13),
      libc6-dbg 2.3.6.ds1-4,
      Pentium4 (x86),
      BUILD/compile-pentium-debug-max
      Raised about 100 Bytes above the required minimum.
      
      
      862d8bab
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.0 · de304106
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.0-bug21856
      
      
      sql/sql_parse.cc:
        Auto merged
      mysql-test/r/ps.result:
        Manual merge.
      mysql-test/t/ps.test:
        Manual merge.
      de304106
    • unknown's avatar
      BUG#21856: Prepared Statements: crash if bad create · ef2d2165
      unknown authored
      When statement to be prepared contained CREATE PROCEDURE, CREATE FUNCTION
      or CREATE TRIGGER statements with a syntax error in it, the preparation
      would fail with syntax error message, but the memory could be corrupted.
      
      The problem occurred because we switch memroot when parse stored
      routine or trigger definitions, and on parse error we restored the
      original memroot only after performing some memory operations.  In more
      detail:
       - prepared statement would activate its own memory root to parse
         the definition of the stored procedure.
       - SP would reset this memory root with its own memory root to
         parse SP statements
       - a syntax error would happen
       - prepared statement would restore the original memory root
       - stored procedure would restore what it thinks was the original
         memory root, but actually was the statement memory root.
      That led to double free - in destruction of the statement and in
      a next call to mysql_parse().
      
      The solution is to restore memroot right after the failed parsing.
      
      
      mysql-test/r/ps.result:
        Add result for bug#21856: Prepared Statements: crash if bad create.
      mysql-test/t/ps.test:
        Add test case for bug#21856: Prepared Statements: crash if bad create.
      sql/sql_parse.cc:
        On parse error if thd->lex->sphead is set we have to free sp_head object
        to restore statement memroot, if it was switched during parsing.
        
        The change here is for safety, currently query_cache_abort() and
        lex->unit.cleanup() calls do not use current memroot.
      sql/sql_prepare.cc:
        On parse error if thd->lex->sphead is set we have to free sp_head object
        to restore statement memroot, if it was switched during parsing.
      ef2d2165
    • unknown's avatar
      Merge chilla.local:/home/mydev/mysql-4.1-merge · 0e5fee5d
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.0-merge
      
      
      include/my_sys.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      0e5fee5d
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 554aaed3
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.0-merge
      
      
      sql/sql_select.cc:
        Auto merged
      554aaed3
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · a4a09cd2
      unknown authored
      into  chilla.local:/home/mydev/mysql-4.1-merge
      
      
      a4a09cd2
    • unknown's avatar
  9. 18 Oct, 2006 2 commits
    • unknown's avatar
      Merge mysql.com:/data0/bk/mysql-5.0 · ea39ca34
      unknown authored
      into  mysql.com:/data0/bk/mysql-5.0-kt
      
      
      ea39ca34
    • unknown's avatar
      BUG#23175 - MYISAM crash/repair failed during repair · 48cf65c0
      unknown authored
      Repair table could crash a server if there is not sufficient
      memory (myisam_sort_buffer_size) to operate. Affects not only
      repair, but also all statements that use create index by sort:
      repair by sort, parallel repair, bulk insert.
      
      Return an error if there is not sufficient memory to store at
      least one key per BUFFPEK.
      
      Also fixed memory leak if thr_find_all_keys returns an error.
      
      
      myisam/sort.c:
        maxbuffer is number of BUFFPEK-s for repair. It is calculated
        as records / keys. keys is number of keys that can be stored
        in memory (myisam_sort_buffer_size). There must be sufficient
        memory to store both BUFFPEK-s and keys. It was checked
        correctly before this patch. However there is another
        requirement that wasn't checked: there must be sufficient
        memory for at least one key per BUFFPEK, otherwise repair
        by sort/parallel repair cannot operate.
        
        Return an error if there is not sufficient memory to store at
        least one key per BUFFPEK.
        
        Also fixed memory leak if thr_find_all_keys returns an error.
      mysql-test/r/repair.result:
        A test case for BUG#23175.
      mysql-test/t/repair.test:
        A test case for BUG#23175.
      48cf65c0