- 21 Feb, 2008 4 commits
-
-
davi@buzz.(none) authored
-
davi@mysql.com/endora.local authored
The problem is that CREATE VIEW statements inside prepared statements weren't being expanded during the prepare phase, which leads to objects not being allocated in the appropriate memory arenas. The solution is to perform the validation of CREATE VIEW statements during the prepare phase of a prepared statement. The validation during the prepare phase assures that transformations of the parsed tree will use the permanent arena of the prepared statement.
-
anozdrin/alik@quad. authored
a table name. The problem was that fill_defined_view_parts() did not return an error if a table is going to be altered. That happened if the table was already in the table cache. In that case, open_table() returned non-NULL value (valid TABLE-instance from the cache). The fix is to ensure that an error is thrown even if the table is in the cache. (This is a backport of the original patch for 5.1)
-
davi@mysql.com/endora.local authored
by patch for bug 32265 .
-
- 20 Feb, 2008 1 commit
-
-
davi@mysql.com/endora.local authored
Executing a prepared statement associated with a materialized cursor yields to the client a metadata packet with wrong table and database names. The problem was occurring because the server was sending the the name of the temporary table used by the cursor instead of the table name of the original table. The same problem occurs when selecting from views, in which case the table name was being sent and not the name of the view. The solution is to fill the list item from the temporary table but preserving the table and database names of the original fields. This is achieved by tweaking the Select_materialize to accept a pointer to the Materialized_cursor class which contains the item list to be filled.
-
- 11 Feb, 2008 2 commits
-
-
mkindahl@dl145h.mysql.com authored
into dl145h.mysql.com:/data0/mkindahl/mysql-5.0-rpl-merge
-
mkindahl@dl145h.mysql.com authored
into dl145h.mysql.com:/data0/mkindahl/mysql-5.0-rpl-merge
-
- 08 Feb, 2008 2 commits
-
-
kostja@dipika.(none) authored
into dipika.(none):/opt/local/work/mysql-5.0-runtime
-
davi@mysql.com/endora.local authored
The unsignedness of large integer user variables was not being properly preserved when feeded to prepared statements. This was happening because the unsigned flags wasn't being updated when converting the user variable is converted to a parameter. The solution is to copy the unsigned flag when converting the user variable to a parameter and take the unsigned flag into account when converting the integer to a string.
-
- 07 Feb, 2008 2 commits
-
-
kostja@dipika.(none) authored
-
msvensson@pilot.mysql.com authored
into pilot.mysql.com:/data/msvensson/mysql/mysql-5.0-runtime
-
- 06 Feb, 2008 2 commits
-
-
sven@riska.(none) authored
slash in filenames also for Create_file_log_event.
-
-
- 05 Feb, 2008 1 commit
-
-
aelkin/elkin@koti.dsl.inet.fi authored
to leave The artifact was caused by a flaw in concurrent accessing the slave's io thd by the io itself and a handling show slave status thread. Namely, show_master_info did not acquire mi->run_lock mutex that is specified for mi->io_thd member. Fixed with deploying the mutex locking and unlocking. The mutex is kept short time and without interleaving with mi->data_lock mutex. Todo: to report and fix an issue with sys_var_slave_skip_counter::{methods} seem to acquire incorrectly active_mi->rli.run_lock instead of the specified active_mi->rli.data_lock A test case is difficult to compose, so rpl_packet should continue serving as the indicator.
-
- 04 Feb, 2008 2 commits
-
-
mkindahl@dl145h.mysql.com authored
-
mkindahl@dl145h.mysql.com authored
-
- 01 Feb, 2008 6 commits
-
-
cbell/Chuck@mysql_cab_desk. authored
into mysql_cab_desk.:D:/source/c++/mysql-5.0-rpl-merge
-
cbell/Chuck@mysql_cab_desk. authored
This patch adds code to convert the path for LOAD DATA INFILE events to a Unix path which is needed for running mysql client on Windows.
-
mkindahl@dl145h.mysql.com authored
on the context.
-
mkindahl@dl145h.mysql.com authored
-
mkindahl@dl145h.mysql.com authored
-
mkindahl@dl145h.mysql.com authored
-
- 31 Jan, 2008 3 commits
-
-
mkindahl@dl145h.mysql.com authored
into dl145h.mysql.com:/data0/mkindahl/mysql-5.0-rpl-merge
-
mkindahl@dl145h.mysql.com authored
-
mkindahl@dl145h.mysql.com authored
-
- 30 Jan, 2008 4 commits
-
-
mkindahl@dl145h.mysql.com authored
-
mkindahl@dl145h.mysql.com authored
-
mkindahl@dl145h.mysql.com authored
into dl145h.mysql.com:/data0/mkindahl/mysql-5.0-rpl-merge
-
hezx@mail.hezx.com authored
into mail.hezx.com:/media/sda3/work/mysql/bkwork/bug26489_corruption_in_relay_log/5.0
-
- 29 Jan, 2008 2 commits
-
-
hezx@mail.hezx.com authored
-
hezx@mail.hezx.com authored
Here is the scenario that causes the failure.(by Mats) 1. The to-be corrupt log event (let's call it X), is split into two packets B and C on the network level (net_write_buff()). The parts are X = (x',x''). The part x' ends up in packet B and part x'' ends up in packet C. Prior to the corrupt event X, the event Y has been written successfully, but has been split into two packets as well, which we call (y',y''). 2. The master sends packet A = (y'',x') to the slave, increases the packet sequence number, the slave receives the packet, but fails to reply before the master gets a timeout. 3. Since the master got a timeout, it reports failure, and aborts sending the binary log by exiting mysql_binlog_send(). However, it leaves the buffer intact, still holding y'' (but not x', since the write_pos is not increased). 4. After exiting mysql_binlog_send(), the master does a disconnection of the client thread, which involves sending an error message e to the client (i.e., the slave). 5. In this case, net_write_buff() is used again, but this time the old contents of the packet is used so that the new packet is D = (y'',e). Note that this will use a new packet sequence number, since the packet number was increased in step 2. 6. The slave receives the tail y'' of the Y log event, concatenates this with x' (which it already received), and writes the event (x',y'') it to the relay log since it hasn't noticed anything is amiss. 7. It then tries to read more bytes, which is either e (if the length given for X just happened to match the length given for Y, or just plain garbage because the slave is out of sync with what is actually sent. 8. After a while, the SQL thread tries to execute the event (x',y''), which is very likely to be just nonsense. The problem can be fixed by not resetting net->error after the call of mysql_binlog_send, so the error message will not be sent and the connection will be closed.
-
- 27 Jan, 2008 1 commit
-
-
tsmith@ramayana.hindu.god authored
and so that it works correctly on Windows.
-
- 25 Jan, 2008 3 commits
-
-
tsmith@ramayana.hindu.god authored
-
tsmith@ramayana.hindu.god authored
into ramayana.hindu.god:/home/tsmith/m/bk/maint/50
-
hezx@mail.hezx.com authored
The problem is when create/rename/drop users, the statement was logged regardless of error, even if no data has been changed, the statement was logged. After this patch, create/rename/drop users don't write the binlog if the statement makes no changes, if the statement does make any changes, log the statement with possible error code. This patch is based on the patch for BUG#29749, which is not pushed
-
- 24 Jan, 2008 1 commit
-
-
anozdrin/alik@quad. authored
into quad.:/mnt/raid/alik/MySQL/devel/5.0-rt-merged-5.0
-
- 23 Jan, 2008 4 commits
-
-
malff@lambda.hsd1.co.comcast.net. authored
-
malff@lambda.hsd1.co.comcast.net. authored
into lambda.hsd1.co.comcast.net.:/home/malff/TREE/mysql-5.0-33618
-
malff@lambda.hsd1.co.comcast.net. authored
Bug 33983 (Stored Procedures: wrong end <label> syntax is accepted) The server used to crash when REPEAT or another control instruction was used in conjunction with labels and a LEAVE instruction. The crash was caused by a missing "pop" of handlers or cursors in the code representing the stored program. When executing the code in a loop, this missing "pop" would result in a stack overflow, corrupting memory. Code generation has been fixed to produce the missing h_pop/c_pop instructions. Also, the logic checking that labels at the beginning and the end of a statement are matched was incorrect, causing Bug 33983. End labels, when used, must match the label used at the beginning of a block.
-
tsmith@ramayana.hindu.god authored
into ramayana.hindu.god:/home/tsmith/m/bk/maint/50
-