1. 06 Oct, 2015 2 commits
  2. 30 Sep, 2015 1 commit
  3. 29 Sep, 2015 1 commit
  4. 28 Sep, 2015 2 commits
  5. 27 Sep, 2015 2 commits
  6. 25 Sep, 2015 2 commits
  7. 24 Sep, 2015 2 commits
  8. 07 Sep, 2015 1 commit
  9. 04 Sep, 2015 1 commit
  10. 04 Aug, 2015 1 commit
  11. 03 Aug, 2015 1 commit
  12. 01 Aug, 2015 3 commits
  13. 31 Jul, 2015 10 commits
  14. 29 Jul, 2015 1 commit
  15. 25 Jul, 2015 2 commits
    • Monty's avatar
      Fixed memory loss detected on P8. This can happen when we call after_flush but... · e40bc659
      Monty authored
      Fixed memory loss detected on P8. This can happen when we call after_flush but never call after_rollback() or after_commit().
      
      The old code used pthread_setspecific() to store temporary data used by the thread.
      This is not safe when used with thread pool, as the thread may change for the transaction.
      
      The fix is to save the data in THD, which is guaranteed to be properly freed.
      I also fixed the code so that we don't do a malloc() for every transaction.
      e40bc659
    • Monty's avatar
      Fixed warnings and errors found by buildbot · 71153414
      Monty authored
      field.cc
      - Fixed warning about overlapping memory copy (backport from 10.0)
      
      Item_subselect.cc
      - Fixed core dump in main.view
      - Problem was that thd->lex->current_select->master_unit()->item was not set, which caused crash in maxr_as_dependent
      
      sql/mysqld.cc
      - Got error on shutdown as we where freeing mutex before all THD objects was freed
        (~THD uses some mutex). Fixed by during shutdown freeing THD inside mutex.
      
      sql/log.cc
      - log_space_lock and LOCK_log where locked in inconsistenly. Fixed by not having a log_space_lock around purge_logs.
      
      sql/slave.cc
      - Remove unnecessary log_space_lock
      - Move cond_broadcast inside lock to ensure we don't miss the signal
      71153414
  16. 21 Jul, 2015 1 commit
    • Jan Lindström's avatar
      MDEV-8474: InnoDB sets per-connection data unsafely · 7a967021
      Jan Lindström authored
      Analysis: At check_trx_exists function InnoDB allocates
      a new trx if no trx is found from thd but this newly
      allocated trx is not registered to thd. This is unsafe,
      because nothing prevents InnoDB plugin from being uninstalled
      while there's active transaction. This can cause crashes, hang
      and any other odd behavior. It may also corrupt stack, as
      functions pointers are not available after dlclose.
      
      Fix: The fix is to use thd_set_ha_data() when
      manipulating per-connection handler data. It does appropriate
      plugin locking.
      7a967021
  17. 16 Jul, 2015 3 commits
    • Monty's avatar
      a63d8738
    • Monty's avatar
      MDEV-8432 Slave cannot replicate signed integer-type values with high bit set to 1 · 00d3b20f
      Monty authored
      The fix is that if the slave has a different integer size than
      the master, then they will assume the master has the same signed/unsigned modifier
      as the slave.
      
      This means that one can safely change a coon the slave an int to a bigint
      or an unsigned int to an unsigned int.  Changing an unsigned int to an
      signed bigint will cause replication failures when the high bit of the
      unsigned int is set.
      
      We can't give an error if the signess is different on the master and slave
      as the binary log doesn't contain the signess of the column on the master.
      00d3b20f
    • Monty's avatar
      MDEV-8432 Slave cannot replicate signed integer-type values with high bit set to 1 · 44de090a
      Monty authored
      The fix is that if the slave has a different integer size than
      the master, then they will assume the master has the same signed/unsigned modifier
      as the slave.
      
      This means that one can safely change a coon the slave an int to a bigint
      or an unsigned int to an unsigned int.  Changing an unsigned int to an
      signed bigint will cause replication failures when the high bit of the
      unsigned int is set.
      
      We can't give an error if the signess is different on the master and slave
      as the binary log doesn't contain the signess of the column on the master.
      44de090a
  18. 26 Jun, 2015 1 commit
  19. 25 Jun, 2015 3 commits
    • Monty's avatar
      Simple cleanups · 67c56ab1
      Monty authored
      - Removing use of calls to current_thd
      - More DBUG_PRINT
      - Code style changes
      - Made some local functions static
      Ensure that calls to print_keyuse are locked with mutex to get all lines in same debug packet
      67c56ab1
    • Monty's avatar
      Problem was that for cases like: · 8c815751
      Monty authored
      SELECT ... WHERE XX IN (SELECT YY)
      this was transformed to something like:
      SELECT ... WHERE IF_EXISTS(SELECT ... HAVING XX=YY)
      
      The bug was that for normal execution XX was fixed in the original outer SELECT context while in PS it was fixed in the sub query context and this confused the optimizer.
      
      Fixed by ensuring that XX is always fixed in the outer context.
      8c815751
    • Monty's avatar
      Fixed crashing bug when using ONLY_FULL_GROUP_BY in a stored procedure/trigger... · 2e941fe9
      Monty authored
      Fixed crashing bug when using ONLY_FULL_GROUP_BY in a stored procedure/trigger that is repeatedly executed.
      This is MDEV-7601, including it's sub tasks MDEV-7594, MDEV-7555, MDEV-7590, MDEV-7581, MDEV-7589
      
      The problem was that select_lex->non_agg_fields was not properly reset for re-execution and this caused an overwrite of a random memory position.
      The fix was move non_agg_fields from select_lext to JOIN, which is properly reset.
      2e941fe9