1. 22 Apr, 2006 2 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-runtime · 2efefe68
      unknown authored
      into  mysql.com:/home/dlenev/mysql-5.0-bg15153-2
      
      
      2efefe68
    • unknown's avatar
      Fix for bug#15153 "CONVERT_TZ() is not allowed in all places in VIEWs". · dc526db8
      unknown authored
      Error was emitted when one tried to select information from view which used
      merge algorithm and which also had CONVERT_TZ() function in its select list.
      
      This bug was caused by wrong assumption that global table list for view
      which is handled using merge algorithm begins from tables belonging to
      the main select of this view. Nowadays the above assumption is not true only
      when one uses convert_tz() function in view's select list, but in future
      other cases may be added (for example we may support merging of views
      with subqueries in select list one day). Relying on this false assumption
      led to the usage of wrong table list for field lookups and therefor errors. 
      
      With this fix we explicitly use pointer to the beginning of main select's
      table list.
      
      
      mysql-test/r/timezone_grant.result:
        Added additional test case for bug#15153 "CONVERT_TZ() is not allowed in
        all places in VIEWs" that checks that usage of CONVERT_TZ() function in view
        does not require additional privileges.
      mysql-test/r/view.result:
        Added test case for bug#15153 "CONVERT_TZ() is not allowed in all places in 
        VIEWs".
      mysql-test/t/timezone_grant.test:
        Added additional test case for bug#15153 "CONVERT_TZ() is not allowed in
        all places in VIEWs" that checks that usage of CONVERT_TZ() function in view
        does not require additional privileges.
      mysql-test/t/view.test:
        Added test case for bug#15153 "CONVERT_TZ() is not allowed in all places in 
        VIEWs".
      sql/sql_view.cc:
        mysql_make_view():
          We should not assume that global table list for view which is handled using
          merge algorithm begins from tables belonging to the main select of this
          view. Nowadays the above assumption is not true only when one uses
          convert_tz() function in view's select list, but in future other cases
          may be added (for example we may support merging of views with subqueries
          in select list one day). So let us instead explicitly use pointer to the
          beginning of main select's table list.
      dc526db8
  2. 21 Apr, 2006 3 commits
  3. 20 Apr, 2006 1 commit
  4. 19 Apr, 2006 3 commits
  5. 18 Apr, 2006 5 commits
    • unknown's avatar
      Fixed BUG#18344: DROP DATABASE does not drop associated routines · 176cd143
      unknown authored
        We must use the db key length in sp_drop_db_routines (and not the
        number of characters), or long db names will be truncated in the key.
      
      
      mysql-test/r/sp.result:
        Updated results for new test case (BUG#18344)
      mysql-test/t/sp.test:
        Added new test case for BUG#18344.
      sql/sp.cc:
        In sp_drop_db_routines(), give the key field's ("db") key length
        instead of the number of characters to index_read(), or the key
        packing will truncate long db names.
      176cd143
    • unknown's avatar
      Merge mysql.com:/extern/mysql/bk/mysql-5.0-runtime · 750bc269
      unknown authored
      into  mysql.com:/extern/mysql/5.0/bug18787/mysql-5.0-runtime
      
      
      mysql-test/r/sp.result:
        Auto merged
      mysql-test/t/sp.test:
        Auto merged
      sql/item_func.cc:
        Auto merged
      750bc269
    • unknown's avatar
      Post-review fix for BUG#18787. Renamed a local variable in · d9142f99
      unknown authored
      Item_func_sp::tmp_table_field() to something more descriptive.
      
      
      sql/item_func.cc:
        Renamed local variable 'res' to 'field' in Item_func_sp::tmp_table_field(),
        because it is.
      d9142f99
    • unknown's avatar
      Fixed BUG#18949: Test case sp-goto is disabled · 661165ee
      unknown authored
        Removed sp-goto.test, sp-goto.result and all (disabled) GOTO code.
        Also removed some related code that's not needed any more (no possible
        unresolved label references any more, so no need to check for them).
        NB: Keeping the ER_SP_GOTO_IN_HNDLR in errmsg.txt; it might become useful
            in the future, and removing it (and thus re-enumerating error codes)
            might upset things. (Anything referring to explicit error codes.)
      
      
      BitKeeper/deleted/.del-sp-goto.result~f343103c63f64b7a:
        Delete: mysql-test/r/sp-goto.result
      BitKeeper/deleted/.del-sp-goto.test~5054d3f729692d3d:
        Delete: mysql-test/t/sp-goto.test
      mysql-test/t/disabled.def:
        sp-goto.test no longer exists.
      sql/lex.h:
        Removed (disabled) GOTO definitions.
      sql/sp_head.cc:
        Removed sp_head::check_backpatch() and simplified sp_head::backpatch().
        Without GOTO, unresolved label references are not possible, so no need
        to check for them.
      sql/sp_head.h:
        Removed sp_head::check_backpatch(). (Not needed with no GOTO)
      sql/sp_pcontext.cc:
        SP_LAB_GOTO was renamed to SP_LAB_IMPL
      sql/sp_pcontext.h:
        Removed SP_LAB_REF (no longer needed) and renamed SP_LAB_GOTO
        to SP_LAB_IMPL, since it's only used for implicit labels now.
      sql/sql_yacc.yy:
        Removed GOTO symbols and (disabled) code, and the no longer needed
        sp_head::check_backpatch() calls.
      661165ee
    • unknown's avatar
      Merge mysql.com:/home/stewart/Documents/MySQL/4.1/bug18881 · da35bb1b
      unknown authored
      into  mysql.com:/home/stewart/Documents/MySQL/5.0/merge
      
      
      ndb/src/kernel/vm/Emulator.cpp:
        Auto merged
      da35bb1b
  6. 17 Apr, 2006 5 commits
  7. 16 Apr, 2006 1 commit
    • unknown's avatar
      Only expand the empty string to the letters "NULL" if the column · 1e2bde0d
      unknown authored
      does not have "NOT NULL" attribute set.  Also, calculate the padding
      characters more safely, so that a negative number doesn't cause it to 
      print MAXINT-n spaces.
      
      
      mysql-test/r/mysql.result:
        Add test result.
      mysql-test/t/mysql.test:
        Add test.
      1e2bde0d
  8. 15 Apr, 2006 1 commit
  9. 14 Apr, 2006 2 commits
  10. 13 Apr, 2006 17 commits