1. 01 Dec, 2006 1 commit
    • unknown's avatar
      Bug#22043 MySQL don't add "USE <DATABASE>" before "DROP PROCEDURE IF EXISTS" · 2f0b1d65
      unknown authored
      - Refactoring of duplicate code
      - Modified bad test cases
      - Changed expected error when operating on information_schema.
      
      
      mysql-test/r/information_schema.result:
        - updated result file with new error code.
      mysql-test/r/rpl_sp.result:
        - Modified test case
      mysql-test/t/information_schema.test:
        - Changed error code for operations on information_schema
      mysql-test/t/rpl_sp.test:
        - Modified test case
      sql/sql_parse.cc:
        - Cleaned up code:
          * replace tab with space
          * simplified if/switch statements
          * refactored duplicated code
      2f0b1d65
  2. 28 Nov, 2006 1 commit
    • unknown's avatar
      Bug#22043 MySQL don't add "USE <DATABASE>" before "DROP PROCEDURE EXISTS" · 9a87702b
      unknown authored
      - CREATE PROCEDURE stores database name based on query context instead
        of 'current database' as set by 'USE' according to manual.
        The bug reporter interpret the filtering statements as bug for
         DROP PROCEDURE based on this behavior.
      - Removed the code which changes db context.
      - Added code to check that a valid db was supplied.  
      
      
      mysql-test/r/rpl_sp.result:
        - Added test case (result)
      mysql-test/t/rpl_sp.test:
        - Added test case
      sql/sp.cc:
        - Removed code for changing current db context.
      sql/sql_parse.cc:
        - Added code to check if a valid db was supplied.
      9a87702b
  3. 27 Nov, 2006 1 commit
    • unknown's avatar
      Fix for bug #21587: FLUSH TABLES causes server crash when used with HANDLER statements · 838b5378
      unknown authored
      Problems (appear only under some circumstances): 
        1. we get a reference to a deleted table searching in the 
           thd->handler_tables_hash in the mysql_ha_read().
      
        2. DBUG_ASSERT(table->file->inited == handler::NONE); assert fails in the
           close_thread_table().
      
      Fix: end open index scans and table scans and remove references to the 
      tables from the handler tables hash. After this preparation it is safe 
      to close the tables. The close can no longer fail on open index/table 
      scans and the closed table will not be used again by handler functions.
                                       
      
      
      sql/mysql_priv.h:
        Fix for bug #21587: FLUSH TABLES causes server crash when used with HANDLER statements
          - mysql_ha_mark_tables_for_reopen() introduced.
      sql/sql_base.cc:
        Fix for bug #21587: FLUSH TABLES causes server crash when used with HANDLER statements
          - call mysql_ha_mark_tables_for_reopen() to prepare for the following close.
      sql/sql_handler.cc:
        Fix for bug #21587: FLUSH TABLES causes server crash when used with HANDLER statements
          - mysql_ha_mark_tables_for_reopen() function introduced.
      838b5378
  4. 10 Nov, 2006 1 commit
  5. 09 Nov, 2006 3 commits
    • unknown's avatar
      Merge quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/inno/41 · 44f15cae
      unknown authored
      into  quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/inno/50
      
      
      innobase/fil/fil0fil.c:
        use local
      44f15cae
    • unknown's avatar
      This ChangeSet must be null-merged to 5.0. Applied innodb-4.1-ss33 · 870b2e0a
      unknown authored
      Fixes:
      - Bug #24089: Race condition in fil_flush_file_spaces()
      
      
      innobase/fil/fil0fil.c:
        Applied innodb-4.1-ss33
        
        Revision r33:
        innodb-4.1: Merge r1002 from innodb/trunk:
        
        fil_flush_file_spaces(): Copy the system->unflushed_spaces list to an
        array while holding the mutex.  This removes the crash-triggering
        race condition that was introduced when fixing Bug 15653.  (Bug #24089)
      870b2e0a
    • unknown's avatar
      This ChangeSet must be null-merged to 5.1. Applied innodb-5.0-ss982, -ss998, -ss1003 · c12c382f
      unknown authored
      Fixes:
      - Bug #15815: Very poor performance with multiple queries running concurrently
      - Bug #22868: 'Thread thrashing' with > 50 concurrent conns under an upd-intensive workloadw
      - Bug #23769: Debug assertion failure with innodb_locks_unsafe_for_binlog
      - Bug #24089: Race condition in fil_flush_file_spaces()
      
      
      innobase/buf/buf0buf.c:
        Applied innodb-5.0-ss982, -ss998, -ss1003
        
        Revision r1000:
        branches/5.0: Merge r999 from trunk:
        
        Reduce buffer pool mutex contention under >= 4 big concurrent
        CPU-bound SELECT queries.  (Bug #22868)
        
        Fix: replace the mutex by one mutex protecting the 'flush list'
        (and the free list) and several mutexes protecting portions of the
        buffer pool, where we keep several indivudual LRU lists of pages.
        
        This patch is from Sunny Bains and Heikki Tuuri.
      innobase/buf/buf0flu.c:
        Applied innodb-5.0-ss982, -ss998, -ss1003
        
        Revision r1000:
        branches/5.0: Merge r999 from trunk:
        
        Reduce buffer pool mutex contention under >= 4 big concurrent
        CPU-bound SELECT queries.  (Bug #22868)
        
        Fix: replace the mutex by one mutex protecting the 'flush list'
        (and the free list) and several mutexes protecting portions of the
        buffer pool, where we keep several indivudual LRU lists of pages.
        
        This patch is from Sunny Bains and Heikki Tuuri.
      innobase/buf/buf0lru.c:
        Applied innodb-5.0-ss982, -ss998, -ss1003
        
        Revision r1000:
        branches/5.0: Merge r999 from trunk:
        
        Reduce buffer pool mutex contention under >= 4 big concurrent
        CPU-bound SELECT queries.  (Bug #22868)
        
        Fix: replace the mutex by one mutex protecting the 'flush list'
        (and the free list) and several mutexes protecting portions of the
        buffer pool, where we keep several indivudual LRU lists of pages.
        
        This patch is from Sunny Bains and Heikki Tuuri.
      innobase/dict/dict0crea.c:
        Applied innodb-5.0-ss982, -ss998, -ss1003
        
        Revision r974:
        branches/5.0: Port r973 from trunk.
        
        Do not break the latching order in TRUNCATE TABLE.
        
        dict_truncate_index_tree(): Replace parameter rec_t* rec with
        btr_pcur_t* pcur.  Reposition pcur before calling btr_create().
        
        sync_thread_add_level(): Remove the relaxation of the assertion added in r968.
      innobase/fil/fil0fil.c:
        Applied innodb-5.0-ss982, -ss998, -ss1003
        
        Revision r1003:
        branches/5.0: Merge r1002 from trunk:
        
        fil_flush_file_spaces(): Copy the system->unflushed_spaces list to an
        array while holding the mutex.  This removes the crash-triggering
        race condition that was introduced when fixing Bug 15653.  (Bug #24089)
      innobase/include/buf0buf.h:
        Applied innodb-5.0-ss982, -ss998, -ss1003
        
        Revision r1000:
        branches/5.0: Merge r999 from trunk:
        
        Reduce buffer pool mutex contention under >= 4 big concurrent
        CPU-bound SELECT queries.  (Bug #22868)
        
        Fix: replace the mutex by one mutex protecting the 'flush list'
        (and the free list) and several mutexes protecting portions of the
        buffer pool, where we keep several indivudual LRU lists of pages.
        
        This patch is from Sunny Bains and Heikki Tuuri.
      innobase/include/buf0buf.ic:
        Applied innodb-5.0-ss982, -ss998, -ss1003
        
        Revision r1000:
        branches/5.0: Merge r999 from trunk:
        
        Reduce buffer pool mutex contention under >= 4 big concurrent
        CPU-bound SELECT queries.  (Bug #22868)
        
        Fix: replace the mutex by one mutex protecting the 'flush list'
        (and the free list) and several mutexes protecting portions of the
        buffer pool, where we keep several indivudual LRU lists of pages.
        
        This patch is from Sunny Bains and Heikki Tuuri.
      innobase/include/dict0crea.h:
        Applied innodb-5.0-ss982, -ss998, -ss1003
        
        Revision r974:
        branches/5.0: Port r973 from trunk.
        
        Do not break the latching order in TRUNCATE TABLE.
        
        dict_truncate_index_tree(): Replace parameter rec_t* rec with
        btr_pcur_t* pcur.  Reposition pcur before calling btr_create().
        
        sync_thread_add_level(): Remove the relaxation of the assertion added in r968.
      innobase/include/sync0arr.h:
        Applied innodb-5.0-ss982, -ss998, -ss1003
        
        Revision r1001:
        branches/5.0: Reduce locking contention:
        
        Bug #15815: 'Thread thrashing' with > 50 concurrent connections under
        an update-intensive workload.
        Fix: Introduce one event per InnoDB semaphore.
        
        This patch is from Sunny Bains and Heikki Tuuri.
        This patch will not be merged to trunk (MySQL/InnoDB 5.1) yet,
        because it tries to address the problem in a different way.
      innobase/include/sync0rw.h:
        Applied innodb-5.0-ss982, -ss998, -ss1003
        
        Revision r1001:
        branches/5.0: Reduce locking contention:
        
        Bug #15815: 'Thread thrashing' with > 50 concurrent connections under
        an update-intensive workload.
        Fix: Introduce one event per InnoDB semaphore.
        
        This patch is from Sunny Bains and Heikki Tuuri.
        This patch will not be merged to trunk (MySQL/InnoDB 5.1) yet,
        because it tries to address the problem in a different way.
      innobase/include/sync0rw.ic:
        Applied innodb-5.0-ss982, -ss998, -ss1003
        
        Revision r1001:
        branches/5.0: Reduce locking contention:
        
        Bug #15815: 'Thread thrashing' with > 50 concurrent connections under
        an update-intensive workload.
        Fix: Introduce one event per InnoDB semaphore.
        
        This patch is from Sunny Bains and Heikki Tuuri.
        This patch will not be merged to trunk (MySQL/InnoDB 5.1) yet,
        because it tries to address the problem in a different way.
      innobase/include/sync0sync.h:
        Applied innodb-5.0-ss982, -ss998, -ss1003
        
        Revision r1001:
        branches/5.0: Reduce locking contention:
        
        Bug #15815: 'Thread thrashing' with > 50 concurrent connections under
        an update-intensive workload.
        Fix: Introduce one event per InnoDB semaphore.
        
        This patch is from Sunny Bains and Heikki Tuuri.
        This patch will not be merged to trunk (MySQL/InnoDB 5.1) yet,
        because it tries to address the problem in a different way.
      innobase/os/os0sync.c:
        Applied innodb-5.0-ss982, -ss998, -ss1003
        
        Revision r1001:
        branches/5.0: Reduce locking contention:
        
        Bug #15815: 'Thread thrashing' with > 50 concurrent connections under
        an update-intensive workload.
        Fix: Introduce one event per InnoDB semaphore.
        
        This patch is from Sunny Bains and Heikki Tuuri.
        This patch will not be merged to trunk (MySQL/InnoDB 5.1) yet,
        because it tries to address the problem in a different way.
      innobase/row/row0mysql.c:
        Applied innodb-5.0-ss982, -ss998, -ss1003
        
        Revision r974:
        branches/5.0: Port r973 from trunk.
        
        Do not break the latching order in TRUNCATE TABLE.
        
        dict_truncate_index_tree(): Replace parameter rec_t* rec with
        btr_pcur_t* pcur.  Reposition pcur before calling btr_create().
        
        sync_thread_add_level(): Remove the relaxation of the assertion added in r968.
      innobase/row/row0sel.c:
        Applied innodb-5.0-ss982, -ss998, -ss1003
        
        Revision r982:
        branches/5.0: row_sel(): Do not try to acquire a LOCK_REC_NOT_GAP lock
        on the supremum record.  Instead, skip to the next record.  (Bug #23769)
        This fix was backported from r623 in the 5.1 tree.
      innobase/srv/srv0start.c:
        Applied innodb-5.0-ss982, -ss998, -ss1003
        
        Revision r926:
        Refer to bug: 22268. Since no one tries to run 5.0 on Windows 95/ME it was
        decided to raise the limit of srv_max_n_threads to 10000 on Windows.
      innobase/sync/sync0arr.c:
        Applied innodb-5.0-ss982, -ss998, -ss1003
        
        Revision r1001:
        branches/5.0: Reduce locking contention:
        
        Bug #15815: 'Thread thrashing' with > 50 concurrent connections under
        an update-intensive workload.
        Fix: Introduce one event per InnoDB semaphore.
        
        This patch is from Sunny Bains and Heikki Tuuri.
        This patch will not be merged to trunk (MySQL/InnoDB 5.1) yet,
        because it tries to address the problem in a different way.
      innobase/sync/sync0rw.c:
        Applied innodb-5.0-ss982, -ss998, -ss1003
        
        Revision r1001:
        branches/5.0: Reduce locking contention:
        
        Bug #15815: 'Thread thrashing' with > 50 concurrent connections under
        an update-intensive workload.
        Fix: Introduce one event per InnoDB semaphore.
        
        This patch is from Sunny Bains and Heikki Tuuri.
        This patch will not be merged to trunk (MySQL/InnoDB 5.1) yet,
        because it tries to address the problem in a different way.
      innobase/sync/sync0sync.c:
        Applied innodb-5.0-ss982, -ss998, -ss1003
        
        Revision r969:
        branches/5.0: Port r968 from trunk:
        
        sync_thread_add_level(): When level == SYNC_TREE_NODE, allow the latching
        order to be violated if the thread holds dict_operation_lock, whose level is
        SYNC_DICT_OPERATION.  This removes the assertion failure of TRUNCATE TABLE
        #ifdef UNIV_SYNC_DEBUG.
        
        
        Revision r974:
        branches/5.0: Port r973 from trunk.
        
        Do not break the latching order in TRUNCATE TABLE.
        
        dict_truncate_index_tree(): Replace parameter rec_t* rec with
        btr_pcur_t* pcur.  Reposition pcur before calling btr_create().
        
        sync_thread_add_level(): Remove the relaxation of the assertion added in r968.
        
        
        Revision r1001:
        branches/5.0: Reduce locking contention:
        
        Bug #15815: 'Thread thrashing' with > 50 concurrent connections under
        an update-intensive workload.
        Fix: Introduce one event per InnoDB semaphore.
        
        This patch is from Sunny Bains and Heikki Tuuri.
        This patch will not be merged to trunk (MySQL/InnoDB 5.1) yet,
        because it tries to address the problem in a different way.
      c12c382f
  6. 08 Nov, 2006 16 commits
  7. 07 Nov, 2006 17 commits