1. 16 Nov, 2015 11 commits
  2. 15 Nov, 2015 1 commit
  3. 14 Nov, 2015 1 commit
  4. 13 Nov, 2015 9 commits
  5. 10 Nov, 2015 11 commits
  6. 09 Nov, 2015 1 commit
    • Nirbhay Choubey's avatar
      MDEV-9021: MYSQLD SEGFAULTS WHEN BUILT USING --WITH-MAX-INDEXES=128 · 7ec65585
      Nirbhay Choubey authored
      The bitmap implementation defines two template Bitmap classes. One
      optimized for 64-bit (default) wide bitmaps while the other is used for
      all other widths.
      
      In order to optimize the computations, Bitmap<64> class has defined its
      own member functions for bitmap operations, the other one, however,
      relies on mysys' bitmap implementation (mysys/my_bitmap.c).
      
      Issue 1:
      In case of non 64-bit Bitmap class, intersect() wrongly reset the
      received bitmap while initialising a new local bitmap structure
      (bitmap_init() clears the bitmap buffer) thus, the received bitmap was
      getting cleared.
      
      Fixed by initializing the local bitmap structure by using a temporary
      buffer and later copying the received bitmap to the initialised bitmap
      structure.
      
      Issue 2:
      The non 64-bit Bitmap class had the Iterator missing which caused
      compilation failure.
      
      Also added a cmake variable to hold the MAX_INDEXES value when supplied
      from the command prompt. (eg. cmake .. -DMAX_INDEXES=128U). Checks have
      been put in place to trigger build failure if MAX_INDEXES value is
      greater than 128.
      
      Test modifications:
      * Introduced include/have_max_indexes_[64|128].inc to facilitate
      skipping of tests for which the output differs with different
      MAX_INDEXES.
      
      * Introduced include/max_indexes.inc which would get modified by cmake
      to reflect the MAX_INDEXES value used to build the server. This file
      simply sets an mtr variable '$max_indexes' to show the MAX_INDEXES
      value, which will then be consumed by the above introduced include file.
      
      * Some tests (portions), dependent on MAX_INDEXES value, have been moved
      to separate test files.
      7ec65585
  7. 07 Nov, 2015 2 commits
  8. 06 Nov, 2015 4 commits
    • Elena Stepanova's avatar
    • Sergei Petrunia's avatar
      Merge pull request #112 from openquery/MDEV-8981 · 4e421687
      Sergei Petrunia authored
      MDEV-8981: Analyze stmt - cycles can overflow
      4e421687
    • Sergey Vojtovich's avatar
      MDEV-9082 - Debian: mysql_install_db is called on upgrade · b80cc31a
      Sergey Vojtovich authored
      A comment in debian/mariadb-server-10.1.postinst says: "can safely run on
      upgrades with existing databases". While this is true there're a few reasons not
      to do that:
      - it increases installation time (it has to run rather heavy mysqld multiple times)
      - as well as it increases mysqld downtime
      - it may fail if database has some plugin specific configs (see MDEV-8437)
      - there should be no need to run this script on upgrade: they should be handled
        by mysql_upgrade to
      - RPM postin doesn't call it if database directory exists
      
      Also postinst is not supposed to create database directories: let
      mysql_install_db do that intead.
      b80cc31a
    • Sergey Vojtovich's avatar
      MDEV-9080 - Debian: incorrect empty password check in postinst · 7f5e005d
      Sergey Vojtovich authored
      There was code that was supposed to "catch upgrades from previous versions where
      the root password wasn't set". But it is wrong in many regards:
      - it is supposed to be executed against running server, but at this point server
        should be down, which makes this code no-op
      - if the above is fixed, root password will be requested twice (initial root
        password request + this one)
      - it asks for a password only once, while "initial root password request" asks
        twice (password + password verification)
      - it may give false positive if unix socket based authentication is in effect
      
      Removed this code since it didn't work for quite a while (at least since
      mysql-5.1) and nobody cared about it.
      7f5e005d