1. 25 Sep, 2007 1 commit
    • stewart@flamingspork.com[stewart]'s avatar
      [PATCH] BUG#30379 Better randomise time before retry in timeout check (DBTC) · 33412d2b
      stewart@flamingspork.com[stewart] authored
      timoOutLoopStartLab() checks if any transactions have been delayed
      for so long that we are forced to perform some action (e.g. abort,
      resend etc).
      
      It is *MEANT* to (according to the comment):
      > To avoid aborting both transactions in a deadlock detected by time-out
      > we insert a random extra time-out of upto 630 ms by using the lowest
      > six bits of the api connect reference.
      > We spread it out from 0 to 630 ms if base time-out is larger than 3 sec,
      > we spread it out from 0 to 70 ms if base time-out is smaller than 300 msec,
      > and otherwise we spread it out 310 ms.
      
      The comment (as all do) lies.
      
      the API connect reference is not very random, producing incredibly
      predictable "random" numbers. This could lead to both txns being
      aborted instead of just one.
      
      Before:
      timeout value: 123 3
      timeout value: 122 2
      timeout value: 122 2
      timeout value: 122 2
      timeout value: 123 3
      
      After:
      timeout value: 127 7
      timeout value: 126 6
      timeout value: 129 9
      timeout value: 139 19
      timeout value: 137 17
      timeout value: 151 31
      timeout value: 130 10
      timeout value: 132 12
      
      Index: ndb-work/ndb/src/kernel/blocks/dbtc/DbtcMain.cpp
      ===================================================================
      33412d2b
  2. 13 Sep, 2007 2 commits
  3. 12 Sep, 2007 2 commits
  4. 29 Aug, 2007 1 commit
  5. 20 Aug, 2007 4 commits
  6. 16 Aug, 2007 1 commit
  7. 15 Aug, 2007 1 commit
  8. 14 Aug, 2007 3 commits
  9. 13 Aug, 2007 3 commits
  10. 08 Aug, 2007 2 commits
  11. 07 Aug, 2007 1 commit
  12. 30 Jul, 2007 1 commit
  13. 27 Jul, 2007 1 commit
  14. 26 Jul, 2007 2 commits
  15. 25 Jul, 2007 2 commits
  16. 13 Jul, 2007 1 commit
  17. 04 Jul, 2007 3 commits
  18. 03 Jul, 2007 2 commits
  19. 02 Jul, 2007 2 commits
  20. 25 Jun, 2007 1 commit
  21. 19 Jun, 2007 2 commits
  22. 18 Jun, 2007 1 commit
  23. 17 Jun, 2007 1 commit