- 25 Jun, 2011 1 commit
-
-
Igor Babaev authored
The following were missing in the patch for mwl106: - KEY_PART_INFO::fieldnr were not set for generated keys to access tmp tables storing the rows of materialized derived tables/views - TABLE_SHARE::column_bitmap_size was not set for tmp tables storing the rows of materialized derived tables/views. These could cause crashes or memory overwrite.
-
- 24 Jun, 2011 9 commits
-
-
Igor Babaev authored
If a view/derived table is non-mergeable then the definition of the tmp table to store the rows for it is created at the prepare stage. In this case if the view definition uses outer joins and a view column belongs to an inner table of one of them then the column should be considered as nullable independently on nullability of the underlying column. If the underlying column happens to be defined as non-nullable then the function create_tmp_field_from_item rather than the function create_tmp_field_from_field should be employed to create the definition of the interesting column in the tmp table.
-
Sergey Petrunya authored
(testcase for #798597 now crashes)
-
Michael Widenius authored
-
Michael Widenius authored
-
Michael Widenius authored
Fixed several errors in Aria discovered by test case for lp:727869 ma_pagecache.c:2103: find_block: Assertion `block->rlocks == 0 - Fixed assert in transaction log handler when aria_check was run on block-record table that was much bigger than expected. - Fixed warnings about wrong mutex order between bitmap and intern_lock - Fixed error in bitmap that could cause two rows to use same block for a block record. - Fixed wrong test that could cause error if last page for a bitmap was used by a blob. - Fixed several bugs in pagecache for the case where pagecase had very few blocks and there was a lot of threads competing to get the blocks (very unlikely case). mysql-test/suite/maria/r/maria-recovery3.result: Updated results sql/mysqld.cc: Allow mi_check() to send information messages for log file storage/maria/ma_bitmap.c: Fixed problem with wrong mutex order when bitmap was the first page that was flushed out of page cache - Fixed by introducing _ma_bitmap_mark_file_changed() that marks file changed without a bitmap lock. - Fixed one case in _ma_change_bitmap_page() where we didn't mark the bitmap changed. This could cause to rows to reuse same block if this was the only change to the bitmap. - Split _ma_bitmap_get_page_bits() in two parts to not take a bitmap lock when we already have it - Fixed bug in _ma_bitmap_set_full_page_bits() that caused an error if last page for a bitmap was used by a blob storage/maria/ma_check.c: Better handling of wrong file length. Fixed bug when we tried to write to transaction log when it was not opened (happened when block record file was bigger than expected) storage/maria/ma_pagecache.c: Fixed several bugs in pagecache for the case where pagecase had very few blocks and there was a lot of threads competing to get the blocks: - In link_block() mark a block given to another thread with PCBLOCK_REASSIGNED to ensure that no other threads can start re-using the block before the thread that requsted a block. - In free_block(), don't reset status for a block that is in re-assign by link_block() (we don't want to loose the PCBLOCK_REASSIGNED flag). - Added call to wait_for_flush() when we got a new block in find_block() to ensure that we don't use a block that is beeing flushed by another thread. - Moved setting of hits_left and last_hit_time in find_block() to where we assign the block. Code cleanup and making code uniform: - Changed a lot of KEYCACHE_DBUG_PRINT to use DBUG_PRINT - Streamlined all reporting of 'signal' and 'wait' between threads to be identical. - Use thread name instead of thread number (for each match against --debug) - Added more DBUG_ENTER, DBUG_PRINT and DBUG_ASSERT() - Added more comments storage/myisam/ha_myisam.cc: Only print information about that we make a backup if we are really making a backup. storage/myisam/mi_check.c: Inform mysqld that we are creating a backup of the data file (for inclusion in error log).
-
Michael Widenius authored
-
Michael Widenius authored
- Fixed error when writing a blob to the last page on the bitmap. - Marked bitmap changed in once case that could cause two rows to use the same blob page.
-
Michael Widenius authored
mysql-test/r/join.result: Test case for LP:798597 mysql-test/t/join.test: Test case for LP:798597 sql/sql_select.cc: In simplify_joins we reset table->maybe_null for outer join tables that can't ever be NULL. This caused a conflict between the previously calculated items and the group_buffer against the fields in the temporary table that are created as not null thanks to the optimization. The fix is to correct the group by items to also be not_null so that they match the used fields and keys.
-
Igor Babaev authored
The function setup_tables should handle table_list elements for semijoin materialized tables in a special way when executing a prepared statement for the second time.
-
- 23 Jun, 2011 1 commit
-
-
Igor Babaev authored
The function simple_pred did not take into account that a multiple equality could include ref items (more exactly items of the class Item_direct_view_ref). It caused crashes for queries over derived tables or views if the min/max optimization could be applied to these queries.
-
- 22 Jun, 2011 2 commits
-
-
Igor Babaev authored
-
Igor Babaev authored
The patch for bugs 717577 and 724942 has missed to make adjustments for the call item_equal->add_const(const_item, orig_field_item) in the function check_simple_equality that builds multiple equality for a field and a constant. As a result, when this field happens to be a view field and the corresponding Item_field object F is wrapped in an Item_direct_view_ref object R the object F is placed in the multiple equality instead of the object R. A substitution of an equal item for F potentially can cause very serious problems and in some cases can lead to crashes of the server.
-
- 21 Jun, 2011 4 commits
-
-
unknown authored
Removed forgotten EXPLAIN EXTENDED from the test file.
-
Sergei Golubchik authored
initialize plugins earlier, to support, for example, non-MyISAM mysql.plugin table.
-
unknown authored
Automerged with 5.3.
-
unknown authored
- Added regression test with queries over the WORLD database. - Discovered and fixed several bugs in the related cost calculation functionality both in the semijoin and non-semijon subquery code. - Added DBUG printing of the cost variables used to decide between IN-EXISTS and MATERIALIZATION.
-
- 17 Jun, 2011 3 commits
-
-
Vladislav Vaintroub authored
-
Sergey Petrunya authored
-
Vladislav Vaintroub authored
Define USE_MARIA_FOR_TMP_TABLES preprocessor constant by default if Aria engine is compiled in. Use CMake variable WITH_ARIA_TMP_TABLES to control the temp table engine setting.
-
- 16 Jun, 2011 1 commit
-
-
Igor Babaev authored
-
- 15 Jun, 2011 7 commits
-
-
Sergei Golubchik authored
-
Sergei Golubchik authored
(without CFLAGS=-DSAFEMALLOC).
-
Sergey Petrunya authored
-In do_sj_dups_weedout(), set nulls_ptr to point to NULL bytes (and not to length bytes) of the DuplicateWeedout column.
-
Sergey Petrunya authored
-
Sergey Petrunya authored
- Testcase
-
Sergey Petrunya authored
BUG#761598: InnoDB: Error: row_search_for_mysql() is called without ha_innobase::external_lock() in maria-5.3 - Testcase
-
Sergey Petrunya authored
- Add testcase
-
- 14 Jun, 2011 1 commit
-
-
Sergei Golubchik authored
-
- 13 Jun, 2011 2 commits
-
-
Michael Widenius authored
-
Michael Widenius authored
Added option to aria_read_log to crash recovery at certain points in the recovery process. Fixed bug that caused future recovery attempts to fail if we got a crash/got killed during closing of tables at end of recovery process. mysql-test/mysql-test-run.pl: Don't abort if 'var' points to stale place; Just remove it. mysql-test/suite/maria/r/maria.result: Fixed wrong indentation mysql-test/t/partition_error.test: Fixed portability problem with partiton_error.test storage/maria/ma_close.c: More DBUG_PRINT info storage/maria/ma_pagecache.c: Copy flush_log_callback when writing to page cache. This fixes problem in recovery when switching from mode of file storage/maria/ma_recovery.c: Added option to aria_read_log to crash recovery at certain points in the recovery process. storage/maria/ma_recovery.h: Added option to aria_read_log to crash recovery at certain points in the recovery process. storage/maria/maria_chk.c: Align aria_chk -d output Don't write warning Aria table '...' is usable but should be fixed if the table was before marked as crashed but now is ok storage/maria/maria_read_log.c: Added option to aria_read_log to crash recovery at certain points in the recovery process.
-
- 12 Jun, 2011 2 commits
-
-
Michael Widenius authored
-
Sergei Golubchik authored
-
- 14 Jun, 2011 1 commit
-
-
unknown authored
The previous patch partially fixed things by waiting for the old dump thread on the master to exit before injecting the DBUG error. This prevents the error injection going to the wrong thread. However, there is still the problem that the old dump thread may never exit, causing the wait to time out. This happens if the dump thread manages to write all events down the socket before the socket is closed by the slave. The master dump thread only checks for slave gone when writing a new event, so if no new events are generated, old dump threads can hang around forever on the master after the slave disconnects. Fix by explicitly killing the old dump thread if it is still around.
-
- 13 Jun, 2011 1 commit
-
-
Sergey Petrunya authored
(Changeset sp1r-igor@olga.mysql.com-20070526173301-38848 moved this loop from one place to another, then the merge of sp1r-gshchepa/uchum@gleb.loc-20070527192244-26330 have kept both copies).
-
- 11 Jun, 2011 5 commits
-
-
Sergey Petrunya authored
- move attempt to evaluate join->exec_const_cond() out of the "Extract constant part of each ON expression" loop (it got there by mistake when merging).
-
Michael Widenius authored
-
Michael Widenius authored
-
Michael Widenius authored
Noted that there was no memory leak, just a lot of used partitioned tables. Fixed old bug: 'show status' now shows memory usage when compiled with safemalloc. Added option --flush to mysqlcheck.c to run a 'flush tables' between each check to keep down memory usage. Changed '--safemalloc' options to mysqld so that one can use --safemalloc and --skip-safemalloc. Now skip-safemalloc is default (ie, we only do checking of memory overrun during free()) to speed up tests. client/client_priv.h: Added OPT_FLUSH_TABLES client/mysqlcheck.c: Added option --flush to mysqlcheck.c to run a 'flush tables' between each check to keep down memory usage. mysql-test/mysql-test-run.pl: Always run tests with --loose-skip-safemysqld for higher speed sql/mysqld.cc: Changed '--safemalloc' options so that one can use --safemalloc and --skip-safemalloc. Now skip-safemalloc is default (ie, we only do checking of memory overrun during free()) to speed up tests sql/sql_parse.cc: Fixed old bug: 'show status' now shows memory usage when compiled with safemalloc. storage/archive/archive_reader.c: Changed all malloc() calls to use my_malloc()/my_free() Added checks of malloc() calls. storage/archive/ha_archive.cc: Detect failure if init_archive_reader() and return errno. This fixed assert crash in my_seek(). Changed all malloc() calls to use my_malloc()/my_free()
-
Michael Widenius authored
-