1. 25 Aug, 2004 3 commits
    • unknown's avatar
      Test case for Bug #4792 lower_case_table_names does not resolve db.tbl.column in SELECT list · 3b55c6f3
      unknown authored
      lowercase_table.result:
        New results for modified lowercase_table test
      lowercase_table.test:
        Added test case for all uppercase database when running under lower_case_table_names.  This really only failed under Windows.  Bug# 4792
      
      
      mysql-test/t/lowercase_table.test:
        Added test case for all uppercase database when running under lower_case_table_names.  This really only failed under Windows.  Bug# 4792
      mysql-test/r/lowercase_table.result:
        New results for modified lowercase_table test
      3b55c6f3
    • unknown's avatar
      Bug #4792 lower_case_table_names does not resolve db.tbl.column in SELECT list · ca59bf47
      unknown authored
      sql_base.cc:
        Added code to lowercase database name in insert_fields when lower_case_table_names=1. This fixes bug# 4792
      
      
      sql/sql_base.cc:
        Added code to lowercase database name in insert_fields when lower_case_table_names=1. This fixes bug# 4792
      ca59bf47
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.0 · b15ee678
      unknown authored
      into build.mysql.com:/users/rburnett/mysql-4.0
      
      
      BitKeeper/etc/logging_ok:
        auto-union
      client/mysql.cc:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      b15ee678
  2. 24 Aug, 2004 5 commits
    • unknown's avatar
      buf0rea.c: · 73fe243d
      unknown authored
        Fix bug: if there was little file I/O in InnoDB, but the insert buffer was used, it could happen that 'Pending normal aio reads' was bigger than 0, but the I/O handler thread did not get waken up in 600 seconds. This resulted in a hang, and crashing of InnoDB.
      
      
      innobase/buf/buf0rea.c:
        Fix bug: if there was little file I/O in InnoDB, but the insert buffer was used, it could happen that 'Pending normal aio reads' was bigger than 0, but the I/O handler thread did not get waken up in 600 seconds. This resulted in a hang, and crashing of InnoDB.
      73fe243d
    • unknown's avatar
      Fix warning VC++ and fix applied fisrt to source 4.1 · 9d1a9d72
      unknown authored
      
      mysys/my_lib.c:
        Same fix for bug #4737 that wrongly I did first on tree 4.1
      mysys/my_vsnprintf.c:
        Fix VC++ warning assuming that my_vsnprintf() is external
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      9d1a9d72
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-4.0 · 6212c6e7
      unknown authored
      into gluh.mysql.r18.ru:/home/gluh/MySQL-BUGS/mysql-4.0
      
      
      6212c6e7
    • unknown's avatar
      Fix for bug #4340: find_in_set is case insensitive even on binary operators(2nd version) · b758a6d1
      unknown authored
      
      mysql-test/r/func_set.result:
        Fix for bug #4340: find_in_set is case insensitive even on binary operators
      mysql-test/t/func_set.test:
        Fix for bug #4340: find_in_set is case insensitive even on binary operators
      sql/item_func.cc:
        Fix for bug #4340: find_in_set is case insensitive even on binary operators
      b758a6d1
    • unknown's avatar
      - make sure to recreate all autoconf/automake-related files after · 8b11e715
      unknown authored
         modifying configure.in for the commercial tarballs
       - added my-innodb-heavy-4G.cnf to the distribution
      
      
      Build-tools/mysql-copyright:
         - make sure to recreate all autoconf/automake-related files after
           modifying configure.in
      support-files/Makefile.am:
         - added my-innodb-heavy-4G.cnf to the distribution
      8b11e715
  3. 23 Aug, 2004 7 commits
  4. 22 Aug, 2004 3 commits
  5. 21 Aug, 2004 1 commit
    • unknown's avatar
      null.test, null.result: · c1fd20bb
      unknown authored
        Added test case for bug #4256.
      join_outer.result:
        Fixed bug #4256.
      item_cmpfunc.h:
        Fixed inconsistency of values of used_tables_cache and
        const_item_cache for Item_func_isnull objects.
        This inconsistency caused bug #4256.
      
      
      sql/item_cmpfunc.h:
        Fixed inconsistency of values of used_tables_cache and
        const_item_cache for Item_func_isnull objects.
        This inconsistency caused bug #4256.
      mysql-test/r/join_outer.result:
        Fixed bug #4256.
      mysql-test/r/null.result:
        Added test case for bug #4256.
      mysql-test/t/null.test:
        Added test case for bug #4256.
      c1fd20bb
  6. 20 Aug, 2004 3 commits
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-4.0 · 4f0e2da3
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.0
      
      
      4f0e2da3
    • unknown's avatar
      Making FLUSH TABLES WITH READ LOCK block COMMITs of existing transactions, · cd8054d4
      unknown authored
      in a deadlock-free manner. This splits locking the global read lock in two steps.
      This fixes a consequence of this bug, known as:
      BUG#4953 'mysqldump --master-data may report incorrect binlog position if using InnoDB'
      And a test.
      
      
      sql/handler.cc:
        making COMMIT wait if FLUSH TABLES WITH READ LOCK happened.
      sql/lock.cc:
        an additional stage so that FLUSH TABLES WITH READ LOCK blocks COMMIT:
        make_global_read_lock_block_commit():
        taking the global read lock is TWO steps (2nd step is optional; without
        it, COMMIT of existing transactions will be allowed):
        lock_global_read_lock() THEN make_global_read_lock_block_commit().
      sql/mysql_priv.h:
        new argument to wait_if_global_read_lock()
      sql/sql_class.h:
        THD::global_read_lock now an uint to reflect the 2 steps of global read lock (does not block COMMIT / does)
      sql/sql_db.cc:
        update for new prototype
      sql/sql_parse.cc:
        implementing the two steps of global read lock so that FLUSH TABLES WITH READ LOCK can block COMMIT without deadlocking with COMMITs.
      cd8054d4
    • unknown's avatar
      A fix (bug #5115: Erronious Syntax Error when comment placed inside of "create table") · 7c3e8f62
      unknown authored
      
      client/mysql.cc:
        in_comment is now outside the add_line().
      7c3e8f62
  7. 19 Aug, 2004 11 commits
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.0/ · d1c5ca31
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/mysql-4.0
      
      
      d1c5ca31
    • unknown's avatar
      432a0f36
    • unknown's avatar
      ha_innodb.cc: · 03a20c23
      unknown authored
        innobase_mysql_tmpfile(): call dup() and my_close() on the file
        returned by create_temp_file()
        in order to avoid memory leak caused by my_open() being paired with close()
      
      
      sql/ha_innodb.cc:
        innobase_mysql_tmpfile(): call dup() and my_close() on the file
        returned by create_temp_file()
        in order to avoid memory leak caused by my_open() being paired with close()
      03a20c23
    • unknown's avatar
      Build bug on 64-Bit platforms. · 8c1af755
      unknown authored
      Removed improper casts.
      Thanks to Joerg Bruehe for the fix.
      
      
      include/my_global.h:
        Build bug on 64-Bit platforms.
        Removed improper casts.
        Changed to uniform writing style.
        Appended 'L' to 32-Bit constants which doesn't hurt on 32-Bit,
        but can be important for some 64-Bit compilers.
      8c1af755
    • unknown's avatar
      Bug #4466 Nothing in .err when mysql service ends because of malformed my.ini options · f2ef3d16
      unknown authored
      my_getopt.c:
        Moved the inclusion of my_getopt.h down below the inclusion of my_sys.h so that enum loglevel definition would be available
      my_sys.h, my_getopt.h:
        moved definition of enum loglevel from my_getopt.h to my_sys.h
      
      
      include/my_getopt.h:
        moved definition of enum loglevel from my_getopt.h to my_sys.h
      include/my_sys.h:
        moved definition of enum loglevel from my_getopt.h to my_sys.h
      mysys/my_getopt.c:
        Moved the inclusion of my_getopt.h down below the inclusion of my_sys.h so that enum loglevel definition would be available
      f2ef3d16
    • unknown's avatar
      Bug #4466 Nothing in .err when mysql service ends because of malformed my.ini options · 87bce854
      unknown authored
      mysqld.cc:
        Changed LOGLEVEL enum to loglevel
      mysql_priv.h, log.cc:
        Changed LOGLEVEL to loglevel.  Removed startup_ from some of the DBUG_ENTER macros. Removed the print_msg_to_log function as it was unused.
      my_getopt.c, my_getopt.h:
        Renamed LOGLEVEL to loglevel to match coding standards
      
      
      include/my_getopt.h:
        Renamed LOGLEVEL to loglevel to match coding standards
      mysys/my_getopt.c:
        Renamed LOGLEVEL to loglevel to match coding standards
      sql/log.cc:
        Changed LOGLEVEL to loglevel.  Removed startup_ from some of the DBUG_ENTER macros. Removed the print_msg_to_log function as it was unused.
      sql/mysql_priv.h:
        Changed LOGLEVEL to loglevel.  Removed startup_ from some of the DBUG_ENTER macros. Removed the print_msg_to_log function as it was unused.
      sql/mysqld.cc:
        Changed LOGLEVEL enum to loglevel
      87bce854
    • unknown's avatar
      typos fixed · f1cf7c13
      unknown authored
      f1cf7c13
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.0/ · 283ebce1
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/mysql-4.0
      
      
      283ebce1
    • unknown's avatar
      8001a7db
    • unknown's avatar
      cosmetic change · f758ada4
      unknown authored
      
      sql/sql_class.h:
        comment
      sql/sql_table.cc:
        smarter use of the Disable_binlog object (using a block so that when leaving it either way, the object gets
        destroyed and so properties of the thread get reset).
      f758ada4
    • unknown's avatar
      copied new my_vsnprintf from 4.1. use "ul" when merging · e769d459
      unknown authored
      
      BitKeeper/etc/ignore:
        Added EXCEPTIONS-CLIENT to the ignore list
      e769d459
  8. 18 Aug, 2004 5 commits
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-4.0 · ac866d9e
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.0
      
      
      ac866d9e
    • unknown's avatar
      Fix for BUG#4971 "CREATE TABLE ... TYPE=HEAP SELECT ... stops slave (wrong DELETE in binlog)": · 95334ac6
      unknown authored
      replacing the no_log argument of mysql_create_table() by some safer method
      (temporarily setting OPTION_BIN_LOG to 0) which guarantees that even the automatic
      DELETE FROM heap_table does not get into the binlog when a not-yet-existing HEAP table
      is opened by mysql_create_table().
      
      
      mysql-test/r/rpl_heap.result:
        result update
      mysql-test/t/rpl_heap.test:
        testing a bug
      sql/log.cc:
        new class Disable_binlog used to temporarily disable binlogging for one thread.
      sql/mysql_priv.h:
        removing argument no_log from mysql_create_table(); no_log was perfect as some
        binlogging could still be done by open_unireg_entry() for a HEAP table.
      sql/sql_class.h:
        new class Disable_binlog used to temporarily disable binlogging for one thread.
      sql/sql_parse.cc:
        removing no_log
      sql/sql_table.cc:
        removing no_log from mysql_create_table(); instead using new class Disable_binlog.
        Disabling binlogging in some cases, where the binlogging is done later by some other code
        (case of CREATE SELECT and ALTER).
      95334ac6
    • unknown's avatar
      BUG# 4466 - Nothing in .err when mysql service ends because of malformed my.ini options · 4736e7d4
      unknown authored
      mysqld.cc:
        Changed option_error_reporter to match new function header that includes LOGLEVEL enum
      mysql_priv.h:
        Removed the MY_ERROR style bitmask.  Changed function headers to use new LOGLEVEL enum
      log.cc:
        Changed print_buffer_to_log to print_buffer_to_file.  Remove the timestamp bool and now all log entries written to stderr are timestamped.  Removed some unused commented code.  changed to use the new LOGLEVEL enum.  
      my_getopt.c:
        Changed functions to use the new LOGLEVEL enum and changed the included error reporter to be default_reporter.  This reporter is used in handle_options if a reporter is not given
      my_getopt.h:
        changed typedefs to use better naming convention.  Moved error bitmask into the LOGLEVEL enum and included it here.
      
      
      include/my_getopt.h:
        changed typedefs to use better naming convention.  Moved error bitmask into the LOGLEVEL enum and included it here.
      mysys/my_getopt.c:
        Changed functions to use the new LOGLEVEL enum and changed the included error reporter to be default_reporter.  This reporter is used in handle_options if a reporter is not given
      sql/log.cc:
        Changed print_buffer_to_log to print_buffer_to_file.  Remove the timestamp bool and now all log entries written to stderr are timestamped.  Removed some unused commented code.  changed to use the new LOGLEVEL enum.
      sql/mysql_priv.h:
        Removed the MY_ERROR style bitmask.  Changed function headers to use new LOGLEVEL enum
      sql/mysqld.cc:
        Changed option_error_reporter to match new function header that includes LOGLEVEL enum
      4736e7d4
    • unknown's avatar
      Bug 4937: different date -> string conversion when using · 0c6b9665
      unknown authored
      SELECT ... UNION and INSERT ... SELECT ... UNION
      
      
      0c6b9665
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.0/ · 8ddcba9d
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/mysql-4.0
      
      
      8ddcba9d
  9. 17 Aug, 2004 2 commits
    • unknown's avatar
      srv0start.c, ut0mem.c, ut0dbg.c, ut0dbg.h, srv0start.h: · 0c062ae6
      unknown authored
        Changes for NetWare to exit the InnoDB gracefully instead of crashing the server (patch by PRam@novell.com, polished a little by Heikki Tuuri)
      mysqld.cc, ha_innodb.cc:
        Changes for NetWare to exit the InnoDB gracefully instead of crashing the server (patch by PRam@novell.com, polished a little by Heikki Tuuri) 
      
      
      sql/ha_innodb.cc:
        Changes for NetWare to exit the InnoDB gracefully instead of crashing the server (patch by PRam@novell.com, polished a little by Heikki Tuuri)
      sql/mysqld.cc:
        Changes for NetWare to exit the InnoDB gracefully instead of crashing the server (patch by PRam@novell.com, polished a little by Heikki Tuuri)
      innobase/include/srv0start.h:
        Changes for NetWare to exit the InnoDB gracefully instead of crashing the server (patch by PRam@novell.com, polished a little by Heikki Tuuri)
      innobase/include/ut0dbg.h:
        Changes for NetWare to exit the InnoDB gracefully instead of crashing the server (patch by PRam@novell.com, polished a little by Heikki Tuuri)
      innobase/ut/ut0dbg.c:
        Changes for NetWare to exit the InnoDB gracefully instead of crashing the server (patch by PRam@novell.com, polished a little by Heikki Tuuri)
      innobase/ut/ut0mem.c:
        Changes for NetWare to exit the InnoDB gracefully instead of crashing the server (patch by PRam@novell.com, polished a little by Heikki Tuuri)
      innobase/srv/srv0start.c:
        Changes for NetWare to exit the InnoDB gracefully instead of crashing the server (patch by PRam@novell.com, polished a little by Heikki Tuuri)
      0c062ae6
    • unknown's avatar
      use my_vsnprintf() just in case · fdc8712c
      unknown authored
      bug#4925
      
      
      fdc8712c