1. 26 Jan, 2007 2 commits
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/dev-opt/mysql-4.1-opt-bug24653 · 483a41bb
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug24653
      
      
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/subselect.result:
        Manual merge
      mysql-test/t/subselect.test:
        Manual merge
      sql/filesort.cc:
        Manual merge
      sql/item_cmpfunc.h:
        Manual merge
      sql/item_subselect.cc:
        Manual merge
      483a41bb
    • unknown's avatar
      Fixed bug #24653. · da561a80
      unknown authored
      The bug report has demonstrated the following two problems.
      1. If an ORDER/GROUP BY list includes a constant expression being 
      optimized away and, at the same time, containing single-row
      subselects that return more that one row, no error is reported.
      Strictly speaking the standard allows to ignore error in this case.
      Yet, now a corresponding fatal error is reported in this case.
      2. If a query requires sorting by expressions containing single-row
      subselects that, however, return more than one row, then the execution
      of the query may cause a server crash. 
      To fix this some code has been added that blocks execution of a subselect
      item in case of a fatal error in the method Item_subselect::exec.
      
      
      mysql-test/r/subselect.result:
        Added a test cases for bug #24653.
      mysql-test/t/subselect.test:
        Added a test cases for bug #24653.
      sql/filesort.cc:
        Fixed bug #24653.
        Added a check for fatal error after reading the next row from the table
        in the function find_all_keys.
      sql/item.cc:
        Fixed bug #24653.
        Down-ported calculation of the attribute with_subselect of for Item objects.
      sql/item.h:
        Fixed bug #24653.
        Down-ported calculation of the attribute with_subselect of for Item objects.
      sql/item_cmpfunc.cc:
        Fixed bug #24653.
        Down-ported calculation of the attribute with_subselect of for Item objects.
      sql/item_cmpfunc.h:
        Fixed bug #24653.
        Down-ported calculation of the attribute with_subselect of for Item objects.
      sql/item_func.cc:
        Fixed bug #24653.
        Down-ported calculation of the attribute with_subselect of for Item objects.
      sql/item_subselect.cc:
        Fixed bug #24653.
        Added a check for fatal error in the method Item_subselect::exec
        to block evaluation of subselects in erroneous situations.
        Down-ported calculation of the attribute with_subselect of for Item objects.
      sql/sql_select.cc:
        Fixed bug #24653.
        Added a check to verify that any constant expression used
        in ORDER BY and/or GROUP BY lists which is optimized away
        does not contain subselects returning more than one row.
        If it does a fatal error is reported.
      da561a80
  2. 24 Jan, 2007 9 commits
  3. 23 Jan, 2007 10 commits
    • unknown's avatar
      Post-merge fix. · 5d9d6493
      unknown authored
      5d9d6493
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-4.1-opt · 8dc8acbb
      unknown authored
      into  olga.mysql.com:/home/igor/mysql-5.0-opt
      
      
      mysql-test/r/fulltext_left_join.result:
        Auto merged
      mysql-test/t/fulltext_left_join.test:
        Auto merged
      sql/item_func.cc:
        Auto merged
      8dc8acbb
    • unknown's avatar
      Merge pnousiainen@bk-internal.mysql.com:/home/bk/mysql-5.0-ndb · 964f502c
      unknown authored
      into  clam.ndb.mysql.com:/export/space/pekka/ndb/version/my50-ndb
      
      
      964f502c
    • unknown's avatar
      Merge willster.(none):/home/stewart/Documents/MySQL/5.0/ndb · a7174850
      unknown authored
      into  willster.(none):/home/stewart/Documents/MySQL/5.0/bug25487
      
      
      a7174850
    • unknown's avatar
      ndb - bug#25562 use byte-size max_data_length() when setting blob part size · 25fb32ef
      unknown authored
      
      sql/ha_ndbcluster.cc:
        bug#25562 use byte-size max_data_length() when setting blob part size
      25fb32ef
    • unknown's avatar
      Merge mysql.com:/home/gluh/MySQL/Merge/5.0 · acef88be
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.0-opt
      
      
      mysql-test/r/func_in.result:
        Auto merged
      mysql-test/r/range.result:
        Auto merged
      mysql-test/r/sp-code.result:
        Auto merged
      mysql-test/t/func_in.test:
        Auto merged
      mysql-test/t/range.test:
        Auto merged
      mysql-test/t/trigger.test:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      mysql-test/r/select.result:
        manual merge
      mysql-test/r/view.result:
        manual merge
      mysql-test/t/select.test:
        manual merge
      acef88be
    • unknown's avatar
      round up Transporter connect timeout · 68ab0996
      unknown authored
      
      ndb/src/common/transporter/Transporter.cpp:
        change so timeout is rounded up to nearest second
      68ab0996
    • unknown's avatar
      Bug #25487 deleting ndb_cluster_connection object takes long time · 8deeb2f9
      unknown authored
        
        aim is to:
        a) if set_connect_timeout called, timeout connect attempt (for retry on
        next call) after timeout period
        b) preserve existing blocking behaviour otherwise (for, e.g. mgmapi)
        
        Related to customer issue with long time deleting ndb_cluster_connection
        object. believe we're hanging on the connect(2) call until timeout (when
        we then realise we should exit the thread).
      
      
      ndb/include/mgmapi/mgmapi.h:
        add ndb_mgm_set_connect_timeout
      ndb/include/util/SocketClient.hpp:
        add timeout (seconds) for max time to wait for connection
      ndb/src/common/transporter/Transporter.cpp:
        set limit on amount of time we'll wait for tcp connect
      ndb/src/common/util/SocketClient.cpp:
        only try to connect for a maximum of timeout time
      ndb/src/mgmapi/mgmapi.cpp:
        add ndb_mgm_set_connect_timeout
      8deeb2f9
    • unknown's avatar
      ndb - bug#22013 · ab8355fa
      unknown authored
          Fix bug in event handling wrt early node shutdown
      
      
      ndb/src/mgmsrv/MgmtSrvr.cpp:
        Fix bug in event handling wrt early node shutdown
      ndb/src/ndbapi/ClusterMgr.cpp:
        Fix reportNodeFailed if only connected wo/ having received any API_REGCONF
      ndb/src/ndbapi/ClusterMgr.hpp:
        Fix reportNodeFailed if only connected wo/ having received any API_REGCONF
      ndb/src/ndbapi/SignalSender.cpp:
        Fix memleak
      ab8355fa
    • unknown's avatar
      bug#25746 ndb: 4209 error with 2 VARCHAR primary keys · 188899cd
      unknown authored
      - post review changes
      
      
      188899cd
  4. 22 Jan, 2007 5 commits
    • unknown's avatar
      Fixed bug #25637: LEFT JOIN with BOOLEAN FULLTEXT loses left table matches. · 6d04643a
      unknown authored
      The bug is actually a duplicate of the bug 14708.
      Down-ported the fix for 14708 from 5.0.  
      Merged the test case for bug 14708 from 5.0.
      
      
      mysql-test/r/fulltext_left_join.result:
        Added a test case for bug #25637 (duplicate .of bug 14708).
        Merged the test case for bug 14708 from 5.0.
      mysql-test/t/fulltext_left_join.test:
        Added a test case for bug #25637 (duplicate of bug 14708).
        Merged the test case for bug 14708 from 5.0.
      sql/item_func.cc:
        Fixed bug #25637: LEFT JOIN with BOOLEAN FULLTEXT loses left table matches.
        The bug is actually a duplicate of the bug 14708.
        Down-ported the fix for 14708 from 5.0.
      6d04643a
    • unknown's avatar
      sql_select.cc: · 6447a7b6
      unknown authored
        Code cleanup after fix for bug#23417.
      
      
      sql/sql_select.cc:
        Code cleanup after fix for bug#23417.
      6447a7b6
    • unknown's avatar
      sql_prepare.cc: · 9e3b03f4
      unknown authored
        Post fix for bug#25123.
      
      
      sql/sql_prepare.cc:
        Post fix for bug#25123.
      9e3b03f4
    • unknown's avatar
      bug#25746 ndb: 4209 error with 2 VARCHAR primary keys · 5f9e20de
      unknown authored
      - make sure keys are copied correctly when varchar has 2 length bytes
      - test case
      
      
      mysql-test/r/ndb_basic.result:
        bug#25746 ndb: 4209 error with 2 VARCHAR primary keys
        - test case
      mysql-test/t/ndb_basic.test:
        bug#25746 ndb: 4209 error with 2 VARCHAR primary keys
        - test case
      sql/ha_ndbcluster.cc:
        bug#25746 ndb: 4209 error with 2 VARCHAR primary keys
        - make sure keys are copied correctly when varchar has 2 length bytes
      5f9e20de
    • unknown's avatar
      Bug#25123: ON DUPLICATE KEY clause allows fields not from the insert table. · df0a0896
      unknown authored
      When inserting into a join-based view the update fields from the ON DUPLICATE
      KEY UPDATE wasn't checked to be from the table being inserted into and were
      silently ignored.
      
      The new check_view_single_update() function is added to check that
      insert/update fields are being from the same single table of the view.
      
      
      sql/sql_insert.cc:
        Bug#25123: ON DUPLICATE KEY clause allows fields not from the insert table.
        The new check_view_single_update() function is added to check that
        insert/update fields are being from the same single table of the view.
      mysql-test/r/insert.result:
        Added a test case for bug#25123: ON DUPLICATE KEY clause allows fields not from the insert table.
      mysql-test/t/insert.test:
        Added a test case for bug#25123: ON DUPLICATE KEY clause allows fields not from the insert table.
      df0a0896
  5. 19 Jan, 2007 14 commits
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · c6d4b94d
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug25580
      
      
      c6d4b94d
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 3e49c84c
      unknown authored
      into  moonbone.local:/work/25172-bug-5.0-opt-mysql
      
      
      3e49c84c
    • unknown's avatar
      Merge recycle.(none):/src/bug22807/my50-bug22807 · 644e6c7f
      unknown authored
      into  recycle.(none):/src/mysql-5.0-maint
      
      
      mysys/string.c:
        Auto merged
      644e6c7f
    • unknown's avatar
      Bug#22807 mysql_upgrade fails when called with a basedir-path containing spaces · 4032c303
      unknown authored
      - Corrected compiler warnings and performance problems with new 
      dynstr_append_os_quoted function.
      
      
      mysys/string.c:
        Bug#22807 mysql_upgrade fails when called with a basedir-path containing spaces
        - Fix compiler warnings.
        - Used dynstr_append_mem where string length is known.
      4032c303
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 9325931a
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug25580
      
      
      mysql-test/r/subselect.result:
        Auto merged
      9325931a
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 341a31b0
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug25580
      
      
      341a31b0
    • unknown's avatar
      Bug#25172: Not checked buffer size leads to a server crash. · 5effa05d
      unknown authored
      After fix for bug#21798 JOIN stores the pointer to the buffer for sorting
      fields. It is used while sorting for grouping and for ordering. If ORDER BY
      clause has more elements then the GROUP BY clause then a memory overrun occurs.
      
      Now the length of the ORDER BY list is always passed to the 
      make_unireg_sortorder() function and it allocates buffer big enough to be
      used for bigger list.
      
      
      sql/sql_delete.cc:
        Bug#25172: Not checked buffer size leads to a server crash.
        Length parameter is initialized to 0 for the make_unireg_sortorder() function.
      sql/sql_select.cc:
        Bug#25172: Not checked buffer size leads to a server crash.
        Now the length of the ORDER BY list is always passed to the 
        make_unireg_sortorder() function and it allocates buffer big enough to be
        used for bigger list.
      sql/sql_table.cc:
        Bug#25172: Not checked buffer size leads to a server crash.
        Length parameter is initialized to 0 for the make_unireg_sortorder() function.
      sql/sql_update.cc:
        Bug#25172: Not checked buffer size leads to a server crash.
        Length parameter is initialized to 0 for the make_unireg_sortorder() function.
      mysql-test/r/select.result:
        Added a test case for bug#25172: Not checked buffer size leads to a server crash.
      mysql-test/t/select.test:
        Added a test case for bug#25172: Not checked buffer size leads to a server crash.
      5effa05d
    • unknown's avatar
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-maint · 636a5b3f
      unknown authored
      into  zippy.cornsilk.net:/home/cmiller/work/mysql/mysql-5.0-maint
      
      
      636a5b3f
    • unknown's avatar
      The rpl tree added a test case, and another source added a warning, · df1b8242
      unknown authored
      and combined, they add a platform-specific warning.  The warnings 
      are not the goal of the test, in any case.
      
      
      mysql-test/t/ps.test:
        Quash platform-specific warnings.
      df1b8242
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0-maint · 0c10457e
      unknown authored
      into  pilot.mysql.com:/home/msvensson/mysql/mysql-5.0-maint
      
      
      0c10457e
    • unknown's avatar
      Bug #15518 Reusing a stmt that has failed during prepare does not clear error · d6e4472f
      unknown authored
       - Additional patch removing check for mysql_errno on already closed
         mysql1
      
      
      tests/mysql_client_test.c:
        No need to check mysql_errno of mysql1 which has already been closed.
      d6e4472f
    • unknown's avatar
      Fixed bug #25219: crash for a query that contains an EXIST subquery with · edf72bf6
      unknown authored
      UNION over correlated and uncorrelated SELECTS.
      In such subqueries each uncorrelated SELECT should be considered as
      uncacheable. Otherwise join_free is called for it and in many cases
      it causes some problems.
      
      
      mysql-test/r/subselect.result:
        Added a test case for bug #25219.
      mysql-test/t/subselect.test:
        Added a test case for bug #25219.
      sql/mysql_priv.h:
        Fixed bug #25219: crash for a query that contains an EXIST subquery with
        UNION over correlated and uncorrelated SELECTS.
        In such subqueries each uncorrelated SELECT should be considered as
        uncacheable. Otherwise join_free is called for it and in many cases
        it causes some problems. 
        Added a new flag UNCACHEABLE_UNITED for such SELECTs.
      sql/sql_lex.cc:
        Fixed bug #25219: crash for a query that contains an EXIST subquery with
        UNION over correlated and uncorrelated SELECTS.
        In such subqueries each uncorrelated SELECT should be considered as
        uncacheable. Otherwise join_free is called for it and in many cases
        it causes some problems.
        Added a new flag UNCACHEABLE_UNITED for such SELECTs.
      edf72bf6
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-5.0-maint · fd534e03
      unknown authored
      into  mysql.com:/usr/home/ram/work/bug22533/my50-bug22533
      
      
      mysql-test/r/select.result:
        Auto merged
      mysql-test/t/select.test:
        Auto merged
      fd534e03