1. 24 May, 2007 1 commit
    • unknown's avatar
      Fixed bug #28561: assertion abort for update on multi-table view with · 48af05a8
      unknown authored
      CHECK OPTION and a subquery in WHERE condition.
      The abort was triggered by setting the value of join->tables for
      subqueries in the function JOIN::cleanup. This function was called
      after an invocation of the JOIN::join_free method for subqueries
      used in WHERE condition.
      
      
      mysql-test/r/view.result:
        Added a test case for bug #28561.
      mysql-test/t/view.test:
        Added a test case for bug #28561.
      sql/sql_select.cc:
        Fixed bug #28561: assertion abort for update on multi-table view with
        CHECK OPTION and a subquery in WHERE condition.
        The abort was triggered by setting the value of join->tables for
        subqueries in the function JOIN::cleanup. This function was called
        after an invocation of the JOIN::join_free method for subqueries
        used in WHERE condition.
        Setting the value of join->tables to for a subquery created serious
        problems for checking WHERE condition after update of the multi-table
        view as this check is performed in the do_select function right
        after a call of the JOIN::join_free method.
        In fact setting join->tables to 0 in JOIN::cleanup is not needed 
        anywhere in the current code.
      48af05a8
  2. 22 May, 2007 4 commits
    • unknown's avatar
      Merge mhansson@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · f7f593ae
      unknown authored
      into  dl145s.mysql.com:/users/mhansson/mysql/autopush/mysql-5.0o-pushee
      
      
      sql/sql_select.cc:
        Auto merged
      f7f593ae
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 13cf5bdd
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B28476-5.0-opt
      
      
      sql/sql_base.cc:
        Auto merged
      sql/table.h:
        Auto merged
      13cf5bdd
    • unknown's avatar
      Bug #28476: force index on a disabled myisam index gives error 124 · 3332b801
      unknown authored
      When processing the USE/FORCE index hints
      the optimizer was not checking if the indexes 
      specified are enabled (see ALTER TABLE).
      Fixed by:
       Backporting the fix for bug 20604 to 5.0
      
      
      mysql-test/r/key.result:
        Test for BUG 20604.
        The important part of the test is the explain output that 
        tests what indexes are used.
      mysql-test/r/myisam.result:
        Bug #28476: test cases
      mysql-test/t/key.test:
        Bug 20604: 
        The minimal test case that reveals the bug. The optimizer for 
        aggregates relies on keys disabled with ALTER TABLE ... DISABLE KEYS
        not being in the set TABLE::keys_in_use_for_query.
        When the execution engine tries to use a disabled index, MyISAM
        returns an error.
      mysql-test/t/myisam.test:
        Bug #28476: test cases
      sql/sql_base.cc:
        Bug #28476: 
         - Ignore disabled indexes in USE/FORCE index
      sql/sql_select.cc:
        Bug 20604 : The intersection operation between table->s->keys_in_use 
        and table->keys_in_use_for_query is no longer necessary.
        We can trust that the latter is a subset of the former.
      sql/table.h:
        Bug 20604:
        Added comments to TABLE_SHARE::keys_in_use and
        TABLE::keys_in_use_for_query.
      3332b801
    • unknown's avatar
      Merge dl145s.mysql.com:/users/mhansson/mysql/push/bug23856/my50-bug23856 · 3c76d369
      unknown authored
      into  dl145s.mysql.com:/users/mhansson/mysql/push/bug23856/mysql-5.0o-pushee
      
      
      sql/item_sum.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/func_gconcat.result:
        Bug#23856: Manually merged
      mysql-test/t/func_gconcat.test:
        Bug#23856: Manually merged
      3c76d369
  3. 21 May, 2007 11 commits
    • unknown's avatar
      14cb59d8
    • unknown's avatar
      Bug#27507: Wrong DATETIME value was allowed by ALTER TABLE in the NO_ZERO_DATE · f3b78f34
      unknown authored
      mode.
      
      When a new DATE/DATETIME field without default value is being added by the
      ALTER TABLE the '0000-00-00' value is used as the default one. But it wasn't
      checked whether such value was allowed by the set sql mode. Due to this
      '0000-00-00' values was allowed for DATE/DATETIME fields even in the
      NO_ZERO_DATE mode.
      
      Now the mysql_alter_table() function checks whether the '0000-00-00' value
      is allowed for DATE/DATETIME fields by the set sql mode.
      The new error_if_not_empty flag is used in the mysql_alter_table() function
      to indicate that it should abort if the table being altered isn't empty.
      The new new_datetime_field field is used in the mysql_alter_table() function
      for error throwing purposes. 
      The new error_if_not_empty parameter is added to the copy_data_between_tables()
      function to indicate the it should return error if the source table isn't empty.
      
      
      mysql-test/t/alter_table.test:
        Added a test case for the bug#27507: Wrong DATETIME value was allowed by
        ALTER TABLE in the NO_ZERO_DATE mode.
      mysql-test/r/alter_table.result:
        Added a test case for the bug#27507: Wrong DATETIME value was allowed by
        ALTER TABLE in the NO_ZERO_DATE mode.
      sql/sql_table.cc:
        Bug#27507: Wrong DATETIME value was allowed by ALTER TABLE in the NO_ZERO_DATE
        mode.
        Now the mysql_alter_table() function checks whether the '0000-00-00' value
        is allowed for DATE/DATETIME fields by the set sql mode.
        The new error_if_not_empty flag is used in the mysql_alter_table() function
        to indicate that it should abort if the table being altered isn't empty.
        The new new_datetime_field field is used in the mysql_alter_table() function
        for error throwing purposes. 
        The new error_if_not_empty parameter is added to the copy_data_between_tables()
        function to indicate the it should return error if the source table isn't empty.
      f3b78f34
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · bc31b650
      unknown authored
      into  mysql.com:/home/hf/work/27984/my50-27984
      
      
      bc31b650
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0-opt · 741bbb75
      unknown authored
      into  mysql.com:/home/hf/work/27984/my50-27984
      
      
      mysql-test/r/type_newdecimal.result:
        merging
      mysql-test/t/type_newdecimal.test:
        merging
      741bbb75
    • unknown's avatar
      Bug #27984 Long Decimal Maths produces truncated results. · cfb9378b
      unknown authored
      decimal_round failed to perform a correct rounding 
      of a decimal number if its first nine digits were '9'.
      It just sets those digits to 0.
      
      
      mysql-test/r/type_newdecimal.result:
        Bug #27984 Long Decimal Maths produces truncated results.
        test result
      mysql-test/t/type_newdecimal.test:
        Bug #27984 Long Decimal Maths produces truncated results.
        test case
      strings/decimal.c:
        Bug #27984 Long Decimal Maths produces truncated results.
        when to == from we break the data if we do to->buf[0]=0
        So now doing this after the data is moved and only
        if we really need to set to->buf[0] to zero
      cfb9378b
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 00ed873c
      unknown authored
      into  mysql.com:/home/hf/work/28361/my50-28361
      
      
      00ed873c
    • unknown's avatar
      test result fixed · 786adf87
      unknown authored
      786adf87
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · be043a5e
      unknown authored
      into  mysql.com:/home/hf/work/27894/my50-27894
      
      
      be043a5e
    • unknown's avatar
      bug#23856 · 84966af9
      unknown authored
      84966af9
    • unknown's avatar
      Bug #28361 Buffer overflow in DECIMAL code on Windows · d2c985e3
      unknown authored
      result max length changed for the 'decimal' fields
      so test results have to be fixed
      
      
      mysql-test/r/ps_2myisam.result:
        Bug #28361 Buffer overflow in DECIMAL code on Windows 
        test result fixed
      mysql-test/r/ps_3innodb.result:
        Bug #28361 Buffer overflow in DECIMAL code on Windows 
        test result fixed
      mysql-test/r/ps_4heap.result:
        Bug #28361 Buffer overflow in DECIMAL code on Windows 
        test result fixed
      mysql-test/r/ps_5merge.result:
        Bug #28361 Buffer overflow in DECIMAL code on Windows 
        test result fixed
      mysql-test/r/ps_7ndb.result:
        Bug #28361 Buffer overflow in DECIMAL code on Windows 
        test result fixed
      d2c985e3
    • unknown's avatar
      Merge macbook:mysql/work/B22855-5.0-opt · 330a82f0
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/B22855-5.0-opt
      
      
      sql/item_subselect.cc:
        Auto merged
      mysql-test/r/subselect3.result:
        manual merge
      mysql-test/t/subselect3.test:
        manual merge
      330a82f0
  4. 20 May, 2007 1 commit
    • unknown's avatar
      bug #28361 Buffer overflow in DECIMAL code on Windows · 59a7e066
      unknown authored
      my_decimal in some cases can contain more decimal digits than
      is officially supported (DECIMAL_MAX_PRECISION), so we need to
      prepare bigger buffer for the resulting string.
      
      
      mysql-test/r/type_newdecimal.result:
        bug #28361 Buffer overflow in DECIMAL code on Windows
        test result
      mysql-test/t/type_newdecimal.test:
        bug #28361 Buffer overflow in DECIMAL code on Windows
        test case
        This test case doesn't fall in most cases even without the fix
        Still valgrind shows the problemn
      sql/my_decimal.h:
        bug #28361 Buffer overflow in DECIMAL code on Windows
        DECIMAL_MAX_POSSIBLE_PRECISION introduced to be used in places,
        when we need to check for the number of digits technicaly possible
        in my_decimal.
        DECIMAL_MAX_STR_LENGTH fixed as it has to fit for the MAX_POSSIBLE_PRECISION
      59a7e066
  5. 18 May, 2007 7 commits
  6. 17 May, 2007 4 commits
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 042b1717
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug28337
      
      
      042b1717
    • unknown's avatar
      Bug#28261: Wrong DATETIME comparison result when the GET_USER_VAR function · c4a4df5a
      unknown authored
      is involved.
      
      The Arg_comparator::compare_datetime() comparator caches its arguments if
      they are constants i.e. const_item() returns true. The
      Item_func_get_user_var::const_item() returns true or false based on
      the current query_id and the query_id where the variable was created.
      Thus even if a query can change its value its const_item() still will return
      true. All this leads to a wrong comparison result when an object of the
      Item_func_get_user_var class is involved.
      
      Now the Arg_comparator::can_compare_as_dates() and the
      get_datetime_value() functions never cache result of the GET_USER_VAR()
      function (the Item_func_get_user_var class).
      
      
      mysql-test/t/type_datetime.test:
        A test case is added for the bug#28261: Wrong DATETIME comparison result when the GET_USER_VAR function
        is involved.
      mysql-test/r/type_datetime.result:
        A test case is added for the bug#28261: Wrong DATETIME comparison result when the GET_USER_VAR function
        is involved.
      sql/item_cmpfunc.cc:
        Bug#28261: Wrong DATETIME comparison result when the GET_USER_VAR function
        is involved.
        Now the Arg_comparator::can_compare_as_dates() and the
        get_datetime_value() functions never cache result of the GET_USER_VAR()
        function (the Item_func_get_user_var class).
      c4a4df5a
    • unknown's avatar
      Bug#22855: · 455352b0
      unknown authored
      Conversion errors when constructing the condition for an
      IN predicates were treated as if the affected column contains
      NULL. If such a IN predicate is inside NOT we get wrong 
      results.
      Corrected the handling of conversion errors in an IN predicate 
      that is resolved by unique_subquery (through 
      subselect_uniquesubquery_engine).
      
      
      mysql-test/r/subselect3.result:
        Bug#22855: test case
      mysql-test/t/subselect3.test:
        Bug#22855: test case
      sql/item_subselect.cc:
        Bug#22855: corrected the handling of conversion errors and
        NULL key values in IN predicate that is resolved by index
        lookup.
      455352b0
    • unknown's avatar
      Fixed bug #28337: wrong results for grouping queries with correlated · dd1a1180
      unknown authored
      subqueries in WHERE conditions.
      This bug was introduced by the patch for bug 27321.
      
      
      mysql-test/r/subselect.result:
        Added a test case for bug #28337.
      mysql-test/t/subselect.test:
        Added a test case for bug #28337.
      sql/item.cc:
        Fixed bug #28337: wrong results for grouping queries with correlated
        subqueries in WHERE conditions.
        This bug was introduced by the patch for bug 27321.
        
        Now in the Item_field::fix_outer_field function we create an Item_outer_ref
        object for an outer reference only if it is used in the SELECT list or
        in the HAVING clause of the subquery against which the reference is resolved.
      dd1a1180
  7. 16 May, 2007 12 commits