- 29 Jan, 2009 2 commits
-
-
Satya B authored
After the earlier fix, mtr tests reports "table full" messages as warnings. This is expected, this patch fixes the mtr testframework to ignore the error message. mysql-test/lib/mtr_report.pl: fixed mtr_report_stats to ignore the Table Full error messages generated by the testcases main.almost_full, main.myisam_data_pointer_size_func
-
Sergey Petrunia authored
-
- 28 Jan, 2009 10 commits
-
-
Sergey Petrunia authored
-
Sergey Petrunia authored
Item_in_optimizer::is_null() evaluated "NULL IN (SELECT ...)" to NULL regardless of whether subquery produced any records, this was a documented limitation. The limitation has been removed (see bugs 8804, 24085, 24127) now Item_in_optimizer::val_int() correctly handles all cases with NULLs. Make Item_in_optimizer::is_null() invoke val_int() to return correct values for "NULL IN (SELECT ...)". mysql-test/r/subselect.result: BUG#37822: Correlated subquery with IN and IS UNKNOWN provides wrong result - Testcase mysql-test/t/subselect.test: BUG#37822: Correlated subquery with IN and IS UNKNOWN provides wrong result - Testcase
-
Gleb Shchepa authored
-
Gleb Shchepa authored
messed up "ROW(...) IN (SELECT ... FROM DUAL)" always returned TRUE. Item_in_subselect::row_value_transformer rewrites "ROW(...) IN SELECT" conditions into the "EXISTS (SELECT ... HAVING ...)" form. For a subquery from the DUAL pseudotable resulting HAVING condition is an expression on constant values, so further transformation with optimize_cond() eliminates this HAVING condition and resets JOIN::having to NULL. Then JOIN::exec treated that NULL as an always-true-HAVING and that caused a bug. To distinguish an optimized out "HAVING TRUE" clause from "HAVING FALSE" we already have the JOIN::having_value flag. However, JOIN::exec() ignored JOIN::having_value as described above as if it always set to COND_TRUE. The JOIN::exec method has been modified to take into account the value of the JOIN::having_value field. mysql-test/r/subselect3.result: Added test case for bug #39069. mysql-test/t/subselect3.test: Added test case for bug #39069. sql/sql_select.cc: Bug #39069: <row constructor> IN <table-subquery> seriously messed up The JOIN::exec method has been modified to take into account the value of the JOIN::having_value field.
-
Davi Arnaut authored
-
Davi Arnaut authored
Dirty close tricky does not work on Windows. mysql-test/r/query_cache_notembedded.result: Remove test case result. mysql-test/t/query_cache_notembedded.test: Remove test case.
-
Georgi Kodinov authored
-
Georgi Kodinov authored
Re-generated the PKI files needed. Removed the ones that are not needed. Updated the tests to reference the correct SSL subject. mysql-test/r/openssl_1.result: Bug #42366: Updated the tests to reference the correct SSL subject mysql-test/std_data/cacert.pem: Bug #42366: Re-generated the PKI files needed. mysql-test/std_data/client-cert.pem: Bug #42366: Re-generated the PKI files needed. mysql-test/std_data/client-key.pem: Bug #42366: Re-generated the PKI files needed. mysql-test/std_data/server-cert-des.pem: Bug #42366: Removed the ones that are not needed. mysql-test/std_data/server-cert.pem: Bug #42366: Re-generated the PKI files needed. mysql-test/std_data/server-key-des.pem: Bug #42366: Removed the ones that are not needed. mysql-test/std_data/server-key.pem: Bug #42366: Re-generated the PKI files needed. mysql-test/std_data/server8k-cert.pem: Bug #42366: Re-generated the PKI files needed. mysql-test/std_data/server8k-key.pem: Bug #42366: Re-generated the PKI files needed. mysql-test/t/openssl_1.test: Bug #42366: Updated the tests to reference the correct SSL subject
-
Satya B authored
When a MEMORY table is full the error is returned to client but not written to error log. Fixed the handler api to write the error mesage to error log when the table is full. Note: No TestCase included as testing the error log is non-trivial. sql/handler.cc: Fixed handler::print_error() to write the error message to error log when the table is full.
-
Alfranio Correia authored
-
- 27 Jan, 2009 2 commits
-
-
Alfranio Correia authored
The fix for BUG#20103 "Escaping with backslash does not work as expected" was implemented too greedy though in that it not only changes the behavior of backslashes within strings but in general, so disabling command shortcuts like \G or \C (which in turn leads to Bug #36391: "mysqlbinlog creates invalid charset statements"). The fix allows the escaping with backslash to take place only inside a string, thus enabling the execution of command shortcuts and presevering the fix for BUG#20103.
-
Andrei Elkin authored
Fixing pb failures caused by mtr invokes the test with --tmpdir to which there are sensitive operations in the test and setup_fake_relay_log.inc also needed --secure-file-priv for its own separate directory. Fixed with removing SELECT INTO OUTFILE and deploying --exec echo instead in the marco. The test's opt file should contain --secure-file-priv=$MYSQL_TEST_DIR as the test operations deal with files located in $MYSQL_TEST_DIR. mysql-test/include/setup_fake_relay_log.inc: Refining setup_fake_relay_log.inc to not use --secure-file-priv sensitive feature. The latter should remain available for the test.
-
- 26 Jan, 2009 7 commits
-
-
Chad MILLER authored
-
Chad MILLER authored
-
Horst Hunger authored
-
Chad MILLER authored
-
Andrei Elkin authored
Overriding a default value of --secure-file-priv on pb.mtr to be $MYSQLTEST_VARDIR which makes pb's mtr happy to execute the regression test for the bug. mysql-test/suite/rpl/t/rpl_cross_version-master.opt: satisfying pb's mtr that uses --vardir to shm.
-
Andrei Elkin authored
Overriding a default value of --secure-file-priv on pb.mtr with a value allowable the test to pass on pb. mysql-test/suite/rpl/t/rpl_cross_version-master.opt: Overriding a default value of --secure-file-priv with a value allowable the test to pass on pb.
-
Ramil Kalimullin authored
myisam_repair_threads > 1 causes crash Problem: parallel repair (myisam_repair_threads > 1) of a myisam table with two or more fulltext keys that use the same parser may lead to a server crash. ALTER TABLE ENABLE KEYS is affected as well. Fix: properly initialize fulltext structures for parallel repair. Note: 1. there's no deterministic test case. 2. now we call parser->init() for each fulltext key (not for each fulltext parser used). storage/myisam/ft_parser.c: Fix for bug #37756: enabling fulltext indexes with myisam_repair_threads > 1 causes crash In ftparser_call_initializer() we "group" parsers and allocate parameters for each unique parser used. In case of parallel repairing we may have a bunch of parsers that use the only MI_INFO structure. Each of these parsers must have its own parameter structure in order not to interfere with others. Moreover, the allocation is done without mutex lock so parallel ftparser_call_initializer() calls are unsafe. Now we don't "group" the fulltext parsers. Parameter allocation code moved to ftparser_alloc_param() function which is called from mi_repair_parallel() as well to allocate parameters for each parser used. storage/myisam/ftdefs.h: Fix for bug #37756: enabling fulltext indexes with myisam_repair_threads > 1 causes crash ftparser_alloc_param(MI_INFO *info) added. storage/myisam/mi_check.c: Fix for bug #37756: enabling fulltext indexes with myisam_repair_threads > 1 causes crash ftparser_alloc_param(info) called in case of parallel repair to allocate fulltext parser parameters. storage/myisam/mi_open.c: Fix for bug #37756: enabling fulltext indexes with myisam_repair_threads > 1 causes crash set keyinfo->ftkey_nr and share->ftkeys.
-
- 24 Jan, 2009 1 commit
-
-
Gleb Shchepa authored
-
- 23 Jan, 2009 6 commits
-
-
Horst Hunger authored
-
Horst Hunger authored
-
Gleb Shchepa authored
in trigger Interchangeable calls to the mysql_change_user client function and invocations of a trigger changing some user variable caused a memory corruption and a crash. The mysql_change_user API call forces TDH::cleanup() on a server that frees user variable entries. However it didn't reset Item_func_set_user_var::entry to NULL because Item_func_set_user_var::cleanup() was not overloaded. So, Item_func_set_user_var::entry held a pointer to freed memory, that caused a crash. The Item_func_set_user_var::cleanup method has been overloaded to cleanup the Item_func_set_user_var::entry field. mysql-test/r/user_var.result: Added test case for bug #42188. mysql-test/t/user_var.test: Added test case for bug #42188. sql/item_func.cc: Bug#42188: crash and/or memory corruption with user variables in trigger The Item_func_set_user_var::cleanup method has been overloaded to cleanup the Item_func_set_user_var::entry field. sql/item_func.h: Bug#42188: crash and/or memory corruption with user variables in trigger The Item_func_set_user_var::cleanup method has been overloaded to cleanup the Item_func_set_user_var::entry field.
-
Horst Hunger authored
Deleted the opt file. Replaced the sleeps by wait condition. Made some beautyfications. Inserted review results.
-
Andrei Elkin authored
an additional changeset to remove printing a path name. mysql-test/suite/rpl/r/rpl_cross_version.result: removing a local exec env dependency mysql-test/suite/rpl/t/rpl_cross_version.test: refining a test to not have local exec env dependency.
-
Andrei Elkin authored
-
- 22 Jan, 2009 5 commits
-
-
Andrei Elkin authored
It's a regression issue. The reason of the bug appeared to be an error introduced into 5.1 source code. A piece of code in Create_file_log_event::do_apply_event() did not have test coverage which made make test and pb unaware. Fixed with inverting the old value of the return value from Create_file_log_event::do_apply_event(). The rpl test suite is extended with `rpl_cross_version' the file to hold regression cases similar to the current. mysql-test/suite/rpl/r/rpl_cross_version.result: new results file mysql-test/suite/rpl/t/rpl_cross_version-master.opt: options to the server to be able to start replication to itself mysql-test/suite/rpl/t/rpl_cross_version.test: regression test for bug#31240. sql/log_event.cc: Correcting the return value from Create_file_log_event::do_apply_event()
-
Satya B authored
-
Davi Arnaut authored
sql/sql_cache.cc: Assert that results are always complete.
-
Davi Arnaut authored
The problem is that the query cache was storing partial results if the statement failed when sending the results to the client. This could cause clients to hang when trying to read the results from the cache as they would, for example, wait indefinitely for a eof packet that wasn't saved. The solution is to always discard the caching of a query that failed to send its results to the associated client. mysql-test/r/query_cache_notembedded.result: Add test case result for Bug#40264 mysql-test/t/query_cache_notembedded.test: Add test case for Bug#40264 sql/sql_cache.cc: Abort if a unreported error was raised.
-
Satya B authored
Extending the existing testcase written for BUG#40949 to verify repair table operation for compressed tables mysql-test/r/myisampack.result: Modified result file for myisampack.test mysql-test/t/myisampack.test: Modified Testcase to test repair operation for compressed tables
-
- 21 Jan, 2009 1 commit
-
-
Serge Kozlov authored
clause server fires immediately after creating event and time between create and delete event sometimes is enough for firing. So adding STARTS clause moves first execution in future after drop of event 1. Added STARTS clause for CREATE EVENT. 2. Updated result file.
-
- 20 Jan, 2009 1 commit
-
-
Staale Smedseng authored
character_set_database !=character_set_server" is fixed.
-
- 16 Jan, 2009 5 commits
-
-
Timothy Smith authored
-
Timothy Smith authored
-
Timothy Smith authored
-
Georgi Kodinov authored
-
Georgi Kodinov authored
-