- 24 Mar, 2014 1 commit
-
-
Michael Widenius authored
Backported multi_update_check_table_access() from 5.6 The code is slightly different in MariaDB, becasue we instansiate fields in merged tables earlier. mysql-test/mysql-test-run.pl: Fixed comment mysql-test/r/view_grant.result: Merged test case from 5.6 mysql-test/t/view_grant.test: Merged test case from 5.6 sql/sql_parse.cc: Reset orig_want_privilege as this will be rechecked later. If not, we will have a problem in mysql_multi_update_prepare() for the call to mysql_handle_derived() sql/sql_update.cc: Backport multi_update_check_table_access() from 5.6
-
- 23 Mar, 2014 5 commits
-
-
Michael Widenius authored
Fixed use-copy option to mysql-test-run mysql-test/mysql-test-run.pl: Fixed use-copy and added comment sql/log.cc: Make copy_up_file_and_fill() safe for disk full
-
Michael Widenius authored
mysql-test/r/create_or_replace.result: More tests for create or replace mysql-test/t/create_or_replace.test: More tests for create or replace sql/log.cc: Don't use binlog_hton if binlog is not enabmed sql/sql_base.cc: We have to call restart_trans_for_tables also if tables where not locked with LOCK TABLES. If not, we will get a crash in TokuDB sql/sql_insert.cc: Don't call binlog_reset_cache() if we don't have binary log open sql/sql_table.cc: Don't log to binary log if not open Better test if we where using create or replace ... select storage/tokudb/mysql-test/tokudb_mariadb/r/create_or_replace.result: More tests for create or replace storage/tokudb/mysql-test/tokudb_mariadb/t/create_or_replace.test: More tests for create or replace
-
Michael Widenius authored
Copied relevant test cases and code from the MySQL 5.6 tree Testing of my_use_symdir moved to engines. mysql-test/r/partition_windows.result: Updated result file mysql-test/suite/archive/archive_no_symlink-master.opt: Testing of symlinks with archive mysql-test/suite/archive/archive_no_symlink.result: Testing of symlinks with archive mysql-test/suite/archive/archive_no_symlink.test: Testing of symlinks with archive mysql-test/suite/archive/archive_symlink.result: Testing of symlinks with archive mysql-test/suite/archive/archive_symlink.test: Testing of symlinks with archive sql/log_event.cc: Updated comment sql/partition_info.cc: Don't test my_use_symdir here sql/sql_parse.cc: Updated comment sql/sql_table.cc: Don't test my_use_symdir here sql/table.cc: Added more DBUG_PRINT storage/archive/ha_archive.cc: Give warnings for index_file_name and if we can't use data directory storage/myisam/ha_myisam.cc: Give warnings if we can't use data directory or index directory
-
Michael Widenius authored
I had forgot to check if binary logging and that we had logged row log events before clearing the transaction cache.
-
Michael Widenius authored
Bug #3329 Incomplete lower_case_table_names=2 implementation The problem was that check_db_name() converted database names to lower case also in case of lower_case_table_names=2. Fixed by removing the conversion in check_db_name for lower_case_table_names = 2 and instead converting db name to lower case at same places as table names are converted. Fixed bug that SHOW CREATE DATABASE FOO showed information for database 'foo'. I also removed some checks of lower_case_table_names when it was enough to use table_alias_charset. mysql-test/mysql-test-run.pl: Added --use-copy argument to force mysql-test-run to copy files instead of doing symlinks. This is needed when you run with test directory on another file system mysql-test/r/lowercase_table.result: Updated results mysql-test/r/lowercase_table2.result: Updated results mysql-test/suite/parts/r/partition_mgm_lc2_innodb.result: Updated results mysql-test/suite/parts/r/partition_mgm_lc2_memory.result: Updated results mysql-test/suite/parts/r/partition_mgm_lc2_myisam.result: Updated results mysql-test/t/lowercase_table.test: Added tests with mixed case databases mysql-test/t/lowercase_table2.test: Added tests with mixed case databases sql/log.cc: Don't check lower_case_table_names when we can use table_alias_charset sql/sql_base.cc: Don't check lower_case_table_names when we can use table_alias_charset sql/sql_db.cc: Use cmp_db_names() for checking if current database changed. mysql_rm_db() now converts db to lower case if lower_case_table_names was used. Changed database options cache to use table_alias_charset. This fixed a bug where SHOW CREATE DATABASE showed wrong information. sql/sql_parse.cc: Change also db name to lower case when file names are changed. Don't need to story copy of database name anymore when lower_case_table_names == 2 as check_db_name() don't convert in this case. Updated arguments to mysqld_show_create_db(). When adding table to TABLE_LIST also convert db name to lower case if needed (same way as we do with table names). sql/sql_show.cc: mysqld_show_create_db() now also takes original name as argument for output to user. sql/sql_show.h: Updated prototype for mysqld_show_create_db() sql/sql_table.cc: In mysql_rename_table(), do same conversions to database name as we do for the file name
-
- 22 Mar, 2014 2 commits
-
-
Michael Widenius authored
Patch from 5.6 by Praveenkumar Hulakund Bug#13608112 - 64048: MYSQL_PRINT_STATUS() MISSING FINAL FFLUSH() Analysis: While printing debug information, memory related information and event related information were written to buffer after flushing it. Because of this, these information were getting printed when we do the next flush. Fix: Instead of calling fflush() before writing memory and event information, calling it after memory and event information.
-
Michael Widenius authored
sql/log_event.cc: Added THD_STAGE_INFO when applying row events
-
- 27 Mar, 2014 4 commits
-
-
Sergey Petrunya authored
- Move [some] engine-agnostic tests from t/selectivity.test to t/selectivity_no_engine.test - Move Histogram::point_selectivity to sql_statistics.cc
-
Sergey Petrunya authored
-
Sergey Petrunya authored
- Histogram::find_bucket() should not walk off the end of the value range. - Address review feedback in Histogram::point_selectivity(): different handling for zero-width buckets, and explanations.
-
Sergei Golubchik authored
-
- 26 Mar, 2014 21 commits
-
-
Sergei Golubchik authored
remove dead code
-
Sergei Golubchik authored
MDEV-5839 TokuDB tables not properly cleaned on DROP DATABASE TokuDB does not support discover_table_names() and writes no files in the database directory, so automatic filename-based discover_table_names() doesn't work either. So, it must force .frm file to disk in ::create()
-
Sergei Golubchik authored
Don't abort plugin reads whem mpvio->make_it_fail is set - this can leak information.
-
Sergei Golubchik authored
-
Sergei Golubchik authored
Rename back my_init_dynamic_array2() -> init_dynamic_array2() It happens to be a part of the de facto API :(
-
Sergei Golubchik authored
-
Sergei Golubchik authored
MDEV-5955 Server crashes in handler::ha_external_lock or assertion `m_lock_type == 2' fails in handler::ha_close on disconnect with a locked temporary table first unlock locked tables, then close and remove temporary
-
Michael Widenius authored
The reason was that a couple of variables that hold number of rows that was used to calculate buffers was uint and caused an overflow. Fixed by changing variables that could hold number of rows from uint to ulong and also added a cast for this test. include/heap.h: Reorder to get better alignment. Changed variables that could hold number of rows from uint to ulong mysql-test/suite/heap/heap.result: Added test case mysql-test/suite/heap/heap.test: Added test case mysql-test/suite/plugins/t/server_audit.test: Added sleep as we want to have disconnect logged before we try a new connect storage/heap/ha_heap.cc: Changed variables that could hold number of rows from uint to ulong Limit number of rows to 4G (as most of the variables that holds rows are ulong anyway) reset records_changed when key_stat_version is changed to not cause increments for every row changed storage/heap/ha_heap.h: changed records_changed to ulong as this can get big storage/heap/hp_create.c: Changed variables that could hold number of rows from uint to ulong Added cast (fixed the original bug) storage/heap/hp_delete.c: Changed variables that could hold number of rows from uint to ulong storage/heap/hp_open.c: Removed not needed cast storage/heap/hp_write.c: Changed variables that could hold number of rows from uint to ulong support-files/compiler_warnings.supp: Removed extra : from supression
-
Sergey Petrunya authored
- Fix Histogram::point_selectivity() to work in the case where the passed value_pos=0 (or 1) and the first (or the last) bucket in the histogram has zero value-range (i.e one value).
-
Sergey Petrunya authored
[Attempt #2] - Use a new selectivity calculation formula in Histogram::point_selectivity. The formula is different from the old one because it was developed from scratch. it doesn't have any possible division-by-zero problems.
-
Sergei Golubchik authored
MDEV-5920 MySQL Bug#16765410 FTS: STACK AROUND THE VARIABLE 'MYSTR' WAS CORRUPTED IN INNOBASE_STRNXFRM
-
Sergei Golubchik authored
MDEV-5861 MySQL Bug#12601974 - STORED PROCEDURE SQL_MODE=NO_BACKSLASH_ESCAPES IGNORED AND BREAKS REPLICATION escape usernames in CREATE/DROP USER error messages according to NO_BACKSLASH_ESCAPES
-
Sergei Golubchik authored
simplify the prototype and move it to sql_string.h
-
Sergei Golubchik authored
-
Sergei Golubchik authored
use LEX_STRING, keep similar functions together, remove duplicated code
-
Sergei Golubchik authored
-
Sergei Golubchik authored
field list, it doesn't work if ALTER TABLE has replaced all fields. Instead, pass the correct original table name down from the caller.
-
Sergei Golubchik authored
from the variable @@session.tokudb_row_format
-
Sergei Golubchik authored
-
Sergei Golubchik authored
MDEV-5815 MySQL BUG#11751736: DROP DATABASE STATEMENT SHOULD REMOVE .OLD SUFFIX FROM DATABASE DIRECTORY Delete .OLD and .TMD files when a MyISAM table is dropped. Same for Aria. sql/sql_db.cc: dead code - *.TMD cannot be deleted from here.
-
Sergei Golubchik authored
-
- 25 Mar, 2014 3 commits
-
-
Sergei Golubchik authored
previous file->index_next (or other file->... index access method) succeeded
-
Sergei Golubchik authored
in the libmysqlclient_16 version node.
-
Sergei Golubchik authored
-
- 24 Mar, 2014 4 commits
-
-
Sergei Golubchik authored
add pthread_mutex_destroy(&THR_LOCK_dbug); that was apparently forgotten since the very first MySQL version
-
Sergei Golubchik authored
error message (because error messages use replacements)
-
Sergei Golubchik authored
-
Sergei Golubchik authored
for new tables
-