1. 21 Jun, 2007 1 commit
    • unknown's avatar
      Bug#24924: shared-memory-base-name that is too long causes buffer overflow · 4d9cc3db
      unknown authored
      long shared-memory-base-names could overflow a static internal buffer
      and thus crash mysqld and various clients.  change both to dynamic
      buffers, show everything but overflowing those buffers still works.
      
      The test case for this would pretty much amount to
      mysqld --shared-memory-base-name=HeyMrBaseNameXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX --shared-memory=1 &
      mysqladmin --no-defaults --shared-memory-base-name=HeyMrBaseNameXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX shutdown
      
      Unfortunately, we can't just use an .opt file for the
      server. The .opt file is used at start-up, before any
      include in the actual test can tell mysqltest to skip
      this one on non-Windows. As a result, such a test would
      break on unices.
      
      Fixing mysql-test-run.pl to export full path for master
      and slave would enable us to start a server from within
      the test which is ugly and, what's more, doesn't work as
      the server blocks (mysqltest offers no fire-and-forget
      fork-and-exec), and mysqladmin never gets run.
      
      Making the test rpl_windows_shm or some such so we can
      is beyond ugly. As is introducing another file-name based
      special case (run "win*.test" only when on Windows). As is
      (yuck) coding half the test into mtr (as in, having it
      hand out a customized environment conductive to the shm-
      thing on Win only).
      
      Situation is exacerbated by the fact that .sh is not
      necessary run as expected on Win.
      
      In short, it's just not worth it. No test-case until we
      have a new-and-improved test framework.
      
      
      sql-common/client.c:
        Bug#24924: shared-memory-base-name that is too long causes buffer overflow
        
        compose shared memory name in dynamic rather than static buffer to prevent
        overflows (clients)
      sql/mysqld.cc:
        Bug#24924: shared-memory-base-name that is too long causes buffer overflow
        
        compose shared memory name in dynamic rather than static buffer to prevent
        overflows (server)
      4d9cc3db
  2. 19 Jun, 2007 4 commits
  3. 18 Jun, 2007 7 commits
    • unknown's avatar
      Bug #28921 Queries containing UDF functions are cached · 5941479e
      unknown authored
      Fixed runtime to no longer allow the caching of queries with UDF calls.
      
      
      mysql-test/r/udf.result:
        Added a test that turns on caching and checks that querys calling UDFs don't get cached.
      mysql-test/t/udf.test:
        Added a test that turns on caching and checks that querys calling UDFs don't get cached.
      sql/sql_yacc.yy:
        Fixed code to set safe_to_cache_query=0 regardless if the function call is a UDF or SP. Where it was placed previously -- at the very end of the else testing for UDFs -- it only executed the statement if the function call was a stored procedure call.
      5941479e
    • unknown's avatar
      Bug #29053 SQL_CACHE in UNION causes non-deterministic functions to be cached · 2a9bb274
      unknown authored
      Changed code to enforce that SQL_CACHE only in the first SELECT is used to turn on caching(as documented), but any SQL_NO_CACHE will turn off caching (not documented, but a useful behaviour, especially for machine generated queries). Added test cases to explicitly test the documented caching behaviour and test cases for the reported bug. 
      
      
      mysql-test/r/query_cache.result:
        Added non-bug specific tests that ensure that only SQL_CACHE in the first SELECT is respected when encountered by the parser. These tests validate what is already documented, that only the outer most SELECTS can use the SQL_CACHE option to turn on caching. Because it would break existing SQL applications, we do not return an error if the SQL_CACHE expression is found in nested SELECTs. Also added test to validate nested SELECT can contain SQL_NO_CACHE and it will always turn off caching for the whole query. 
        
        Also added a bug specific test case to validate that the buggy behavior as reported has been fixed.
      mysql-test/t/query_cache.test:
        Added non-bug specific tests that ensure that only SQL_CACHE in the first SELECT is respected when encountered by the parser. These tests validate what is already documented, that only the outer most SELECTS can use the SQL_CACHE option to turn on caching. Because it would break existing SQL applications, we do not return an error if the SQL_CACHE expression is found in nested SELECTs. Also added test to validate nested SELECT can contain SQL_NO_CACHE and it will always turn off caching for the whole query. 
        
        Also added a bug specific test case to validate that the buggy behavior as reported has been fixed.
      sql/sql_yacc.yy:
        Added an explicit check to make sure "SELECT SQL_CACHE" only works on the first select in a query.
        
        The parser will always hit the outermost SELECT first, and if the SQL_CACHE option is found it sets the safe_to_query flag in the lex. Then, if there are subseqent "uncachable" subqueries or functions, as it parses those elements it sets the safe_to_query to 0. However, this cause problems if nested SELECTs also used the SQL_CACHE option, because then it would set back safe_to_query to 1, even though there are uncacheable expressions previously parsed.
        
        By adding the check to ensure only the first SELECT can turn caching on, it means a subsequent SQL_CACHE option can't turn caching back on after a uncacheable subsequery was already encountered.
      2a9bb274
    • unknown's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/maint/41 · 1919b308
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/50
      
      
      configure.in:
        Auto merged
      1919b308
    • unknown's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/50 · 34a55d77
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/50
      
      
      34a55d77
    • unknown's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/41 · bf398091
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/41
      
      
      configure.in:
        Auto merged
      bf398091
    • unknown's avatar
      Merge svojtovich@bk-internal.mysql.com:/home/bk/mysql-5.0 · 4831826c
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/merge/mysql-5.0-engines
      
      
      4831826c
    • unknown's avatar
      Merge dfischer@bk-internal.mysql.com:/home/bk/mysql-5.0 · fe99cf3a
      unknown authored
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0
      
      
      fe99cf3a
  4. 17 Jun, 2007 8 commits
  5. 16 Jun, 2007 3 commits
  6. 15 Jun, 2007 15 commits
    • unknown's avatar
      binlog.result, binlog.test: · 651a8e7f
      unknown authored
        Post-merge fix: replace xid=* with XID to isolate from number of transactions
      
      
      mysql-test/r/binlog.result:
        Post-merge fix: replace xid=* with XID to isolate from number of transactions
      mysql-test/t/binlog.test:
        Post-merge fix: replace xid=* with XID to isolate from number of transactions
      651a8e7f
    • unknown's avatar
      Merge tsmith@bk-internal.mysql.com:/home/bk/mysql-5.0-build · 3982f318
      unknown authored
      into  quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/maint/jun14/50
      
      
      3982f318
    • unknown's avatar
      Merge tsmith@bk-internal.mysql.com:/home/bk/mysql-5.0-maint · c2db927b
      unknown authored
      into  quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/maint/jun14/50
      
      
      configure.in:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      c2db927b
    • unknown's avatar
      Merge chilla.local:/home/mydev/mysql-4.1-axmrg · 559bc939
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.0-axmrg
      
      
      559bc939
    • unknown's avatar
      Merge chilla.local:/home/mydev/mysql-5.0-amain · 30057f67
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.0-axmrg
      
      
      mysql-test/r/view.result:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      30057f67
    • unknown's avatar
      Merge chilla.local:/home/mydev/mysql-5.0-ateam · 352d6489
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.0-axmrg
      
      
      352d6489
    • unknown's avatar
      Merge chilla.local:/home/mydev/mysql-4.1-amain · 82f757ff
      unknown authored
      into  chilla.local:/home/mydev/mysql-4.1-axmrg
      
      
      82f757ff
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-maint · 08d2e29c
      unknown authored
      into  zippy.cornsilk.net:/home/cmiller/work/mysql/mysql-5.0-maint
      
      
      08d2e29c
    • unknown's avatar
      Fix for bug #28144: "Slave_IO_Running" differs in replication tests · d2f858ab
      unknown authored
      Problem: show slave status may return different Slave_IO_Running values running some tests.
      Fix: wait for a certain slave state if needed to get tests more predictable.
      
      
      mysql-test/r/rpl_log_pos.result:
        Fix for bug #28144: "Slave_IO_Running" differs in replication tests
          - test result adjusted.
      mysql-test/r/rpl_ssl.result:
        Fix for bug #28144: "Slave_IO_Running" differs in replication tests
          - test result adjusted.
      mysql-test/t/rpl_log_pos.test:
        Fix for bug #28144: "Slave_IO_Running" differs in replication tests
          - test has been rewritten to get certain slave state, now we use wait_for_slave_param.inc
            to ensure we get proper IO/SQL slave's threads states.
      mysql-test/t/rpl_ssl.test:
        Fix for bug #28144: "Slave_IO_Running" differs in replication tests
          - wait_for_slave_to_start.inc used to get certain slave states in order 
            to be more predictable.
      mysql-test/include/wait_for_slave_param.inc:
        New BitKeeper file ``mysql-test/include/wait_for_slave_param.inc''
        
        allow to wait until SHOW SLAVE STATUS has returned a spicified value.
      d2f858ab
    • unknown's avatar
      follow-up fix · 9bba1059
      unknown authored
      
      include/violite.h:
        this may already be defined
      9bba1059
    • unknown's avatar
      Backport of · 60829746
      unknown authored
      mysql-test/include/wait_for_slave_io_to_stop.inc
      mysql-test/include/wait_for_slave_sql_to_stop.inc
      mysql-test/include/wait_for_slave_to_start.inc
      mysql-test/include/wait_for_slave_to_stop.inc
      from 5.1
      
      
      mysql-test/include/wait_for_slave_io_to_stop.inc:
        New BitKeeper file ``mysql-test/include/wait_for_slave_io_to_stop.inc''
      mysql-test/include/wait_for_slave_sql_to_stop.inc:
        New BitKeeper file ``mysql-test/include/wait_for_slave_sql_to_stop.inc''
      mysql-test/include/wait_for_slave_to_start.inc:
        New BitKeeper file ``mysql-test/include/wait_for_slave_to_start.inc''
      mysql-test/include/wait_for_slave_to_stop.inc:
        New BitKeeper file ``mysql-test/include/wait_for_slave_to_stop.inc''
      60829746
    • unknown's avatar
      Merge pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0-build · 57726dc0
      unknown authored
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0-build-work
      
      
      57726dc0
    • unknown's avatar
      Merge dfischer@bk-internal.mysql.com:/home/bk/mysql-5.0 · 288917f5
      unknown authored
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0
      
      
      288917f5
    • unknown's avatar
      Added yassl and taocrypt sources to mysqlclientlib · 8ebcb3ee
      unknown authored
      
      client/CMakeLists.txt:
        Fix for bug #27861: unresolved externals (yassl and taocrypt)
      8ebcb3ee
    • unknown's avatar
      Bug#28862 Extended Latin1 characters get lost in CVS engine · 39700afd
      unknown authored
        Problem: Temporary buffer which is used for quoting and escaping
        was initialized to character set utf8, and thus didn't allow
        to store data in other character sets.
        Fix: changing character set of the buffer to be able to
        store any arbitrary sequence of bytes.
      
      
      mysql-test/r/csv.result:
        Adding test case
      mysql-test/t/csv.test:
        Adding test case
      sql/examples/ha_tina.cc:
        Changing character set of the buffer to "binary".
      39700afd
  7. 14 Jun, 2007 2 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-maint · 578b81bb
      unknown authored
      into  zippy.cornsilk.net:/home/cmiller/work/mysql/mysql-5.0-maint
      
      
      configure.in:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      578b81bb
    • unknown's avatar
      Merge tsmith@bk-internal.mysql.com:/home/bk/mysql-5.0-build · cb93ff4d
      unknown authored
      into  quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/maint/jun14/50
      
      
      configure.in:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/r/binlog.result:
        Auto merged
      mysql-test/r/have_log_bin.require:
        Auto merged
      BitKeeper/deleted/.del-ctype_cp932_notembedded.test:
        Auto merged
      mysql-test/t/binlog.test:
        Auto merged
      mysql-test/t/ctype_cp932_binlog.test:
        Auto merged
      mysql-test/t/ctype_ucs_binlog.test:
        Auto merged
      mysql-test/t/flush_block_commit_notembedded.test:
        Auto merged
      mysql-test/t/insert_select-binlog.test:
        Auto merged
      mysql-test/t/mysqlbinlog-cp932.test:
        Auto merged
      mysql-test/t/mysqldump.test:
        Auto merged
      mysql-test/t/sp_trans.test:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/mix_innodb_myisam_binlog.result:
        Use local
      mysql-test/t/blackhole.test:
        manual merge
      mysql-test/t/drop_temp_table.test:
        manual merge
      mysql-test/t/mix_innodb_myisam_binlog.test:
        Use local
      mysql-test/t/mysqlbinlog.test:
        Use local
      cb93ff4d