1. 25 Jul, 2006 1 commit
    • unknown's avatar
      Bug#16712: group_concat returns odd srting insead of intended result · 4e7121c0
      unknown authored
        when calculating GROUP_CONCAT all blob fields are transformed
        to varchar when making the temp table.
        However a varchar has at max 2 bytes for length. 
        This fix makes the conversion only for blobs whose max length 
        is below that limit. 
        Otherwise blob field is created by make_string_field() call.
      
      
      mysql-test/r/func_gconcat.result:
        Bug#16712: group_concat returns odd srting insead of intended result
          * testsuite for the bug
      mysql-test/t/func_gconcat.test:
        Bug#16712: group_concat returns odd srting insead of intended result
          * testsuite for the bug
      sql/item_sum.cc:
        Bug#16712: group_concat returns odd srting insead of intended result
          * force blob->varchar conversion for small enough blobs only
      sql/sql_select.cc:
        Bug#16712: group_concat returns odd srting insead of intended result
          * force blob->varchar conversion for small enough blobs only
      4e7121c0
  2. 07 Jul, 2006 1 commit
  3. 06 Jul, 2006 6 commits
    • unknown's avatar
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-4.1-opt · cba001b7
      unknown authored
      into  olga.mysql.com:/home/igor/mysql-5.0-opt
      
      
      mysql-test/r/func_str.result:
        Auto merged
      mysql-test/t/func_str.test:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      sql/item_strfunc.h:
        Auto merged
      cba001b7
    • unknown's avatar
      Merge ibabaev@bk-internal.mysql.com:/home/bk/mysql-4.1-opt · 8cb368bc
      unknown authored
      into  olga.mysql.com:/home/igor/mysql-4.1-opt
      
      
      8cb368bc
    • unknown's avatar
      Fixed bug #18243. · cf7627bc
      unknown authored
      The implementation of the method Item_func_reverse::val_str
      for the REVERSE function modified the argument of the function.
      This led to wrong results for expressions that contained
      REVERSE(ref) if ref occurred somewhere else in the expressions.
      
      
      mysql-test/r/func_str.result:
        Added a test case for bug #18243.
      mysql-test/t/func_str.test:
        Added a test case for bug #18243.
      sql/item_strfunc.cc:
        Fixed bug #18243.
        The implementation of the method Item_func_reverse::val_str
        for the REVERSE function modified the argument of the function.
        This led to wrong results for expressions that contained
        REVERSE(ref) if ref occurred somewhere else in the expressions.
        
        The implementation of Item_func_reverse::val_str has been changed
        to make the argument intact.
      sql/item_strfunc.h:
        Fixed bug #18243.
        Added tmp_value to the Item_func_reverse class to store
        the result of the function. It erroneously replaced the 
        argument before this fix.
      cf7627bc
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 665d46e1
      unknown authored
      into  rakia.(none):/home/kgeorge/mysql/autopush/test
      
      
      665d46e1
    • unknown's avatar
      Bug #20569 Garbage in DECIMAL results from some mathematical functions · 8e354677
      unknown authored
        Adding decimal "digits" in multiplication resulted in signed overflow and
      producing wrong results.
      
        Fixed by using large enough buffers and intermediary result types :
      dec2 (currently longlong) to hold result of adding decimal "digits" 
      (currently int32). 
      
      
      mysql-test/r/select.result:
        Bug #20569 Garbage in DECIMAL results from some mathematical functions
          * test suite for the bug
      mysql-test/t/select.test:
        Bug #20569 Garbage in DECIMAL results from some mathematical functions
          * test suite for the bug
      strings/decimal.c:
        Bug #20569 Garbage in DECIMAL results from some mathematical functions
          * fixed the overflow in adding decimal "digits"
      8e354677
  4. 04 Jul, 2006 3 commits
    • unknown's avatar
      Better comments for void Item::top_level_item() · 1401c2c7
      unknown authored
      1401c2c7
    • unknown's avatar
      Merge mysql.com:/home/kgeorge/mysql/5.0/teamclean · 8a67bdd0
      unknown authored
      into  mysql.com:/home/kgeorge/mysql/5.0/B16110
      
      
      mysql-test/r/view.result:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      8a67bdd0
    • unknown's avatar
      Bug #16110: insert permitted into view col w/o default value · e08ff115
      unknown authored
      When compiling INSERT statements the check whether columns are provided values
      depends on the flag whether a field is used in that query (Field::query_id).
      However the check for updatability of VIEW columns (check_view_insertability())
      was calling fix_fields() and thus setting the Field::query_id even for the 
      view fields that are not referenced in the current INSERT statement.
      So the correct check for columns without default values 
      ( check_that_all_fields_are_given_values() ) is assuming that all the VIEW
      columns were mentioned in the INSERT field list and was issuing no 
      warnings or errors.
      Fixed check_view_insertability() to turn off the flag whether or not to set
      Field::query_id (THREAD::set_query_id) before calling fix fields and restore
      it when it's done.
      
      
      mysql-test/r/view.result:
        Bug #16110: insert permitted into view col w/o default value
          * test case
      mysql-test/t/view.test:
        Bug #16110: insert permitted into view col w/o default value
          * test case
      sql/sql_insert.cc:
        Bug #16110: insert permitted into view col w/o default value
          * avoid setting the "field used" flag for fields when checking view columns 
            for updatability.
          * a missing DBUG_RETURN added.
      e08ff115
  5. 29 Jun, 2006 29 commits