1. 19 May, 2004 3 commits
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-4.0 · 4eb67ce4
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.0
      
      
      sql/set_var.cc:
        Auto merged
      4eb67ce4
    • unknown's avatar
      Fix for BUG#3829 "Setting server_id on fly doesn't allow replication to start" · 66c96f2c
      unknown authored
      (fix by our Harrison Fisk): when one does SET GLOBAL SERVER_ID=x, we must set
      server_id_supplied to 1.
      
      
      sql/mysql_priv.h:
        server_id_supplied must be here to be visible in set_var.cc
      sql/mysqld.cc:
        rephrasing warnings when server id is not set explicitely.
      sql/set_var.cc:
        when one does SET GLOBAL SERVER_ID=x; it should be considered as explicitely setting
        the server id, so do server_id_supplied=1.
      sql/slave.cc:
        Correcting wrong comment
      66c96f2c
    • unknown's avatar
      Fix for Bug#3754 "SET GLOBAL myisam_max_sort_file_size doesn't · 458f0751
      unknown authored
      work as expected": precision-losing conversion removed from 
      sys_var_thd_ulonglong.
      
      
      mysql-test/r/variables.result:
        Test case for Bug#3754
      mysql-test/t/variables.test:
        Test case for Bug#3754
      sql/set_var.cc:
        Fix for Bug#3754: precision-losing conversion removed from 
        sys_var_thd_ulonglong.
      458f0751
  2. 18 May, 2004 1 commit
  3. 17 May, 2004 7 commits
    • unknown's avatar
      mem0pool.c: · 08d1de2c
      unknown authored
        Fix a memory corruption bug: in 32-bit computers, every 4 billionth malloc outside innodb_additional_mem_pool_size was mistreated when freeing the memory; this could corrupt the InnoDB additional mem pool and could have caused crashes anywhere, also inside MySQL, or even database corruption! the bug exists also in 3.23 and 4.1; workaround: configure innodb_additional_mem_pool_size big enough
      
      
      innobase/mem/mem0pool.c:
        Fix a memory corruption bug: in 32-bit computers, every 4 billionth malloc outside innodb_additional_mem_pool_size was mistreated when freeing the memory; this could corrupt the InnoDB additional mem pool and could have caused crashes anywhere, also inside MySQL, or even database corruption! the bug exists also in 3.23 and 4.1; workaround: configure innodb_additional_mem_pool_size big enough
      08d1de2c
    • unknown's avatar
      dict0dict.c: · d4f6c7a4
      unknown authored
        Allocate the table name buffer from the mem heap of a foreign key object rather than pointing to the name buffer in the table object; even though this apparently caused no bugs in RENAME, DROP, ALTER TABLE, or elsewhere, this convention was very prone to memory allocation bugs
      
      
      innobase/dict/dict0dict.c:
        Allocate the table name buffer from the mem heap of a foreign key object rather than pointing to the name buffer in the table object; even though this apparently caused no bugs in RENAME, DROP, ALTER TABLE, or elsewhere, this convention was very prone to memory allocation bugs
      d4f6c7a4
    • unknown's avatar
      InnoDB: srv0srv.c: Remove reference to sync0ipm.h (fix ChangeSet@1.1833) · 31280b06
      unknown authored
      
      innobase/srv/srv0srv.c:
        Remove reference to sync0ipm.h
      31280b06
    • unknown's avatar
      added newline at the end of the file. · f948d7bb
      unknown authored
      f948d7bb
    • unknown's avatar
      InnoDB: Remove unused module sync0ipm · 29f480c5
      unknown authored
      
      BitKeeper/deleted/.del-sync0ipm.c~48eb5196b6819734:
        Delete: innobase/sync/sync0ipm.c
      BitKeeper/deleted/.del-sync0ipm.h~92a27f3bd9b15164:
        Delete: innobase/include/sync0ipm.h
      BitKeeper/deleted/.del-sync0ipm.ic~2024167f6418de39:
        Delete: innobase/include/sync0ipm.ic
      innobase/sync/makefilewin:
        Remove unused file sync0ipm.c
      innobase/include/Makefile.am:
        Remove unused files sync0ipm.h and sync0ipm.ic
      innobase/sync/Makefile.am:
        Remove unused file sync0ipm.c
      29f480c5
    • unknown's avatar
      InnoDB: Remove unused module os0shm · c0044631
      unknown authored
      
      BitKeeper/deleted/.del-os0shm.h~72e5e03d7b74061f:
        Delete: innobase/include/os0shm.h
      BitKeeper/deleted/.del-os0shm.c~489ce7f33d07ffa:
        Delete: innobase/os/os0shm.c
      BitKeeper/deleted/.del-os0shm.ic~1cac6731d2a64d53:
        Delete: innobase/include/os0shm.ic
      innobase/include/Makefile.am:
        Remove unused files os0shm.h and os0shm.ic
      innobase/os/Makefile.am:
        Remove unused file os0shm.c
      innobase/os/makefilewin:
        Remove unused file os0shm.c
      c0044631
    • unknown's avatar
  4. 15 May, 2004 1 commit
  5. 14 May, 2004 4 commits
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-4.0 · 5c7ed146
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.0
      
      
      5c7ed146
    • unknown's avatar
      Replication testsuite: making the master-slave synchronization less likely to fail, · 028a672f
      unknown authored
      by adding sleep-and-retries (max 4 times) if MASTER_POS_WAIT() returns NULL
      in sync_with_master and sync_slave_with_master.
      The problem showed up only today, in MySQL 5.0 in rpl_server_id2.test,
      but may affect 4.x as well, so fixing it here. Note that I am also fixing
      5.0 too, with the same exact patch, because I don't want to leave 5.0 broken
      until the next 4.0->4.1->5.0 merge.
      
      
      client/mysqltest.c:
        in sync_with_master (and sync_slave_with_master), if MASTER_POS_WAIT() returns NULL,
        it may be that the slave SQL thread did not have time to start yes, so we sleep
        1 sec and retry, 4 times at most.
      mysql-test/r/rpl_server_id2.result:
        result update
      mysql-test/t/rpl_server_id2.test:
        master_slave.inc already drops the table
      028a672f
    • unknown's avatar
      Many files: · 7bd91ac0
      unknown authored
        Fix remaining cases of Bug #3596: fix possible races caused by an obsolete value of thd->query_length in SHOW PROCESSLIST and SHOW INNODB STATUS; this fix depends on the fact that thd->query is always set to NULL before setting it to point to a new query
      
      
      sql/sql_class.h:
        Fix remaining cases of Bug #3596: fix possible races caused by an obsolete value of thd->query_length in SHOW PROCESSLIST and SHOW INNODB STATUS; this fix depends on the fact that thd->query is always set to NULL before setting it to point to a new query
      sql/ha_innodb.cc:
        Fix remaining cases of Bug #3596: fix possible races caused by an obsolete value of thd->query_length in SHOW PROCESSLIST and SHOW INNODB STATUS; this fix depends on the fact that thd->query is always set to NULL before setting it to point to a new query
      sql/log_event.cc:
        Fix remaining cases of Bug #3596: fix possible races caused by an obsolete value of thd->query_length in SHOW PROCESSLIST and SHOW INNODB STATUS; this fix depends on the fact that thd->query is always set to NULL before setting it to point to a new query
      sql/slave.cc:
        Fix remaining cases of Bug #3596: fix possible races caused by an obsolete value of thd->query_length in SHOW PROCESSLIST and SHOW INNODB STATUS; this fix depends on the fact that thd->query is always set to NULL before setting it to point to a new query
      sql/sql_db.cc:
        Fix remaining cases of Bug #3596: fix possible races caused by an obsolete value of thd->query_length in SHOW PROCESSLIST and SHOW INNODB STATUS; this fix depends on the fact that thd->query is always set to NULL before setting it to point to a new query
      sql/sql_parse.cc:
        Fix remaining cases of Bug #3596: fix possible races caused by an obsolete value of thd->query_length in SHOW PROCESSLIST and SHOW INNODB STATUS; this fix depends on the fact that thd->query is always set to NULL before setting it to point to a new query
      sql/sql_show.cc:
        Fix remaining cases of Bug #3596: fix possible races caused by an obsolete value of thd->query_length in SHOW PROCESSLIST and SHOW INNODB STATUS; this fix depends on the fact that thd->query is always set to NULL before setting it to point to a new query
      7bd91ac0
    • unknown's avatar
      InnoDB: Remove unused function ut_str_catenate() · 2d743fe2
      unknown authored
      
      innobase/include/ut0mem.h:
        Remove unused function ut_str_catenate()
      innobase/ut/ut0mem.c:
        Remove unused function ut_str_catenate()
      2d743fe2
  6. 13 May, 2004 8 commits
    • unknown's avatar
      ha_innodb.cc, trx0trx.h, lock0lock.c, trx0trx.c: · ae17c3c7
      unknown authored
      Reserve the MySQL LOCK_thread_count mutex when printing thd->query of
      an arbitrary transaction; if we are printing thd->query of a transaction that
      we know is currently executing inside InnoDB, then we know that MySQL cannot
      meanwhile change thd->query, and no need to reserve the MySQL mutex; note
      that this patch still leaves open the possibility of races in MySQL's
      thd->query_len
      
      
      innobase/trx/trx0trx.c:
        Reserve the MySQL LOCK_thread_count mutex when printing thd->query of an arbitrary transaction; if we are printing thd->query of the a transaction that we know is currently executing inside InnoDB, then we know that MySQL cannot meanwhile change thd->query, and no need to reserve the MySQL mutex; note that thsi patch still leaves aopen the possibility of races in MySQL's thd->query_len
      innobase/lock/lock0lock.c:
        Reserve the MySQL LOCK_thread_count mutex when printing thd->query of an arbitrary transaction; if we are printing thd->query of the a transaction that we know is currently executing inside InnoDB, then we know that MySQL cannot meanwhile change thd->query, and no need to reserve the MySQL mutex; note that thsi patch still leaves aopen the possibility of races in MySQL's thd->query_len
      innobase/include/trx0trx.h:
        Reserve the MySQL LOCK_thread_count mutex when printing thd->query of an arbitrary transaction; if we are printing thd->query of the a transaction that we know is currently executing inside InnoDB, then we know that MySQL cannot meanwhile change thd->query, and no need to reserve the MySQL mutex; note that thsi patch still leaves aopen the possibility of races in MySQL's thd->query_len
      sql/ha_innodb.cc:
        Reserve the MySQL LOCK_thread_count mutex when printing thd->query of an arbitrary transaction; if we are printing thd->query of the a transaction that we know is currently executing inside InnoDB, then we know that MySQL cannot meanwhile change thd->query, and no need to reserve the MySQL mutex; note that thsi patch still leaves aopen the possibility of races in MySQL's thd->query_len
      ae17c3c7
    • unknown's avatar
      Merge lgrimmer@build.mysql.com:/home/bk/mysql-4.0 · e5a2fc8e
      unknown authored
      into mysql.com:/space/my/mysql-4.0
      
      
      e5a2fc8e
    • unknown's avatar
      ha_innodb.cc: · 6be0dc12
      unknown authored
        A flawed fix of the thd->query race in SHOW INNODB STATUS; see the comments in code about how to fix this properly; we cannot use LOCK_thread_count to protect thd->query, because that will cause a deadlock of threads
      
      
      sql/ha_innodb.cc:
        A flawed fix of the thd->query race in SHOW INNODB STATUS; see the comments in code about how to fix this properly; we cannot use LOCK_thread_count to protect thd->query, because that will cause a deadlock of threads
      6be0dc12
    • unknown's avatar
      Merge mysql.com:/space/my/mysql-4.0 · 377f3356
      unknown authored
      into mysql.com:/space/my/mysql-4.0-build
      
      
      377f3356
    • unknown's avatar
      - make sure the binaries are executable before calling them during · a6ff8d00
      unknown authored
         make_binary_distribution (bug#2857)
      
      
      scripts/make_binary_distribution.sh:
         - make sure the binaries are executable before calling them (bug#2857)
      a6ff8d00
    • unknown's avatar
      ha_innodb.cc: · 9e20f63a
      unknown authored
        innobase_mysql_print_thd(): protect thd with LOCK_thread_count (Bug #3596)
      
      
      sql/ha_innodb.cc:
        innobase_mysql_print_thd(): protect thd with LOCK_thread_count
      9e20f63a
    • unknown's avatar
      InnoDB: fixed bug in dict0dict.c: dict_index_name_print() · 6a397320
      unknown authored
      
      innobase/dict/dict0dict.c:
        dict_index_name_print(): output table name to file, not stderr
      6a397320
    • unknown's avatar
      InnoDB: Remove os_file_lock() from the 4.0 tree (unfix Bug #3608) · 72595ada
      unknown authored
      
      innobase/os/os0file.c:
        Remove os_file_lock()
      72595ada
  7. 12 May, 2004 2 commits
  8. 11 May, 2004 4 commits
  9. 10 May, 2004 7 commits
  10. 07 May, 2004 3 commits