An error occurred fetching the project authors.
  1. 04 Oct, 2003 1 commit
    • unknown's avatar
      Fix for bugs #1437, #1446 · 759aabf7
      unknown authored
      include/mysql.h:
        read_statistic added to virtual methods
      libmysql/client_settings.h:
        interface for cli_read_statistic added
      libmysql/libmysql.c:
        read_statistic and mysql_stat code changes
      libmysqld/lib_sql.cc:
        emb_read_statistic implemented
        server_version initialized
      sql-common/client.c:
        cli_read_statistic added to the table
      sql/sql_parse.cc:
        storage of result of COM_STATISTIC changed in embedded library
      759aabf7
  2. 02 Oct, 2003 1 commit
  3. 29 Sep, 2003 3 commits
    • unknown's avatar
      fix for #1344 · 6fbd3da5
      unknown authored
      handling of init-file option added to embedded library
      main problem was killing of output (resulting recordsets etc)
      i added checks for empty output in Protocol:: methods
      better solution could be special Protocol_nul class to redirect
      results to nowhere
      
      
      libmysqld/lib_sql.cc:
        code was added to call read_init_file
        Protocol methods now can support output to nowhere
      sql/mysqld.cc:
        bootstrap function extended to work in embedded library
      sql/sql_parse.cc:
        handle_bootstrap modified to work in embedded library
      6fbd3da5
    • unknown's avatar
      SCRUM · 9a942c85
      unknown authored
      WL604 Privilegies in embedded library
      another bug fixed
      
      
      sql/sql_parse.cc:
        flag selection fixed
      9a942c85
    • unknown's avatar
      SCRUM · e1c1aa7a
      unknown authored
      WL#604 Privileges in embedded library
      bugs fixed
      
      
      sql/mysql_priv.h:
        reload_acl_and_cache interface unifdefed
      sql/sql_parse.cc:
        ifdefs added/removed
      e1c1aa7a
  4. 26 Sep, 2003 1 commit
    • unknown's avatar
      SCRUM: · 17053698
      unknown authored
      WL#604 Privileges in embedded library
      code added to check privileges in embedded library
      NO_EMBEDDED_ACCESS_CHECKS macros inserted in code so we can exclude
      access-checking parts. Actually we now can exclude these parts from
      standalone server as well. Do we need it?
      Access checks are disabled in embedded server by default. One should
      edit libmysqld/Makefile manually to get this working.
      We definitely need the separate configure for embedded server
      
      
      include/mysql.h:
        options added so user of embedded library can set the client host
        it will work as if the usual client connects from this host
      libmysqld/Makefile.am:
        Usually one doesn't need access checking in embedded library
        we definitely should separate configure for embedded server
      libmysqld/lib_sql.cc:
        necessary code for getting passwords and access checks added
      libmysqld/libmysqld.c:
        code #ifdef-ed - we use this only when we check permissions
      sql-common/client.c:
        one mysql_close left now
      sql/item_strfunc.cc:
        #ifndef-s added
      sql/log.cc:
        #ifndef-s added
      sql/mysql_priv.h:
        #ifndef-s added
        also i removed default parameters from check_access and check_table_access
        definitions to set definitions working
      sql/mysqld.cc:
        #ifndef-s added
        localhost renamed to my_localhost
      sql/repl_failsafe.cc:
        parameters added
      sql/set_var.cc:
        #ifndef-s added
      sql/sql_acl.cc:
        #ifndef-s added
      sql/sql_acl.h:
        #ifndef-s added
      sql/sql_base.cc:
        #ifndef-s added
      sql/sql_cache.cc:
        #ifndef-s added
      sql/sql_class.cc:
        #ifndef-s added
      sql/sql_db.cc:
        #ifndef-s added
      sql/sql_derived.cc:
        #ifndef-s added
      sql/sql_insert.cc:
        #ifndef-s added
      sql/sql_parse.cc:
        a horde of #ifndef-s added
      sql/sql_prepare.cc:
        #ifndef-s added
      sql/sql_repl.cc:
        parameters added
      sql/sql_show.cc:
        #ifndef-s added
      sql/sql_update.cc:
        #ifndef-s added
      17053698
  5. 19 Sep, 2003 1 commit
    • unknown's avatar
      SCRUM · 2d46389a
      unknown authored
      embedded library
      hash_insert renamed to my_hash_insert to avoid name intersection
      with another libraries
      is there better idea?
      
      
      client/mysqltest.c:
        hash_insert ->my_hash_insert
      include/hash.h:
        hash_insert ->my_hash_insert
      mysys/hash.c:
        hash_insert ->my_hash_insert
      mysys/testhash.c:
        hash_insert ->my_hash_insert
      sql/ha_berkeley.cc:
        hash_insert ->my_hash_insert
      sql/ha_innodb.cc:
        hash_insert ->my_hash_insert
      sql/hash_filo.h:
        hash_insert ->my_hash_insert
      sql/item_func.cc:
        hash_insert ->my_hash_insert
      sql/lock.cc:
        hash_insert ->my_hash_insert
      sql/repl_failsafe.cc:
        hash_insert ->my_hash_insert
      sql/set_var.cc:
        hash_insert ->my_hash_insert
      sql/slave.cc:
        hash_insert ->my_hash_insert
      sql/sql_acl.cc:
        hash_insert ->my_hash_insert
      sql/sql_base.cc:
        hash_insert ->my_hash_insert
      sql/sql_cache.cc:
        hash_insert ->my_hash_insert
      sql/sql_parse.cc:
        hash_insert ->my_hash_insert
      sql/sql_select.cc:
        hash_insert ->my_hash_insert
      sql/sql_udf.cc:
        hash_insert ->my_hash_insert
      sql/table.cc:
        hash_insert ->my_hash_insert
      tools/mysqlmanager.c:
        hash_insert ->my_hash_insert
      2d46389a
  6. 16 Sep, 2003 1 commit
  7. 15 Sep, 2003 1 commit
  8. 14 Sep, 2003 1 commit
  9. 13 Sep, 2003 2 commits
    • unknown's avatar
      Fixes for OPTION_FOUND_ROWS in UNION's · aedc0ab0
      unknown authored
      mysql-test/r/subselect.result:
        A warning added to subselect test due to the recent changes.
        
        UNION in sub-select returns the empty set, which is why this warning is
        a mistery to me.
      mysql-test/r/union.result:
        two changes.
        
        First one is due to the proper handling of LIMIT offset, limit in 
        UNION without all.
        
        Second is a change in behaviour due to the fact that ORDER by in a 
        UNION without braces is not now applicable to the last SELECT node.
        
        It can not be applied until one bug is fixed (after my vacation).
        
        Should be documented.
      aedc0ab0
    • unknown's avatar
      Remove 'extern' references from .cc files · c4079104
      unknown authored
      mysys/checksum.c:
        Cleanup
      mysys/my_static.h:
        Remove not used include file
      sql/item_strfunc.cc:
        Remove 'extern' references
      sql/lock.cc:
        Remove 'extern' references
      sql/log.cc:
        Remove 'extern' references
      sql/mysql_priv.h:
        Add 'extern' references
      sql/net_serv.cc:
        Added comment
      sql/repl_failsafe.cc:
        Remove 'extern' references
      sql/set_var.cc:
        Remove 'extern' references
      sql/sql_derived.cc:
        Remove 'extern' references
      sql/sql_insert.cc:
        Remove 'extern' references
      sql/sql_parse.cc:
        Remove 'extern' references
      sql/sql_prepare.cc:
        Remove 'extern' references
      sql/sql_repl.cc:
        Remove 'extern' references
      sql/sql_string.cc:
        Added comment
      sql/sql_table.cc:
        Remove 'extern' references
      sql/sql_test.cc:
        Remove 'extern' references
      sql/sql_yacc.yy:
        Remove 'extern' references
      sql/table.cc:
        Remove 'extern' references
      c4079104
  10. 10 Sep, 2003 1 commit
  11. 09 Sep, 2003 1 commit
    • unknown's avatar
      Cleaned up last bug fixes · 8272be94
      unknown authored
      Fix bug in SHOW GRANTS when there is a column privilege but no table privilege
      
      
      include/mysql.h:
        Make server_inited external
      libmysqld/libmysqld.c:
        Remove reference to (wrong) external variable
      mysql-test/r/grant.result:
        Fixed up grant test to not user 'user1' or 'user2'
        Check for bug in SHOW GRANTS when there is a column privilege but no table privilege
      mysql-test/r/mix_innodb_myisam_binlog.result:
        Change to use tables t1 and t2
      mysql-test/t/grant.test:
        Fixed up grant test to not user 'user1' or 'user2'
        Check for bug in SHOW GRANTS when there is a column privilege but no table privilege
      mysql-test/t/mix_innodb_myisam_binlog.test:
        Change to use tables t1 and t2
      sql/sql_acl.cc:
        Fix bug in SHOW GRANTS when there is a column privilege but no table privilege
      sql/sql_parse.cc:
        Use HAVE_REPLICATION instead of EMBEDDED_LIBRARY
      8272be94
  12. 08 Sep, 2003 3 commits
    • unknown's avatar
      fix for #1218 · be67ce0b
      unknown authored
      sql/sql_parse.cc:
        This line fails in libmysqld.
        And isn't needed while we don't check privileges in embedded library
      be67ce0b
    • unknown's avatar
      Trimming of embedded library code · 9fd07637
      unknown authored
      sql/sql_parse.cc:
        It's better to check for HAVE_REPLICATION here instead of EMBEDDED_LIBRARY
      9fd07637
    • unknown's avatar
      fix for #1211 · 8aff7009
      unknown authored
      sql/sql_parse.cc:
        Replication's commands were allowed, but didn't have proper implementations
        for embedded library
      8aff7009
  13. 06 Sep, 2003 1 commit
    • unknown's avatar
      Fix for LOAD DATA to work with embedded library · 1496610d
      unknown authored
      libmysqld/lib_sql.cc:
        There's now one common SCRAMBLE_LENGTH
      sql/sql_load.cc:
        mysql_load fixed to work with embedded library
      sql/sql_parse.cc:
        LOAD DATA enabled for embedded library
      1496610d
  14. 03 Sep, 2003 3 commits
  15. 29 Aug, 2003 2 commits
    • unknown's avatar
      removed stale comment · 54fa3925
      unknown authored
      13:58 <monty> konstantin: the comment is missplaced (probably after merge).
                You can remove it
      
      
      sql/sql_parse.cc:
        removed stale comment
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      54fa3925
    • unknown's avatar
      Revert change of lower-case-table handling as this breaks how alias works. · 6d17d7f5
      unknown authored
      Changes like this should be done to 4.1, not to a stable release
      
      
      mysql-test/r/lowercase_table.result:
        Revert change of lower-case-table handling
      mysql-test/t/lowercase_table.test:
        Revert change of lower-case-table handling
      sql/sql_class.cc:
        Revert change of lower-case-table handling
      sql/sql_class.h:
        Revert change of lower-case-table handling
      sql/sql_parse.cc:
        Revert change of lower-case-table handling
      sql/sql_table.cc:
        Revert change of lower-case-table handling
      sql/sql_yacc.yy:
        Revert change of lower-case-table handling
      6d17d7f5
  16. 22 Aug, 2003 1 commit
    • unknown's avatar
      2 minor edits, plus · fdfb10f2
      unknown authored
      fix for BUG#1113 "INSERT into non-trans table SELECT ; ROLLBACK" does not send warning"
      and
      fix for BUG#873 "In transaction, INSERT to non-trans table is written too early to binlog".
      Now we don't always write the non-trans update immediately to the binlog;
      if there is something in the binlog cache we write it to the binlog cache
      (because the non-trans update could depend on a trans table which was modified
      earlier in the transaction); then in case of ROLLBACK, we write the binlog
      cache to the binlog, wrapped with BEGIN/ROLLBACK.
      This guarantees that the slave does the same updates.
      For ROLLBACK TO SAVEPOINT: when we execute a SAVEPOINT command we write it
      to the binlog cache. At ROLLBACK TO SAVEPOINT, if some non-trans table was updated,
      we write ROLLBACK TO SAVEPOINT to the binlog cache; when the transaction
      terminates (COMMIT/ROLLBACK), the binlog cache will be flushed to the binlog
      (because of the non-trans update) so we'll have SAVEPOINT and ROLLBACK TO
      SAVEPOINT in the binlog.
      
      Apart from this rare case of updates of mixed table types in transaction, the
      usual way is still clear the binlog cache at ROLLBACK, or chop it at
      ROLLBACK TO SAVEPOINT (meaning the SAVEPOINT command is also chopped, which
      is fine).
      Note that BUG#873 encompasses subbugs 1) and 2) of BUG#333 "3 binlogging bugs when doing INSERT with mixed InnoDB/MyISAM".
      
      
      client/mysqldump.c:
        Minor edit: one CHANGE MASTER with 2 arguments instead of 2 CHANGE MASTER with one argument each.
      mysql-test/r/rpl_loaddata.result:
        result update
      mysql-test/t/rpl_loaddata.test:
        minor edit: simplifying the test.
      sql/handler.cc:
        Fix for BUG#873. See comments in code, and the description of the changeset.
      sql/log.cc:
        * Previously, if a query updated a non-transactional table we wrote it immediately
        to the real binlog. This causes a bug when the update is done inside a transaction
        and uses the content of an updated transactional table (because this makes
        a wrong order of queries in the binlog). So if the binlog cache is not empty,
        we write the query to the binlog cache; otherwise we can write it to the binlog.
        * Previously, when we flushed the binlog cache to the binlog, we wrapped it
        with BEGIN/COMMIT. Now it's also possible to wrap it with BEGIN/ROLLBACK, to handle
        transactions which update both transactional and non-transactional tables.
      sql/log_event.cc:
        The slave thread can leave a transaction if COMMIT or if ROLLBACK.
      sql/sql_class.h:
        prototype
      sql/sql_insert.cc:
        Fix for BUG#1113:
        this was because the INSERT SELECT code did not set OPTION_STATUS_NO_TRANS_UPDATE.
      sql/sql_parse.cc:
        Don't send ER_WARNING_NOT_COMPLETE_ROLLBACK if this is the SQL slave thread (see comments).
      fdfb10f2
  17. 21 Aug, 2003 1 commit
    • unknown's avatar
      fixed a crash on COMPRESS() and other zlib-dependent functions when compiled w/o zlib · e103da7a
      unknown authored
      moved them all from different places to item_strfunc.{h,cc}
      checksum table command
      Com_xxx status variables updated
      
      
      sql/item_create.cc:
        fixed a crash on COMPRESS() and other zlib-dependent functions when compiled w/o zlib
        moved them all from different places to item_strfunc.{h,cc}
      sql/item_func.cc:
        fixed a crash on COMPRESS() and other zlib-dependent functions when compiled w/o zlib
        moved them all from different places to item_strfunc.{h,cc}
      sql/item_func.h:
        fixed a crash on COMPRESS() and other zlib-dependent functions when compiled w/o zlib
        moved them all from different places to item_strfunc.{h,cc}
      sql/item_geofunc.h:
        fixed a crash on COMPRESS() and other zlib-dependent functions when compiled w/o zlib
        moved them all from different places to item_strfunc.{h,cc}
      sql/item_strfunc.cc:
        fixed a crash on COMPRESS() and other zlib-dependent functions when compiled w/o zlib
        moved them all from different places to item_strfunc.{h,cc}
      sql/item_strfunc.h:
        fixed a crash on COMPRESS() and other zlib-dependent functions when compiled w/o zlib
        moved them all from different places to item_strfunc.{h,cc}
      sql/mysql_priv.h:
        checksum table command
      sql/mysqld.cc:
        Com_xxx updated
      sql/sql_lex.h:
        checksum table command
      sql/sql_parse.cc:
        checksum table command
      sql/sql_table.cc:
        checksum table command
      sql/sql_yacc.yy:
        checksum table command
      e103da7a
  18. 20 Aug, 2003 1 commit
    • unknown's avatar
      after merge changing · 5e00fc02
      unknown authored
      uninitialized value fixed
      
      
      sql/item_cmpfunc.cc:
        fixed uninitialized used_tables_cache
        othyer caches moved on proper place
      sql/item_subselect.cc:
        fixed reported table bit
      sql/mysql_priv.h:
        after merge chenges.
      sql/sql_parse.cc:
        used same new operator for all allocation in subroutine
      sql/sql_union.cc:
        fake st_select_lex should have item list for ref_array allocation
      sql/sql_yacc.yy:
        after merge changing
      5e00fc02
  19. 19 Aug, 2003 3 commits
    • unknown's avatar
      Fix for BUG#1086. Now we don't preserve event's log_pos through · e3541b8a
      unknown authored
      log-slave-updates since this causes unexpected values in 
      Exec_master_log_pos in A->B->C replication setup, synchronization
       problems in master_pos_wait()... 
      Still this brokes some functionality in sql/repl_failsafe.cc 
      (but this file is not used now)
      
      
      mysql-test/r/rpl_log.result:
        SHOW BINLOG EVENTS for binlog on slave should give the same 
        Orig_log_pos and Pos values
      sql/log_event.cc:
        Do not propagate our master's log pos to our bin log
      sql/repl_failsafe.cc:
        Added comment about broken SHOW NEW MASTER
      sql/slave.cc:
        Do not propagate our master's log pos to our bin log
      sql/sql_class.cc:
        THD::log_pos is no longer needed
      sql/sql_class.h:
        THD::log_pos is no longer needed
      sql/sql_parse.cc:
        Added comment about broken SHOW NEW MASTER
      e3541b8a
    • unknown's avatar
      A fix for a bug with long definition of SET or ENUM. · 651ead1a
      unknown authored
      Barkov approved it already
      
      
      
      651ead1a
    • unknown's avatar
      After merge fixes + bugs from last merge · aa900a5e
      unknown authored
      mysql-test/mysql-test-run.sh:
        Use --skip-bdb with valgrind (as bdb tables causes valgrind to hang)
        Fix --ddd option
      mysql-test/t/union.test:
        After merge fix
      sql/item.cc:
        Fixed typo
      sql/log_event.cc:
        Move current_tablenr to open_tables()
      sql/protocol.h:
        Fixed wrong memory reference
      sql/set_var.cc:
        After merge fix
      sql/slave.cc:
        Reset thd->lex.current_select before execute
      sql/sql_base.cc:
        Move current_tablenr to open_tables()
      sql/sql_class.cc:
        Move current_tablenr to open_tables()
        Add missing update_charset()
      sql/sql_parse.cc:
        Move current_tablenr to open_tables()
        Simple cleanup
      sql/table.cc:
        Code cleanup
      aa900a5e
  20. 18 Aug, 2003 1 commit
    • unknown's avatar
      After merge fixes · 2901c3b8
      unknown authored
      Use server character set if --default-character-set is not used
      Added convert_string() for more efficient alloc+character-set convert of strings
      
      
      BitKeeper/deleted/.del-convert.result~a3b56e1db6f498e9:
        Delete: mysql-test/r/convert.result
      BitKeeper/deleted/.del-convert.test~f4ceb743194dfe72:
        Delete: mysql-test/t/convert.test
      BitKeeper/deleted/.del-make_win_src_distribution.old~5c9ebdc4a852b43b:
        Delete: scripts/make_win_src_distribution.old
      client/mysql.cc:
        Use server character set if --default-character-set is not used
      client/mysqltest.c:
        Code cleanup (merge identical code)
        More debug messages
      heap/hp_create.c:
        After merge fix
      include/m_ctype.h:
        After merge fix
      include/my_global.h:
        Remove size_str (we already have size_s)
      include/mysql_com.h:
        After merge fix
      libmysql/libmysql.c:
        After merge fix
      libmysqld/Makefile.am:
        After merge fix
      mysql-test/r/auto_increment.result:
        After merge fix
      mysql-test/r/create.result:
        After merge fix
      mysql-test/r/ctype_latin1_de.result:
        After merge fix
      mysql-test/r/distinct.result:
        After merge fix
      mysql-test/r/drop.result:
        After merge fix
      mysql-test/r/fulltext.result:
        After merge fix
      mysql-test/r/func_gconcat.result:
        After merge fix
      mysql-test/r/func_str.result:
        After merge fix
      mysql-test/r/func_test.result:
        After merge fix
      mysql-test/r/grant.result:
        After merge fix
      mysql-test/r/group_by.result:
        After merge fix
      mysql-test/r/handler.result:
        After merge fix
      mysql-test/r/heap.result:
        After merge fix
      mysql-test/r/heap_btree.result:
        After merge fix
      mysql-test/r/heap_hash.result:
        After merge fix
      mysql-test/r/innodb.result:
        After merge fix
      mysql-test/r/insert.result:
        After merge fix
      mysql-test/r/insert_select.result:
        After merge fix
      mysql-test/r/join_outer.result:
        After merge fix
      mysql-test/r/key.result:
        After merge fix
      mysql-test/r/key_cache.result:
        After merge fix
      mysql-test/r/loaddata.result:
        After merge fix
      mysql-test/r/myisam.result:
        After merge fix
      mysql-test/r/null.result:
        After merge fix
      mysql-test/r/null_key.result:
        After merge fix
      mysql-test/r/order_by.result:
        After merge fix
      mysql-test/r/rpl_do_grant.result:
        After merge fix
      mysql-test/r/rpl_error_ignored_table.result:
        After merge fix
      mysql-test/r/rpl_ignore_grant.result:
        After merge fix
      mysql-test/r/rpl_loaddata.result:
        After merge fix
      mysql-test/r/rpl_log.result:
        After merge fix
      mysql-test/r/rpl_log_pos.result:
        After merge fix
      mysql-test/r/rpl_max_relay_size.result:
        After merge fix
      mysql-test/r/rpl_replicate_do.result:
        After merge fix
      mysql-test/r/rpl_reset_slave.result:
        After merge fix
      mysql-test/r/rpl_rotate_logs.result:
        After merge fix
      mysql-test/r/rpl_user_variables.result:
        After merge fix
      mysql-test/r/select.result:
        After merge fix
      mysql-test/r/select_safe.result:
        After merge fix
      mysql-test/r/subselect.result:
        After merge fix
      mysql-test/r/type_blob.result:
        After merge fix
      mysql-test/r/type_decimal.result:
        After merge fix
      mysql-test/r/type_float.result:
        After merge fix
      mysql-test/r/type_ranges.result:
        After merge fix
      mysql-test/r/type_time.result:
        After merge fix
      mysql-test/r/type_uint.result:
        After merge fix
      mysql-test/r/union.result:
        After merge fix
      mysql-test/r/warnings.result:
        After merge fix
      mysql-test/t/auto_increment.test:
        After merge fix
      mysql-test/t/case.test:
        After merge fix
      mysql-test/t/ctype_collate.test:
        After merge fix
      mysql-test/t/ctype_latin1_de.test:
        After merge fix
      mysql-test/t/drop.test:
        After merge fix
      mysql-test/t/func_in.test:
        After merge fix
      mysql-test/t/func_set.test:
        After merge fix
      mysql-test/t/func_str.test:
        After merge fix
      mysql-test/t/func_test.test:
        After merge fix
      mysql-test/t/grant.test:
        After merge fix
      mysql-test/t/group_by.test:
        After merge fix
      mysql-test/t/handler.test:
        After merge fix
      mysql-test/t/heap.test:
        After merge fix
      mysql-test/t/heap_btree.test:
        After merge fix
      mysql-test/t/heap_hash.test:
        After merge fix
      mysql-test/t/innodb.test:
        After merge fix
      mysql-test/t/insert_select.test:
        After merge fix
      mysql-test/t/key.test:
        After merge fix
      mysql-test/t/key_cache.test:
        After merge fix
      mysql-test/t/lock_tables_lost_commit-master.opt:
        After merge fix
      mysql-test/t/lock_tables_lost_commit.test:
        After merge fix
      mysql-test/t/myisam.test:
        After merge fix
      mysql-test/t/row.test:
        After merge fix
      mysql-test/t/subselect.test:
        After merge fix
      mysql-test/t/type_decimal.test:
        After merge fix
      mysql-test/t/type_ranges.test:
        After merge fix
      mysql-test/t/type_uint.test:
        After merge fix
      mysql-test/t/variables.test:
        After merge fix
      mysql-test/t/warnings.test:
        After merge fix
      scripts/make_win_src_distribution.sh:
        after merge fixes
      sql-common/client.c:
        After merge fix
        Change my_connect() to use poll()
        If character set is not given, use servers character set.
      sql/field.cc:
        After merge fix
        Don't give warnings when storing data in fields in optimizer.
      sql/ha_myisammrg.h:
        After merge fix
      sql/log.cc:
        After merge fix
      sql/log_event.cc:
        After merge fix
      sql/mysqld.cc:
        After merge fix
      sql/opt_range.cc:
        After merge fix
      sql/set_var.cc:
        Code cleanup
        Fixed wrong usage of base_names (like medium.key_buffer) that caused core dumps
      sql/set_var.h:
        Fixed wrong usage of base_names (like medium.key_buffer) that caused core dumps
      sql/slave.cc:
        After merge fix
      sql/sql_acl.cc:
        After merge fix
        Code cleanup
      sql/sql_class.cc:
        Added convert_string() for more efficient alloc+character-set convert of strings
        Add cached flags to avoid calling mysql_charset_same() during parsing.
      sql/sql_class.h:
        Added convert_string() for more efficient alloc+character-set convert of strings
        Add cached flags to avoid calling mysql_charset_same() during parsing.
      sql/sql_handler.cc:
        After merge fix
      sql/sql_lex.h:
        After merge fix
      sql/sql_parse.cc:
        Optimize and fix memory reference errors reported by valgrind
      sql/sql_repl.cc:
        After merge fix
      sql/sql_yacc.yy:
        After merge fix
        Avoid calling mysql_charset_same() when parsing identifiers
      strings/ctype-latin1.c:
        Port latin_de conversion code from 4.0
      2901c3b8
  21. 17 Aug, 2003 1 commit
    • unknown's avatar
      Fix mutex handling in SHOW_VARIABLES (key_buffer_size was not properly protected) · 0eaf4d8d
      unknown authored
      Changed some non fatal myisamchk error messages to warnings
      
      
      myisam/myisamchk.c:
        Change error -> warning
      sql/handler.cc:
        Add mutex around keybuff_size usage
      sql/mysql_priv.h:
        Indentation update
      sql/set_var.cc:
        Add mutex around longlong variable usage
      sql/sql_parse.cc:
        Fix mutex handling in SHOW_VARIABLES
      sql/sql_show.cc:
        Fix mutex handling in SHOW_VARIABLES
      0eaf4d8d
  22. 11 Aug, 2003 1 commit
    • unknown's avatar
      Fix: create table t1 (a char(10) character set cp1251) SELECT _koi8r'blabla' as a · 0960c3eb
      unknown authored
      The above query created a field of koi8r charset, not cp1251
      
      Change:
      CREATE TABLE a (a CHAR(1) CHARACTER SET utf8) 
      Length now means character length, not byte length.
      The above creates a field that guarantees can store a multibyte value
      1 character long. For utf8 the above creates a field that can store
      3 bytes.
      
      
      0960c3eb
  23. 10 Aug, 2003 1 commit
    • unknown's avatar
      Remove wrong bug fix when calling create_sort_index. · 20901eda
      unknown authored
      Fix possible replication bug with LOAD DATA ... IGNORE LINES #
      
      
      mysql-test/r/rpl_log.result:
        Test of load data ... ignore # lines
      mysql-test/t/rpl_log.test:
        Test of load data ... ignore # lines
      sql/log_event.cc:
        Fix replication bug with LOAD DATA ... IGNORE LINES #
        (Note that the code that is probably not executed in 4.0)
      sql/sql_parse.cc:
        Indentation fix
      sql/sql_select.cc:
        Remove wrong bug fix (all tests passes)
      sql/sql_yacc.yy:
        Indentation cleanup
      20901eda
  24. 30 Jul, 2003 1 commit
  25. 29 Jul, 2003 1 commit
    • unknown's avatar
      prevented finding references in item_list for non-SELECT st_select_lex · 668cd972
      unknown authored
      (fixed BUG#943)
      
      
      mysql-test/r/subselect.result:
        test for bug 943
      mysql-test/t/subselect.test:
        test for bug 943
      sql/item.cc:
        bool field changed with enum
        prevented finding references in item_list for non-SELECT st_select_lex
      sql/sql_lex.cc:
        bool field changed with enum
      sql/sql_lex.h:
        bool field changed with enum
      sql/sql_parse.cc:
        all subqueries and UNION parts marked as SELECT
      sql/sql_yacc.yy:
        bool field changed with enum
        PRIMARY SELECT command st_select_lex marked as SELECT
      668cd972
  26. 23 Jul, 2003 1 commit
  27. 22 Jul, 2003 1 commit
  28. 18 Jul, 2003 1 commit
    • unknown's avatar
      Style fixes, comments for 4.1.1 authorization · 30ced7f7
      unknown authored
      Now special 1-byte packet is used for request of old password
      Fixed bug with --skip-grant-tables and acl_getroot
      
      
      include/mysql.h:
        removed scramble_323 member as now scramble_323 function does not count
        on trailing zero for scramble
      include/mysql_com.h:
        updated declarations
      libmysql/libmysql.c:
        now server sends special 1-byte packet instead of old scramble
        to re-request password.
        mysql->scramble_323 replaced with mysql->scramble
      sql-common/client.c:
        now server sends special 1-byte packet instead of old scramble
        to re-request password.
        mysql->scramble_323 replaces with mysql->scramble
      sql/password.c:
        comments beautified
        hash_password now accepts password length
      sql/protocol.cc:
        added send_old_password_request function
      sql/protocol.h:
        added send_old_password_request function
      sql/sql_acl.cc:
        style fixes, bug with --skip-grant-tables and acl_getroot
        fixed
      sql/sql_class.h:
        thd->scramble_323 removed as now
        old functions accept not null-terminated scrambles
      sql/sql_crypt.cc:
        fixed with new hash_password proto
      sql/sql_parse.cc:
        style fixes
        few comments added
      30ced7f7
  29. 14 Jul, 2003 1 commit
    • unknown's avatar
      Safety and speedup fixes: · e1a30696
      unknown authored
      Changed is_open() to work as before.
      Added back inited argument to LOG
      
      
      mysql-test/r/rpl_flush_log_loop.result:
        Fixed results (probably bug in previous rpatch)
      sql/handler.cc:
        Changed is_open() to work as before
      sql/item_func.cc:
        Changed is_open() to work as before
      sql/log.cc:
        Part revert of previous patch.
        The reason for adding back 'inited' is that is that we can't be 100 % sure that init_pthread_objects() is called before mysqld dies (for example on windows)
        I removed mutex lock handling in is_open() as the new code didn't have ANY affect except beeing slower.
        Added back checking of is_open() to some functions as we don't want to do a mutex lock when we are not using logging.
        Indentation/comment fixes
      sql/log_event.cc:
        Changed is_open() to work as before
      sql/repl_failsafe.cc:
        Changed is_open() to work as before
      sql/sql_base.cc:
        Changed is_open() to work as before
      sql/sql_class.h:
        Changed is_open() to work as before. Added back 'inited' variable
      sql/sql_db.cc:
        Changed is_open() to work as before
      sql/sql_delete.cc:
        Changed is_open() to work as before
      sql/sql_insert.cc:
        Changed is_open() to work as before
      sql/sql_load.cc:
        Changed is_open() to work as before
      sql/sql_parse.cc:
        Changed is_open() to work as before
      sql/sql_rename.cc:
        Changed is_open() to work as before
      sql/sql_repl.cc:
        Changed is_open() to work as before
      sql/sql_table.cc:
        Changed is_open() to work as before
      sql/sql_update.cc:
        Changed is_open() to work as before
      e1a30696
  30. 11 Jul, 2003 1 commit
    • unknown's avatar
      Fix for BUG#791: · d974959b
      unknown authored
      a safer way of initing the mutexes in MYSQL_LOG.
      is_open() is now always thread-safe.
      See each file for details.
      
      
      sql/handler.cc:
        is_open() with locks
      sql/item_func.cc:
        is_open() with locks
      sql/log.cc:
        No more 'inited'.
        We now always use is_open() in a thread-safe manner.
        This simplifies some functions (no more need to test is_open() twice).
      sql/log_event.cc:
        is_open() with locks
      sql/mysqld.cc:
        Init mutexes for the global MYSQL_LOG objects.
        We care about no_rotate, because we can't do it in open() anymore (because
        we don't have 'inited' anymore).
      sql/repl_failsafe.cc:
        is_open() with locks
      sql/slave.cc:
        init pthread objects (mutexes, conds) in the constructor of st_relay_log_info.
        Some better locking in rotate_relay_log().
      sql/sql_base.cc:
        is_open() with locks
      sql/sql_class.h:
        Before, we inited LOCK_log in MYSQL_LOG::open(), so in other places of the code
        when we were never 100% sure that it had been inited. For example, if the server
        was running without --log-bin, ::open() was not called so the mutex was not
        inited. We could detect it with !inited, but not safely as 'inited' was not
        protected by any mutex.
        So now:
        we *always* init the LOCK_log mutex, even if the log is not used. We can't init
        the mutex in MYSQL_LOG's constructor, because for global objects like
        mysql_bin_log, mysql_log etc, the constructor is called before MY_INIT(), but
        safe_mutex depends on MY_INIT(). So we have a new function MYSQL_LOG::init_pthread_objects
        which we call in main(), after MY_INIT().
        For the relay log, we call this function in the constructor of
        st_relay_log_info, which is called before any function tries to
        use the relay log (the relay log is always invoked as rli.relay_log).
        So now we should be safe in all cases and we don't need 'inited'.
      sql/sql_db.cc:
        is_open() with locks
      sql/sql_delete.cc:
        is_open() with locks
      sql/sql_insert.cc:
        is_open() with locks
      sql/sql_load.cc:
        is_open() with locks
      sql/sql_parse.cc:
        is_open() with locks
      sql/sql_rename.cc:
        is_open() with locks
      sql/sql_repl.cc:
        is_open() with locks
      sql/sql_table.cc:
        is_open() with locks
      sql/sql_update.cc:
        is_open() with locks
      d974959b