1. 07 Jun, 2010 2 commits
  2. 05 Jun, 2010 1 commit
    • Sergei Golubchik's avatar
      few small MySQL bugs/issues that impact the engines, as discussed in the SE summit · ac6b3c44
      Sergei Golubchik authored
      * remove handler::index_read_last()
      * create handler::keyread_read_time() (was get_index_only_read_time() in opt_range.cc)
      * ha_show_status() allows engine's show_status() to fail
      * remove HTON_FLUSH_AFTER_RENAME
      * fix key_cmp_if_same() to work for floats and doubles
      * set table->status in the server, don't force engines to do it
      * increment status vars in the server, don't force engines to do it
      
      mysql-test/r/status_user.result:
        correct test results - innodb was wrongly counting internal
        index searches as handler_read_* calls.
      sql/ha_partition.cc:
        compensate for handler incrementing status counters -
        we want to count only calls to underlying engines
      sql/handler.h:
        inline methods moved to sql_class.h
      sql/key.cc:
        simplify the check
      sql/opt_range.cc:
        move get_index_only_read_time to the handler class
      sql/sp.cc:
        don't use a key that's stored in the record buffer -
        the engine can overwrite the buffer with anything, destroying the key
      sql/sql_class.h:
        inline handler methods that need to see THD and TABLE definitions
      sql/sql_select.cc:
        no ha_index_read_last_map anymore
      sql/sql_table.cc:
        remove HTON_FLUSH_AFTER_RENAME
      sql/table.cc:
        set HA_CAN_MEMCMP as appropriate
      sql/tztime.cc:
        don't use a key that's stored in the record buffer -
        the engine can overwrite the buffer with anything, destroying the key
      storage/myisam/ha_myisam.cc:
        engines don't need to update table->status or use ha_statistic_increment anymore
      storage/myisam/ha_myisam.h:
        index_read_last_map is no more
      ac6b3c44
  3. 03 Jun, 2010 2 commits
    • Sergei Golubchik's avatar
      include guards · 59eb4f6a
      Sergei Golubchik authored
      59eb4f6a
    • Sergei Golubchik's avatar
      fixes for test suite · a0a81bd2
      Sergei Golubchik authored
      mysql-test/suite/pbxt/r/mysqlshow.result:
        update the forgotten test results
      sql/table.cc:
        add defensive asserts.
        fix the code that didn't in MySQL > 5.2.0 with frm's created before 5.1.10
      a0a81bd2
  4. 02 Jun, 2010 1 commit
  5. 01 Jun, 2010 1 commit
  6. 31 May, 2010 1 commit
  7. 28 May, 2010 1 commit
  8. 27 May, 2010 3 commits
    • Sergei Golubchik's avatar
      4c4b5447
    • Sergei Golubchik's avatar
    • Michael Widenius's avatar
      Fixed compiler warnings · 80ba8556
      Michael Widenius authored
      Fixed failing test innodb.innodb-autoinc.test
      Enabled innodb test suite
      
      mysql-test/mysql-test-run.pl:
        Enabled innodb test suite
      mysql-test/r/innodb-autoinc.result:
        Removed test as it exists in suite innodb
      mysql-test/suite/innodb/t/disabled.def:
        Removed innodb-autoinc
      mysql-test/suite/innodb/t/innodb-autoinc.test:
        Update to be able to run with plugin
      mysql-test/t/innodb-autoinc.test:
        Removed test as it exists in suite innodb
      sql/filesort.cc:
        Removed not used variable
      sql/slave.cc:
        Remove compiler warnings
      storage/pbxt/src/ha_pbxt.cc:
        Removed not used variable
      storage/xtradb/dict/dict0crea.c:
        Fixed compiler warning about unsigned comparison
      support-files/compiler_warnings.supp:
        Disable some not relevant warnings
      80ba8556
  9. 26 May, 2010 7 commits
  10. 25 May, 2010 1 commit
  11. 21 May, 2010 1 commit
  12. 15 May, 2010 5 commits
  13. 14 May, 2010 3 commits
    • Sergei Golubchik's avatar
      crash on --with-embedded-privilege-control builds: · 3b98d69d
      Sergei Golubchik authored
      1. fix broken change user handling (no restart should happen in the normal case)
      2. add assert to guarantee that we never send a request to change to the same plugin
      3. "fix" plugin string as sent by the client to be able to compare native plugins by pointers
      4. more complete MYSQL initialization in the embedded case
      5. change_user.test updated to handle -with-embedded-privilege-control builds
      3b98d69d
    • Bo Thorsen's avatar
      Add a -nobuild argument to the script. Useful for building the zip file... · febb68f5
      Bo Thorsen authored
      Add a -nobuild argument to the script. Useful for building the zip file release with Express Edition which doesn't have the devenv command
      febb68f5
    • Michael Widenius's avatar
      Fixed build failures and compiler warning · 73d3805d
      Michael Widenius authored
      mysql-test/suite/binlog/r/binlog_unsafe.result:
        Updated results (RAND() doesn't require statement based logging anymore for inserts)
      mysql-test/t/information_schema_all_engines.test:
        Ensure that InnoDB is used
      storage/pbxt/bin/Makefile.am:
        Fixed build failure on build hosts
        (Patch from Kristian Nielsen)
      storage/pbxt/bin/xtstat_xt.cc:
        Added missing argument
      storage/pbxt/src/datalog_xt.cc:
        Fixed compiler warnings
      storage/pbxt/src/ha_pbxt.cc:
        Fixed compiler warnings
      storage/pbxt/src/table_xt.cc:
        Fixed compiler warnings
      support-files/compiler_warnings.supp:
        Added suppression of compiler warnings in Xtradb
        (Failure can only happen for corrupted tables, but should be fixed properly at some point)
      73d3805d
  14. 13 May, 2010 1 commit
    • Michael Widenius's avatar
      Fixes after last merge of MySQL 5.1 · 6659ad49
      Michael Widenius authored
      - INSERT with RAND() doesn't require row based logging again
      - Some bugs fixed in opt_range() where we table->key_read was wrongly used
      
      
      
      .bzrignore:
        Ignore new xtstat binary
      mysql-test/r/index_merge_myisam.result:
        Update results (old result was wrong)
      mysql-test/suite/binlog/r/binlog_stm_binlog.result:
        Added drop table first
      mysql-test/suite/binlog/r/binlog_stm_unsafe_warning.result:
        Added test for when RAND() requires row based logging
      mysql-test/suite/binlog/t/binlog_stm_binlog.test:
        Added drop table first
      mysql-test/suite/binlog/t/binlog_stm_unsafe_warning.test:
        Added test for when RAND() requires row based logging
      scripts/make_binary_distribution.sh:
        Removed type from last commit
      sql/item_create.cc:
        Don't require row based logging when using RAND() with INSERT
      sql/opt_range.cc:
        Revert wrong patch from Oracle:
        - As QUICK_RANGE_SELECT uses it's own 'file' handler to the tables, one can't use 'table->key_read' as a flag to detect if index only read (keyread) is used or not
        - Don't set keyread if keyread is already enabled
        - Don't disable key read, if we didn't enable it ourselves
        - Simplify code (and ensure that we do proper cleanup of index only read)
      sql/opt_range.h:
        Added flags to detect if the range optimizer enabled index only read (key read) or not
      sql/opt_sum.cc:
        Use our more optimized macros
      sql/sql_lex.h:
        Added 'readable' function to check if we are in a sub query function or not (not normal query or sub query in FROM clause)
      sql/sql_select.cc:
        Use our more optimized keyread macros
        Added ASSERTS early
        Simplify code on eliminate_item_equal()
        Fixed that substitute_for_best_equal_field() doesn't core dump in case of out of memory conditions.
        Removed not needed test for 'field->maybe_null()'
        Replaced master_unit()->item with is_subquery_function() (More readable)
      sql/sql_update.cc:
        Use our more optimized keyread macros
      sql/table.cc:
        Use our more optimized keyread macros
      sql/table.h:
        Use separate functions to enable/disable Index only reads
        - Safer, more readable, better logging and faster.
      6659ad49
  15. 12 May, 2010 5 commits
  16. 11 May, 2010 4 commits
  17. 10 May, 2010 1 commit