- 13 Jul, 2006 2 commits
-
-
unknown authored
into moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.0-bug18630 sql/item_func.cc: Auto merged sql/item_func.h: Auto merged sql/sql_parse.cc: Auto merged sql/sql_trigger.cc: Auto merged
-
unknown authored
context. Routine arguments were evaluated in the security context of the routine itself, not in the caller's context. The bug is fixed the following way: - Item_func_sp::find_and_check_access() has been split into two functions: Item_func_sp::find_and_check_access() itself only finds the function and check that the caller have EXECUTE privilege on it. New function set_routine_security_ctx() changes security context for SUID routines and checks that definer have EXECUTE privilege too. - new function sp_head::execute_trigger() is called from Table_triggers_list::process_triggers() instead of sp_head::execute_function(), and is effectively just as the sp_head::execute_function() is, with all non-trigger related code removed, and added trigger-specific security context switch. - call to Item_func_sp::find_and_check_access() stays outside of sp_head::execute_function(), and there is a code in sql_parse.cc before the call to sp_head::execute_procedure() that checks that the caller have EXECUTE privilege, but both sp_head::execute_function() and sp_head::execute_procedure() call set_routine_security_ctx() after evaluating their parameters, and restore the context after the body is executed. mysql-test/r/sp-security.result: Add test case for bug#18630: Arguments of suid routine calculated in wrong security context. mysql-test/t/sp-security.test: Add result for bug#18630: Arguments of suid routine calculated in wrong security context. sql/item_func.cc: Do not change security context before executing the function, as it will be changed after argument evaluation. Do not change security context in Item_func_sp::find_and_check_access(). sql/item_func.h: Change prototype for Item_func_sp::find_and_check_access(). sql/sp_head.cc: Add set_routine_security_ctx() function. Add sp_head::execute_trigger() method. Change security context in sp_head::execute_trigger(), and in sp_head::execute_function() and sp_head::execute_procedure() after argument evaluation. Move pop_all_cursors() call to sp_head::execute(). sql/sp_head.h: Add declaration for sp_head::execute_trigger() and set_routine_security_ctx(). sql/sql_parse.cc: Do not change security context before executing the procedure, as it will be changed after argument evaluation. sql/sql_trigger.cc: Call new sp_head::execute_trigger() instead of sp_head::execute_function(), which is responsible to switch security context.
-
- 12 Jul, 2006 3 commits
-
-
unknown authored
into bodhi.local:/opt/local/work/mysql-5.0-runtime
-
unknown authored
sql/item_timefunc.cc: Fix a valgrind warning in type_date test.
-
unknown authored
into dl145k.mysql.com:/data0/mkindahl/bk/mysql-5.0-rpl ndb/include/kernel/GlobalSignalNumbers.h: Auto merged ndb/src/kernel/blocks/dbdict/Dbdict.cpp: Auto merged ndb/src/kernel/blocks/dbdict/Dbdict.hpp: Auto merged ndb/src/kernel/blocks/dbdih/DbdihMain.cpp: Auto merged ndb/src/ndbapi/ndberror.c: Auto merged sql/ha_ndbcluster.cc: Auto merged sql/handler.h: Auto merged sql/sql_base.cc: Auto merged sql/sql_insert.cc: Auto merged
-
- 11 Jul, 2006 8 commits
-
-
unknown authored
when dropping/creating tables" mysql-test/r/ps.result: A post-merge fix. mysql-test/t/ps.test: A post-merge fix: all 5.0 tests should go after 4.1 tests. sql/sql_lex.cc: auxilliary -> auxiliary sql/sql_prepare.cc: auxilliary -> auxiliary sql/table.cc: Update st_table_list::reinit_before_use in 5.0 to include 5.0-specific cleanups. sql/table.h: st_table_list::reinit_before_use is public.
-
unknown authored
into bodhi.local:/opt/local/work/mysql-5.0-runtime-merge-41 ndb/src/mgmsrv/ConfigInfo.cpp: Auto merged sql/table.cc: Auto merged mysql-test/r/ps.result: Manual merge: use local. mysql-test/t/ps.test: Manual merge: remove duplicate test cases from ps.test. sql/sql_lex.cc: Manual merge. sql/sql_prepare.cc: Manual merge. sql/table.h: Manual merge.
-
unknown authored
into bodhi.local:/opt/local/work/mysql-5.0-runtime-merge-41 sql/sql_table.cc: Auto merged
-
unknown authored
into chilla.local:/home/mydev/mysql-5.0-amerge sql/handler.h: Auto merged sql/sql_table.cc: Auto merged
-
unknown authored
-
unknown authored
into trift2.:/M50/mysql-5.0
-
unknown authored
into dl145k.mysql.com:/data0/mkindahl/bk/MERGE/mysql-5.0-merge ndb/include/kernel/GlobalSignalNumbers.h: Auto merged ndb/src/kernel/blocks/dbdict/Dbdict.cpp: Auto merged ndb/src/kernel/blocks/dbdict/Dbdict.hpp: Auto merged ndb/src/kernel/blocks/dbdih/DbdihMain.cpp: Auto merged ndb/src/ndbapi/ndberror.c: Auto merged
-
unknown authored
into bodhi.local:/opt/local/work/mysql-5.0-runtime-merge-41 sql/opt_range.cc: Auto merged support-files/mysql.spec.sh: Auto merged mysql-test/Makefile.am: Manual merge.
-
- 10 Jul, 2006 21 commits
-
-
unknown authored
sql/sql_locale.cc: "true" -> TRUE
-
unknown authored
into trift2.:/M50/mysql-5.0 configure.in: Auto merged
-
unknown authored
-
unknown authored
sql/sql_locale.cc: Fix Windows compilation failure "cannot convert from 'const char [6]' to 'const BOOL'" and an apparent bug (use of "FALSE" instead of FALSE for initialization of is_ascii member of MY_LOCALE)
-
unknown authored
-
unknown authored
into gbichot3.local:/home/mysql_src/mysql-5.0
-
unknown authored
mysql-test/r/myisam.result: Fix test results. mysql-test/t/myisam.test: In 5.0 show create table also outputs data directory. For the test for Bug#8706 it's MYSQLTEST_VARDIR, and there is no way to replace it with anything else in test output.
-
unknown authored
into orca.ndb.mysql.com:/space_old/pekka/ndb/version/my50-1.2167.1.2 ndb/include/kernel/GlobalSignalNumbers.h: Auto merged ndb/src/common/debugger/signaldata/SignalNames.cpp: Auto merged ndb/src/kernel/blocks/dbdih/DbdihMain.cpp: Auto merged ndb/src/kernel/blocks/ndbcntr/NdbcntrMain.cpp: Auto merged ndb/test/run-test/daily-basic-tests.txt: Auto merged
-
unknown authored
ndb/src/kernel/blocks/dbdict/DictLock.txt: wait until SL_STARTED before sending DICT_UNLOCK_ORD ndb/src/kernel/blocks/dbdih/Dbdih.hpp: wait until SL_STARTED before sending DICT_UNLOCK_ORD ndb/src/kernel/blocks/dbdih/DbdihMain.cpp: wait until SL_STARTED before sending DICT_UNLOCK_ORD ndb/src/kernel/vm/SimulatedBlock.cpp: wait until SL_STARTED before sending DICT_UNLOCK_ORD ndb/src/kernel/vm/SimulatedBlock.hpp: wait until SL_STARTED before sending DICT_UNLOCK_ORD ndb/test/run-test/daily-basic-tests.txt: wait until SL_STARTED before sending DICT_UNLOCK_ORD
-
unknown authored
ndb/include/kernel/GlobalSignalNumbers.h: 5.0 : add NODE_START_REP from 5.1 ndb/src/common/debugger/signaldata/SignalNames.cpp: 5.0 : add NODE_START_REP from 5.1 ndb/src/kernel/blocks/ndbcntr/NdbcntrMain.cpp: 5.0 : add NODE_START_REP from 5.1 ndb/src/kernel/vm/SimulatedBlock.cpp: 5.0 : add NODE_START_REP from 5.1 ndb/src/kernel/vm/SimulatedBlock.hpp: 5.0 : add NODE_START_REP from 5.1
-
unknown authored
fails" mysql-test/t/myisam.test: Fix myisam.test to work with non-default mysqltest var directory.
-
unknown authored
VC++Files/libmysqld/libmysqld.dsp: Add sql_locale.cpp VC++Files/libmysqld/libmysqld.vcproj: Add sql_locale.cpp VC++Files/sql/mysqld.dsp: Add sql_locale.cpp VC++Files/sql/mysqld.vcproj: Add sql_locale.cpp
-
unknown authored
into orca.ndb.mysql.com:/space_old/pekka/ndb/version/my50
-
unknown authored
ndb/src/kernel/blocks/dbtup/DbtupMeta.cpp: non-debug compile fix
-
unknown authored
into dsl-hkigw8-feb1fb00-100.dhcp.inet.fi:/usr_rh9/home/elkin.rh9/MySQL/TEAM/FIXES/5.0/20919_temp_nlog sql/sql_base.cc: Manual merge
-
unknown authored
into trift2.:/M50/mysql-5.0
-
unknown authored
support-files/mysql.spec.sh: Fix a typing error in the "make" target for the Perl script to run the tests.
-
unknown authored
into trift2.:/M50/back23-5.0 support-files/mysql.spec.sh: Auto merged
-
unknown authored
into orca.ndb.mysql.com:/space_old/pekka/ndb/version/my50-bug20847
-
unknown authored
mysql-test/Makefile.am: fix cp of mode 444 files
-
unknown authored
into orca.ndb.mysql.com:/space_old/pekka/ndb/version/my50-bug20847
-
- 09 Jul, 2006 2 commits
-
-
unknown authored
closing temp tables through end_thread had a flaw in binlog-off branch of close_temporary_tables where next table to close was reset via table->next for (table= thd->temporary_tables; table; table= table->next) which was wrong since the current table instance got destoyed at close_temporary(table, 1); The fix adapts binlog-on branch method to engage the loop's internal 'next' variable which holds table->next prior table's destoying. sql/sql_base.cc: no-binlog branch is fixed: scanning across temporary_tables must be careful to save next table since the current is being destroyed inside of close_temporary. binlog-is-open case is ok.
-
unknown authored
between pointer to function and pointer to object. sql/item_func.cc: Use typedef names instead of hard-coded types for udf init/deinit functions. sql/sql_udf.cc: Use typedef names for udf function types.
-
- 08 Jul, 2006 3 commits
-
-
unknown authored
into bodhi.local:/opt/local/work/mysql-5.0-runtime-merge-41 myisam/mi_create.c: Auto merged mysql-test/r/myisam.result: Auto merged mysql-test/t/myisam.test: Auto merged sql/item_timefunc.cc: Auto merged sql/sql_class.cc: Auto merged sql/sql_insert.cc: Auto merged sql/sql_parse.cc: Auto merged sql/sql_trigger.cc: Auto merged support-files/mysql.spec.sh: Auto merged mysql-test/r/federated.result: Manual merge. mysql-test/t/federated.test: Manual merge.
-
unknown authored
into chilla.local:/home/mydev/mysql-5.0-amerge
-
unknown authored
-
- 07 Jul, 2006 1 commit
-
-
unknown authored
into bodhi.local:/opt/local/work/mysql-5.0-runtime-merge-41 BitKeeper/etc/ignore: auto-union libmysqld/Makefile.am: Auto merged myisam/mi_create.c: Auto merged mysql-test/r/date_formats.result: Auto merged mysql-test/t/date_formats.test: Auto merged sql/Makefile.am: Auto merged sql/item_timefunc.cc: Auto merged sql/mysql_priv.h: Auto merged sql/opt_range.cc: Auto merged sql/sql_class.h: Auto merged support-files/mysql.spec.sh: Auto merged mysql-test/r/myisam.result: Manual merge. mysql-test/t/myisam.test: Manual merge. sql/set_var.cc: Manual merge. sql/set_var.h: Manual merge. sql/sql_cache.cc: Manual merge. sql/sql_class.cc: Manual merge.
-