1. 16 Jul, 2005 1 commit
    • unknown's avatar
      Fix bug#11868 NOT NULL ref optimization in subquery used in update must be · 560ff1a2
      unknown authored
      disabled if ref is built with a key from the updated table
      
      Problem was in add_not_null_conds() optimization function.
      It contains following code:
      JOIN_TAB *referred_tab= not_null_item->field->table->reginfo.join_tab;
      ...
      add_cond_and_fix(&referred_tab->select_cond, notnull);
      For UPDATE described in bug report referred_tab is 0 and dereferencing it
      crashes the server.
      
      
      
      sql/sql_select.cc:
        Fix bug #11868 NOT NULL ref optimization in subquery used in update must be
        disabled if ref is built with a key from the updated table
      mysql-test/r/update.result:
        Test case for bug#11868 Update with subquery with ref built with a key from
        the updated table crashes server.
      mysql-test/t/update.test:
        Test case for bug#11868 Update with subquery with ref built with a key from the updated table crashes server
      560ff1a2
  2. 15 Jul, 2005 10 commits
    • unknown's avatar
      Fix bug#11482 4.1.12 produces different resultset for a complex query · 0f41fb42
      unknown authored
        than in previous 4.1.x
      
      Wrongly applied optimization were adding NOT NULL constraint which results in
      rejecting valid rows and reduced result set.
      
      The problem was that add_notnull_conds() while checking subquery were adding
      NOT NULL constraint to left joined table, to which, normally, optimization 
      don't have to be applied.
      
      
      sql/sql_select.cc:
        Fix bug #11482 Wrongly applied optimization was erroneously rejecting valid rows
        Constraint were added to optimization appliance test.
      mysql-test/t/select.test:
        Test case for bug #11482  Wrongly applied optimization was erroneously rejecting valid rows
      mysql-test/r/select.result:
        Test case for bug #11482  Wrongly applied optimization was erroneously rejecting valid rows
      0f41fb42
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-4.1 · dba31904
      unknown authored
      into poseidon.ndb.mysql.com:/home/tomas/mysql-4.1-new
      
      
      tests/mysql_client_test.c:
        Auto merged
      dba31904
    • unknown's avatar
      Merge poseidon.ndb.mysql.com:/home/tomas/mysql-4.1-release · 2a48132e
      unknown authored
      into poseidon.ndb.mysql.com:/home/tomas/mysql-4.1-new
      
      
      mysql-test/t/ctype_utf8.test:
        Auto merged
      ndb/src/common/mgmcommon/ConfigRetriever.cpp:
        Auto merged
      ndb/src/common/transporter/TransporterRegistry.cpp:
        Auto merged
      ndb/src/mgmclient/CommandInterpreter.cpp:
        Auto merged
      ndb/src/mgmsrv/MgmtSrvr.cpp:
        Auto merged
      ndb/src/mgmsrv/MgmtSrvr.hpp:
        Auto merged
      ndb/src/mgmsrv/Services.cpp:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      2a48132e
    • unknown's avatar
      Merge mysqldev@production.mysql.com:my/mysql-4.1-release · 130cd50d
      unknown authored
      into poseidon.ndb.mysql.com:/home/tomas/mysql-4.1-release
      
      
      130cd50d
    • unknown's avatar
      BUG#11898 ndb_mgmd not releasing resources, added "ping" on add_listener · d4679992
      unknown authored
            + added close of some fd's
            + debug prints
      
      
      d4679992
    • unknown's avatar
      Bug #11132, reverted bug-fix, it introduces another bug. Ndbd's may get the same nodeid · 9622c473
      unknown authored
      In 4.1 the connection to the management server _must_ stay, that is how we
      ensure that the nodeids are reserved correctly
      
      
      
      9622c473
    • unknown's avatar
      BUG#11596 (partial fix), IP addresses not shown in ndb_mgm SHOW command on... · 22b6dec5
      unknown authored
       BUG#11596 (partial fix), IP addresses not shown in ndb_mgm SHOW command on second ndb_mgmd (or on ndb_mgmd restart)
      
      
      
      22b6dec5
    • unknown's avatar
      - manual merge of the fix for BUG#10984: create a "mysql" user group and assign the · 7dbae42b
      unknown authored
        mysql user account to that group in the server postinstall section of the RPM spec
        file
      
      
      support-files/mysql.spec.sh:
        - manual merge of the fix for BUG#10984: create a "mysql" user group and assign the 
          mysql user account to that group in the server postinstall section.
      7dbae42b
    • unknown's avatar
      RPM spec file improvements: · 5c27ff06
      unknown authored
      - create a "mysql" user group and assign the mysql user account to that group
        in the server postinstall section. (BUG 10984)
      - backported some changes from the 4.1 RPM spec file (cleanups: removed the incomplete
        Brazilian translations, more consequent use of macros)
      
      
      support-files/mysql.spec.sh:
        - create a "mysql" user group and assign the mysql user account to that group
          in the server postinstall section. (BUG 10984)
        - backported some changes from the 4.1 RPM spec file (cleanups: removed the incomplete
          Brazilian translations, more consequent use of macros)
      5c27ff06
    • unknown's avatar
      Jim's fix for the #10443. · 10b76d41
      unknown authored
      Fix handling of floats and doubles when using prepared statements             
      API in the embedded server. 
      
      
      sql/sql_prepare.cc:
        Jim's fix for the #10443.
        
        Within the embedded server, there's no need to use float4get()              
        and float8get() for setting parameters, since they are never                
        stored.
      10b76d41
  3. 14 Jul, 2005 21 commits
    • unknown's avatar
      Fix ps.test in --ps-protocol · 951dacdc
      unknown authored
      
      mysql-test/t/ps.test:
        Disable prepared statements for a part of the test to avoid
        result mismatch.
      951dacdc
    • unknown's avatar
      Hastily remove an occasionally checked in symlink :( · 73386c15
      unknown authored
      
      BitKeeper/deleted/.del-var~507a9bd3b926223e:
        Delete: mysql-test/var
      73386c15
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · d9e44dc7
      unknown authored
      into  mysql.com:/opt/local/work/mysql-4.1-root
      
      
      d9e44dc7
    • unknown's avatar
      A fix and a test case for Bug#11299 "prepared statement makes wrong SQL · cb7a5b53
      unknown authored
       syntax in binlog which stops replication":
      disallow the use of parameter markers which can lead to generation
      of malformed binlog queries. 
      
      
      mysql-test/r/ps.result:
        Test results fixed: a test case for Bug#11299
      mysql-test/t/ps.test:
        A test case for Bug#11299
      sql/sql_lex.cc:
        Introduce a new parser token for a parameter marker. Make sure
        that a parameter marker can not be used in a query which, when
        transformed to a binlog query, becomes grammatically incorrect.
      sql/sql_yacc.yy:
        The check for COM_PREPARE has been moved into the lexer.
      mysql-test/var:
        New BitKeeper file ``mysql-test/var''
      cb7a5b53
    • unknown's avatar
      Merge mysqldev@production:my/mysql-4.1-release · 297f80ed
      unknown authored
      into mysql.com:/space/my/mysql-4.1.13-clone
      
      
      297f80ed
    • unknown's avatar
      misc (memleak) fixes: · 638fe9ec
      unknown authored
          added using ndb_end and showing mem allocation stat at exit
          added init of variable
          added destruction of LocalConfig to still memleak
          added delete of theFacade on exit
          stopSessions(true) on socket server to ensure destuction of threads
          added destruction of arbit manager thread
          added true option to stopSessions in transporter facade to ensure destructions of threads
      
      
      ndb/include/util/ndb_opts.h:
        added using ndb_end and showing mem allocation stat at exit
      ndb/src/common/logger/LogHandler.cpp:
        added init of variable
      ndb/src/mgmapi/mgmapi.cpp:
        added destruction of LocalConfig to still memleak
        debug printouts
      ndb/src/mgmclient/main.cpp:
        added using ndb_end and showing mem allocation stat at exit
      ndb/src/mgmsrv/MgmtSrvr.cpp:
        added delete of theFacade on exit
        removed area51
        added debug prints
      ndb/src/mgmsrv/main.cpp:
        added using ndb_end and showing mem allocation stat at exit
        moved glob struct to heap to enable ndb_end usage
        moved options out of glob struct
        stopSessions(true) on socket server to ensure destuction of threads
      ndb/src/ndbapi/ClusterMgr.cpp:
        added destruction of arbit manager thread
        debug printouts
      ndb/src/ndbapi/TransporterFacade.cpp:
        added true option to stopSessions in transporter facade to ensure destructions of threads
        + debug prints
      638fe9ec
    • unknown's avatar
      BUG#11898 ndb_mgmd not releasing resources, added "ping" on add_listener · 2fdc89da
      unknown authored
          + added close of some fd's
          + debug prints
      
      
      ndb/src/mgmclient/CommandInterpreter.cpp:
         BUG#11898 ndb_mgmd not releasing resources, added "ping"
        + debug prints
      ndb/src/mgmsrv/MgmtSrvr.hpp:
         BUG#11898 ndb_mgmd not releasing resources, added "ping"
        + debug prints
      ndb/src/mgmsrv/Services.cpp:
         BUG#11898 ndb_mgmd not releasing resources, added "ping" on add_listener
        + added close of some fd's
        + debug prints
      2fdc89da
    • unknown's avatar
      Merge rburnett@bk-internal.mysql.com:/home/bk/mysql-4.1 · 86ae5158
      unknown authored
      into  linux.site:/home/reggie/bk/mysql-4.1
      
      
      86ae5158
    • unknown's avatar
      A fix and a test case for Bug#11183 "mysql_stmt_reset() doesn't reset · bd44c99b
      unknown authored
      information about error".
      
      
      libmysql/libmysql.c:
        Clear the last error on the statement if mysql_stmt_reset succeeded.
      tests/mysql_client_test.c:
        A test case for Bug#11183 "mysql_stmt_reset() doesn't reset information 
        about error"
      bd44c99b
    • unknown's avatar
      stilled mem leak in usage on getVersionString · f7c3e510
      unknown authored
          added __LINE__ so systemErrorLab for better error printout
      
      
      ndb/include/ndb_version.h.in:
        stilled mem leak in usage on getVersionString
      ndb/include/util/version.h:
        stilled mem leak in usage on getVersionString
      ndb/src/common/util/version.c:
        stilled mem leak in usage on getVersionString
      ndb/src/kernel/blocks/qmgr/Qmgr.hpp:
        added __LINE__ so systemErrorLab for better error printout
      ndb/src/kernel/blocks/qmgr/QmgrMain.cpp:
        stilled mem leak in usage on getVersionString
        added __LINE__ so systemErrorLab for better error printout
      ndb/tools/restore/restore_main.cpp:
        stilled mem leak in usage on getVersionString
      f7c3e510
    • unknown's avatar
      added debug prints · 66fccd82
      unknown authored
      
      ndb/include/portlib/NdbTCP.h:
        added debug prints
      ndb/include/util/SocketServer.hpp:
        added debug prints
      ndb/src/common/mgmcommon/ConfigRetriever.cpp:
        debug prints
      ndb/src/common/mgmcommon/IPCConfig.cpp:
        debug prints
      ndb/src/common/portlib/NdbMutex.c:
        debug prints
      ndb/src/common/portlib/NdbTCP.cpp:
        debug printout
      ndb/src/common/portlib/NdbThread.c:
        debug printout
      ndb/src/common/transporter/TransporterRegistry.cpp:
        debug printout
      ndb/src/common/util/Parser.cpp:
        debug printout
      ndb/src/common/util/SocketClient.cpp:
        debug printout
      ndb/src/common/util/SocketServer.cpp:
        debug printout
      66fccd82
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 69ecbbcb
      unknown authored
      into  mysql.com:/opt/local/work/mysql-4.1-root
      
      
      69ecbbcb
    • unknown's avatar
      Merge mysql.com:/home/psergey/mysql-4.1-build-tree · 96dcb8c2
      unknown authored
      into mysql.com:/home/psergey/mysql-4.1-merge-from-build
      
      
      sql/item_func.cc:
        Auto merged
      96dcb8c2
    • unknown's avatar
      4906face
    • unknown's avatar
      fix for #11808 backported. · 2a6e45b0
      unknown authored
      
      tests/mysql_client_test.c:
        fix for #11808 backported.
        cmp_double() introduced in order to avoid using long double registers           
        (for local double vars).
      2a6e45b0
    • unknown's avatar
      Fix for BUG#11869: In Item_func_match::fix_index() handle the case when there is no · c0bcf503
      unknown authored
        source table present (this happens for ORDER BY after UNION)
      
      
      mysql-test/r/fulltext_order_by.result:
        Testcase for BUG#11869
      mysql-test/t/fulltext_order_by.test:
        Testcase for BUG#11869
      c0bcf503
    • unknown's avatar
      Fix for BUG#11700: in add_not_null_conds(), call full fix_fields() for the created NOT NULL. · d91c901f
      unknown authored
        This is needed because in some cases range optimization is performed twice and added 
        NOT NULL item must have correct const_table_map() value. 
      
      
      mysql-test/r/select.result:
        Testcase for BUG#11700
      mysql-test/t/select.test:
        Testcase for BUG#11700
      d91c901f
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · eb4a309b
      unknown authored
      into  mysql.com:/opt/local/work/mysql-4.1-root
      
      
      eb4a309b
    • unknown's avatar
      A fix and a test case for Bug#9735. · a16a61d9
      unknown authored
      No separate typecode for MEDIUMTEXT/LONGTEXT is added, as we
      have no sound decision yet what typecodes and for what types are
      sent by the server (aka what constitutes a distinct type in MySQL).
      
      
      
      mysql-test/r/ps_2myisam.result:
        Test results fixed: new longtext/longblob length (2^32)
      mysql-test/r/ps_3innodb.result:
        Test results fixed: new longtext/longblob length (2^32)
      mysql-test/r/ps_4heap.result:
        Test results fixed: new longtext/longblob length (2^32)
      mysql-test/r/ps_5merge.result:
        Test results fixed: new longtext/longblob length (2^32)
      mysql-test/r/ps_6bdb.result:
        Test results fixed: new longtext/longblob length (2^32)
      mysql-test/r/ps_7ndb.result:
        Test results fixed: new longtext/longblob length (2^32)
      sql/field.cc:
        A fix for Bug#9735 "mysql_fetch_fields() acts strange on 
        LONGBLOB/LONGTEXT": fix wrong initialization of field_length
        in case of BLOB fields.
      tests/mysql_client_test.c:
        A test case for Bug#9735  "mysql_fetch_fields() acts strange on 
        LONGBLOB/LONGTEXT"
      a16a61d9
    • unknown's avatar
      b0d97b2c
    • unknown's avatar
      Merge abarkov@bk-internal.mysql.com:/home/bk/mysql-4.1 · 86cb32b7
      unknown authored
      into  mysql.com:/usr/home/bar/mysql-4.1.num-conv
      
      
      mysql-test/r/ctype_utf8.result:
        Auto merged
      mysql-test/t/ctype_utf8.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      86cb32b7
  4. 13 Jul, 2005 8 commits
    • unknown's avatar
      A test case for Bug#9442 "Set parameter make query fail if column · c663aa89
      unknown authored
      character set is UCS2".
      The bug is no longer repeatable.
      
      
      mysql-test/r/ps.result:
        Test results fixed (a test case for Bug#9442)
      mysql-test/t/ps.test:
        A test case for Bug#9442 "Set parameter make query fail if column 
        character set is UCS2
      c663aa89
    • unknown's avatar
      A fix and a test case for Bug#9379 (collation of a parameter marker is · 98248f04
      unknown authored
      binary).
      
      
      mysql-test/r/ps.result:
        Test results fixed (Bug#9379)
      mysql-test/t/ps.test:
        A test case for Bug#9379 (collation of a parameter marker is binary)
      sql/item.cc:
        - set Item_param::collation to str_value collation, if Item_param
        is assigned a string. Reset it to default in Item_param::reset() (on 
        the next execution it can be assigned a number).
      sql/item_func.cc:
        - now that item collation can change between executions
        (if this item is Item_param), we need to register the change
        of the execution tree in the rollback list.
      98248f04
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · e064ca31
      unknown authored
      into  mysql.com:/opt/local/work/mysql-4.1-11458
      
      
      e064ca31
    • unknown's avatar
      Cleanup after test for Bug#11458 · f5c8f42f
      unknown authored
      f5c8f42f
    • unknown's avatar
      4.1.13 has been cloned off · 5ef54bb9
      unknown authored
      
      configure.in:
        Increase version number to 4.1.14, as the clone for 4.1.13 has been created.
      5ef54bb9
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 7a0f6d52
      unknown authored
      into  mysql.com:/opt/local/work/mysql-4.1-11458
      
      
      sql/mysql_priv.h:
        Auto merged
      7a0f6d52
    • unknown's avatar
      - a fix for Bug#11458 "Prepared statement with subselects return random · ece17ba3
      unknown authored
      data": remove the fix for another bug (8807) that
      added OUTER_REF_TABLE_BIT to all subqueries that used a placeholder
      to prevent their evaluation at prepare. As this bit hanged in 
      Item_subselect::used_tables_cache for ever, a constant subquery with
      a placeholder was never evaluated as such, which caused wrong 
      choice of the execution plan for the statement.
      - to fix Bug#8807 backport a better fix from 5.0
      - post-review fixes.
      
      
      mysql-test/r/ps.result:
        Bug#11458: test results fixed
      mysql-test/t/ps.test:
        - add a test case for Bug#11458 "Prepared statement with subselects return 
        random data"
      sql/item.cc:
        - remove unnecessary Item_param::fix_fields
        - fix Item_param::set_null to set item_type accordingly (safety:
          Item_param should behave like a basic constant).
      sql/item.h:
        Remove Item_param::fix_fields
      sql/item_subselect.h:
        Remove no more existing friend.
      sql/mysql_priv.h:
        Add UNCACHEABLE_PREPARE to mark all subqueries as uncacheable if
        in statement prepare (backport from 5.0).
      sql/sql_lex.h:
        Comment fixed.
      sql/sql_parse.cc:
        If in statement prepare, mark all subqueries as uncacheable (backport
        from 5.0)
      sql/sql_prepare.cc:
        Switch off the uncacheable flag from all subqueries after statement
        prepare is done (backport from 5.0)
      ece17ba3
    • unknown's avatar
      Bug#11905: Tables used in rpl_deadlock are not dropped at the · ecd1ea93
      unknown authored
      end of the test, causing subsequent tests to fail.
      
      
      mysql-test/r/rpl_deadlock.result:
        Result change.
      mysql-test/t/rpl_deadlock.test:
        Tables used in the test but not dropped.
      ecd1ea93