1. 14 Mar, 2008 1 commit
  2. 12 Mar, 2008 1 commit
  3. 29 Feb, 2008 2 commits
    • unknown's avatar
      test fix · be59a0ea
      unknown authored
      
      mysql-test/r/symlink.result:
        result fix
      be59a0ea
    • unknown's avatar
      Bug#32167 another privilege bypass with DATA/INDEX DIRECORY(ver 4.1,5.0) · ab604259
      unknown authored
      added new function test_if_data_home_dir() which checks that
      path does not contain mysql data home directory.
      Using of mysql data home directory in
      DATA DIRECTORY & INDEX DIRECTORY is disallowed.
      
      
      mysql-test/r/symlink.result:
        test result
      mysql-test/t/symlink.test:
        test case
      sql/mysql_priv.h:
        new variable mysql_unpacked_real_data_home
      sql/mysqld.cc:
        new variable mysql_unpacked_real_data_home
      sql/sql_parse.cc:
        added new function test_if_data_home_dir() which checks that
        path does not contain mysql data home directory.
        Using of mysql data home directory in
        DATA DIRECTORY & INDEX DIRECTORY is disallowed.
      ab604259
  4. 26 Feb, 2008 1 commit
    • unknown's avatar
      configure.in: · b93e09a2
      unknown authored
        Corrected calculation of version id, incorrect last two digits if < 10
        Keep "sp1" or "a" in MYSQL_NO_DASH_VERSION, to set correct version in
        RPM spec file
        Added MYSQL_NUMERIC_VERSION that is like MYSQL_NO_DASH_VERSION before
        Added clear doc how the different version variables differ
      SocketServer.cpp:
        Corrected typo in debug error message
      
      
      ndb/src/common/util/SocketServer.cpp:
        Corrected typo in debug error message
      configure.in:
        Corrected calculation of version id, incorrect last two digits if < 10
        Keep "sp1" or "a" in MYSQL_NO_DASH_VERSION, to set correct version in
        RPM spec file
        Added MYSQL_NUMERIC_VERSION that is like MYSQL_NO_DASH_VERSION before
        Added clear doc how the different version variables differ
      b93e09a2
  5. 17 Feb, 2008 1 commit
  6. 10 Feb, 2008 1 commit
    • unknown's avatar
      Bug #33796 Memory leak for prepared statements in embedded server. · db66526c
      unknown authored
      Field data for a query was stored to the stmt->alloc that is emptied
      with mysql_stmt_close statement only. That means a lot of memory can
      be occupied without a reason if used doesn't call mysql_stmt_close often.
      
      
      libmysql/libmysql.c:
        Bug #33796 Memory leak for prepared statements in embedded server.
        
        Clean up result->alloc even if there's no 'data' created
      libmysqld/lib_sql.cc:
        Bug #33796 Memory leak for prepared statements in embedded server.
        
        alloc 'fields' in the 'result.alloc' as the 'mem_root' is only cleaned with
        mysql_stmt_close'
      db66526c
  7. 31 Jan, 2008 1 commit
  8. 29 Jan, 2008 1 commit
  9. 28 Jan, 2008 1 commit
  10. 25 Jan, 2008 1 commit
    • unknown's avatar
      Bug#33841: mysql client crashes when returning results for long-\ · 60ea77d4
      unknown authored
      	running queries
      
      Bug#33976: buffer overflow of variable time_buff in function com_go()
      
      An internal buffer was too short.  Overextending could smash the 
      stack on some architectures and cause SEGVs.  This is not a problem
      that could be exploited to run arbitrary code.
      
      To fix, I expanded one buffer to cover all the size that could be
      written to (we know the abolute max).
      
      
      client/mysql.cc:
        Bump up the max size of the time-elapsed buffer displayed at the end
        of queries.
      60ea77d4
  11. 22 Jan, 2008 1 commit
  12. 21 Jan, 2008 1 commit
  13. 03 Jan, 2008 2 commits
  14. 27 Dec, 2007 1 commit
    • unknown's avatar
      scripts/make_binary_distribution.sh: · 07aab86f
      unknown authored
      Fix the code to get the "libgcc" file name so that the failure of Intel's ICC
      to provide this information does not cause any problems.
      
      This fixes  bug#33536  Option "--print-libgcc-file" does not work with ICC compiler
      
      
      scripts/make_binary_distribution.sh:
        The (old) code to get the "libgcc" file name does not really work when using Intel's ICC.
        ICC accepts the "--print-libgcc-file" option but ignores it, does not produce any output.
        
        However, ICC tricks automake into taking it for a GCC ("GXX" variable is set, see
        http://www.gnu.org/software/autoconf/manual/html_node/C_002b_002b-Compiler.html#C_002b_002b-Compiler
        and its discussion of the "AC_PROG_CXX" macro).
        
        There are two possible approaches:
        a) Check "$CC" or "$CXX" to tell ICC from GCC, and do not ask ICC for the "libgcc" file name.
        b) Just ask it, but protect that code so that its failure does not cause any damage.
        
        This patch takes the second route:
        1) Put the call "@CC@ ... --print-libgcc-file" into a pipeline, followed by "|| true",
           so that (for the shell semantics) the command cannot fail.
           (ICC will exit non-zero because it is not given a source file.)
        2) Explicitly redirect any error messages.
        3) Do not use the compiler's return code but rather the (non)empty variable to check success.
        4) Ensure that the contents really is a file before taking it as a file name.
        
        Item 1) is especially important when the tool gets a "set -e" (this happens in 5.1, currently)
        which would make the failing compiler call a fatal thing.
        
        This fixes  bug#33536  Option "--print-libgcc-file" does not work with ICC compiler
      07aab86f
  15. 17 Dec, 2007 3 commits
  16. 13 Dec, 2007 1 commit
  17. 10 Dec, 2007 2 commits
    • unknown's avatar
      Merge tsmith@bk-internal.mysql.com:/home/bk/mysql-4.1-bug15815 · d802c0ac
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/maint/41
      
      
      innobase/buf/buf0buf.c:
        Auto merged
      innobase/buf/buf0flu.c:
        Auto merged
      innobase/buf/buf0lru.c:
        Auto merged
      innobase/include/buf0buf.h:
        Auto merged
      innobase/include/buf0buf.ic:
        Auto merged
      innobase/include/sync0arr.h:
        Auto merged
      innobase/include/sync0rw.h:
        Auto merged
      innobase/include/sync0rw.ic:
        Auto merged
      innobase/include/sync0sync.h:
        Auto merged
      innobase/os/os0sync.c:
        Auto merged
      innobase/sync/sync0arr.c:
        Auto merged
      innobase/sync/sync0rw.c:
        Auto merged
      innobase/sync/sync0sync.c:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      d802c0ac
    • unknown's avatar
      Merge pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-4.1 · 069ca6d0
      unknown authored
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-4.1-build
      
      
      069ca6d0
  18. 06 Dec, 2007 2 commits
  19. 05 Dec, 2007 1 commit
  20. 01 Dec, 2007 2 commits
  21. 30 Nov, 2007 5 commits
    • unknown's avatar
      Merge four.local.lan:/work/merge/mysql-4.1-dev · d09dfdab
      unknown authored
      into  four.local.lan:/work/trees/mysql-4.1-build-src-clean
      
      
      d09dfdab
    • unknown's avatar
      Merge mysql.com:/home/hf/work/31900/my41-31900 · d87a75c1
      unknown authored
      into  mysql.com:/home/hf/work/mrg/my41-mrg
      
      
      d87a75c1
    • unknown's avatar
      Fix for · 56b00941
      unknown authored
         Bug#31030 rpl000015.test fails if $MYSQL_TCP_PORT != 3306
      Note:
        This bug does not occur in MySQL 5.0 and up, because
        ChangeSet 1.2328.2.1 2006/11/27 for MySQL 5.0 prevents this.
        The 5.0 fix uses the environment variable DEFAULT_MASTER_PORT
        which is set by mysql-test-run.pl.
        mysql-test-run.pl in 4.1 does not set this variable.
        There are two alternatives:
        1) Backport the 5.0 fix for this test including modifications
           to mysql-test-run.pl and mysql-test-run-shell.
           This is a not acceptable impact on an old MySQL version.
        2) Fix the problem different than in 5.0 like in the current
           ChangeSet + do not apply these changes when upmerging to 5.0
      
      
      mysql-test/r/rpl000015.result:
        Updated result
      mysql-test/t/disabled.def:
        Enable rpl000015
      mysql-test/t/rpl000015.test:
        Unify the MASTER_PORT number
      56b00941
    • unknown's avatar
      my_global.h: · 44ebdc09
      unknown authored
        Added 64 bit Mac OS X hard coded settings, for universal binaries
      
      
      include/my_global.h:
        Added 64 bit Mac OS X hard coded settings, for universal binaries
      44ebdc09
    • unknown's avatar
  22. 29 Nov, 2007 2 commits
    • unknown's avatar
      my_global.h: · f177f5f9
      unknown authored
        Added 64 bit Mac OS X hard coded settings, for universal binaries
      
      
      include/my_global.h:
        Added 64 bit Mac OS X hard coded settings, for universal binaries
      f177f5f9
    • unknown's avatar
      Bug #29085 A small double precision number becomes zero. · 23e402bf
      unknown authored
      Denormalized DOUBLE-s can't be properly handled by old MIPS processors.
      So we need to enable specific mode for them so IRIX will do use
      software round to handle such numbers. 
      
      
      sql/mysqld.cc:
        Bug #29085 A small double precision number becomes zero.
        
        reset_floating_point_exeption() renamed as set_proper_floating_point_mode()
        #ifdef __sgi code added to enable denormalized DOUBLE-s on IRIX
      23e402bf
  23. 27 Nov, 2007 1 commit
    • unknown's avatar
      Bug#32707: misdimensioned buffer in protocol layer · 7c0db983
      unknown authored
      Miscalculation in protocol-layer: size buffer correctly so
      even really long error messages cannot overflow our buffer.
      
      
      sql/protocol.cc:
        size buffer correctly so really long error messages cannot overflow it.
      7c0db983
  24. 26 Nov, 2007 2 commits
    • unknown's avatar
      Bug #31900 Wrong confusing comment in mysql_com.h header file. · 7257ed0e
      unknown authored
      comment fixed as we truly need const_item to be 1 to mark
      constant function
      
      
      include/mysql_com.h:
        Bug #31900 Wrong confusing comment in mysql_com.h header file.
        
        comment fixed
      7257ed0e
    • unknown's avatar
      Bug#31752: check strmake() bounds · a905ac34
      unknown authored
      strmake() calls are easy to get wrong. Add checks in extra
      debug mode to identify possible exploits.
      
      Remove some dead code.
      
      Remove some off-by-one errors identified with new checks.
      
      
      sql/log.cc:
        fix off-by-one buffer-length argument to prevent stack smashing
      sql/repl_failsafe.cc:
        fix off-by-one buffer-length argument to prevent stack smashing
      sql/set_var.cc:
        fix off-by-one buffer-length argument to prevent stack smashing
        (already approved, backports #31588)
      sql/sql_show.cc:
        misdimensioned buffers: functions further down the callstack
        expect bufsize of FN_REFLEN
      sql/unireg.cc:
        When EXTRA_DEBUG is enabled, strmake() will write funny patterns to
        buffers it operates on to identify possibly overflows. This leads to
        badness in mysql_create_frm(), so we explicitly put any unused bytes
        (back) into a defined state. Not a bug-fix, but part of the strmake()
        bug detector.
      strings/strmake.c:
        strmake() takes maximum string length rather than buffer-length
        (string length + 1 to accomodate \0 terminator) as argument.
        Since this is easy to get wrong, add extra debug code to identify
        off-by-ones so we can prevent stack smashing.
        
        Alternative "BAD_STRING_COMPILER" removed after checking
        with Monty.
      a905ac34
  25. 24 Nov, 2007 1 commit
  26. 21 Nov, 2007 1 commit
  27. 20 Nov, 2007 1 commit