- 28 Dec, 2014 1 commit
-
-
Jan Lindström authored
Patch by James Taylor.
-
- 23 Dec, 2014 1 commit
-
-
Elena Stepanova authored
-
- 21 Dec, 2014 1 commit
-
-
unknown authored
-
- 19 Dec, 2014 4 commits
-
-
Sergey Vojtovich authored
-
Sergey Vojtovich authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
- 18 Dec, 2014 2 commits
-
-
Sergey Petrunya authored
-
Sergey Petrunya authored
generate_derived_keys_for_table() did not work correctly in the case where - it had a potential index on derived table - however, TABLE::check_tmp_key() would disallow creation of this index after looking at its future key parts (because of the key parts exceeding max. index length) - the code would leave a KEYUSE structure that refers to a non-existant index. Depending on further optimizer calculations, this could cause a crash.
-
- 17 Dec, 2014 3 commits
-
-
Sergei Golubchik authored
MDEV-7150 Wrong auto increment values on INSERT .. ON DUPLICATE KEY UPDATE when the inserted columns include NULL in an auto-increment column when restoring auto-inc value in INSERT ... ON DUPLICATE KEY UPDATE, take into account that 1. it may be changed in the UPDATE clause (old code did that) 2. it may be changed in the INSERT clause and then cause a dup key (old code missed that)
-
unknown authored
-
unknown authored
Item_ident fixed to allow double cleanup().
-
- 16 Dec, 2014 1 commit
-
-
Alexander Barkov authored
-
- 15 Dec, 2014 4 commits
-
-
Michael Widenius authored
MDEV-6855 Assertion `cond_type == Item::FUNC_ITEM' failed in check_group_min_max_predicates with GROUP BY, aggregate in WHERE SQ, multi-part key mysql-test/r/group_by.result: Test for MDEV-6855 mysql-test/t/group_by.test: Test for MDEV-6855 sql/item.h: Fixed spelling error sql/opt_range.cc: Added handling of cond_type == Item::CACHE_ITEM in WHERE clauses for MIN/MAX optimization. Fixed indentation
-
Michael Widenius authored
There was a bug in lock handling when mixing INSERT ... SELECT on the same table. mysql-test/suite/maria/insert_select.result: Test case for MDEV_4010 mysql-test/suite/maria/insert_select.test: Test case for MDEV_4010 mysys/thr_lock.c: We wrongly alldoed TL_WRITE_CONCURRENT_INSERT when there was a TL_READ_NO_INSERT lock
-
Michael Widenius authored
mysql-test/r/kill-2.result: test case for MDEV-6896 mysql-test/t/kill-2-master.opt: test case for MDEV-6896 mysql-test/t/kill-2.test: test case for MDEV-6896 sql/sql_parse.cc: Use host_or_ip instead of host as host may be 0
-
Michael Widenius authored
MDEV-6871 Multi-value insert on MyISAM table that makes slaves crash (when using --skip-external-locking=0) Problem was that repair() did lock and unlock tables, which leaved already locked tables in wrong state include/my_check_opt.h: Added option T_NO_LOCKS to disable locking during repair() Fixed duplicated bit T_NO_CREATE_RENAME_LSN mysql-test/suite/rpl/r/myisam_external_lock.result: Test case for MDEV-6871 mysql-test/suite/rpl/t/myisam_external_lock-slave.opt: Test case for MDEV-6871 mysql-test/suite/rpl/t/myisam_external_lock.test: Test case for MDEV-6871 storage/maria/ha_maria.cc: Don't lock tables during enable_indexes() Removed some calls to current_thd storage/myisam/ha_myisam.cc: Don't lock tables during enable_indexes() Removed some calls to current_thd
-
- 12 Dec, 2014 2 commits
-
-
Nirbhay Choubey authored
-
Nirbhay Choubey authored
-
- 01 Dec, 2014 1 commit
-
-
Sergey Vojtovich authored
On PPC64 high-loaded server may crash due to assertion failure in InnoDB rwlocks code. This happened because load order between "recursive" and "writer_thread" wasn't properly enforced.
-
- 03 Dec, 2014 1 commit
-
-
Jan Lindström authored
Problem is that there could be undo slots from previous runs.
-
- 02 Dec, 2014 1 commit
-
-
Jan Lindström authored
Problem is that on Windows command "perl" failed with error: 255 my_errno: 0 errno: 0. Do not run on Windows.
-
- 01 Dec, 2014 1 commit
-
-
Elena Stepanova authored
Applied the fix previously pushed into 10.0. Initial Jan's commit comment: Problem is that test could open Microsoft C++ Client Debugger windows with abort exception. Lets not try to test this on windows.
-
- 25 Nov, 2014 3 commits
-
-
Jan Lindström authored
Thanks to Daniel Black.
-
Jan Lindström authored
-
Jan Lindström authored
-
- 21 Nov, 2014 3 commits
-
-
Jan Lindström authored
-
Sergey Vojtovich authored
server This is an addition to original patch. Added full memory barrier to ensure proper StoreLoad order between waiters and lock_word on PPC64.
-
Jan Lindström authored
Use traditional statistics estimation by default (innodb-stats-traditional=true). There could be performance regression for customers if there is a lot of open table operations.
-
- 20 Nov, 2014 1 commit
-
-
Sergei Golubchik authored
-
- 19 Nov, 2014 4 commits
-
-
Sergei Golubchik authored
This came with the upgrade from yassl 2.3.0 to 2.3.4 - ssl tests started to hang on Windows. Comparing and removing changes I've got to this: void input_buffer::set_current(uint i) { - if (i) - check(i - 1, size_); - current_ = i; + if (error_ == 0 && i && check(i - 1, size_) == 0) + current_ = i; + else + error_ = -1; } in 2.3.0 i==0 was only used to avoid the check, in 2.3.4 it's an error. but there are places in the code that do set_current(0) and others that do, like, { before=get_current(); ...; set_current(before); } - and the initial value of current_ is 0. So, I suspect that set_current(0) should not be an error, but it should only skip the check().
-
Sergei Golubchik authored
followup: * explicitly disable SSLv2 and SSLv3, keep other protocols enabled * fix a compiler warning * rename the test and combinations to avoid confusion vio/viossl.c: fix a compiler warning
-
Jan Lindström authored
innodb_stats_sample_pages Analysis: If you set the number of analyzed pages to very low number compared to actual pages on that table/index it randomly pics those pages (default 8 pages), this leads to fact that query after analyze table returns different results. If the index tree is small, smaller than 10 * n_sample_pages + total_external_size, then the estimate is ok. For bigger index trees it is common that we do not see any borders between key values in the few pages we pick. But still there may be n_sample_pages different key values, or even more. And it just tries to approximate to n_sample_pages (8). Fix: (1) Introduced new dynamic configuration variable innodb_stats_sample_traditional that retains the current design. Default false. (2) If traditional sample is not used we use n_sample_pages = max(min(srv_stats_sample_pages, index->stat_index_size), log2(index->stat_index_size)* srv_stats_sample_pages); (3) Introduced new dynamic configuration variable stat_modified_counter (default = 0) if set sets lower bound for row updates when statistics is re-estimated. If user has provided upper bound for how many rows needs to be updated before we calculate new statistics we use minimum of provided value and 1/16 of table every 16th round. If no upper bound is provided (srv_stats_modified_counter = 0, default) then calculate new statistics if 1 / 16 of table has been modified since the last time a statistics batch was run. We calculate statistics at most every 16th round, since we may have a counter table which is very small and updated very often. @param t table @return true if the table has changed too much and stats need to be recalculated */ #define DICT_TABLE_CHANGED_TOO_MUCH(t) \ ((ib_int64_t) (t)->stat_modified_counter > (srv_stats_modified_counter ? \ ut_min(srv_stats_modified_counter, (16 + (t)->stat_n_rows / 16)) : \ 16 + (t)->stat_n_rows / 16))
-
Kristian Nielsen authored
The bug was that full memory barrier was missing in the code that ensures that a waiter on an InnoDB mutex will not go to sleep unless it is guaranteed to be woken up again by another thread currently holding the mutex. This made possible a race where a thread could get stuck waiting for a mutex that is in fact no longer locked. If that thread was also holding other critical locks, this could stall the entire server. There is an error monitor thread than can break the stall, it runs about once per second. But if the error monitor thread itself got stuck or was not running, then the entire server could hang infinitely. This was introduced on i386/amd64 platforms in 5.5.40 and 10.0.13 by an incorrect patch that tried to fix the similar problem for PowerPC. This commit reverts the incorrect PowerPC patch, and instead implements a fix for PowerPC that does not change i386/amd64 behaviour, making PowerPC work similarly to i386/amd64.
-
- 18 Nov, 2014 6 commits
-
-
Sergei Golubchik authored
-
Sergei Golubchik authored
change SSL methods to be SSLv23 (according to openssl manpage: "A TLS/SSL connection established with these methods may understand the SSLv2, SSLv3, TLSv1, TLSv1.1 and TLSv1.2 protocols") from TLSv1 methods, that go back to the initial SSL implementation in MySQL in 2001. OpenSSL default ciphers are different if TLSv1.2 is enabled, so tests need to take this into account.
-
Sergei Golubchik authored
-
Sergei Golubchik authored
e.g. from "error:00000001:lib(0):func(0):reason(1)" to "error:140830B5:SSL routines:SSL3_CLIENT_HELLO:no ciphers available"
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-