1. 03 Apr, 2007 2 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/data0/bk/mysql-5.0 · 63021b27
      unknown authored
      into  bk-internal.mysql.com:/data0/bk/mysql-5.0-marvel
      
      
      client/mysql.cc:
        Auto merged
      heap/hp_write.c:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_delete.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_load.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      63021b27
    • unknown's avatar
      Fix for BUG#27337: Privileges are not properly restored. · 508382eb
      unknown authored
      The problem was that THD::db_access variable was not restored after
      database switch in stored-routine-execution code.
      
      The fix is to restore THD::db_access in this case.
      
      Unfortunately, this fix requires additional changes,
      because in prepare_schema_table(), called on the parsing stage, we checked
      privileges. That was wrong according to our design, but this flaw haven't
      struck so far, because it was masked. All privilege checkings must be
      done on the execution stage in order to be compatible with prepared statements
      and stored routines. So, this patch also contains patch for
      prepare_schema_table(), which moves the checkings to the execution phase.
      
      
      mysql-test/r/grant.result:
        Updated result file.
      mysql-test/t/grant.test:
        Added test case for BUG#27337.
      sql/mysql_priv.h:
        Added function declaration.
      sql/sql_db.cc:
        Fix for BUG#27337 -- set THD::db_access even if we're called
        from stored-routine-execution code.
      sql/sql_parse.cc:
        Split prepare_schema_table() into two functions:
          - prepare_schema_table(), which is called from the parser (parsing stage);
          - check_show_access(), which is called on the execution stage.
      sql/sql_show.cc:
        Ignore schema_select_lex member if its table is NULL.
      508382eb
  2. 02 Apr, 2007 1 commit
  3. 31 Mar, 2007 6 commits
  4. 30 Mar, 2007 7 commits
    • unknown's avatar
      Merge mysql.com:/nfsdisk1/lars/bkroot/mysql-5.0-rpl · 787aaede
      unknown authored
      into  mysql.com:/nfsdisk1/lars/MERGE/mysql-5.0-merge
      
      
      sql/mysqld.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      787aaede
    • unknown's avatar
      BUG#26624, pushbuild fixes: Merge to 5.0 · c95249cd
      unknown authored
      
      mysql-test/r/range.result:
        Auto merged
      mysql-test/t/range.test:
        Auto merged
      c95249cd
    • unknown's avatar
      BUG#26624: high mem usage (crash) in range optimizer · 3c0080f0
      unknown authored
      Pushbuild fixes: 
       - Make MAX_SEL_ARGS smaller (even 16K records_in_range() calls is 
         more than it makes sense to do in typical cases)
       - Don't call sel_arg->test_use_count() if we've already allocated 
         more than MAX_SEL_ARGs elements. The test will succeed but will take
         too much time for the test suite (and not provide much value).
      
      
      mysql-test/r/range.result:
        BUG#26624: high mem usage (crash) in range optimizer
        Pushbuild fixes: make the test go faster
      mysql-test/t/range.test:
        BUG#26624: high mem usage (crash) in range optimizer
        Pushbuild fixes: make the test go faster
      3c0080f0
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-4.1 · abdcd114
      unknown authored
      into  mysql.com:/home/kent/bk/tmp/mysql-4.1-build
      
      abdcd114
    • unknown's avatar
      Bug#23233: 0 as LAST_INSERT_ID() after INSERT .. ON DUPLICATE in the · e8da4d1b
      unknown authored
      NO_AUTO_VALUE_ON_ZERO mode.
      
      In the NO_AUTO_VALUE_ON_ZERO mode the table->auto_increment_field_not_null
      variable is used to indicate that a non-NULL value was specified by the user
      for an auto_increment column. When an INSERT .. ON DUPLICATE updates the
      auto_increment field this variable is set to true and stays unchanged for the
      next insert operation. This makes the next inserted row sometimes wrongly have
      0 as the value of the auto_increment field.
      
      Now the fill_record() function resets the table->auto_increment_field_not_null
      variable before filling the record.
      The table->auto_increment_field_not_null variable is also reset by the
      open_table() function for a case if we missed some auto_increment_field_not_null
      handling bug.
      Now the table->auto_increment_field_not_null is reset at the end of the
      mysql_load() function.
      
      Reset the table->auto_increment_field_not_null variable after each
      write_row() call in the copy_data_between_tables() function.
      
      
      
      
      sql/field_conv.cc:
        Bug#23233: 0 as LAST_INSERT_ID() after INSERT .. ON DUPLICATE in the 
        NO_AUTO_VALUE_ON_ZERO mode.
        A comment is corrected.
      sql/handler.cc:
        Bug#23233: 0 as LAST_INSERT_ID() after INSERT .. ON DUPLICATE in the 
        NO_AUTO_VALUE_ON_ZERO mode.
        Now the handler::update_auto_increment() function doesn't reset the
        table->auto_increment_field_not_null variable as it is done in the
        fill_record() function.
      sql/sql_base.cc:
        Bug#23233: 0 as LAST_INSERT_ID() after INSERT .. ON DUPLICATE in the 
        NO_AUTO_VALUE_ON_ZERO mode.
        Now the fill_record() function resets the table->auto_increment_field_not_null
        variable before filling the record.
        The table->auto_increment_field_not_null variable is also reset by the
        open_table() function for a case if we missed some auto_increment_field_not_null
        handling bug.
      sql/sql_insert.cc:
        Bug#23233: 0 as LAST_INSERT_ID() after INSERT .. ON DUPLICATE in the
        NO_AUTO_VALUE_ON_ZERO mode.
        Now the the table->auto_increment_field_not_null is reset at the end of the
        mysql_insert() an in the select_insert class destructor.
      sql/sql_load.cc:
        Bug#23233: 0 as LAST_INSERT_ID() after INSERT .. ON DUPLICATE in the 
        NO_AUTO_VALUE_ON_ZERO mode.
        Now the table->auto_increment_field_not_null is reset at the end of the
        mysql_load() function.
      sql/sql_table.cc:
        Bug#23233: 0 as LAST_INSERT_ID() after INSERT .. ON DUPLICATE in the
        NO_AUTO_VALUE_ON_ZERO mode.
        Reset the table->auto_increment_field_not_null variable after each
        write_row() call in the copy_data_between_tables() function.
      sql/table.h:
        Bug#23233: 0 as LAST_INSERT_ID() after INSERT .. ON DUPLICATE in the
        NO_AUTO_VALUE_ON_ZERO mode.
        A comment added.
      mysql-test/r/insert_update.result:
        Added the test case for the bug#23233: 0 as LAST_INSERT_ID() after
        INSERT .. ON DUPLICATE in the NO_AUTO_VALUE_ON_ZERO mode.
      mysql-test/t/insert_update.test:
        Added the test case for the bug#23233: 0 as LAST_INSERT_ID() after
        INSERT .. ON DUPLICATE in the NO_AUTO_VALUE_ON_ZERO mode.
      e8da4d1b
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 2fabc70c
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.0-axmrg
      
      
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/ha_ndbcluster.h:
        Auto merged
      2fabc70c
    • unknown's avatar
      Merge abarkov@bk-internal.mysql.com:/home/bk/mysql-5.0-rpl · c7a3ae34
      unknown authored
      into  mysql.com:/home/bar/mysql-5.0.b22638
      
      c7a3ae34
  5. 29 Mar, 2007 18 commits
  6. 28 Mar, 2007 6 commits
    • unknown's avatar
      configure.in: · c566b272
      unknown authored
        Don't install ndb man pages if no ndb configured
      config-win.h, CMakeLists.txt, README, configure.js:
        Removed Cybozu patches
      
      
      configure.in:
        Don't install ndb man pages if no ndb configured
      CMakeLists.txt:
        Removed Cybozu patches
      include/config-win.h:
        Removed Cybozu patches
      win/README:
        Removed Cybozu patches
      win/configure.js:
        Removed Cybozu patches
      c566b272
    • unknown's avatar
      Merge ua141d10.elisa.omakaista.fi:/home/my/bk/mysql-4.1-main · dffc97e4
      unknown authored
      into  ua141d10.elisa.omakaista.fi:/home/my/bk/mysql-5.0-marvel
      
      
      BitKeeper/deleted/.del-_dynrec.c~48dd758f5a5450df:
        Auto merged
      BitKeeper/deleted/.del-_page.c~148b1a613d052ee8:
        Auto merged
      BitKeeper/deleted/.del-_search.c~f509292aa1ff18ff:
        Auto merged
      BitKeeper/deleted/.del-close.c~fd62629496ee5bcc:
        Auto merged
      BitKeeper/deleted/.del-delete.c~65ee8daaa75a14b6:
        Auto merged
      BitKeeper/deleted/.del-my_tempnam.c~a8562f15dad3012f:
        Auto merged
      BitKeeper/deleted/.del-open.c~95b3b75042fae00a:
        Auto merged
      BitKeeper/deleted/.del-rkey.c~cc54c6498352f999:
        Auto merged
      client/mysql.cc:
        Auto merged
      client/mysqldump.c:
        Auto merged
      include/my_sys.h:
        Auto merged
      include/raid.h:
        Auto merged
      myisam/mi_close.c:
        Auto merged
      BitKeeper/deleted/.del-sort.c~e2e56b5a37ce86f4:
        Auto merged
      BitKeeper/deleted/.del-write.c~8f1918b1f6770e54:
        Auto merged
      myisam/mi_page.c:
        Auto merged
      myisam/myisamchk.c:
        Auto merged
      mysys/default.c:
        Auto merged
      mysys/mf_keycaches.c:
        Auto merged
      mysys/my_dup.c:
        Auto merged
      mysys/my_fopen.c:
        Auto merged
      mysys/my_handler.c:
        Auto merged
      mysys/my_malloc.c:
        Auto merged
      mysys/my_static.c:
        Auto merged
      mysys/my_write.c:
        Auto merged
      mysys/safemalloc.c:
        Auto merged
      mysys/tree.c:
        Auto merged
      mysys/typelib.c:
        Auto merged
      regex/regexec.c:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/sql_repl.cc:
        Auto merged
      sql-common/my_time.c:
        Auto merged
      BitKeeper/deleted/.del-compiler_warnings.supp:
        Delete: support-files/compiler_warnings.supp
      client/mysqlbinlog.cc:
        Manual merge from 4.1.
      client/sql_string.cc:
        Manual merge from 4.1.
      extra/perror.c:
        Manual merge from 4.1.
      heap/_check.c:
        Manual merge from 4.1.
      heap/hp_delete.c:
        Manual merge from 4.1.
      heap/hp_hash.c:
        Manual merge from 4.1.
      heap/hp_open.c:
        Manual merge from 4.1.
      heap/hp_rkey.c:
        Manual merge from 4.1.
      heap/hp_rrnd.c:
        Manual merge from 4.1.
      heap/hp_write.c:
        Manual merge from 4.1.
      libmysql/libmysql.c:
        Manual merge from 4.1.
      libmysqld/libmysqld.c:
        Manual merge from 4.1.
      myisam/mi_delete.c:
        Manual merge from 4.1.
      myisam/mi_dynrec.c:
        Manual merge from 4.1.
      myisam/mi_keycache.c:
        Manual merge from 4.1.
      myisam/mi_statrec.c:
        Manual merge from 4.1.
      myisammrg/myrg_extra.c:
        Manual merge from 4.1.
      mysys/hash.c:
        Manual merge from 4.1.
      mysys/list.c:
        Manual merge from 4.1.
      mysys/mf_iocache.c:
        Manual merge from 4.1.
      mysys/mf_keycache.c:
        Manual merge from 4.1.
      mysys/my_alloc.c:
        Manual merge from 4.1.
      mysys/my_fstream.c:
        Manual merge from 4.1.
      mysys/my_getwd.c:
        Manual merge from 4.1.
      mysys/my_lib.c:
        Manual merge from 4.1.
      mysys/my_lread.c:
        Manual merge from 4.1.
      mysys/my_lwrite.c:
        Manual merge from 4.1.
      mysys/my_pread.c:
        Manual merge from 4.1.
      mysys/my_read.c:
        Manual merge from 4.1.
      mysys/my_realloc.c:
        Manual merge from 4.1.
      mysys/my_seek.c:
        Manual merge from 4.1.
      mysys/raid.cc:
        Manual merge from 4.1.
      mysys/thr_lock.c:
        Manual merge from 4.1.
      ndb/src/mgmclient/CommandInterpreter.cpp:
        Manual merge from 4.1.
      sql/ha_archive.cc:
        Manual merge from 4.1.
      sql/ha_innodb.cc:
        Manual merge from 4.1.
      sql/ha_ndbcluster.cc:
        Manual merge from 4.1.
      sql/item_subselect.cc:
        Manual merge from 4.1.
      sql/log.cc:
        Manual merge from 4.1.
      sql/log_event.cc:
        Manual merge from 4.1.
      sql/mysqld.cc:
        Manual merge from 4.1.
      sql/net_serv.cc:
        Manual merge from 4.1.
      sql/slave.cc:
        Manual merge from 4.1.
      sql/sql_cache.cc:
        Manual merge from 4.1.
      sql/sql_class.cc:
        Manual merge from 4.1.
      sql/sql_delete.cc:
        Manual merge from 4.1.
      sql/sql_parse.cc:
        Manual merge from 4.1.
      sql/sql_prepare.cc:
        Manual merge from 4.1.
      sql-common/client.c:
        Manual merge from 4.1.
      sql/sql_select.cc:
        Manual merge from 4.1.
      sql/sql_table.cc:
        Manual merge from 4.1.
      sql/sql_update.cc:
        Manual merge from 4.1.
      sql/strfunc.cc:
        Manual merge from 4.1.
      sql/table.cc:
        Manual merge from 4.1.
      sql/tztime.cc:
        Manual merge from 4.1.
      sql/unireg.cc:
        Manual merge from 4.1.
      tests/mysql_client_test.c:
        Manual merge from 4.1.
      dffc97e4
    • unknown's avatar
      Merge mysql.com:/home/psergey/mysql-4.1-bug26625 · 3362a93e
      unknown authored
      into  mysql.com:/home/psergey/mysql-4.1-bug26624-r2
      
      3362a93e
    • unknown's avatar
      BUG#26624: high mem usage (crash) in range optimizer · 968f7b47
      unknown authored
      - Added PARAM::alloced_sel_args where we count the # of SEL_ARGs
        created by SEL_ARG tree cloning operations.
      - Made the range analyzer to shortcut and not do any more cloning 
        if we've already created MAX_SEL_ARGS SEL_ARG objects in cloning.
      - Added comments about space complexity of SEL_ARG-graph 
        representation.
      
      
      mysql-test/r/range.result:
        BUG#26624: Testcase
      mysql-test/t/range.test:
        BUG#26624: Testcase
      968f7b47
    • unknown's avatar
      BUG#25521 - optimize table, delete, show table status leads to table · fe689587
      unknown authored
                  losing it's .MYD
      
      When OPTIMIZE TABLE is completed it attempts to rename temporary
      file to original name. This step may fail on windows when a file
      is opened. As a result data file might be deleted and optimized
      copy of file (table_name.MYD) remains.
      
      This situation is handled properly by my_delete_allow_opened, so
      use it instead of my_delete when attempting to rename a file on
      windows.
      
      No suitable test case for this bug.
      
      
      mysys/my_redel.c:
        Attempting to delete an opened file and to immediately create
        a new one with the same name may result in my_redel failure on
        windows. It may fail because file is not deleted until it is
        closed.
        
        This situation is handled properly by my_delete_allow_opened, so
        use it instead of my_delete.
      fe689587
    • unknown's avatar
      Delete: sql/mysqld.cc.rej · 5cc44c1c
      unknown authored
      5cc44c1c