1. 15 Jul, 2008 2 commits
    • Sergey Petrunia's avatar
      Merge · 63bfaa46
      Sergey Petrunia authored
      63bfaa46
    • Sergey Petrunia's avatar
      BUG#35478: sort_union() returns bad data when sort_buffer_size is hit · 2951f00b
      Sergey Petrunia authored
      - In QUICK_INDEX_MERGE_SELECT::read_keys_and_merge: when we got table->sort from Unique,
        tell init_read_record() not to use rr_from_cache() because a) rowids are already sorted
        and b) it might be that the the data is used by filesort(), which will need record rowids
        (which rr_from_cache() cannot provide).
      - Fully de-initialize the table->sort read in QUICK_INDEX_MERGE_SELECT::get_next(). This fixes BUG#35477.
      (bk trigger: file as fix for BUG#35478).
      2951f00b
  2. 14 Jul, 2008 2 commits
    • Marc Alff's avatar
      Merge · 504f7e2d
      Marc Alff authored
      504f7e2d
    • Marc Alff's avatar
      Bug#35577 (CREATE PROCEDURE causes either crash or syntax error depending on · 0816ee6d
      Marc Alff authored
      build)
      
      The crash was caused by freeing the internal parser stack during the parser
      execution.
      This occured only for complex stored procedures, after reallocating the parser
      stack using my_yyoverflow(), with the following C call stack:
      - MYSQLparse()
      - any rule calling sp_head::restore_lex()
      - lex_end()
      - x_free(lex->yacc_yyss), xfree(lex->yacc_yyvs)
      
      The root cause is the implementation of stored procedures, which breaks the
      assumption from 4.1 that there is only one LEX structure per parser call.
      
      The solution is to separate the LEX structure into:
      - attributes that represent a statement (the current LEX structure),
      - attributes that relate to the syntax parser itself (Yacc_state),
      so that parsing multiple statements in stored programs can create multiple
      LEX structures while not changing the unique Yacc_state.
      
      Now, Yacc_state and the existing Lex_input_stream are aggregated into
      Parser_state, a structure that represent the complete state of the (Lexical +
      Syntax) parser.
      0816ee6d
  3. 10 Jul, 2008 4 commits
  4. 09 Jul, 2008 3 commits
  5. 08 Jul, 2008 2 commits
  6. 07 Jul, 2008 3 commits
    • Marc Alff's avatar
      Merge · 68925ec2
      Marc Alff authored
      68925ec2
    • Marc Alff's avatar
      Bug#26030 (Parsing fails for stored routine w/multi-statement execution · f3ff1aeb
      Marc Alff authored
      enabled)
      
      Before this fix, the lexer and parser would treat the ';' character as a
      different token (either ';' or END_OF_INPUT), based on convoluted logic,
      which failed in simple cases where a stored procedure is implemented as a
      single statement, and used in a multi query.
      
      With this fix:
      - the character ';' is always parsed as a ';' token in the lexer,
      - parsing multi queries is implemented in the parser, in the 'query:' rules,
      - the value of thd->client_capabilities, which is the capabilities
        negotiated between the client and the server during bootstrap,
        is immutable and not arbitrarily modified during parsing (which was the
        root cause of the bug)
      f3ff1aeb
    • Mats Kindahl's avatar
      Bug #37150 Risk for crash in User_var_log_event::exec_event() · b9d6d4c0
      Mats Kindahl authored
      On certain kinds of errors (e.g., out of stack), a call to Item_func_
      set_user_var::fix_fields() might fail.  Since the return value of this
      call was not checked inside User_var_log_event::exec_event(), continuing
      execution after this will cause a crash inside Item_func_set_user_var::
      update_hash().
      
      The bug is fixed by aborting execution of the event with an error if
      fix_fields() fails, since it is not possible to continue execution anyway.
      b9d6d4c0
  7. 04 Jul, 2008 2 commits
  8. 02 Jul, 2008 1 commit
  9. 01 Jul, 2008 1 commit
    • Patrick Crews's avatar
      Bug#37380 - Test funcs_1.is_columns_myisam_embedded fails on OS X · 8d5dc3a5
      Patrick Crews authored
      Test was failing due to the addition of a '\x05' character in result sets
      Latest builds of the server have shown this problem to have disappeared.
      Removing code within the test that disables the test on Mac OS X.
      
      Recommit due to tree error on earlier, approved patch.
      8d5dc3a5
  10. 30 Jun, 2008 1 commit
    • Matthias Leich's avatar
      Fix for · dd7bc1a6
      Matthias Leich authored
         Bug#36787 Test funcs_1.charset_collation_1 failing
      Details:
      1. Skip charset_collation_1 if charset "ucs2_bin" is
         missing (property which distincts "vanilla" builds
         from the others)
      2. Let builds with version_comment LIKE "%Advanced%"
         (found them for 5.1) execute charset_collation_3.
      3. Update comments charset_collation.inc so that they
         reflect the current experiences.
      dd7bc1a6
  11. 27 Jun, 2008 2 commits
    • Timothy Smith's avatar
      Merge from upstream (my:5.0-bugteam) · 7553eece
      Timothy Smith authored
      7553eece
    • Gleb Shchepa's avatar
      backport from 6.0 · 790edf00
      Gleb Shchepa authored
            
      Bug#35658 (An empty binary value leads to mysqld crash)
              
      Before this fix, the following token
        b''
      caused the parser to crash when reading the binary value from the empty string.
      The crash was caused by:
        ptr+= max_length - 1;
      because max_length is unsigned and was 0, causing an overflow.
              
      With this fix, an empty binary literal b'' is parsed as a binary value 0,
      in Item_bin_string.
      790edf00
  12. 25 Jun, 2008 2 commits
  13. 24 Jun, 2008 3 commits
  14. 18 Jun, 2008 1 commit
    • Matthias Leich mleich@mysql.com's avatar
      Fix for · 9b6a012c
      Matthias Leich mleich@mysql.com authored
           Bug#37167 funcs_1: Many tests fail if the embedded server is used.
           Bug#37164 funcs_1: Some tests fail if an optional character set is missing.
      + some cleanup within the testsuite related to the fixes above
      + some adjustments to open bugs on Mac OS X
      9b6a012c
  15. 17 Jun, 2008 3 commits
  16. 16 Jun, 2008 2 commits
    • Matthias Leich mleich@mysql.com's avatar
      Fix for · 00c19cd8
      Matthias Leich mleich@mysql.com authored
         Bug#37167 funcs_1: Many tests fail if the embedded server is used.
         Bug#37164 funcs_1: Some tests fail if an optional character set is missing.
      + some cleanup within the testsuite related to the fixes above
      + some adjustments to open bugs on Mac OS X
      
      Details:
      - Remove the initial loading of data from tests if these data
        are not somewhere retrieved
      - Remove any use of columns with attribute unicode
        (-> UCS2 is no more needed) from tests where unicode
        properties are not checked or somehow required
      - Create a separate branch of the Character maximum length test
        (CML). If UCS2 is available than this test gets applied to
        every available type of string column with attribute unicode
        This prevents any loss of coverage by the points above.
      - Disable the execution of is_tables_ndb which gives wrong
        results because of a bug. Correct the exepected results of
        this test.
      - In case of tests failing when applied to the embedded server
          1) Create a variant of this test for the embedded server
        or
          2) Skip the test in case of embedded server
        depending on purpose and complexity of test.
      - Skip the tests which could suffer from
        Bug 28309 First insert violates unique constraint - was "memory" table empty ?
        Bug 37380 Test funcs_1.is_columns_myisam_embedded fails on OS X
        (both bugs Mac OS X, embedded server, MySQL 5.0 only)
      - Minor improvements like remove typos
      00c19cd8
    • Hakan Kuecuekyilmaz's avatar
      Fix for Bug#16902. · d6700c7e
      Hakan Kuecuekyilmaz authored
      d6700c7e
  17. 13 Jun, 2008 2 commits
  18. 12 Jun, 2008 1 commit
  19. 10 Jun, 2008 2 commits
  20. 03 Jun, 2008 1 commit