1. 18 Apr, 2006 1 commit
    • unknown's avatar
      Fixed BUG#18949: Test case sp-goto is disabled · 661165ee
      unknown authored
        Removed sp-goto.test, sp-goto.result and all (disabled) GOTO code.
        Also removed some related code that's not needed any more (no possible
        unresolved label references any more, so no need to check for them).
        NB: Keeping the ER_SP_GOTO_IN_HNDLR in errmsg.txt; it might become useful
            in the future, and removing it (and thus re-enumerating error codes)
            might upset things. (Anything referring to explicit error codes.)
      
      
      BitKeeper/deleted/.del-sp-goto.result~f343103c63f64b7a:
        Delete: mysql-test/r/sp-goto.result
      BitKeeper/deleted/.del-sp-goto.test~5054d3f729692d3d:
        Delete: mysql-test/t/sp-goto.test
      mysql-test/t/disabled.def:
        sp-goto.test no longer exists.
      sql/lex.h:
        Removed (disabled) GOTO definitions.
      sql/sp_head.cc:
        Removed sp_head::check_backpatch() and simplified sp_head::backpatch().
        Without GOTO, unresolved label references are not possible, so no need
        to check for them.
      sql/sp_head.h:
        Removed sp_head::check_backpatch(). (Not needed with no GOTO)
      sql/sp_pcontext.cc:
        SP_LAB_GOTO was renamed to SP_LAB_IMPL
      sql/sp_pcontext.h:
        Removed SP_LAB_REF (no longer needed) and renamed SP_LAB_GOTO
        to SP_LAB_IMPL, since it's only used for implicit labels now.
      sql/sql_yacc.yy:
        Removed GOTO symbols and (disabled) code, and the no longer needed
        sp_head::check_backpatch() calls.
      661165ee
  2. 12 Apr, 2006 4 commits
    • unknown's avatar
      Merge mysql.com:/home/tomash/src/mysql_ab/mysql-5.0 · aadfa648
      unknown authored
      into  mysql.com:/home/tomash/src/mysql_ab/mysql-5.0-bug15933
      
      
      aadfa648
    • unknown's avatar
      Bug#16461: connection_id() does not work properly inside trigger · 886a35bd
      unknown authored
      CONNECTION_ID() was implemented as a constant Item, i.e. an instance of
      Item_static_int_func class holding value computed at creation time.
      Since Items are created on parsing, and trigger statements are parsed
      on table open, the first connection to open a particular table would
      effectively set its own CONNECTION_ID() inside trigger statements for
      that table.
      
      Re-implement CONNECTION_ID() as a class derived from Item_int_func, and
      compute connection_id on every call to fix_fields().
      
      
      mysql-test/r/trigger.result:
        Add result for bug#16461.
      mysql-test/t/trigger.test:
        Add test case for bug#16461.
      sql/item.cc:
        Remove now unused class Item_static_int_func.
      sql/item.h:
        Remove now unused class Item_static_int_func.
      sql/item_create.cc:
        Use new implementation of CONNECTION_ID().
      sql/item_func.cc:
        Re-implement CONNECTION_ID() as Item_func_connection_id
        (was Item_static_int_func).  Set max_length to 10, as it was before.
        Compute connection_id dynamically on every call to fix_fields().
      sql/item_func.h:
        Re-implement CONNECTION_ID() as Item_func_connection_id
        (was Item_static_int_func).
      886a35bd
    • unknown's avatar
      Merge mysql.com:/home/tomash/src/mysql_ab/mysql-5.0 · 1dc282ae
      unknown authored
      into  mysql.com:/home/tomash/src/mysql_ab/mysql-5.0-bug15933
      
      
      1dc282ae
    • unknown's avatar
      In test for bug#15933 we have to wait for all disconnects to finish to avoid · 51a3d366
      unknown authored
      a race between updating and checking Max_used_connections.  This is done in
      a loop until either disconnect finished or timeout expired.  In a latter case
      the test will fail.
      
      
      mysql-test/r/status.result:
        Update result to match changes in test case.
      mysql-test/t/status.test:
        Close extra conections in previous test.
        In test for bug#15933 we have to wait for all disconnects to finish to avoid
        a race between updating and checking Max_used_connections.  This is done in
        a loop until either disconnect finished or timeout expired.  In a latter case
        the test will fail.
        Use con1, con2, con3 instead of con3, con4, con5.
      51a3d366
  3. 07 Apr, 2006 3 commits
    • unknown's avatar
      Merge mysql.com:/extern/mysql/bk/mysql-5.0-runtime · daac3886
      unknown authored
      into  mysql.com:/extern/mysql/5.0/generic/mysql-5.0-runtime
      
      
      daac3886
    • unknown's avatar
      Renaming sp_pcontext members and methods; less cryptic and more consistent. · 148cf113
      unknown authored
      Also added comments, and fixing some coding style (mostly in comments too).
      There are no functional changes, so no tests or documentation needed.
      (This was originally part of a bugfix, but it was decided to not include this
       in that patch; instead it's done separately.)
      
      
      sql/sp_head.cc:
        Renaming sp_pcontext members and methods; less cryptic and more consistent.
      sql/sp_head.h:
        Renaming sp_pcontext members and methods; less cryptic and more consistent.
      sql/sp_pcontext.cc:
        Renaming sp_pcontext members and methods; less cryptic and more consistent.
        Also added comments, and fixing some coding style (mostly in comments too).
      sql/sp_pcontext.h:
        Renaming sp_pcontext members and methods; less cryptic and more consistent.
        Also added comments, and fixing some coding style (mostly in comments too).
      sql/sp_rcontext.cc:
        Renaming sp_pcontext members and methods; less cryptic and more consistent.
      sql/sp_rcontext.h:
        Renaming sp_pcontext members and methods; less cryptic and more consistent.
      sql/sql_yacc.yy:
        Renaming sp_pcontext members and methods; less cryptic and more consistent.
      148cf113
    • unknown's avatar
      Bug#15933: max_used_connections is wrong after FLUSH STATUS if connections are cached · cab73a60
      unknown authored
      After FLUSH STATUS max_used_connections was reset to 0, and haven't
      been updated while cached threads were reused, until the moment a new
      thread was created.
      
      The first suggested fix from original bug report was implemented:
      
        a) On flushing the status, set max_used_connections to
        threads_connected, not to 0.
      
        b) Check if it is necessary to increment max_used_connections when
        taking a thread from the cache as well as when creating new threads
      
      
      mysql-test/r/status.result:
        Add result for bug#15933.
      mysql-test/t/status.test:
        Add test case for bug#15933.
        Fixed typo.
      sql/mysql_priv.h:
        Add declaration of refresh_status(), which is now external.
      sql/mysqld.cc:
        Remove start_cached_thread() (code moved directly into create_new_thread()).
        Add comment for create_new_thread ().
        In create_new_thread() update max_used_connections when creating new thread
        and when reusing the cached one.
        Move refresh_status() from sql/sql_parse.cc here, on refresh set
        max_used_connections to the current number of connections.
      sql/sql_parse.cc:
        refresh_status() moved to sql/mysqld.cc.
      cab73a60
  4. 03 Apr, 2006 5 commits
    • unknown's avatar
      yassl link problem fixed · 70f4dbaa
      unknown authored
      
      config/ac-macros/yassl.m4:
        typo
      libmysql/Makefile.am:
        move common code to Makefile.shared
      libmysql/Makefile.shared:
        move common code to Makefile.shared
      libmysql_r/Makefile.am:
        move common code to Makefile.shared
      70f4dbaa
    • unknown's avatar
      Merge · b5ca7236
      unknown authored
      
      scripts/mysql_install_db.sh:
        Auto merged
      b5ca7236
    • unknown's avatar
      Makefile.am: · 2574445e
      unknown authored
        Distribute mysql-test-run.pl
      
      
      mysql-test/Makefile.am:
        Distribute mysql-test-run.pl
      2574445e
    • unknown's avatar
      Merge mysql.com:/Users/kent/mysql/bk/mysql-4.0 · d2744ebc
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-4.1-new
      
      
      scripts/mysql_install_db.sh:
        Auto merged
      d2744ebc
    • unknown's avatar
      mysql_install_db.sh, MySQLEULA.txt, mysql_install_db.c: · e2b19a59
      unknown authored
        Changed web address order.mysql.com to shop.mysql.com
      
      
      netware/mysql_install_db.c:
        Changed web address order.mysql.com to shop.mysql.com
      Docs/MySQLEULA.txt:
        Changed web address order.mysql.com to shop.mysql.com
      scripts/mysql_install_db.sh:
        Changed web address order.mysql.com to shop.mysql.com
      e2b19a59
  5. 02 Apr, 2006 1 commit
    • unknown's avatar
      Makefile.am: · 6de1d9d3
      unknown authored
        Install Perl mysql-test-run into test directory
      
      
      mysql-test/Makefile.am:
        Install Perl mysql-test-run into test directory
      6de1d9d3
  6. 01 Apr, 2006 11 commits
    • unknown's avatar
      Merge · a6871e27
      unknown authored
      a6871e27
    • unknown's avatar
      Makefile.am: · 2a4e2e8d
      unknown authored
        Let "make install" install mysql-test-run.pl
      mysql.spec.sh:
        Set $LDFLAGS from $MYSQL_BUILD_LDFLAGS (bug#16662)
      
      
      support-files/mysql.spec.sh:
        Set $LDFLAGS from $MYSQL_BUILD_LDFLAGS (bug#16662)
      mysql-test/Makefile.am:
        Let "make install" install mysql-test-run.pl
      2a4e2e8d
    • unknown's avatar
      Merge mysql.com:/Users/kent/mysql/bk/mysql-4.0 · 3eb7f2a2
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-4.1-new
      
      
      README:
        Auto merged
      3eb7f2a2
    • unknown's avatar
      README: · c19a6fc5
      unknown authored
        Typo (bug#17167)
      
      
      README:
        Typo (bug#17167)
      c19a6fc5
    • unknown's avatar
      zlib.m4: · 3ff1ec0f
      unknown authored
        Use CPPFLAGS when testing to link "libz" found in --with-zlib-dir=,
        and search the given include directory first (bug#18369)
      
      
      config/ac-macros/zlib.m4:
        Use CPPFLAGS when testing to link "libz" found in --with-zlib-dir=,
        and search the given include directory first (bug#18369)
      3ff1ec0f
    • unknown's avatar
      Merge mysql.com:/Users/kent/mysql/bk/mysql-4.1-new · 381e1fce
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-5.0-new
      
      
      BitKeeper/deleted/.del-acinclude.m4~f4ab416bac5003:
        Auto merged
      381e1fce
    • unknown's avatar
      acinclude.m4: · 1f762dab
      unknown authored
        Use CPPFLAGS when testing to link "libz" found in --with-zlib-dir=,
        and search the given include directory first (bug#18369)
      
      
      acinclude.m4:
        Use CPPFLAGS when testing to link "libz" found in --with-zlib-dir=,
        and search the given include directory first (bug#18369)
      1f762dab
    • unknown's avatar
      Merge mysql.com:/Users/kent/mysql/bk/mysql-4.1-new · 835d2286
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-5.0-new
      
      
      VC++Files/libmysqld/libmysqld.vcproj:
        Auto merged
      VC++Files/mysys/mysys.vcproj:
        Auto merged
      VC++Files/sql/mysqld.vcproj:
        Auto merged
      835d2286
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-5.0 · ab96fa07
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-5.0-new
      
      
      ab96fa07
    • unknown's avatar
      Merge aivanov@bk-internal.mysql.com:/home/bk/mysql-5.0 · a432c53f
      unknown authored
      into  mysql.com:/home/alexi/innodb/mysql-5.0-merged
      
      
      a432c53f
    • unknown's avatar
      vcproj files: · 0ad405f9
      unknown authored
        Set MYSQL_SERVER_SUFFIX from build scripts, not hard
        code it into Visual Studio project files, bug#15974
      
      
      VC++Files/bdb/bdb.vcproj:
        Set MYSQL_SERVER_SUFFIX from build scripts, not hard code into project files, bug#15974
      VC++Files/innobase/innobase.vcproj:
        Set MYSQL_SERVER_SUFFIX from build scripts, not hard code into project files, bug#15974
      VC++Files/libmysqld/libmysqld.vcproj:
        Set MYSQL_SERVER_SUFFIX from build scripts, not hard code into project files, bug#15974
      VC++Files/mysqldemb/mysqldemb.vcproj:
        Set MYSQL_SERVER_SUFFIX from build scripts, not hard code into project files, bug#15974
      VC++Files/mysys/mysys.vcproj:
        Set MYSQL_SERVER_SUFFIX from build scripts, not hard code into project files, bug#15974
      VC++Files/sql/mysqld.vcproj:
        Set MYSQL_SERVER_SUFFIX from build scripts, not hard code into project files, bug#15974
      0ad405f9
  7. 31 Mar, 2006 6 commits
    • unknown's avatar
      Makefile.am, yassl.m4: · 872d1d71
      unknown authored
        Enable automake to determine dependency on yaSSL, by explicitly
        listing the .la files in Makefile.am, instead of using
        'yassl_libs_with_path', bug#18273
      
      
      config/ac-macros/yassl.m4:
        Enable automake to determine dependency on yaSSL, by explicitly
        listing the .la files in Makefile.am, instead of using
        'yassl_libs_with_path', bug#18273
      libmysql/Makefile.am:
        Enable automake to determine dependency on yaSSL, by explicitly
        listing the .la files in Makefile.am, instead of using
        'yassl_libs_with_path', bug#18273
      libmysql_r/Makefile.am:
        Enable automake to determine dependency on yaSSL, by explicitly
        listing the .la files in Makefile.am, instead of using
        'yassl_libs_with_path', bug#18273
      872d1d71
    • unknown's avatar
      Merge aivanov@bk-internal.mysql.com:/home/bk/mysql-5.0 · 87c70a59
      unknown authored
      into  mysql.com:/home/alexi/innodb/mysql-5.0-merged
      
      
      87c70a59
    • unknown's avatar
      Applied innodb-5.0-ss398 snapshot. · f6ffb77c
      unknown authored
       Fixed BUG#15650: DELETE with LEFT JOIN crashes server
       with innodb_locks_unsafe_for_binlog.
       Fixed compilation problem with non-C99 compilers
       in btr0sea.c
      
      
      innobase/btr/btr0sea.c:
        Applied innodb-5.0-ss398 snapshot.
         Fix compilation problem with non-C99 compilers.
      sql/ha_innodb.cc:
        Applied innodb-5.0-ss398 snapshot.
         Remove assertion ut_error which crashes the mysqld
         server if it prints a warning about the adaptive latch.
      f6ffb77c
    • unknown's avatar
      Fixed a typo. · 1de12691
      unknown authored
      1de12691
    • unknown's avatar
      Merge mysql.com:/home/timka/mysql/src/5.0-virgin · 085aa5c9
      unknown authored
      into  mysql.com:/home/timka/mysql/src/5.0-bug-16710
      
      
      mysql-test/r/group_min_max.result:
        Auto merged
      mysql-test/t/group_min_max.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      085aa5c9
    • unknown's avatar
      Fix for BUG#16710. · a01d48f9
      unknown authored
      The bug was due to a missed case in the detection of whether an index
      can be used for loose scan. More precisely, the range optimizer chose
      to use loose index scan for queries for which the condition(s) over
      an index key part could not be pushed to the index together with the
      loose scan.
      
      As a result, loose index scan was selecting the first row in the
      index with a given GROUP BY prefix, and was applying the WHERE
      clause after that, while it should have inspected all rows with
      the given prefix, and apply the WHERE clause to all of them.
      
      The fix detects and skips such cases.
      
      
      mysql-test/r/group_min_max.result:
        Added test for BUG#16710.
      mysql-test/t/group_min_max.test:
        Added test for BUG#16710.
      sql/item.cc:
        Added new method [Item | Item_field]::find_item_in_field_list_processor.
      sql/item.h:
        Added new method [Item | Item_field]::find_item_in_field_list_processor.
      sql/opt_range.cc:
        Handle the case when there is no MIN/MAX aggregate function, and a
        keypart of the index being considered, that is after the GROUP BY
        prefix, is used in the WHERE clause and the condition where it is
        used cannot be pushed to the index.
        If this is the case, we rule out this index.
      a01d48f9
  8. 30 Mar, 2006 9 commits