1. 28 Jun, 2005 1 commit
    • unknown's avatar
      group_by.result, group_by.test: · 67abd491
      unknown authored
        Added a test case for bug #11414.
      sql_select.cc:
        Fixed bug #11414: crash on Windows with some simple
        GROUP BY queries.
        It happened to an allocation of an array containing
        0 Copy_field elements in setup_copy_fields.
        The bug had been already fixed in 5.0.
      
      
      sql/sql_select.cc:
        Fixed bug #11414: crash on Windows with some simple
        GROUP BY queries.
        It happened to an allocation of an array containing
        0 Copy_field elements in setup_copy_fields.
        The bug had been already fixed in 5.0.
      mysql-test/t/group_by.test:
        Added a test case for bug #11414.
      mysql-test/r/group_by.result:
        Added a test case for bug #11414.
      67abd491
  2. 25 Jun, 2005 1 commit
  3. 24 Jun, 2005 3 commits
    • unknown's avatar
      Bug#10178 - failure to find a row in heap table by concurrent UPDATEs · a7e66efc
      unknown authored
      Moved the key statistics update to info().
      The table is not locked in open(). This made wrong stats possible.
      
      No test case for the test suite.
      This happens only with heavy concurrency.
      A test script is added to the bug report.
      
      
      mysql-test/r/heap_hash.result:
        Bug#10178 - failure to find a row in heap table by concurrent UPDATEs
        Updated test results to reflect the new  statistics behaviour.
      mysql-test/t/heap_hash.test:
        Bug#10178 - failure to find a row in heap table by concurrent UPDATEs
        Added a FLUSH TABLES to avoid statistics differences between normal 
        and ps-protocol tests.
      sql/ha_heap.cc:
        Bug#10178 - failure to find a row in heap table by concurrent UPDATEs
        Moved the key statistics update to info().
        The table is not locked in open(). This made wrong stats possible.
      sql/ha_heap.h:
        Bug#10178 - failure to find a row in heap table by concurrent UPDATEs
        Added an element to track the validity of the key statistics.
      a7e66efc
    • unknown's avatar
    • unknown's avatar
      an improvement (bug #7851: C++ 'new' conflicts with kernel header asm/system.h). · 77dc5c42
      unknown authored
      
      include/my_global.h:
        an improvement (bug #7851: C++ 'new' conflicts with kernel header asm/system.h).
        redefine 'new' before #include <asm/atomic.h> in any case.
      77dc5c42
  4. 23 Jun, 2005 18 commits
    • unknown's avatar
      Merge tkatchaounov@bk-internal.mysql.com:/home/bk/mysql-4.1 · 22882964
      unknown authored
      into mysql.com:/home/timka/mysql/src/4.1-virgin
      
      
      22882964
    • unknown's avatar
      Merge ibabaev@bk-internal.mysql.com:/home/bk/mysql-4.1 · 26576e90
      unknown authored
      into rurik.mysql.com:/home/igor/mysql-4.1
      
      
      26576e90
    • unknown's avatar
      Merge tkatchaounov@bk-internal.mysql.com:/home/bk/mysql-4.1 · 5d12a0bf
      unknown authored
      into mysql.com:/home/timka/mysql/src/4.1-virgin
      
      
      5d12a0bf
    • unknown's avatar
      Merge mysql.com:/Users/kent/mysql/bk/mysql-4.1-gca · 7ed5026d
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-4.1
      
      
      7ed5026d
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/mysql-4.1 · d9a7e4e0
      unknown authored
      into rurik.mysql.com:/home/igor/dev/mysql-4.1-1
      
      
      d9a7e4e0
    • unknown's avatar
      Merge spetrunia@bk-internal.mysql.com:/home/bk/mysql-4.1 · 10932371
      unknown authored
      into mysql.com:/home/psergey/mysql-4.1-bug10151
      
      
      10932371
    • unknown's avatar
      sql_parse.cc: · d06446af
      unknown authored
        Fix for fix for bug #9728
        Error caused server hang on prepared insert ... select
      
      
      sql/sql_parse.cc:
        Fix for fix for bug #9728
        Error caused server hang on prepared insert ... select
      d06446af
    • unknown's avatar
      mysql-test-run.pl: · 744f6a1a
      unknown authored
        Might need a restart after test with special TZ
        Removed unused argument to run_mysqltest()
      
      
      mysql-test/mysql-test-run.pl:
        Might need a restart after test with special TZ
        Removed unused argument to run_mysqltest()
      744f6a1a
    • unknown's avatar
      Merge spetrunia@bk-internal.mysql.com:/home/bk/mysql-4.1 · 7ef70bc9
      unknown authored
      into mysql.com:/home/psergey/mysql-4.1-bug10151
      
      
      7ef70bc9
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/mysql-4.1 · eb79c6bc
      unknown authored
      into rurik.mysql.com:/home/igor/dev/mysql-4.1-1
      
      
      eb79c6bc
    • unknown's avatar
      func_str.result, func_str.test: · 98253bd6
      unknown authored
        Added a test case for bug #10124.
      sql_select.h, item_subselect.cc, sql_select.cc:
        Fixed bug #10124.
        The copy method of the store_key classes can return
        STORE_KEY_OK=0, STORE_KEY_FATAL=1, STORE_KEY_CONV=2 now.
      field.cc:
        Fixed bug #10124.
        When ussuing a warning the store methods return 2 instead of 1 now.
      
      
      sql/field.cc:
        Fixed bug #10124.
        When ussuing a warning the store methods return 2 instead of 1 now.
      sql/sql_select.cc:
        Fixed bug #10124.
        The copy method of the store_key classes can return
        STORE_KEY_OK=0, STORE_KEY_FATAL=1, STORE_KEY_CONV=2 now.
      sql/item_subselect.cc:
        Fixed bug #10124.
        The copy method of the store_key classes can return
        STORE_KEY_OK=0, STORE_KEY_FATAL=1, STORE_KEY_CONV=2 now.
      sql/sql_select.h:
        Fixed bug #10124.
        The copy method of the store_key classes can return
        STORE_KEY_OK=0, STORE_KEY_FATAL=1, STORE_KEY_CONV=2 now.
      mysql-test/t/func_str.test:
        Added a test case for bug #10124.
      mysql-test/r/func_str.result:
        Added a test case for bug #10124.
      98253bd6
    • unknown's avatar
      Merge tkatchaounov@bk-internal.mysql.com:/home/bk/mysql-4.1 · ab008ede
      unknown authored
      into mysql.com:/home/timka/mysql/src/4.1-virgin
      
      
      ab008ede
    • unknown's avatar
      Merge lgrimmer@bk-internal.mysql.com:/home/bk/mysql-4.1 · 165d271a
      unknown authored
      into mysql.com:/space/my/mysql-4.1
      
      
      165d271a
    • unknown's avatar
      - manual merge of the new node names · a0fedf78
      unknown authored
      a0fedf78
    • unknown's avatar
      - fixed text file generation - the node names in the info page had changed · 0beb0abf
      unknown authored
      
      BitKeeper/deleted/.del-generate-flag-images~f77476753fff8186:
        Delete: Docs/Support/generate-flag-images
      Docs/Makefile.am:
        - fixed node names for the new info file
      Docs/Support/generate-text-files.pl:
        - stop printing if the index was reached
      0beb0abf
    • unknown's avatar
      Merge spetrunia@bk-internal.mysql.com:/home/bk/mysql-4.1 · 4775eaaa
      unknown authored
      into mysql.com:/home/psergey/mysql-4.1-bug10151
      
      
      4775eaaa
    • unknown's avatar
      Merge mysql.com:/home/timka/mysql/src/4.1-virgin · 1abe8e69
      unknown authored
      into mysql.com:/home/timka/mysql/src/4.1-bug-11185
      
      
      1abe8e69
    • unknown's avatar
      Fix for BUG#11185. · e4296f58
      unknown authored
      The source of the problem is in Field_longlong::cmp. If 'this' is
      an unsigned number, the method casts both the current value, and
      the constant that we compare with to an unsigned number. As a
      result if the constant we compare with is a negative number, it
      wraps to some unsigned number, and the comparison is incorrect.
      
      When the optimizer chooses the "range" access method, this problem
      causes handler::read_range_next to reject the current key when the
      upper bound key is a negative number because handler::compare_key
      incorrectly considers the positive and negative keys to be equal.
      
      The current patch does not correct the source of the problem in
      Field_longlong::cmp because it is not easy to propagate sign
      information about the constant at query execution time. Instead
      the patch changes the range optimizer so that it never compares
      unsiged fields with negative constants. As an added benefit,
      queries that do such comparisons will execute faster because
      the range optimizer replaces conditions like:
      (a) (unsigned_int [< | <=] negative_constant) == FALSE
      (b) (unsigned_int [> | >=] negative_constant) == TRUE
      with the corresponding constants.
      In some cases this may even result in constant time execution.
      
      
      mysql-test/r/range.result:
        - Changed incorrect result of an old test
        - Added new results for BUG#11185
      mysql-test/t/range.test:
        - Added new tests for BUG#11185
        - Deleted an old comment because now the problem is fixed
      sql/opt_range.cc:
        Added a new optimization to the range optimizer where we detect that
        an UNSIGNED field is compared with a negative constant. Depending on
        the comparison operator, we know directly that the result of the
        comparison is either TRUE or FALSE for all input values, and we need
        not check each value.
        
        This optimization is also necessary so that the index range access
        method produces correct results when comparing unsigned fields with
        negative constants.
      e4296f58
  5. 22 Jun, 2005 11 commits
  6. 21 Jun, 2005 6 commits
    • unknown's avatar
      BUG#10442 Minor changes from code review · d785fc60
      unknown authored
      
      mysql-test/r/rpl_multi_update3.result:
        Changes from code review
      mysql-test/t/rpl_multi_update3.test:
        Changes from code review
      sql/sql_parse.cc:
        Changes from code review
      d785fc60
    • unknown's avatar
      Bug #9148 Denial of Service · 0bc88379
      unknown authored
      
      my_access.c:
        Fixed problem where in some cases check_if_legal_filename was returning 0 for illegal names
      
      
      mysys/my_access.c:
        Fixed problem where in some cases check_if_legal_filename was returning 0 for illegal names
      0bc88379
    • unknown's avatar
      Merge mysql.com:/Users/emurphy/src/bk-clean/mysql-4.1 · 5031e9ad
      unknown authored
      into  mysql.com:/Users/emurphy/src/work/mysql-4.1-bug10442
      
      
      5031e9ad
    • unknown's avatar
      mysql-test-run.pl: · d18ab5a0
      unknown authored
        Added optional paths for finding mysqld on Windows
        Added language/charset options to embedded mysql_client_test
      
      
      mysql-test/mysql-test-run.pl:
        Added optional paths for finding mysqld on Windows
        Added language/charset options to embedded mysql_client_test
      d18ab5a0
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-4.1 · a23bf165
      unknown authored
      into  moonbone.local:/work/mysql-4.1-bug-10886
      
      
      sql/sql_insert.cc:
        Auto merged
      a23bf165
    • unknown's avatar
      Fix bug #10886 - INSERT ... SELECT ... ON DUPLICATE KEY UPDATE produces bad results · 8e45c057
      unknown authored
      Temporary field wasn't restored to default values after ON DUPLICATE KEY
       UPDATE event, which results in wrong data being inserted in new record.
      
      
      sql/sql_insert.cc:
        Fix bug #10886 - INSERT ... SELECT ... ON DUPLICATE KEY UPDATE produces bad results
      mysql-test/t/insert_select.test:
        Test case for bug #10886 - INSERT ... SELECT ... ON DUPLICATE KEY 
        UPDATE produces bad results
      mysql-test/r/insert_select.result:
        Test case for bug #10886 - INSERT ... SELECT ... ON DUPLICATE KEY UPDATE 
        produces bad results
      8e45c057