1. 12 Aug, 2015 2 commits
    • Alexander Barkov's avatar
      Splitting a static function get_func_mm_tree() into virtual · 6e091dc7
      Alexander Barkov authored
      methods in Item_bool_func descendants, which gives some advantages:
      - Removing the "bool inv" parameter, as its now available through "this"
        for Item_func_between and Item_func_in, and is not needed for the other
        Item_func_xxx.
      - Removing casts
      - Making a step to data types plugings
      6e091dc7
    • Alexander Barkov's avatar
      Removing RANGE_OPT_PARA::cond · 9a64262d
      Alexander Barkov authored
      Its initialization in Item_func_xxx::get_mm_tree() is redundant:
      the pointer to the current function is passed to get_mm_tree() anyway.
      9a64262d
  2. 10 Aug, 2015 1 commit
  3. 09 Aug, 2015 1 commit
  4. 08 Aug, 2015 5 commits
    • Nirbhay Choubey's avatar
      MDEV-7205 : Galera cluster & sql_log_bin = off don't work · cd1a11ac
      Nirbhay Choubey authored
      While sql_bin_log=1(0) is meant to control binary logging for the
      current session so that the updates to do(not) get logged into the
      binary log to be replicated to the async MariaDB slave. The same
      should not affect galera replication.
      
      That is, the updates should always get replicated to other galera
      nodes regardless of sql_bin_log's value.
      
      Fixed by making sure that the updates are written to binlog cache
      irrespective of sql_bin_log.
      
      Added test cases.
      cd1a11ac
    • Jan Lindström's avatar
      MDEV-8582: innodb_force_primary_key option does not force PK or unique key · 46ad86f6
      Jan Lindström authored
      Analysis: Handler used table flag HA_REQUIRE_PRIMARY_KEY but a bug on
      sql_table.cc function mysql_prepare_create_table internally marked
      secondary key with NOT NULL colums as unique key and did not then
      fail on requirement that table should have primary key or unique key.
      46ad86f6
    • Jan Lindström's avatar
      MDEV-8582: innodb_force_primary_key option does not force PK or unique key · 3307eaab
      Jan Lindström authored
      Analysis: Handler table flag HA_REQUIRE_PRIMARY_KEY alone is not enough
      to force primary or unique key, if table has at least one NOT NULL
      column and secondary key for that column.
      
      Fix: Add additional check that table really has primary key or
      unique key for InnoDB terms.
      3307eaab
    • Jan Lindström's avatar
      MDEV-8583: Empty lines in encryption logging · 05bcb088
      Jan Lindström authored
      Removed extra line break.
      05bcb088
    • Jan Lindström's avatar
      MDEV-8410: Changing file-key-management to example-key-management causes crash and no real error · 18b0176a
      Jan Lindström authored
      MDEV-8409: Changing file-key-management-encryption-algorithm causes crash and no real info why
      
      Analysis: Both bugs has two different error cases. Firstly, at startup
      when server reads latest checkpoint but requested key_version,
      key management plugin or encryption algorithm or method is not found
      leading corrupted log entry. Secondly, similarly when reading system
      tablespace if requested key_version, key management plugin or encryption
      algorithm or method is not found leading buffer pool page corruption.
      
      Fix: Firsly, when reading checkpoint at startup check if the log record
      may be encrypted and if we find that it could be encrypted, print error
      message and do not start server. Secondly, if page is buffer pool seems
      corrupted but we find out that there is crypt_info, print additional
      error message before asserting.
      18b0176a
  5. 07 Aug, 2015 1 commit
  6. 04 Aug, 2015 4 commits
    • Kristian Nielsen's avatar
      Merge branch 'mdev8302-3' into 10.1 · afd59b57
      Kristian Nielsen authored
      afd59b57
    • Kristian Nielsen's avatar
      Fix embedded server build · 5ca061e6
      Kristian Nielsen authored
      5ca061e6
    • Kristian Nielsen's avatar
      Merge MDEV-8302 into 10.1 · dbd20579
      Kristian Nielsen authored
      dbd20579
    • Kristian Nielsen's avatar
      MDEV-8302: Duplicate key with parallel replication · 9b9c5e89
      Kristian Nielsen authored
      This bug is essentially another variant of MDEV-7458.
      
      If a transaction conflict caused a deadlock kill of T2 in record_gtid()
      during commit, the code would do a rollback _before_ running
      rgi->unmark_start_commit(). This creates a race where following transactions
      could start too early (before T2 has completed its transaction retry). This
      in turn could lead to replication failure, if there was a conflict that
      caused eg. duplicate key error or similar.
      
      The fix is to remove these rollbacks (in Query_log_event::do_apply_event()
      and Xid_log_event::do_apply_event(). They seem out-of-place; code in
      log_event.cc generally does not roll back on error, this is handled higher
      up.
      
      In addition, because of the extreme difficulty of reproducing bugs like
      MDEV-7458 and MDEV-8302, this patch adds some extra precations to try to
      detect (in debug builds) or prevent (in release builds) similar bugs.
      ha_rollback_trans() will now call unmark_start_commit() if needed (and
      assert in debug build when a caller does rollback without unmark first).
      
      We also add an extra check for thd->killed() so that we avoid doing
      mark_start_commit() if we already have a pending deadlock kill.
      
      And we add a missing unmark_start_commit() call in the error case, found by
      the above assertion.
      9b9c5e89
  7. 24 Jul, 2015 1 commit
  8. 23 Jul, 2015 2 commits
  9. 22 Jul, 2015 2 commits
  10. 21 Jul, 2015 1 commit
    • Jan Lindström's avatar
      MDEV-8501: encryption.create_or_replace fails in buildbot on P8 builders · 62b5a561
      Jan Lindström authored
      Analysis: There is race between drop table and encryption threads that
      could cause encryption thread to enter mutex that has been already
      released.
      
      Fix: When destroying crypt_data first enter the mutex and set crypt data
      unavailable, then release the memory and clean up the data. This should
      make the race more unprobable. Additionally, added big_test for
      create_or_replace as it could fail testcase timeout
      if you have slow I/O (tested that testcase passes with --mem).
      62b5a561
  11. 20 Jul, 2015 5 commits
  12. 19 Jul, 2015 4 commits
  13. 17 Jul, 2015 1 commit
  14. 16 Jul, 2015 2 commits
    • Monty's avatar
      Fix for MySQL bug #77448 Inconsistent handling of RAND() in WHERE and HAVING · 0ad00c66
      Monty authored
      Problem was that for queries of type:
      
      select rand() r, rand()  p, rand() = rand() from a having r = p
      
      The optimizer thought that r = p was same as rand() = rand() and this would always be true.
      
      The problem was that when testing if two expressions are equal, we didn't take into account no determinstic functions.
      
      The fix is to not compare non deterministic functions as equal.
      0ad00c66
    • Monty's avatar
      MDEV-8469 Add RESET MASTER TO x to allow specification of binlog file nr · 872a953b
      Monty authored
      Other things:
      - Avoid calling init_and_set_log_file_name() when opening binary log.
      - Remove newlines early when reading from index file.
      - Ensure that reset_logs() will work even if thd is 0 (Can happen on startup)
      - Added thd to sart_slave_threads() for better error handling.
      872a953b
  15. 15 Jul, 2015 1 commit
  16. 14 Jul, 2015 6 commits
  17. 13 Jul, 2015 1 commit