1. 13 Oct, 2005 3 commits
    • unknown's avatar
      BUG#13343 CREATE|etc TRIGGER|VIEW|USER don't commit the transaction (inconsistency) · 799b1e6c
      unknown authored
      Updated more DDL statements to cause implicit commit.
      
      
      mysql-test/r/rpl_ddl.result:
        updated results to test for implicit commit for:
        CREATE OR REPLACE VIEW
        ALTER VIEW
        DROP VIEW
        CREATE TRIGGER
        DROP TRIGGER
        CREATE USER
        RENAME USER
        DROP USER
      mysql-test/t/rpl_ddl.test:
        updated results to test for implicit commit for:
        CREATE OR REPLACE VIEW
        ALTER VIEW
        DROP VIEW
        CREATE TRIGGER
        DROP TRIGGER
        CREATE USER
        RENAME USER
        DROP USER
      sql/sql_parse.cc:
        added implicit commit for:
        CREATE OR REPLACE VIEW
        ALTER VIEW
        DROP VIEW
        CREATE TRIGGER
        DROP TRIGGER
        CREATE USER
        RENAME USER
        DROP USER
      799b1e6c
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 849eafa7
      unknown authored
      into poseidon.ndb.mysql.com:/home/tomas/mysql-5.0
      
      
      849eafa7
    • unknown's avatar
      BUG# 13052 · a2ceebf2
      unknown authored
      Clean application of patch - 
      - Added --tz-utc to fix issue of dumping timestamp values between 
      servers with different global time zone settings, particularly 
      with regard to the day of DST changeover, which without this fix,
       would dump duplicate timestamp values.
      
      
      client/client_priv.h:
        BUG# 13052 - clean application of http://lists.mysql.com/internals/30993
      client/mysqldump.c:
        BUG# 13052
        
        Clean application of patch http://lists.mysql.com/internals/30993
        
        - added new --tz-utc option
        - added saving of TIME_ZONE in dump file
        - set TIME_ZONE to "+00:00" in dump
      mysql-test/r/mysqldump.result:
        BUG# 13052 New results
      mysql-test/t/mysqldump.test:
        BUG# 13052
        
        Added new test to test if the new option --tz-utc places 
        'SET TIME_ZONE="+00:00" at the top of the file and that this fixes 
        the problem of ending up with duplicate timestamp values that should
         be unique on eve of DST
      a2ceebf2
  2. 12 Oct, 2005 32 commits
    • unknown's avatar
      Merge mysql.com:/users/lthalmann/bkroot/mysql-5.0 · 5dcfa572
      unknown authored
      into  mysql.com:/users/lthalmann/bk/mysql-5.0-mysqlbinlog-ulong
      
      
      5dcfa572
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-5.0 · ada1f886
      unknown authored
      into  mysql.com:/home/mysql_src/mysql-5.0
      
      
      ada1f886
    • unknown's avatar
      fixes after merge of 4.1. · 16f3cb03
      unknown authored
      
      mysql-test/r/subselect.result:
        correcting non-ascii chars hosed by automerge as usual
      mysql-test/t/subselect.test:
        correcting non-ascii chars hosed by automerge as usual
      sql/log_event.cc:
        correcting bad manual merge. ZERO_LEN is not needed in 5.0, as ::exec_event() just tell()s the relay log instead
        of using get_event_len().
      sql/log_event.h:
        get_event_len() is not needed in 5.0, ZERO_LEN neither.
      sql/slave.cc:
        fixes to take into account 5.0 specificities in replication. ZERO_LEN is not needed.
      16f3cb03
    • unknown's avatar
      Building with compile-pentium-valgrind-max (without safemalloc) defines my_free() without flags, · bec38058
      unknown authored
      so a typo on flags will go unnoticed; I put flags in this my_free() definition (as a no-op which
      will still make the compiler check correctness of the flags). Applied: this caught a typo in my_realloc.c. Kindly approved by Konstantin and Mats.
      
      
      include/my_sys.h:
        When we define my_free(PTR,FG) to be my_no_flags_free(PTR) we don't make the compiler check
        correctness of FG, which can hurt if another person build with a different definition of my_free;
        so I add FG in the expression.
      mysys/my_realloc.c:
        typo found by the change in my_sys.h :)
      bec38058
    • unknown's avatar
      Merge mysql.com:/users/lthalmann/bkroot/mysql-5.0 · 7b8f2df2
      unknown authored
      into  mysql.com:/users/lthalmann/bk/mysql-5.0-mysqlbinlog-ulong
      
      
      7b8f2df2
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-5.0 · e7ac9b92
      unknown authored
      into  mysql.com:/home/mysql_src/mysql-5.0
      
      
      e7ac9b92
    • unknown's avatar
      replace port number with string identifier so that it may have different ports and still run · 06c8c18a
      unknown authored
      (problem found by kent)
      
      
      mysql-test/r/federated.result:
        replace port number with a named identifier
      mysql-test/t/federated.test:
        add call to replace the resulting display of the port number with a string
      06c8c18a
    • unknown's avatar
      Merge mysql.com:/home/mysql_src/mysql-4.1 · 7f8be07b
      unknown authored
      into  mysql.com:/home/mysql_src/mysql-5.0
      
      
      7f8be07b
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 431753ec
      unknown authored
      into  mysql.com:/home/dlenev/src/mysql-5.0-repl
      
      
      431753ec
    • unknown's avatar
      make_binary_distribution.sh: · bf1f78c1
      unknown authored
        Copy *.cnf files in mysql-test/std_data/
      Makefile.am:
        Added std_data/*.cnf to copy ndb config
      
      
      mysql-test/Makefile.am:
        Added std_data/*.cnf to copy ndb config
      scripts/make_binary_distribution.sh:
        Copy *.cnf files in mysql-test/std_data/
      bf1f78c1
    • unknown's avatar
      To force a restart at the end of test, the option file must be non-empty, it's... · 3b3712fd
      unknown authored
      To force a restart at the end of test, the option file must be non-empty, it's not enough if it exists and is empty.
      
      
      mysql-test/t/rpl_dual_pos_advance-master.opt:
        the option file must be non-empty (because there's a -z test in mysql-test-run)
      3b3712fd
    • unknown's avatar
      Merge mysql.com:/home/mysql_src/mysql-4.1 · 8b1a32ae
      unknown authored
      into  mysql.com:/home/mysql_src/mysql-5.0;
      a very bad automerge (issues with non-ascii chars), plus some hard conflicts I'll fix by hand in a next cset
      
      
      BitKeeper/deleted/.del-compile-pentium64-valgrind-max:
        Delete: BUILD/compile-pentium64-valgrind-max
      BitKeeper/etc/config:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/slave.h:
        Auto merged
      client/mysqltest.c:
        manual merge
      mysql-test/r/subselect.result:
        manual merge
      mysql-test/t/subselect.test:
        manual merge
      sql/log_event.cc:
        manual merge
      sql/log_event.h:
        manual merge
      sql/slave.cc:
        manual merge
      sql/sql_yacc.yy:
        manual merge
      8b1a32ae
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 92713c00
      unknown authored
      into  mysql.com:/home/dlenev/src/mysql-5.0-repl
      
      
      sql/sp_head.cc:
        Auto merged
      92713c00
    • unknown's avatar
      Temporary solution for bug #13969 "Routines which are replicated from master · f48db1bc
      unknown authored
      can't be executed on slave". It will be possible to solve this problem
      in more correct way when we will implement WL#2897 "Complete definer support
      in the stored routines".
      
      
      mysql-test/r/rpl_sp.result:
        Added test for bug #13969 "Routines which are replicated from master can't be
        executed on slave".
      mysql-test/t/rpl_sp.test:
        Added test for bug #13969 "Routines which are replicated from master can't be
        executed on slave".
      sql/sp_head.cc:
        sp_change_security_context():
          Currently the slave replication thread creates all stored routines with
          definer ''@'', ignoring the actual definer. When the slave replication
          thread executes these routines, it ignores the definer, and so the routines
          work. However, in case of a failover, the replica operates in a normal mysqld
          mode and changes security context to the definer when executing a routine.
          A proper fix for this issue is described in WL#2897 "Complete definer support
          in the stored routines". Until this WL is implemented, we need this temporary
          fix, which ignores errors when changing security context.
      f48db1bc
    • unknown's avatar
      slave.cc: · 3f11381b
      unknown authored
        SCCS merged
      
      
      sql/slave.cc:
        SCCS merged
      3f11381b
    • unknown's avatar
      Fix of incompatible types · 8e8e3007
      unknown authored
      len and packet_error needs to be of same type for (len == packet_error) to
      check failures
      
      
      8e8e3007
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 9767b637
      unknown authored
      into poseidon.ndb.mysql.com:/home/tomas/mysql-5.0
      
      
      ndb/src/mgmsrv/InitConfigFileParser.cpp:
        Auto merged
      9767b637
    • unknown's avatar
      postt review fixes · ad2a4306
      unknown authored
      ad2a4306
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · 8d9c66a5
      unknown authored
      into  mysql.com:/usr/home/pem/bug13510/mysql-5.0
      
      
      8d9c66a5
    • unknown's avatar
      556fdfbd
    • unknown's avatar
      Bug #13009 No gaps allowed in node id number sequence · 983cad51
      unknown authored
      + some small bugfixes in ndb_config
      + extending ndb_config to print connections and take shm option
      
      
      983cad51
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · 60534415
      unknown authored
      into  mysql.com:/usr/home/pem/bug13510/mysql-5.0
      
      
      60534415
    • unknown's avatar
      merge · 61dfc334
      unknown authored
      61dfc334
    • unknown's avatar
      Fix for BUG#13023: "SQL Thread is up but doesn't move forward". Details in slave.cc; · 7ff27a61
      unknown authored
      in short we now record whenever the slave I/O thread ignores a master's event because of its server id,
      and use this info in the slave SQL thread to advance Exec_master_log_pos. Because if we
      do not, this variable stays at the position of the last executed event, i.e. the last *non-ignored*
      executed one, which may not be the last of the master's binlog (and so the slave *looks* behind
      the master though it's data-wise it's not).
      
      
      mysql-test/t/rpl_dual_pos_advance-master.opt:
        empty; its goal is just to trigger a server restart after running the test,
        so that the master forgets that it was a slave (otherwise it affects the following tests).
      sql/log.cc:
        No more default arguments for Rotate_log_event constructor.
        MYSQL_LOG::appendv() is now called without mutex.
      sql/log_event.cc:
        Moving one Rotate_log_event constructor from log_event.h. Support for on-demand choice of
        duplicating the string argument of the constructor or not (because there now are needs for both
        alternatives, see slave.cc).
      sql/log_event.h:
        We now have a case where a Rotate_log_event is executed by the slave SQL thread while
        not being in the relay log, so it needs to pretend its length is 0: a ZERO_LEN flag for that;
        a flag DUP_NAME (replaces "bool alloced") to be able to choose if we want the constructor
        to duplicate the string argument or not.
      sql/slave.cc:
        A comment for BUG#13861 (to be fixed). llstr() instead of %ld as the number is ulonglong.
        mi->rli becomes rli in some places.
        Fix for BUG#13023:
        - in the slave I/O thread, whenever we ignore an event because of its server id we update
        a couple of coordinates in memory
        - in the slave SQL thread, whenever we bump into the end of the latest relay log, we check
        this couple of coordinates to see if we should advance our Exec_master_log_pos.
        - when the slave I/O thread terminates it saves these in-memory coordinates into a Rotate event
        in the relay log, so that they are durable.
      sql/slave.h:
        A couple of coordinates in RELAY_LOG_INFO to keep track of the last ignored events received
        by the slave I/O thread (ignored because of the server id).
      mysql-test/r/rpl_dual_pos_advance.result:
        New BitKeeper file ``mysql-test/r/rpl_dual_pos_advance.result''
      mysql-test/t/rpl_dual_pos_advance.test:
        Test for BUG#13023 (with a part, disabled, to test BUG#13861 when I fix it).
        Before the fix, this test used to hang.
      7ff27a61
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · efd99d95
      unknown authored
      into  mysql.com:/usr/home/pem/bug13616/mysql-5.0
      
      
      sql/sp_head.cc:
        Auto merged
      efd99d95
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · 51ebdc65
      unknown authored
      into  mysql.com:/usr/home/pem/bug13616/mysql-5.0
      
      
      51ebdc65
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-5.0 · 14b89a32
      unknown authored
      into mysql.com:/home/gluh/MySQL/Merge/5.0
      
      
      14b89a32
    • unknown's avatar
      after merge fix · f96b66ef
      unknown authored
      
      config/ac-macros/yassl.m4:
        added HAVE_YASSL variable
      sql/mysqld.cc:
        added HAVE_YASSL define
      f96b66ef
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 9af6650a
      unknown authored
      into  mysql.com:/users/grog/4.1
      
      
      9af6650a
    • unknown's avatar
      sql_yacc.yy: · be559ad6
      unknown authored
        Bug #10308: Parse 'purge master logs' with subselect correctly.
      subselect.test:
        Bug #10308: Test for 'purge master logs' with subselect.
      subselect.result:
        Bug #10308: Test result for 'purge master logs' with subselect.
      
      
      mysql-test/r/subselect.result:
        Bug #10308: Test result for 'purge master logs' with subselect.
      mysql-test/t/subselect.test:
        Bug #10308: Test for 'purge master logs' with subselect.
      sql/sql_yacc.yy:
        Bug #10308: Parse 'purge master logs' with subselect correctly.
      be559ad6
    • unknown's avatar
      Merge lgrimmer@bk-internal:/home/bk/mysql-5.0 · 771fadef
      unknown authored
      into mysql.com:/space/my/mysql-5.0
      
      
      771fadef
    • unknown's avatar
      4.1->5.0 merge · 533b8ba2
      unknown authored
      
      sql/mysqld.cc:
        Auto merged
      sql/sql_parse.cc:
        manual merge
      533b8ba2
  3. 11 Oct, 2005 5 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 706157f0
      unknown authored
      into  mysql.com:/home/my/mysql-5.0
      
      
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      server-tools/instance-manager/instance.cc:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/slave.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_manager.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/table.cc:
        Auto merged
      sql/unireg.cc:
        Auto merged
      706157f0
    • unknown's avatar
      Reviewing new pushed code · 0ce12f70
      unknown authored
      - CHAR() now returns binary string as default
      - CHAR(X*65536+Y*256+Z) is now equal to CHAR(X,Y,Z) independent of the character set for CHAR()
      - Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
        (Some old systems returns ETIME and it's safer to test for both values
         than to try to write a wrapper for each old system)
      - Fixed new introduced bug in NOT BETWEEN X and X
      - Ensure we call commit_by_xid or rollback_by_xid for all engines, even if one engine has failed
      - Use octet2hex() for all conversion of string to hex
      - Simplify and optimize code
      
      
      client/mysqldump.c:
        Simple optimizations of new code
        Indentation fixes
      client/mysqltest.c:
        Removed not needed variable
      include/mysql_com.h:
        Made octec2hex() more usable
      mysql-test/r/ctype_utf8.result:
        CHAR() now returns binary string as default
      mysql-test/r/func_str.result:
        CHAR() now returns binary string as default
      mysql-test/r/range.result:
        Added test to verify new introduced bug in NOT BETWEEN X and X
      mysql-test/r/user_var-binlog.result:
        CHAR() now returns binary string as default
      mysql-test/r/view.result:
        More tests of view rename
      mysql-test/t/ctype_utf8.test:
        CHAR() now returns binary string as default
      mysql-test/t/func_str.test:
        CHAR() now returns binary string as default
      mysql-test/t/range.test:
        Added test to verify new introduced bug in NOT BETWEEN X and X
      mysql-test/t/view.test:
        More tests of view rename
      mysys/mf_keycache.c:
        Indentation changes
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      mysys/my_os2cond.c:
        Fix to MySQL coding style
        Optimized functions
      mysys/thr_lock.c:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      mysys/thr_mutex.c:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      server-tools/instance-manager/instance.cc:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      server-tools/instance-manager/thread_registry.cc:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      sql/ha_federated.cc:
        Use octet2hex()
      sql/ha_ndbcluster.cc:
        Removed not used variable
      sql/handler.cc:
        Simplify code
        Use *NONE* instead of 'none' for not existing storage engine
        Ensure we call commit_by_xid or rollback_by_xid for all engines, even if one engine has failed
      sql/item.h:
        Remove not needed test for *ref.  (If ref is set, it should never point at 0)
      sql/item_func.cc:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
        Simplify code
        More comments
        Require that last argument to find_and_check_access() is given
        (Made code shorter and faster)
      sql/item_strfunc.cc:
        Changed CHAR() to return result in binary collation
        CHAR(X*65536+Y*256+Z) is now equal to CHAR(X,Y,Z) independent of the character set for CHAR()
        
        Bar will shortly add the following syntax:
        CHAR(.... USING character_set)
        and ensure that
        CONVERT(CHAR(....) USING utf8) cuts not legal utf8 strings
        Use ocet2hex()
      sql/item_strfunc.h:
        CHAR() now returns a binary string
      sql/log_event.cc:
        Use octet2hex()
        Simplify code
      sql/parse_file.cc:
        Indentation fixes
        Use for() instead of while()
      sql/password.c:
        Make octet2hex() more generally usable by returning pointer to end 0
      sql/slave.cc:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      sql/sql_base.cc:
        Indentation fixes
      sql/sql_insert.cc:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      sql/sql_manager.cc:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      sql/sql_parse.cc:
        Don't check thd->db when checking for function privileges
      sql/sql_prepare.cc:
        Fixed wrong merge
      sql/sql_select.cc:
        Fixed new bug for NOT BETWEEN X and X
      sql/sql_show.cc:
        Removed not used variable
      sql/sql_table.cc:
        Indentation fixed
        Removed DBUG_PRINT that is obvious from context
      sql/sql_view.cc:
        Simplify code
      sql/unireg.cc:
        Use octet2hex()
      0ce12f70
    • unknown's avatar
      Merge mysql.com:/space/my/mysql-4.1 · 87308abf
      unknown authored
      into mysql.com:/space/my/mysql-4.1-build
      
      
      87308abf
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 4857e205
      unknown authored
      into moonbone.local:/work/13327-bug-5.0-mysql
      
      
      4857e205
    • unknown's avatar
      Merge mysql.com:/space/my/mysql-4.1-build · 1cd63ae3
      unknown authored
      into mysql.com:/space/my/mysql-5.0-build
      
      
      scripts/make_win_src_distribution.sh:
        Auto merged
      1cd63ae3