1. 03 Nov, 2005 1 commit
    • unknown's avatar
      Bug#14397 - OPTIMIZE TABLE with an open HANDLER causes a crash · 7d183320
      unknown authored
      Version for 4.0.
      It fixes two problems:
      1. The cause of the bug was that we did not check the table version for
         the HANDLER ... READ commands. We did not notice when a table was
         replaced by a new one. This can happen during ALTER TABLE, REPAIR
         TABLE, and OPTIMIZE TABLE (there might be more cases). I call the fix
         for this problem "the primary bug fix".
      2. mysql_ha_flush() was not always called with a locked LOCK_open.
         Though the function comment clearly said it must.
         I changed the code so that the locking is done when required. I call
         the fix for this problem "the secondary fix".
      
      
      mysql-test/r/handler.result:
        Bug#14397 - OPTIMIZE TABLE with an open HANDLER causes a crash
        The test result.
      mysql-test/t/handler.test:
        Bug#14397 - OPTIMIZE TABLE with an open HANDLER causes a crash
        The test case.
      sql/mysql_priv.h:
        Bug#14397 - OPTIMIZE TABLE with an open HANDLER causes a crash
        Changed a definition for the secondary fix.
      sql/sql_base.cc:
        Bug#14397 - OPTIMIZE TABLE with an open HANDLER causes a crash
        Changed function calls for the secondary fix.
      sql/sql_class.cc:
        Bug#14397 - OPTIMIZE TABLE with an open HANDLER causes a crash
        Changed a function call for the secondary fix.
      sql/sql_handler.cc:
        Bug#14397 - OPTIMIZE TABLE with an open HANDLER causes a crash
        The first two diffs make the primary bug fix.
        The rest is for the secondary fix.
      sql/sql_table.cc:
        Bug#14397 - OPTIMIZE TABLE with an open HANDLER causes a crash
        Changed function calls for the secondary fix.
      7d183320
  2. 25 Oct, 2005 4 commits
  3. 13 Oct, 2005 7 commits
  4. 12 Oct, 2005 1 commit
    • unknown's avatar
      memcpy_overlap() removed, as · 6c89848d
      unknown authored
        1. it's wrong to use memcpy() for overlapped areas;
        2. we use it only once.
      During merge to 4.1 will remove a memcpy_overlap() call 
      from strings/ctype-tis620.c as well in order to fix 
      bug #10836: ctype_tis620 test failure with ICC-compiled binaries on IA64.
      
      
      myisam/mi_search.c:
        use memmove() instead, as memcpy_overlap() is removed.
      6c89848d
  5. 11 Oct, 2005 2 commits
  6. 09 Oct, 2005 2 commits
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-4.0 · a1f49284
      unknown authored
      into moonbone.local:/work/7672-bug-4.0-mysql
      
      
      a1f49284
    • unknown's avatar
      Fix bug#7672 Unknown column error in order clause · f3f84ed8
      unknown authored
      When fixing Item_func_plus in ORDER BY clause field c is searched in all
      opened tables, but because c is an alias it wasn't found there.
      
      This patch adds a flag to select_lex which allows Item_field::fix_fields() 
      to look up in select's item_list to find aliased fields.
      
      
      sql/item.cc:
        Fix bug#7672 Unknown column error in order clause
        When fixing fields in ORDER BY clause allow Item_field::fix_fields() to look up items in select's item list to find aliased fields.
      sql/sql_lex.cc:
         Fix bug#7672 Unknown column error in order clause
      sql/sql_lex.h:
        Fix bug#7672 Unknown column error in order clause
        Added flag to select_lex allowing Item_field::fix_fields to look up items in select's item list.
      sql/sql_select.cc:
        Fix bug#7672 Unknown column error in order clause
      mysql-test/t/select.test:
        Test case for bug#7672 Unknown column error in order clause
      mysql-test/r/select.result:
        Test case for bug#7672 Unknown column error in order clause
      f3f84ed8
  7. 03 Oct, 2005 1 commit
    • unknown's avatar
      InnoDB: Display an error message in /* */ comments · 9595cc33
      unknown authored
      in SHOW CREATE TABLE if a temporary file cannot be created.
      (Bug #13002)
      
      
      sql/ha_innodb.cc:
        ha_innobase::get_foreign_key_create_info(): Display an error
        message to the user if a temporary file cannot be created.
      9595cc33
  8. 29 Sep, 2005 3 commits
  9. 27 Sep, 2005 1 commit
  10. 23 Sep, 2005 1 commit
    • unknown's avatar
      Bug#9112 - Merge table with composite index producing invalid results with some queries · 674c8165
      unknown authored
      The problem was an ab-use of last_rkey_length.
      Formerly we saved the packed key length (of the search key)
      in this element. But in certain cases it got replaced by 
      the (packed) result key length.
      Now we use a new element of MI_INFO to save the packed key 
      length of the search key.
      
      
      myisam/mi_dbug.c:
        Bug#9112 - Merge table with composite index producing invalid results with some queries
        Fixed the recognition of NULL values in _mi_print_key().
      myisam/mi_rkey.c:
        Bug#9112 - Merge table with composite index producing invalid results with some queries
        Saved the packed key length in a new element of MI_INFO.
      myisam/mi_search.c:
        Bug#9112 - Merge table with composite index producing invalid results with some queries
        Added a comment and trace prints.
      myisam/myisamdef.h:
        Bug#9112 - Merge table with composite index producing invalid results with some queries
        Added a new element to store the packed key length
        for use by the MyISAMMRG engine.
      myisammrg/myrg_rkey.c:
        Bug#9112 - Merge table with composite index producing invalid results with some queries
        Changed to use the new element of MI_INFO to get at the
        packed key length.
      mysql-test/r/merge.result:
        Bug#9112 - Merge table with composite index producing invalid results with some queries
        The test result.
      mysql-test/t/merge.test:
        Bug#9112 - Merge table with composite index producing invalid results with some queries
        The test case.
      674c8165
  11. 19 Sep, 2005 1 commit
  12. 18 Sep, 2005 1 commit
  13. 15 Sep, 2005 1 commit
    • unknown's avatar
      Turn off EOLN_NATIVE flag for all test files · 900645b8
      unknown authored
      Ignored some generated files
      
      
      mysql-test/t/analyze.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/ansi-master.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/ansi.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/backup-master.sh:
        Turn off EOLN_NATIVE flag
      mysql-test/t/bdb-alter-table-2-master.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/bdb-deadlock.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/bdb_cache-master.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/bdb_cache.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/bool.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/cast.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/constraints.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/convert.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/create_select_tmp.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/ctype_cp1251-master.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/ctype_cp1251.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/ctype_latin1_de-master.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/ctype_latin1_de.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/ctype_tis620-master.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/ctype_tis620.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/ctype_ujis-master.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/ctype_ujis.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/drop_temp_table.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/flush_block_commit.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/func_concat.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/func_encrypt-master.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/func_if.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/func_isnull.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/gcc296.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/grant.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/grant_cache-master.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/grant_cache.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/init_file-master.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/init_file.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/innodb-deadlock.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/innodb-lock.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/innodb_cache-master.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/innodb_cache.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/innodb_handler.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/isam.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/loaddata.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/lock_multi.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/lock_tables_lost_commit-master.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/lock_tables_lost_commit.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/lowercase_table-master.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/lowercase_table.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/lowercase_table2.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/lowercase_table3-master.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/lowercase_table3.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/mix_innodb_myisam_binlog-master.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/mix_innodb_myisam_binlog.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/multi_update-master.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/myisam-blob-master.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/myisam-blob.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/mysqlbinlog-master.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/mysqlbinlog.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/mysqldump.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/packet.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/query_cache.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/query_cache_merge.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/query_cache_notembedded.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/repair.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/repair_part2-master.sh:
        Turn off EOLN_NATIVE flag
      mysql-test/t/repair_part2.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl000016-slave.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_EE_error.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_alter.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_chain_temp_table.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_change_master.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_commit_after_flush.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_do_grant.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_drop.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_empty_master_crash.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_error_ignored_table-slave.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_error_ignored_table.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_failsafe.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_flush_log_loop-master.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_flush_log_loop-master.sh:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_flush_log_loop-slave.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_flush_log_loop-slave.sh:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_flush_log_loop.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_free_items-slave.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_free_items.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_get_lock.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_heap.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_ignore_grant-slave.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_ignore_grant.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_insert_id.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_loaddata.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_loaddata_rule_m-master.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_loaddata_rule_m.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_loaddata_rule_s-slave.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_loaddata_rule_s.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_loaddatalocal.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_log-master.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_log-slave.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_master_pos_wait.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_max_relay_size.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_multi_delete-slave.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_multi_delete.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_multi_delete2-slave.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_multi_delete2.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_multi_update.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_multi_update2-slave.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_multi_update2.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_optimize.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_relayspace-slave.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_relayspace.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_reset_slave.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_server_id1.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_server_id2-slave.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_server_id2.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_set_charset.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_skip_error-slave.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_skip_error.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_start_stop_slave.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/rpl_trunc_binlog.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/system_mysql_db.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/system_mysql_db_fix-master.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/system_mysql_db_fix.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/system_mysql_db_refs.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/timezone-master.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/timezone.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/timezone3-master.opt:
        Turn off EOLN_NATIVE flag
      mysql-test/t/timezone3.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/type_set.test:
        Turn off EOLN_NATIVE flag
      mysql-test/t/variables-master.opt:
        Turn off EOLN_NATIVE flag
      BitKeeper/etc/ignore:
        added support-files/MacOSX/preflight
      900645b8
  14. 14 Sep, 2005 1 commit
  15. 13 Sep, 2005 1 commit
  16. 12 Sep, 2005 2 commits
  17. 08 Sep, 2005 3 commits
  18. 07 Sep, 2005 1 commit
  19. 06 Sep, 2005 2 commits
  20. 02 Sep, 2005 3 commits
  21. 01 Sep, 2005 1 commit