1. 10 Nov, 2005 3 commits
    • unknown's avatar
      WL#2818 (Add creator to the trigger definition for privilege · 7dbea7df
      unknown authored
      checks on trigger activation)
      
      
      mysql-test/r/information_schema.result:
        Update result file: a new column DEFINER has been added to
        INFORMATION_SCHEMA.TRIGGERS.
      mysql-test/r/mysqldump.result:
        Update result file: a new column DEFINER has been added to
        INFORMATION_SCHEMA.TRIGGERS.
      mysql-test/r/rpl_ddl.result:
        Update result file: a new column DEFINER has been added to
        INFORMATION_SCHEMA.TRIGGERS.
      mysql-test/r/rpl_sp.result:
        Update result file: a new clause DEFINER has been added to
        CREATE TRIGGER statement.
      mysql-test/r/rpl_trigger.result:
        Results for new test cases were added.
      mysql-test/r/skip_grants.result:
        Error message has been changed.
      mysql-test/r/trigger.result:
        Added DEFINER column.
      mysql-test/r/view.result:
        Error messages have been changed.
      mysql-test/r/view_grant.result:
        Error messages have been changed.
      mysql-test/t/mysqldump.test:
        Drop created procedure to not affect further tests.
      mysql-test/t/rpl_trigger.test:
        Add tests for new column in information schema.
      mysql-test/t/skip_grants.test:
        Error tag has been renamed.
      mysql-test/t/view.test:
        Error tag has been renamed.
      mysql-test/t/view_grant.test:
        Error tag has been changed.
      sql/item_func.cc:
        Fix typo in comments.
      sql/mysql_priv.h:
        A try to minimize copy&paste:
          - introduce operations to be used from sql_yacc.yy;
          - introduce an operation to be used from trigger and
            view processing code.
      sql/share/errmsg.txt:
        - Rename ER_NO_VIEW_USER to ER_MALFORMED_DEFINER in order to
          be shared for view and trigger implementations;
        - Fix a typo;
        - Add a new error code for trigger warning.
      sql/sp.cc:
        set_info() was split into set_info() and set_definer().
      sql/sp_head.cc:
        set_info() was split into set_info() and set_definer().
      sql/sp_head.h:
        set_info() was split into set_info() and set_definer().
      sql/sql_acl.cc:
        Add a new check: exit from the cycle if the table is NULL.
      sql/sql_lex.h:
        - Rename create_view_definer to definer, since it is used for views
          and triggers;
        - Change st_lex_user to LEX_USER, since st_lex_user is a structure.
          So, formally, it should be "struct st_lex_user", which is longer
          than just LEX_USER;
        - Add trigger_definition_begin.
      sql/sql_parse.cc:
        - Add a new check: exit from the cycle if the table is NULL;
        - Implement definer-related functions.
      sql/sql_show.cc:
        Add DEFINER column.
      sql/sql_trigger.cc:
        Add DEFINER support for triggers.
      sql/sql_trigger.h:
        Add DEFINER support for triggers.
      sql/sql_view.cc:
        Rename create_view_definer to definer.
      sql/sql_yacc.yy:
        Add support for DEFINER-clause in CREATE TRIGGER statement.
        
        Since CREATE TRIGGER and CREATE VIEW can be similar at the start,
        yacc is unable to distinguish between them. So, had to modify both
        statements in order to make it parsable by yacc.
      mysql-test/r/trigger-compat.result:
        Result file for triggers backward compatibility test.
      mysql-test/r/trigger-grant.result:
        Result file of the test for WL#2818.
      mysql-test/t/trigger-compat.test:
        Triggers backward compatibility test: check that the server
        still can load triggers w/o definer attribute and modify
        tables with such triggers (add a new trigger, etc).
      mysql-test/t/trigger-grant.test:
        Test for WL#2818 -- check that DEFINER support in triggers
        works properly
      7dbea7df
    • unknown's avatar
      Fix a comment. · 96ae0b92
      unknown authored
      
      sql/sql_cursor.cc:
        A post-review fix for Bug#13488
      96ae0b92
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · ad1254fb
      unknown authored
      into  mysql.com:/usr/home/pem/bug14719/mysql-5.0
      
      
      ad1254fb
  2. 09 Nov, 2005 13 commits
  3. 08 Nov, 2005 6 commits
  4. 07 Nov, 2005 8 commits
    • unknown's avatar
      Merge mysql.com:/home/cps/mysql/trees/mysql-4.1 · ce648a30
      unknown authored
      into  mysql.com:/home/cps/mysql/trees/mysql-5.0-virgin
      
      
      sql/examples/ha_tina.cc:
        Auto merged
      support-files/mysql.spec.sh:
        SCCS merged
      ce648a30
    • unknown's avatar
      Merge jbruehe@bk-internal.mysql.com:/home/bk/mysql-5.0 · b8e4fa6f
      unknown authored
      into mysql.com:/M50/mysql-5.0
      
      
      b8e4fa6f
    • unknown's avatar
      Merge pchardin@bk-internal.mysql.com:/home/bk/mysql-4.1 · 01cad639
      unknown authored
      into  mysql.com:/home/cps/mysql/trees/mysql-4.1
      
      
      01cad639
    • unknown's avatar
      mysql-test/r/connect.result + mysql-test/t/connect.test · af2e0dc4
      unknown authored
      Replace the full socket path name, not just a directory component. bug#14720
      
      
      mysql-test/r/connect.result:
        In cases where "--tmpdir=" is given to the test run, the socket file is not created below
        "$MYSQL_TEST_DIR" but rather within this directory. So the "--replace_result" should not 
        be done to a directory in the path but rather to the complete path name of the socket file. 
        bug#14720
      mysql-test/t/connect.test:
        In cases where "--tmpdir=" is given to the test run, the socket file is not created below
        "$MYSQL_TEST_DIR" but rather within this directory. So the "--replace_result" should not
        be done to a directory in the path but rather to the complete path name of the socket file.
        bug#14720
      af2e0dc4
    • unknown's avatar
      Bug#13707 - Server crash with INSERT DELAYED on MyISAM table · 9725d32b
      unknown authored
      Initialized 'ptr' for a newly instantiated varstring field.
      This is required by INSERT DELAYED.
      
      No test case. This is a migration issue. There are two shell
      scripts attached to the bug report. They can be used for testing.
      
      
      sql/field.cc:
        Bug#13707 - Server crash with INSERT DELAYED on MyISAM table
        Initialized 'ptr' for a newly instantiated varstring field.
        This is required by INSERT DELAYED.
      9725d32b
    • unknown's avatar
      Fix for BUG#14703 "Valgrind error when inserting 0 into a BIT column (like in type_bit.test)": · 50f48187
      unknown authored
      test "length" first (otherwise when "length" is 0, the *from invalid access still triggers a Valgrind warning).
      I wrote to the Valgrind authors in case this is something fixable in Valgrind (normally the
      decision to issue a warning is based on the simulated CPU condition code, which should not be undefined here).
      
      
      BUILD/compile-pentium64-valgrind-max:
        putting this script in sync with compile-pentium-valgrind-max, otherwise we didn't have the federated engine compiled in.
      mysql-test/r/read_only.result:
        result update
      sql/field.cc:
        To avoid a Valgrind warning running the type_bit test: test "length" first (otherwise when "length" is 0, the *from invalid access still triggers a Valgrind warning).
      50f48187
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-5.0 · 21447f17
      unknown authored
      into  mysql.com:/home/mysql_src/mysql-5.0
      
      
      21447f17
    • unknown's avatar
      BUG#14480, attempt2: In CREATE ... SELECT ..., don't count the same field twice · 467deb4c
      unknown authored
      when calculating table->null_fields.
      
      
      mysql-test/r/create.result:
        Testcase for BUG#14480
      mysql-test/t/create.test:
        Testcase for BUG#14480
      sql/sql_table.cc:
        BUG#14480: For CREATE ... SELECT ... a field list passed to mysql_prepare_table() contains
        instances of create_field for both create-list and select-list. mysql_prepare_table() 
        matches elements that refer to the same field, and joins them together. When the "join"  
        is performed, both of create_field structures has already been counted in "null_fields". 
        
        This fix makes sure that "null_fields" contains the correct value after two create_field 
        structures have been joined.
      467deb4c
  5. 06 Nov, 2005 2 commits
  6. 05 Nov, 2005 4 commits
    • unknown's avatar
      Fix Bug#14672 Bug in deletion · b0829011
      unknown authored
      
      mysql-test/r/csv.result:
        correct result file
      mysql-test/t/csv.test:
        Add test for a bug
      sql/examples/ha_tina.cc:
        Add O_APPEND flag to my_open. We should always add rows to the end of file
      b0829011
    • unknown's avatar
      Fix Bug#13894 Server crashes on update of CSV table · 1b65c704
      unknown authored
      
      mysql-test/r/csv.result:
        update result file
      mysql-test/t/csv.test:
        Add test for a bug
      sql/examples/ha_tina.cc:
        sort function should return reverted values for chains to be sorted in
        the right orded. don't do a strange memmove
      1b65c704
    • unknown's avatar
      Merge spetrunia@bk-internal.mysql.com:/home/bk/mysql-5.0 · 34da7170
      unknown authored
      into mysql.com:/home/psergey/mysql-5.0-oct03-push
      
      
      sql/mysql_priv.h:
        Auto merged
      34da7170
    • unknown's avatar
      mysql.spec.sh: · 0e878d7e
      unknown authored
        Always use bundled zlib
      
      
      support-files/mysql.spec.sh:
        Always use bundled zlib
      0e878d7e
  7. 04 Nov, 2005 4 commits