1. 01 Sep, 2005 19 commits
    • unknown's avatar
      Fixes after merging fix for bug #12423 "Deadlock when doing FLUSH PRIVILEGES · 7dff8f20
      unknown authored
      and GRANT in multi-threaded environment" into 5.0 tree.
      
      
      sql/sql_acl.cc:
        After merge fixes.
      7dff8f20
    • unknown's avatar
      Merge mysql.com:/home/dlenev/src/mysql-4.1-bg12423 · 7783dbbc
      unknown authored
      into  mysql.com:/home/dlenev/src/mysql-5.0-merges
      
      
      mysql-test/lib/mtr_report.pl:
        Auto merged
      mysql-test/lib/mtr_timer.pl:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_acl.h:
        Auto merged
      sql/examples/ha_archive.cc:
        Auto merged
      mysql-test/lib/mtr_process.pl:
        Manual merge.
      mysql-test/mysql-test-run.pl:
        Manual merge.
      mysql-test/r/grant2.result:
        Manual merge.
      mysql-test/t/grant2.test:
        Manual merge.
      sql/sql_acl.cc:
        Manual merge.
      sql/sql_parse.cc:
        Manual merge.
      7783dbbc
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 84ddd543
      unknown authored
      into  mysql.com:/home/dlenev/src/mysql-4.1-bg12423
      
      
      sql/mysqld.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      mysql-test/r/grant2.result:
        Manual merge.
      mysql-test/t/grant2.test:
        Manual merge.
      84ddd543
    • unknown's avatar
      Fix for bug #12423 "Deadlock when doing FLUSH PRIVILEGES and GRANT in · 2a64e9a2
      unknown authored
      multi-threaded environment".
      
      To avoid deadlocks between several simultaneously run account management 
      commands (particularly between FLUSH PRIVILEGES/SET PASSWORD and GRANT
      commands) we should always take table and internal locks during their
      execution in the same order. In other words we should first open and lock
      privilege tables and only then obtain acl_cache::lock/LOCK_grant locks.
      
      
      mysql-test/r/grant2.result:
        Added test for bug #12423 "Deadlock when doing FLUSH PRIVILEGES and GRANT in 
        multi-threaded environment".
      mysql-test/t/grant2.test:
        Added test for bug #12423 "Deadlock when doing FLUSH PRIVILEGES and GRANT in 
        multi-threaded environment".
      sql/mysqld.cc:
        acl_init/grant_init() are now used only at server start up so they always
        allocate temporary THD object and don't need argument for passing pointer
        to it.
      sql/sql_acl.cc:
        To avoid deadlocks between several simultaneously run account management 
        commands (particularly between FLUSH PRIVILEGES/SET PASSWORD and GRANT
        commands) we should always take table and internal locks during their
        execution in the same order. In other words we should first open and lock
        privilege tables and only then obtain acl_cache::lock/LOCK_grant locks.
        
        Changed acl_reload()/grant_reload() and change_password()/update_user_table()
        in such way that they obey this principle. Now in acl_reload()/grant_reload()/
        change_password() we open and lock privilege tables, then obtain internal
        locks and then call acl_load()/grant_load()/update_user_table() functions to
        do actual loading or updating.
      sql/sql_acl.h:
        acl_init/grant_init() are now used only at server start up so they always
        allocate temporary THD object and don't need argument for passing pointer
        to it. acl_reload()/grant_reload() now are able to report about their
        success or failure through return value.
      sql/sql_parse.cc:
        If reload_acl_and_cache() is called from SIGHUP handler we have to
        allocate temporary THD for execution of acl_reload()/grant_reload().
      2a64e9a2
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · f5db9c9a
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.0
      
      
      f5db9c9a
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/mysql-5.0 · fee8f2d2
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/bug11286/my50-bug11286
      
      
      client/mysqltest.c:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      fee8f2d2
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-4.1 · 3aa2467e
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-4.1
      
      
      3aa2467e
    • unknown's avatar
      mtr_process.pl: · b63869bd
      unknown authored
        Make sure mtr_kill_processes() is called with an array ref
        Corrected error string for STDERR redirect
      
      
      mysql-test/lib/mtr_process.pl:
        Make sure mtr_kill_processes() is called with an array ref
      b63869bd
    • unknown's avatar
      Merge pnousiainen@bk-internal.mysql.com:/home/bk/mysql-5.0 · ebfa6c2d
      unknown authored
      into  mysql.com:/export/space/pekka/ndb/version/my50
      
      
      ebfa6c2d
    • unknown's avatar
      ndb - fix ha_ndb crash on ordered index on nullable varchar · d2a0a879
      unknown authored
      
      mysql-test/r/ndb_index_ordered.result:
        fix ha_ndb crash on ordered index on nullable varchar
      mysql-test/t/ndb_index_ordered.test:
        fix ha_ndb crash on ordered index on nullable varchar
      sql/ha_ndbcluster.cc:
        fix ha_ndb crash on ordered index on nullable varchar
      d2a0a879
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/mysql-5.0 · 944666ef
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/bug12526/my50-bug12526
      
      
      944666ef
    • unknown's avatar
      Bug #12717 yassl: Crashes in "integer.cpp" when compiled with icc · e4cfbaed
      unknown authored
       - Temporary fix, disable x86 assembler.
      
      
      BUILD/compile-pentium-icc:
        Cleanup build script for icc
      extra/yassl/taocrypt/include/misc.hpp:
        Disable x86 assembler  when compiling with icc
      BUILD/compile-pentium-icc-yassl:
        New BitKeeper file ``BUILD/compile-pentium-icc-yassl''
      e4cfbaed
    • unknown's avatar
      Bug #11286 yassl incompatible with "load data infile" · 100e92f4
      unknown authored
       - Make sure that mysqltest always uses ssl when connecting to the server.
       - Pass a i32-bit int variable as argument to FIONREAD ioctl.
      
      
      client/mysqltest.c:
        Set the flag CLIENT_REMENBER_OPTIONS so that all connection attempts from mysqltest is done with the same settings.
        Old impl caused mysqltest to loose all it's settings in the second connection attempt, ex ssl settings.
      extra/yassl/src/socket_wrapper.cpp:
        64-bit Solaris requires the variable passed to FIONREAD be a 32-bit value.
        Using "int" unless _WIN32_ is defined.
      sql/sql_parse.cc:
        Update error message when sslaccepts fails. Must have been a copy and paste error.
      vio/viossl.c:
        Minor fixes
        Add timeout to DBUG_PRINT
        use function vio_ssl_fd to get sd from vio
        Remove extra whitespace
      vio/viosslfactories.c:
        Remove DBUG_PRINT("enter" in sslaccept and sslconnect as it tries to print out null strings. That is not suported on all platforms.
      100e92f4
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · b5f87344
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.0
      
      
      sql/examples/ha_archive.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      b5f87344
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 8fddb973
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-4.1
      
      
      sql/examples/ha_archive.cc:
        Auto merged
      8fddb973
    • unknown's avatar
      Merge mysql.com:/home/jimw/my/mysql-4.1-clean · d1c80dd6
      unknown authored
      into  mysql.com:/home/jimw/my/mysql-5.0-clean
      
      
      configure.in:
        Auto merged
      include/my_global.h:
        Auto merged
      myisam/mi_extra.c:
        Auto merged
      mysql-test/r/lowercase_table.result:
        Auto merged
      mysql-test/t/lowercase_table.test:
        Auto merged
      mysys/my_access.c:
        Auto merged
      BitKeeper/deleted/.del-extra.c~706f29d72beb2565:
        Auto merged
      sql/examples/ha_tina.cc:
        Resolve conflict
      d1c80dd6
    • unknown's avatar
      Merge mysql.com:/home/jimw/my/mysql-4.1-7156 · 1b6fdf86
      unknown authored
      into  mysql.com:/home/jimw/my/mysql-4.1-clean
      
      
      1b6fdf86
    • unknown's avatar
      Merge mysql.com:/home/jimw/my/mysql-4.1-12325 · 53effe94
      unknown authored
      into  mysql.com:/home/jimw/my/mysql-4.1-clean
      
      
      53effe94
    • unknown's avatar
      Fix handling of filenames that start the same as reserved filenames · b33e9493
      unknown authored
      on Windows. (Bug #12325)
      
      
      mysql-test/r/lowercase_table.result:
        Update results
      mysql-test/t/lowercase_table.test:
        Move test to new windows.test, since it is Windows-specific
      mysys/my_access.c:
        Check that we've matched the whole forbidden name.
      mysql-test/include/windows.inc:
        New BitKeeper file ``mysql-test/include/windows.inc''
      mysql-test/r/windows.result:
        New BitKeeper file ``mysql-test/r/windows.result''
      mysql-test/t/windows.test:
        New BitKeeper file ``mysql-test/t/windows.test''
      b33e9493
  2. 31 Aug, 2005 21 commits
    • unknown's avatar
      Merge mysql.com:/home/jimw/my/mysql-4.1-clean · bdddd8c0
      unknown authored
      into  mysql.com:/home/jimw/my/mysql-5.0-clean
      
      
      mysql-test/r/func_gconcat.result:
        Auto merged
      mysql-test/t/func_gconcat.test:
        Auto merged
      mysql-test/t/system_mysql_db_fix.test:
        Auto merged
      ndb/src/kernel/blocks/backup/BackupInit.cpp:
        Auto merged
      ndb/src/kernel/blocks/dbacc/Dbacc.hpp:
        Auto merged
      ndb/src/kernel/blocks/dbacc/DbaccInit.cpp:
        Auto merged
      ndb/src/kernel/blocks/dbacc/DbaccMain.cpp:
        Auto merged
      ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
        Auto merged
      ndb/src/kernel/blocks/dbdict/Dbdict.hpp:
        Auto merged
      ndb/src/kernel/blocks/dbdih/DbdihMain.cpp:
        Auto merged
      ndb/src/kernel/blocks/dblqh/Dblqh.hpp:
        Auto merged
      ndb/src/kernel/blocks/dblqh/DblqhInit.cpp:
        Auto merged
      ndb/src/kernel/blocks/dblqh/DblqhMain.cpp:
        Auto merged
      ndb/src/kernel/blocks/dbtup/Dbtup.hpp:
        Auto merged
      ndb/src/kernel/blocks/dbtup/DbtupGen.cpp:
        Auto merged
      ndb/src/kernel/blocks/dbtup/DbtupMeta.cpp:
        Auto merged
      ndb/src/kernel/blocks/ndbcntr/NdbcntrMain.cpp:
        Auto merged
      ndb/src/kernel/vm/SimulatedBlock.cpp:
        Auto merged
      ndb/src/kernel/vm/SimulatedBlock.hpp:
        Auto merged
      ndb/src/mgmclient/CommandInterpreter.cpp:
        Auto merged
      ndb/src/mgmsrv/ConfigInfo.cpp:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      ndb/src/ndbapi/ndberror.c:
        Resolve conflicts
      sql/ha_innodb.cc:
        Resolve conflicts
      sql/item_strfunc.cc:
        Resolve conflicts
      bdddd8c0
    • unknown's avatar
      92e2b9ed
    • unknown's avatar
      fcc48eb3
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-4.1 · 1e791cc5
      unknown authored
      into poseidon.ndb.mysql.com:/home/tomas/mysql-4.1
      
      
      1e791cc5
    • unknown's avatar
      added make of ndb sys file printer · c2005a0f
      unknown authored
      c2005a0f
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-4.1 · f1e34fb7
      unknown authored
      into moonbone.local:/work/12861-bug-4.1-mysql
      
      
      f1e34fb7
    • unknown's avatar
      improved the ndb redo log reader · 35c17763
      unknown authored
      35c17763
    • unknown's avatar
      create.test, create.result, sql_select.cc, item.cc: · c6b54efe
      unknown authored
        After merge fix for bug #12537
      
      
      sql/item.cc:
        After merge fix for bug #12537
      sql/sql_select.cc:
        After merge fix for bug #12537
      mysql-test/r/create.result:
        After merge fix for bug #12537
      mysql-test/t/create.test:
        After merge fix for bug #12537
      c6b54efe
    • unknown's avatar
      Manual merged · a1f59825
      unknown authored
      
      mysql-test/r/create.result:
        Auto merged
      mysql-test/t/create.test:
        Auto merged
      a1f59825
    • unknown's avatar
      Add test for madvise() being declared in C++ code, because it is not · b34af8cd
      unknown authored
      on Solaris even though it is available, and declare it ourselves in
      that case. (Bug #7156)
      
      
      configure.in:
        Add test for madvise() being declared when C++ compiler is used.
      include/my_global.h:
        Handle madvise() being available but not declared in C++
      isam/extra.c:
        Fix typo in define test
      myisam/mi_extra.c:
        Fix typo in define test
      sql/examples/ha_tina.cc:
        Test that we have madvise() before trying to call it.
      b34af8cd
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-4.1 · 88dedca2
      unknown authored
      into poseidon.ndb.mysql.com:/home/tomas/mysql-4.1
      
      
      88dedca2
    • unknown's avatar
      Merge svlasenko@bk-internal.mysql.com:/home/bk/mysql-5.0 · 8699f77c
      unknown authored
      into  selena.:H:/MYSQL/src/#11815-mysql-5.0
      
      
      8699f77c
    • unknown's avatar
      mtr_timer.pl, mtr_report.pl, mtr_process.pl, mysql-test-run.pl: · 0caa2a61
      unknown authored
        Backporting from 5.0
      
      
      mysql-test/mysql-test-run.pl:
        Backporting from 5.0
      mysql-test/lib/mtr_process.pl:
        Backporting from 5.0
      mysql-test/lib/mtr_report.pl:
        Backporting from 5.0
      mysql-test/lib/mtr_timer.pl:
        Backporting from 5.0
      0caa2a61
    • unknown's avatar
      Fix bug #12861 client hang with group_concat insubquery FROM DUAL. · fc45b816
      unknown authored
      Item_func_group_concat::fix_fields() set maybe_null flag to 0, and set it to
      1 only if some of it's arguments may be null. When used in subquery in tmp 
      table created field which can't be null. When no data retireved result field
      have to be set to null and error mentioned in bug report occurs. Also this 
      bug can occur if selecting from not null field in empty table.
      
      Function group_concat now marked maybe_null from the very beginning not only
      if some of it's argument may be null.
      
      
      sql/item_sum.cc:
        Fix bug #12861 client hang with group_concat insubquery FROM DUAL.
      mysql-test/r/func_gconcat.result:
        Test case for bug #12861 client hang with group_concat insubquery FROM DUAL.
      mysql-test/t/func_gconcat.test:
        Test case for bug #12861 client hang with group_concat insubquery FROM DUAL.
      fc45b816
    • unknown's avatar
      c2252e45
    • unknown's avatar
      ha_innodb.cc: · 8510e747
      unknown authored
        Fix bug #12410 : InnoDB was too permissive with LOCK TABLE ... READ LOCAL, and alowed new inserts to the table; we now make READ LOCAL equivalent to READ for InnoDB; note that this will cause slightly more locking in mysqldump, but makes the InnoDB table dumps consistent with MyISAM table dumps; note that the real code change patch was accidentally pushed with my another patch 5 minutes ago
      
      
      sql/ha_innodb.cc:
        Fix bug #12410 : InnoDB was too permissive with LOCK TABLE ... READ LOCAL, and alowed new inserts to the table; we now make READ LOCAL equivalent to READ for InnoDB; note that this will cause slightly more locking in mysqldump, but makes the InnoDB table dumps consistent with MyISAM table dumps; note that the real code change patch was accidentally pushed with my another patch 5 minutes ago
      8510e747
    • unknown's avatar
      ha_innodb.cc: · 138e44b8
      unknown authored
        Fix bug #12852 : do not increment the open handle count to a table if the table does not have an .ibd file and InnoDB decides to return an error from the ::open() function; then the table can be dropped even if the user has tried to open it
      
      
      sql/ha_innodb.cc:
        Fix bug #12852 : do not increment the open handle count to a table if the table does not have an .ibd file and InnoDB decides to return an error from the ::open() function; then the table can be dropped even if the user has tried to open it
      138e44b8
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-4.1 · d0c2e46f
      unknown authored
      into poseidon.ndb.mysql.com:/home/tomas/mysql-4.1
      
      
      d0c2e46f
    • unknown's avatar
      corrected some erroneous ndb error messages · 46e57973
      unknown authored
      46e57973
    • unknown's avatar
    • unknown's avatar
      Merge mysql.com:/usr/home/ram/work/4.1.b9613 · c00dd12c
      unknown authored
      into  mysql.com:/usr/home/ram/work/mysql-5.0
      
      
      sql/ha_blackhole.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      mysql-test/r/variables.result:
        merging
      mysql-test/t/variables.test:
        merging
      c00dd12c