1. 18 Jul, 2005 18 commits
    • unknown's avatar
      Merge mysql.com:/home/kostja/mysql/mysql-4.1-root · 7f6f31ae
      unknown authored
      into  mysql.com:/home/kostja/mysql/mysql-5.0-merge
      
      
      client/mysqltest.c:
        Auto merged
      mysql-test/r/rpl_log.result:
        Auto merged
      mysql-test/r/rpl_rotate_logs.result:
        Auto merged
      mysql-test/r/select.result:
        Auto merged
      mysql-test/r/timezone_grant.result:
        Auto merged
      mysql-test/t/ctype_utf8.test:
        Auto merged
      mysql-test/t/timezone_grant.test:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_repl.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      configure.in:
        Manual merge
      mysql-test/r/olap.result:
        Manual merge
      mysql-test/t/olap.test:
        Manual merge
      mysql-test/t/select.test:
        Manual merge
      sql/mysqld.cc:
        Manual merge
      sql/sql_parse.cc:
        Manual merge
      7f6f31ae
    • unknown's avatar
      Fixed the ucs2 -> eucjpms conversion bug (bug#11717) · 21332fe0
      unknown authored
      
      mysql-test/r/ctype_eucjpms.result:
        Added test for the bug#11717
      mysql-test/t/ctype_eucjpms.test:
        Added test for the bug#11717
      strings/ctype-eucjpms.c:
        Fixed the ucs2 -> eucjpms conversion bug
      21332fe0
    • unknown's avatar
      Fix BUILD/autorun.sh to really bail out on error. · c6825704
      unknown authored
      
      BUILD/autorun.sh:
        Make exit on error actually work.
      c6825704
    • unknown's avatar
      Fixes to previous changeset · f29f6ce1
      unknown authored
      get_defaults_file() -> get_defaults_options()
      
      
      include/my_sys.h:
        Remove deleted function
      libmysql/libmysql.def:
        get_defaults_file() -> get_defaults_options()
      libmysqld/libmysqld.def:
        get_defaults_file() -> get_defaults_options()
      f29f6ce1
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 5b6c1348
      unknown authored
      into  mishka.local:/home/my/mysql-5.0
      
      
      client/mysqldump.c:
        Auto merged
      include/my_sys.h:
        Auto merged
      mysys/Makefile.am:
        Auto merged
      sql/ha_innodb.cc:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/sql_cache.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysys/default.c:
        SCCS merged
      5b6c1348
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0 · abde46de
      unknown authored
      into moonbone.local:/work/mysql-5.0-bug-11482
      
      
      abde46de
    • unknown's avatar
      Merge moonbone.local:/work/mysql-4.1-bug-11868 · 3e5cbdbb
      unknown authored
      into moonbone.local:/work/mysql-5.0-bug-11482
      
      
      mysql-test/r/update.result:
        Auto merged
      mysql-test/t/update.test:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      3e5cbdbb
    • unknown's avatar
      Merge grichter@bk-internal.mysql.com:/home/bk/mysql-5.0 · 76d1bf38
      unknown authored
      into lmy002.wdf.sap.corp:/home/georg/work/mysql/prod/mysql-5.0
      
      
      76d1bf38
    • unknown's avatar
      select.test: · 435a1c93
      unknown authored
        Changed test case comment to be more meaningful
      
      
      mysql-test/t/select.test:
        Changed test case comment to be more meaningful
      435a1c93
    • unknown's avatar
      Manual merge · d4b1f6fa
      unknown authored
      
      mysql-test/r/select.result:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      d4b1f6fa
    • unknown's avatar
      Fix bug#11482 4.1.12 produces different resultset for a complex query · 6b08ac6b
      unknown authored
        than in previous 4.1.x
      
      Wrongly applied optimization were adding NOT NULL constraint which results in
      rejecting valid rows and reduced result set.
      
      The problem was that add_notnull_conds() while checking subquery were adding
      NOT NULL constraint to left joined table, to which, normally, optimization 
      don't have to be applied.
      
      
      sql/sql_select.cc:
        Fix bug #11482 Wrongly applied optimization was erroneously rejecting valid rows
        Constraint were added to optimization appliance test.
      mysql-test/t/select.test:
        Test case for bug #11482  Wrongly applied optimization was erroneously rejecting valid rows
      mysql-test/r/select.result:
        Test case for bug #11482  Wrongly applied optimization was erroneously rejecting valid rows
      6b08ac6b
    • unknown's avatar
      Alleviate the autoconf requirement. · ddc35864
      unknown authored
      ddc35864
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-4.1 · ffa7e3f1
      unknown authored
      into production.mysql.com:/nfstmp1/guilhem/mysql-4.1-prod
      
      
      ffa7e3f1
    • unknown's avatar
      Fix for BUG#12003 "assertion failure in testsuite (double lock of · 750eedd9
      unknown authored
       LOCK_thread_count)" and for BUG#12004 "SHOW BINARY LOGS reports 0
      for the size of all binlogs but the current one".
      There are a lot of 4.1->5.0 unmerged changes (hardest are in the optimizer), can't merge; still pushing in 4.1 because my changes 
      are very small. Feel free to ask me if you have problems merging them.
      
      
      mysql-test/r/rpl_log.result:
        correcting binlog sizes
      mysql-test/r/rpl_rotate_logs.result:
        correcting binlog sizes
      sql/mysqld.cc:
        don't lock LOCK_thread_count when you already have it
      sql/sql_repl.cc:
        my_open() needs the complete name, not only the base name
      750eedd9
    • unknown's avatar
      Cleanups during review · 68b4d7b7
      unknown authored
      Changed defaults option --instance to --defaults-group-suffix
      Changed option handling to allow --defaults-file, --defaults-extra-file and --defaults-group-suffix to be given in any order
      Changed MYSQL_INSTANCE to MYSQL_GROUP_SUFFIX
      mysql_print_defaults now understands --defaults-group-suffix
      Remove usage of my_tempnam() (not safe function)
      if( -> if ( and while( to while (
      
      
      BitKeeper/deleted/.del-my_tempnam.c~a8562f15dad3012f:
        Delete: mysys/my_tempnam.c
      VC++Files/client/mysqlclient.dsp:
        Remove not used file my_tempnam.c
      VC++Files/client/mysqlclient_ia64.dsp:
        Remove not used file my_tempnam.c
      VC++Files/libmysql/libmysql.dsp:
        Remove not used file my_tempnam.c
      VC++Files/libmysql/libmysql_ia64.dsp:
        Remove not used file my_tempnam.c
      VC++Files/mysys/mysys.dsp:
        Remove not used file my_tempnam.c
      VC++Files/mysys/mysys_ia64.dsp:
        Remove not used file my_tempnam.c
      client/mysql.cc:
        Change to use get_defaults_options()
        Remove compiler warnings
      client/mysqldump.c:
        Indentation fixes
        Use quoted table name for 'primary_key_fields'
      extra/my_print_defaults.c:
        Add support for --defaults-group-suffix
        change to use get_default_options()
      extra/replace.c:
        Replace my_tempnam() with create_tmp_file() to allow us to remove my_tempnam.c
      include/config-win.h:
        Added DEFAULT_GROUP_SUFFIX_ENV
      include/my_sys.h:
        Change defaults_instance -> defaults_group_suffix
        Change get_defaults_files -> get_defaults_options
      libmysql/Makefile.shared:
        Added DEFAULT_GROUP_SUFFIX_ENV
      mysys/Makefile.am:
        Added DEFAULT_GROUP_SUFFIX_ENV
        Remove my_tempnam.c
      mysys/default.c:
        Changed --instance to --defaults-group-suffix
        Changed MYSQL_INSTANCE to MYSQL_GROUP_SUFFIX and moved the name to Makefile.am
        (mysys shouldn't by MySQL independent)
        Changed option handling to allow --defaults-file, --defaults-extra-file and --defaults-group-suffix to be given in any order
      mysys/default_modify.c:
        Optimized code to use allocated space more efficently
        Reduce code size
        Ensure that realloc() works independent of argument size
      mysys/my_bitmap.c:
        Added missing return
      sql/ha_innodb.cc:
        Change if( -> if (
      sql/ha_ndbcluster.cc:
        Change while( -> while (
      sql/item_cmpfunc.cc:
        Break loop early (simple optimization)
      sql/item_strfunc.cc:
        Change if( -> if (
      sql/log.cc:
        Fixed comment
      sql/mysqld.cc:
        Change if( -> if (
      sql/opt_range.cc:
        while( -> while (
        if( -> if (
      sql/parse_file.cc:
        Change if( -> if (
      sql/sql_cache.cc:
        while( -> while (
      sql/sql_parse.cc:
        Change if( -> if (
      sql/sql_prepare.cc:
        Added comment
      sql/sql_select.cc:
        while( -> while (
        Removed index variable by incrementing pointer
      sql/sql_show.cc:
        Change if( -> if (
      sql/sql_yacc.yy:
        Change if( -> if (
      tests/mysql_client_test.c:
        Added cast to first argument to bzero()
      68b4d7b7
    • unknown's avatar
    • unknown's avatar
      Merge lgrimmer@bk-internal.mysql.com:/home/bk/mysql-4.1 · 3ee08038
      unknown authored
      into mysql.com:/space/my/mysql-4.1
      
      
      mysql-test/t/ctype_utf8.test:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      3ee08038
    • unknown's avatar
      Merge lgrimmer@bk-internal.mysql.com:/home/bk/mysql-5.0 · ee686641
      unknown authored
      into mysql.com:/space/my/mysql-5.0
      
      
      tests/mysql_client_test.c:
        Auto merged
      ee686641
  2. 17 Jul, 2005 5 commits
    • unknown's avatar
      Merge pgalbraith@bk-internal.mysql.com:/home/bk/mysql-5.0 · 0d0aa7a4
      unknown authored
      into  krsna.patg.net:/home/patg/mysql-5.0
      
      
      0d0aa7a4
    • unknown's avatar
      select.result, select.test: · 6a88fa48
      unknown authored
        Added a test case for bug #11745.
      sql_select.cc:
        Fixed bug # 11745.
        Added support of where clause for queries with FROM DUAL.
      sql_yacc.yy:
        Fixed bug # 11745.
        Added optional where clause for queries with FROM DUAL.
      
      
      sql/sql_yacc.yy:
        Fixed bug # 11745.
        Added optional where clause for queries with FROM DUAL.
      sql/sql_select.cc:
        Fixed bug # 11745.
        Added support of where clause for queries with FROM DUAL.
      mysql-test/t/select.test:
        Added a test case for bug #11745.
      mysql-test/r/select.result:
        Added a test case for bug #11745.
      6a88fa48
    • unknown's avatar
      Federated Storage Engine, bug 9925 "Federated query processor (step 2 or step 3) not using logic in · 6771f8d0
      unknown authored
      WHERE statement"
      
      
      sql/ha_federated.cc:
        Changes per Jimw's review. 
        
        notes about some suggestions:
        
        1. Tried to replace my_sprintf with strxmov, but had problems. Couldn't 
           get the test suite to run at all, and could not find any particular
           error. Since this is something that is not critical, I'll leave it
           as is for now.
        2. I would like to use my_error to create all of my error messages, but 
           cannot figure out how to get it to take more than one argument to be
           passed to the error message (I tried this once but had errors, and 
           cannot find an example of how to get it to work despite seeing messages
           with obviously more than one arg
        3. Replaced all string building from literals to defined SQL string pieces
           such as "SELECT ", "FROM " ...
        4. Format fixes, spacing fixes completed
        5. Removed records_in_range records calculation functionality
      sql/ha_federated.h:
        Formatting changes, new defines for SQL query string tokens
      sql/share/errmsg.txt:
        changed 'SRC' to 'SOURCE' per Jimw's review
      6771f8d0
    • unknown's avatar
      Merge ibabaev@bk-internal.mysql.com:/home/bk/mysql-4.1 · 89519b67
      unknown authored
      into rurik.mysql.com:/home/igor/mysql-4.1
      
      
      sql/sql_select.cc:
        Auto merged
      89519b67
    • unknown's avatar
      func_in.result, func_in.test: · e155a0c0
      unknown authored
        Fixed bug #11885.
      sql_select.cc:
        Fixed bug #11885.
        Predicates of the forms 'a IN (v)' 'a NOT IN (v)' now
        is replaced by 'a=v' and 'a<>v' at the parsing stage.
      sql_yacc.yy:
        Fixed bug #11885.
        Predicates of the forms 'a IN (v)' 'a NOT IN (v)' now 
        is replaced by 'a=v' and 'a<>v' at the parsing stage.
      
      
      sql/sql_yacc.yy:
        Fixed bug #11885.
        Predicates of the forms 'a IN (v)' 'a NOT IN (v) now 
        is replaced by 'a=v' and 'a<>v' at the parsing stage.
      sql/sql_select.cc:
        Fixed bug #11885.
        Predicates of the forms 'a IN (v)' 'a NOT IN (v) now
        is replaced by 'a=v' and 'a<>v' at the parsing stage.
      mysql-test/t/func_in.test:
        Fixed bug #11885.
      mysql-test/r/func_in.result:
        Fixed bug #11885.
      e155a0c0
  3. 16 Jul, 2005 14 commits
    • unknown's avatar
      opt_range.cc: · e2bd7401
      unknown authored
        Fixed bug #11853.
        Corrected the code of the range optimization for
        NOT IN and NOT BETWEEN.
      range.test, range.result:
        Fixed bug #11853.
      
      
      mysql-test/t/range.test:
        Fixed bug #11853.
      sql/opt_range.cc:
        Fixed bug #11853.
        Corrected the code of the range optimization for
        NOT IN and NOT BETWEEN.
      e2bd7401
    • unknown's avatar
      After-merge fixes (4.1 -> 5.0). · 7bdc4dd0
      unknown authored
      
      mysql-test/r/sp.result:
        Test results fixed: rewritten test for Bug#6129
      mysql-test/r/view.result:
        Push a change to the result file from Sanja's patch.
      mysql-test/t/sp.test:
        Rewrite the test for Bug#6129 (now that stored procedures don't
        evaluate system variables at parse, the test produced different results).
        The old test failed with 1 in the second invocation (the old
        result was wrong).
      sql/item_func.cc:
        After-merge fix.
      sql/item_func.h:
        After-merge fix.
      sql/mysql_priv.h:
        After-merge fix.
      sql/mysqld.cc:
        Rollback the patch for Bug#7403 (it breaks the test suite).
      7bdc4dd0
    • unknown's avatar
      Merge mysql.com:/opt/local/work/mysql-4.1-root · 40efb362
      unknown authored
      into  mysql.com:/media/sda1/mysql/mysql-5.0-merge
      
      
      mysql-test/r/select.result:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/ps.result:
        Manual merge (again).
      mysql-test/t/ps.test:
        Manual merge (again).
      mysql-test/t/select.test:
        Manual merge (again).
      sql/item_func.cc:
        Manual merge (again).
      sql/item_func.h:
        Manual merge (again).
      sql/set_var.h:
        Manual merge (again).
      40efb362
    • unknown's avatar
      Added test for Bug #11521 · 7adfe96d
      unknown authored
      "Negative integer keys incorrectly substituted for 0 during range analysis."
      
      The problem is that the range optimizer incorrectly replaces any negative
      constant with '0' for all types except BIGINT because the method save_in_field()
      casts negative integers to non-negative. This causes incorrect query
      results where (0 = any_negative_number).
      
      The problem caused by this bug is fixed by the patch for BUG#11185.
      That patch constitutes an optimization due to which the problem code is
      never called with negative constants. This patch adds a test so we are sure
      that the problem does not reappear.
      
      
      mysql-test/r/select.result:
        Test for BUG#11521.
      mysql-test/t/select.test:
        Test for BUG#11521.
      7adfe96d
    • unknown's avatar
      cs fixes · 0789b177
      unknown authored
      0789b177
    • unknown's avatar
      Merge grichter@bk-internal.mysql.com:/home/bk/mysql-5.0 · 757ad317
      unknown authored
      into lmy002.wdf.sap.corp:/home/georg/work/mysql-5.0
      
      
      tests/mysql_client_test.c:
        Auto merged
      757ad317
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-5.0 · 58f67c6d
      unknown authored
      into  sanja.is.com.ua:/home/bell/mysql/bk/work-bug6-5.0
      
      
      58f67c6d
    • unknown's avatar
      Restore previous used client charset in mysql_reconnect · 90002cdc
      unknown authored
      Moved mysql_set_character_set function to client.c
      Changed function prototype for mysql_set_character_set (as suggested
      by Konstantin)
      
      
      include/mysql.h:
        Changed function prototype
      libmysql/libmysql.c:
        moved mysql_set_character_set to client.c
      sql-common/client.c:
        moved mysql_set_character_set to client.c
      90002cdc
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.1 · b6f3a373
      unknown authored
      into  mysql.com:/home/jimw/my/mysql-4.1-clean
      
      
      b6f3a373
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-4.1 · cc57265b
      unknown authored
      into moonbone.local:/work/mysql-4.1-bug-11868
      
      
      cc57265b
    • unknown's avatar
      Fix bug#11868 NOT NULL ref optimization in subquery used in update must be · 560ff1a2
      unknown authored
      disabled if ref is built with a key from the updated table
      
      Problem was in add_not_null_conds() optimization function.
      It contains following code:
      JOIN_TAB *referred_tab= not_null_item->field->table->reginfo.join_tab;
      ...
      add_cond_and_fix(&referred_tab->select_cond, notnull);
      For UPDATE described in bug report referred_tab is 0 and dereferencing it
      crashes the server.
      
      
      
      sql/sql_select.cc:
        Fix bug #11868 NOT NULL ref optimization in subquery used in update must be
        disabled if ref is built with a key from the updated table
      mysql-test/r/update.result:
        Test case for bug#11868 Update with subquery with ref built with a key from
        the updated table crashes server.
      mysql-test/t/update.test:
        Test case for bug#11868 Update with subquery with ref built with a key from the updated table crashes server
      560ff1a2
    • unknown's avatar
      Merge baker@bk-internal.mysql.com:/home/bk/mysql-5.0 · 2f4fd88a
      unknown authored
      into  zim.(none):/home/brian/mysql/foo-5.0
      
      
      2f4fd88a
    • unknown's avatar
      Added federated to max base test. · 48995b9a
      unknown authored
      
      BUILD/SETUP.sh:
        Added federated to base_max tests.
      48995b9a
    • unknown's avatar
      This is the same patch as 1.1937, with small variable declaration changes, memory · d887a692
      unknown authored
      deallocation cleanup
      
      
      mysql-test/r/federated.result:
        new test results
      mysql-test/t/federated.test:
        New tests, and added explains per Timour's suggestion. This will keep
                track of whether changes have been made to the optimiser that might affect
                Federated.
                Also changed the error codes to federated error codes in the error tests
      sql/ha_federated.cc:
        1. Not using MAX_REMOTE_SIZE, so removed
                 2. Changed all defines that were IO_SIZE to FEDERATED_QUERY_BUFFER_SIZE
                 3. Now using Federated Error Codes
                 4. Implemented ::info (gets valid 'records' number)
                 5. Implemented ::read_range_first - now uses indexes in range operations
                 6. Better allocation in get_share
                 7. Cleaned up memory bug in get_share
                 8. Better initial query "SELECT * FROM t1 WHERE 1=0" for check_foreign_data_src
                 9. emit_key_part_name and emit_key_part_element for read_range_first to not
                    have redundancy
                 10. Made sure all 'append's pass length, and use append("") to ensure proper
                     null termination of strings being built.
                 11. Better message creation. If ER_QUERY_ON_FOREIGN_DATA_SRC, I also pass
                     the actual error code and message from the foreign data src.
                 12. Cleaned up how the result set and share->scheme is freed.
      sql/share/errmsg.txt:
        New Federated error messages that are more tailored to the type of information
        we want to see when federated has an error.
      mysql-test/include/federated.inc:
        New bitkeeper file, include file for separating setup from main test suite
      mysql-test/include/federated_cleanup.inc:
        New BitKeeper file ``mysql-test/include/federated_cleanup.inc''
      sql/ha_federated.h:
        Added comments where needed, one was already commented about
      d887a692
  4. 15 Jul, 2005 3 commits