1. 06 Dec, 2012 2 commits
  2. 21 Dec, 2012 1 commit
  3. 20 Dec, 2012 2 commits
    • Vladislav Vaintroub's avatar
      MDEV-3945 - do not hold LOCK_thread_count when freeing THD. · 21b4fda3
      Vladislav Vaintroub authored
        
      The patch decreases the duration of LOCK_thread_count, so it is not hold during THD destructor and freeing memory.
      This mutex  now only protects the integrity of threads list, when removing THD from it,  and thread_count variable.
        
      The add_to_status() function that updates global status during client disconnect,  is now correctly protected by the LOCK_status mutex.
      
      Benchmark : in a  "non-persistent" sysbench test (oltp_ro with reconnect after each query),  ~ 25% more connects/disconnects were measured
      21b4fda3
    • unknown's avatar
      MDEV-3899 Valgrind warnings (blocks are definitely lost) in filesort on IN... · 1b2692d0
      unknown authored
      MDEV-3899  Valgrind warnings (blocks are definitely lost) in filesort on IN subquery with SUM and DISTINCT
        
      Analysys:
      In the beginning of JOIN::cleanup there is code that is supposed to
      free all filesort buffers. The code assumes that the table being sorted
      is the first non-constant table. To get this table it calls:
      first_top_level_tab(this, WITHOUT_CONST_TABLES)
        
      However, first_top_level_tab() instead returned the wrong table - the first
      one in the plan, instead of the first non-constant table. There is no other
      place outside filesort() where sort buffers may be freed. As a result, the
      sort buffer was not freed, and there was a memory leak.
        
      Solution:
      Change first_top_level_tab(), to test for WITH_CONST_TABLES instead of
      WITHOUT_CONST_TABLES.
      1b2692d0
  4. 19 Dec, 2012 1 commit
    • Michael Widenius's avatar
      Fixed some compiler warnings · 35b60208
      Michael Widenius authored
      client/mysqldump.c:
        Removed compiler warning
      extra/yassl/taocrypt/include/pwdbased.hpp:
        Removed compiler warning (iterations is always unsigned)
      support-files/compiler_warnings.supp:
        Ignore warnings from groff
      35b60208
  5. 18 Dec, 2012 1 commit
  6. 17 Dec, 2012 2 commits
    • Michael Widenius's avatar
      Fixed the CREATE TABLE IF EXIST generates warnings instead of errors · 2dbce3d0
      Michael Widenius authored
      mysql-test/r/create.result:
        Updated test results
      mysql-test/t/create.test:
        Updated test
      sql/sql_base.cc:
        Use push_internal_handler/pop_internal_handler to avoid errors & warnings instead of clear_error
        Give a warnings instead of an error for CREATE TABLE IF EXISTS
      sql/sql_parse.cc:
        Check if we failed because of table exists (can only happen from create)
      sql/sql_table.cc:
        Check if we failed because of table exists (can only happen from create)
      2dbce3d0
    • unknown's avatar
      MDEV-3818: Query against view over IS tables worse than equivalent query without view · d7a01487
      unknown authored
      Analysis:
      The reason for the suboptimal plan when querying IS tables through a view
      was that the view columns that participate in an equality are wrapped by
      an Item_direct_view_ref and were not recognized as being direct column
      references.
      
      Solution:
      Use the original Item_field objects via the real_item() method.
      d7a01487
  7. 16 Dec, 2012 4 commits
  8. 14 Dec, 2012 1 commit
  9. 26 Nov, 2012 1 commit
    • unknown's avatar
      Fix of MDEV-3874: Server crashes in Item_field::print on a SELECT from a MERGE... · b8b875cb
      unknown authored
      Fix of MDEV-3874: Server crashes in Item_field::print on a SELECT from a MERGE view with materialization+semijoin, subquery, ORDER BY.
      
      The problem was that in debugging binaries it try to print item to assign human readable name to the item.
      But subquery item was already freed (join_free/cleanup with full cleanup) so Item_field refers to temporary
      table which memory had been already freed.
      b8b875cb
  10. 05 Dec, 2012 1 commit
    • Igor Babaev's avatar
      Fixed bug mdev-3888. · 5e345281
      Igor Babaev authored
      When inserting a record with update on duplicate keys the server calls
      the ha_index_read_idx_map handler function to look for the record
      that violates unique key constraints. The third parameter of this call
      should mark only the base components of the index where the server is
      searched for the record. Possible hidden components of the primary key
      are to be unmarked.
      5e345281
  11. 01 Dec, 2012 2 commits
  12. 27 Nov, 2012 3 commits
  13. 26 Nov, 2012 2 commits
  14. 22 Nov, 2012 2 commits
  15. 21 Nov, 2012 2 commits
  16. 17 Nov, 2012 1 commit
    • Sergei Golubchik's avatar
      MDEV-736 LP:1004615 - Unexpected warnings "Encountered illegal value '' when... · 13ba0dd2
      Sergei Golubchik authored
      MDEV-736 LP:1004615 - Unexpected warnings "Encountered illegal value '' when converting to DECIMAL" on a query with aggregate functions and GROUP BY
      
      fix: don't call field->val_decimal() if the field->is_null()
      because the buffer at field->ptr might not hold a valid decimal value
      
      sql/item_sum.cc:
        do not call field->val_decimal() if the field->is_null()
      storage/maria/ma_blockrec.c:
        cleanup
      storage/maria/ma_rrnd.c:
        cleanup
      strings/decimal.c:
        typo
      13ba0dd2
  17. 20 Nov, 2012 3 commits
  18. 19 Nov, 2012 3 commits
  19. 17 Nov, 2012 1 commit
  20. 15 Nov, 2012 1 commit
    • Sergei Golubchik's avatar
      MDEV-3826 compilation of client programs fail: m_string.h tries to include <mysql/plugin.h> · 3a1fdc9e
      Sergei Golubchik authored
      mysql_config:
      - add not only $pkgincludedir, but also $pkgincludedir/.. to the header search path,
        for #include <mysql/plugin.h> to work
      
      
      scripts/mysql_config.sh:
        - don't support headers in */include anymore. only in */include/mysql
        - remove the incorrect "bug fix" (fixed correctly long time ago)
        - add not only $pkgincludedir, but also $pkgincludedir/.. to the header search path,
          for #include <mysql/plugin.h> to work
        - but don't do it, if $pkgincludedir/.. is /usr/include
      3a1fdc9e
  21. 12 Nov, 2012 1 commit
  22. 10 Nov, 2012 2 commits
    • Vladislav Vaintroub's avatar
      MDEV-3849 - 1 bytes stack overwrite in normalize_dirname(). · 35313020
      Vladislav Vaintroub authored
      Take into account that length of strings passed down to this function can be up to FN_REFLEN+1 bytes. including terminating zero.
      The overwrite was caused by incomplete fix to MySQL Bug # 44834
      35313020
    • Igor Babaev's avatar
      Fixed bug mdev-3845. · 094f4cf7
      Igor Babaev authored
      If triggers are used for an insert/update/delete statement than the values of
      all virtual columns must be computed as any of them may be used by the triggers.
      094f4cf7
  23. 09 Nov, 2012 1 commit