1. 12 Jun, 2006 2 commits
  2. 03 Jun, 2006 1 commit
  3. 02 Jun, 2006 3 commits
    • unknown's avatar
      Merge ibabaev@bk-internal.mysql.com:/home/bk/mysql-4.1-opt · ccad0572
      unknown authored
      into  rurik.mysql.com:/home/igor/mysql-4.1-opt
      
      
      ccad0572
    • unknown's avatar
      Fixed bug #18206. · e3e06587
      unknown authored
      The bug report revealed two problems related to min/max optimization:
      1. If the length of a constant key used in a SARGable condition for
      for the MIN/MAX fields is greater than the length of the field an 
      unwanted warning on key truncation is issued;
      2. If MIN/MAX optimization is applied to a partial index, like INDEX(b(4))
      than can lead to returning a wrong result set.
      
      
      mysql-test/r/func_group.result:
        Added test cases for bug #18206.
      mysql-test/t/func_group.test:
        Added test cases for bug #18206.
      sql/opt_sum.cc:
        Fixed bug #18206.
        Suppressed the warning about data truncation when store_val_in_field
        was used to store keys for the field used in MIN/MAX optimization.
        Blocked MIN/MAX optimization for partial keys, such as in INDEX(b(4)).
      sql/sql_select.cc:
        Fixed bug #18206.
        Added a parameter for the function store_val_in_field allowing to
        control setting warnings about data truncation in the function.
      sql/sql_select.h:
        Fixed bug #18206.
        Added a parameter for the function store_val_in_field allowing to
        control setting warnings about data truncation in the function.
      e3e06587
    • unknown's avatar
      Bug #4981: 4.x and 5.x produce non-optimal execution path, · 3390eaa0
      unknown authored
              3.23 regression test failure
      
      The member SEL_ARG::min_flag was not initialized, 
      due to which the condition for no GEOM_FLAG in function 
      key_or did not choose "Range checked for each record" as 
      the correct access method.
      
      
      mysql-test/r/select.result:
        testcase for 'Range checked' access method
      mysql-test/t/select.test:
        testcase for 'Range checked' access method
      sql/opt_range.cc:
        All of the class members initialized
      3390eaa0
  4. 30 May, 2006 1 commit
  5. 29 May, 2006 1 commit
    • unknown's avatar
      Fixed bug#18360: Incorrect type coercion in IN() results in false comparison · c007daba
      unknown authored
      The IN() function uses agg_cmp_type() to aggregate all types of its arguments
      to find out some common type for comparisons. In this particular case the 
      char() and the int was aggregated to double because char() can contain values
      like '1.5'. But all strings which do not start from a digit are converted to
      0. thus 'a' and 'z' become equal. 
      This behaviour is reasonable when all function arguments are constants. But 
      when there is a field or an expression this can lead to false comparisons. In
      this case it makes more sense to coerce constants to the type of the field
      argument.
      
      The agg_cmp_type() function now aggregates types of constant and non-constant
      items separately. If some non-constant items will be found then their
      aggregated type will be returned. Thus after the aggregation constants will be
      coerced to the aggregated type. 
      
      
      mysql-test/t/func_in.test:
        Added test case for bug#18360: Incorrect type coercion in IN() results in false comparison.
      mysql-test/r/func_in.result:
        Added test case for bug#18360: Incorrect type coercion in IN() results in false comparison.
      sql/item_cmpfunc.cc:
        Fixed bug#18360: Incorrect type coercion in IN() results in false comparison.
        The agg_cmp_type() function now aggregates types of constant and non-constant
        items separately. If some non-constant items will be found then their
        aggregated type will be returned. Thus after the aggregation constants will
        be coerced to the aggregated type.
      c007daba
  6. 28 May, 2006 1 commit
    • unknown's avatar
      Fixed bug#19225: unchecked error results in server crash · 2264b644
      unknown authored
      In multi-table delete a table for delete can't be used for selecting in
      subselects. Appropriate error was raised but wasn't checked which leads to a
      crash at the execution phase.
      
      The mysql_execute_command() now checks for errors before executing select
      for multi-delete.
      
      
      mysql-test/t/multi_update.test:
        Added test case for bug#19225: unchecked error results in server crash
      mysql-test/r/multi_update.result:
        Added test case for bug#19225: unchecked error results in server crash
      sql/sql_parse.cc:
        Fixed bug#19225: unchecked error results in server crash
        The mysql_execute_command() now checks for errors before executing select for multi-delete.
      2264b644
  7. 25 May, 2006 1 commit
    • unknown's avatar
      Fixed bug#16716: subselect in concat() may lead to a wrong result. · 1991a87d
      unknown authored
      The Item_func_concat::val_str() function tries to make as less re-allocations
      as possible. This results in appending strings returned by 2nd and next
      arguments to the string returned by 1st argument if the buffer for the first
      argument has enough free space. A constant subselect is evaluated only once 
      and its result is stored in an Item_cache_str. In the case when the first
      argument of the concat() function is such a subselect Item_cache_str returns
      the stored value and Item_func_concat::val_str() append values of other
      arguments to it. But for the next row the value in the Item_cache_str isn't
      restored because the subselect is a constant one and it isn't evaluated second
      time. This results in appending string values of 2nd and next arguments to the 
      result of the previous Item_func_concat::val_str() call.
      
      The Item_func_concat::val_str() function now checks whether the first argument 
      is a constant one and if so it doesn't append values of 2nd and next arguments
      to the string value returned by it.
      
      
      mysql-test/t/func_concat.test:
        Added test case for bug#16716: subselect in concat() may lead to a wrong result.
      mysql-test/r/func_concat.result:
        Added test case for bug#16716: subselect in concat() may lead to a wrong result.
      sql/item_strfunc.cc:
        Fixed bug#16716: subselect in concat() may lead to a wrong result.
        The Item_func_concat::val_str() function now checks whether the first argument 
        is a constant one and if so it doesn't append values of 2nd and next arguments
        to the string value returned by it.
      1991a87d
  8. 24 May, 2006 5 commits
  9. 23 May, 2006 3 commits
  10. 22 May, 2006 1 commit
  11. 21 May, 2006 1 commit
  12. 20 May, 2006 2 commits
    • unknown's avatar
      Merge · ddd9fbac
      unknown authored
      
      support-files/mysql.spec.sh:
        SCCS merged
      ddd9fbac
    • unknown's avatar
      mysql.spec.sh: · 65fcdee5
      unknown authored
        Always compile position independent
      
      
      support-files/mysql.spec.sh:
        Always compile position independent
      65fcdee5
  13. 19 May, 2006 4 commits
    • unknown's avatar
      Fix for bug #18536: mysqldump does not maintain table orders as per --tables option · c41b767a
      unknown authored
      
      client/mysqldump.c:
        Fix for bug #18536: mysqldump does not maintain table orders as per --tables option
          - use list to store table names instead of hash.
      mysql-test/r/mysqldump.result:
        Fix for bug #18536: mysqldump does not maintain table orders as per --tables option
          - test result.
      mysql-test/t/mysqldump.test:
        Fix for bug #18536: mysqldump does not maintain table orders as per --tables option
          - test case.
      c41b767a
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.1 · 891361be
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-4.1
      
      
      891361be
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/my41-bug13711 · 5c484b20
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-4.1
      
      
      5c484b20
    • unknown's avatar
      Bug#15869 Cannot shutdown the server - it restarts · 5ceb394f
      unknown authored
       - A segfault occured when the function 'kill_server' called 
         'my_sigset' with signal number 0. 'my_sigset' is a macro which
         uses 'sigaction' to install the signal handler with an invalid
         signal number will on most platforms return EINVAL but yields
         a segfauilt on IRIX 6.5
       - The server crash was detected by mysqld_safe and it was restarted although
         a shutdown was requested. 
       - Semantics of kill_server(0) is not known, leaving it intact
      
      
      include/my_pthread.h:
        Check return value from sigaction with a DBUG_ASSERT
        Also DBUG_ASSERT if signal number 0 is passed
      sql/mysqld.cc:
        Don't call my_sigset if signo is 0
      5ceb394f
  14. 17 May, 2006 2 commits
  15. 16 May, 2006 9 commits
  16. 15 May, 2006 3 commits