1. 28 Aug, 2006 3 commits
    • marko's avatar
      Reindent the code base (except for ha_innodb.{cc,h} and generated parser · 8f18616e
      marko authored
      and lexer files).  From now on, the following Emacs cc-mode settings apply
      when indenting C function bodies in InnoDB:
      
      (setq c-basic-offset 8)
      (setq c-label-minimum-indentation 0)
      (add-to-list 'c-offsets-alist '(c . 0))
      (add-to-list 'c-offsets-alist '(label . [0]))
      
      The indentation rules for function declarations still have not been
      formalized, and they must be formatted manually.
      
      Try to limit all lines to at most 79 characters (assuming TAB stops every
      8 characters) by splitting lines before opening parenthesis, or at
      string constants.
      
      Fix some grammar mistakes in diagnostic output:
       match to, match with -> match
       found from -> found in
       trying rename -> trying to rename
      
      Fix an error in page_check_dir(): it said "supremum not pointed to"
      when the infimum was not pointed to.
      
      Enclose commented-out code snippets in #if 0 ... #endif instead of /* ... */.
      Add (void*) casts to some %p parameters in fprintf() calls.  Try to
      split lines before a binary operator, not after one.  (These three fixes
      were not made everywhere.)
      8f18616e
    • osku's avatar
      page_validate(): Add missing space to error print, for real this time, · bd338ceb
      osku authored
      following an error in r761.
      bd338ceb
    • osku's avatar
      btr_cur_search_to_nth_level(): Document where cursor is left at in · 66241d5a
      osku authored
      PAGE_CUR_LE searches.
      
      page_validate(): Add missing space to error print.
      66241d5a
  2. 22 Aug, 2006 1 commit
  3. 17 Aug, 2006 2 commits
  4. 16 Aug, 2006 1 commit
  5. 14 Aug, 2006 4 commits
  6. 11 Aug, 2006 5 commits
    • marko's avatar
    • marko's avatar
      ha_innobase::delete_all_rows(): Correct an error introduced in r705: · b0d9c363
      marko authored
      Replace the local variable "trx" with "prebuilt->trx".
      
      Also, replace the second invocation of the macro current_thd with
      the local variable thd.
      b0d9c363
    • marko's avatar
      Merge a change from MySQL AB: · 122ca353
      marko authored
      # ChangeSet
      #   2006/07/30 05:16:08+04:00 aivanov@mysql.com 
      #   Make innodb_thread_concurrency 0 by default.
      #    Fixing test result.
      # 
      # mysql-test/r/innodb.result
      #   2006/07/30 05:16:05+04:00 aivanov@mysql.com +1 -1
      #   Make innodb_thread_concurrency 0 by default.
      #    Fixing test result.
      122ca353
    • marko's avatar
      Merge a change from MySQL AB (originally implemented by Marko · b4270e70
      marko authored
      in the 5.0 tree and now merged to the 5.1 tree):
      
      # ChangeSet
      #   2006/07/29 07:17:33+04:00 aivanov@mysql.com 
      #   Make innodb_flush_log_at_trx_commit a settable global variable.
      # 
      # sql/ha_innodb.cc
      #   2006/07/29 07:17:29+04:00 aivanov@mysql.com +1 -3
      #   Remove innobase_flush_log_at_trx_commit
      #   (set srv_flush_log_at_trx_commit directly).
      # 
      # sql/ha_innodb.h
      #   2006/07/29 07:17:29+04:00 aivanov@mysql.com +1 -1
      #   Remove innobase_flush_log_at_trx_commit.
      #   Declare srv_flush_log_at_trx_commit.
      # 
      # storage/innobase/include/srv0srv.h
      #   2006/07/29 07:17:30+04:00 aivanov@mysql.com +1 -1
      #   Change the type of srv_flush_log_at_trx_commit.
      # 
      # storage/innobase/srv/srv0srv.c
      #   2006/07/29 07:17:30+04:00 aivanov@mysql.com +1 -1
      #   Change the type of srv_flush_log_at_trx_commit.
      # 
      b4270e70
    • marko's avatar
      Merge a change from MySQL AB: · 6389cd96
      marko authored
      # ChangeSet
      #   2006/07/28 21:27:01+04:00 sergefp@mysql.com 
      #   BUG#14940 "MySQL choose wrong index", v.2
      # mysql-test/r/innodb_gis.result
      #   2006/07/28 21:26:56+04:00 sergefp@mysql.com +15 -15
      #   BUG#14940: Adjust the test results: EXPLAIN EXTENDED now has extra "filtered" column
      6389cd96
  7. 08 Aug, 2006 3 commits
  8. 07 Aug, 2006 3 commits
  9. 02 Aug, 2006 2 commits
  10. 01 Aug, 2006 1 commit
  11. 31 Jul, 2006 2 commits
  12. 28 Jul, 2006 1 commit
  13. 27 Jul, 2006 1 commit
    • marko's avatar
      Remove the special treatment of tables · cef9a026
      marko authored
      rsql_IDENTIFIER_recover_innodb_tmp_table, which is redundant and
      was broken with the introduction of the "safe" file name encoding of
      identifiers.  (Bug #21313)
      cef9a026
  14. 21 Jul, 2006 2 commits
  15. 15 Jun, 2006 3 commits
  16. 13 Jun, 2006 1 commit
    • marko's avatar
      Merge changes from MySQL AB: · 3412bdf0
      marko authored
      innodb_mysql.test, innodb_mysql.result:
        Bug #16798: Uninitialized row buffer reads in ref-or-null optimizer
        Bug #12882: min/max inconsistent on empty table
        Test of behaviour with CREATE ... SELECT
       Moved from group_min_max.test:
        Bug #12672: primary key implicitly included in every innodb index
        Bug #6142: a problem with empty innodb table 
        Bug #9798: group by with rollup
      
      ChangeSet@2006/06/01 21:47:15+03:00 bell@sanja.is.com.ua 
      #   interface for transaction log management added to handlerton
      #   iterators creation interface added to handlerton
      ha_innodb.cc: Add get_log_status = create_iterator = NULL
      
      ChangeSet@2006/06/04 18:52:22+03:00 monty@mysql.com 
      #   This changeset is largely a handler cleanup changeset (WL#3281),
      #   but includes fixes and cleanups that was found necessary while
      #   testing the handler changes
      # sql/ha_innodb.h
      #   2006/06/04 18:52:09+03:00 monty@mysql.com +6 -13
      #   Update to 'newer' table handler interface
      #   - table_flags are now ulonglong
      #   - Added reset() method
      #   - Removed not needed ha_retrieve_all_cols() and ha_retrieve_all_pk()
      #     columns.
      #   - Made build_template() a class function to be able to easier access
      #     class variables
      # sql/ha_innodb.cc
      #   2006/06/04 18:52:09+03:00 monty@mysql.com +37 -44
      #   Update to 'newer' table handler interface
      #   - Update innobase_create_handler() to new interface
      #   - Removed HA_NOT_EXACT_COUNT (not needed)
      #   - Renamed HA_PRIMARY_KEY_ALLOW_RANDOM_ACCESS
      #     to HA_PRIMARY_KEY_REQUIRED_FOR_POSITION.
      #   - Prefixed base status variables with 'stats'
      #   - Use table column bitmaps instead of ha_get_bit_in_read_set()
      #   - Added ::reset(), with code from ::extra(HA_EXTRA_RESET)
      #   - Removed HA_EXTRA_RETRIVE_ALL_COLS and HA_EXTRA_RETRIEVE_PRIMARY_KEY as
      #     the table->read_set and table->write_set bitmaps now are accurate
      
      ChangeSet@2006/06/02 22:21:32+02:00 guilhem@mysql.com 
      #   First push for WL#3146 "less locking in auto_increment". It is a
      #   0-real-change patch.
      #   New prototype for get_auto_increment() (but new arguments not yet used),
      #   to be able to reserve a finite interval of auto_increment values from
      #   cooperating engines.
      #   A hint on how many values to reserve is found in
      #   handler::estimation_rows_to_insert,
      #   filled by ha_start_bulk_insert(), new wrapper around start_bulk_insert().
      #   NOTE: this patch changes nothing, for all engines.
      #   But it makes the API ready for those
      #   engines which will want to do reservation.
      #   More csets will come to complete WL#3146.
      ha_innodb.h, ha_innodb.cc: update to new prototype of get_auto_increment
      
      ChangeSet@2006/05/28 14:51:01+02:00 serg@sergbook.mysql.com 
      #   handlerton cleanup:
      #   duplicate fields removed, st_mysql_storage_engine added to support
      #   run-time handlerton initialization (no compiler warnings), handler API
      #   is now tied to MySQL version, handlerton->plugin mapping added
      #   (slot-based), dummy default_hton removed, plugin-type-specific
      #   initialization generalized, built-in plugins are now initialized too,
      #   --default-storage-engine no longer needs a list of storage engines
      #   in handle_options().
      #   
      # sql/ha_innodb.h
      #   2006/05/28 14:50:53+02:00 serg@sergbook.mysql.com +1 -1
      #   handlerton cleanup: remove duplicate fields, add st_mysql_storage_engine,
      #   initialize handlerton run-time to avoid compiler warnings
      # 
      # sql/ha_innodb.cc
      #   2006/05/28 14:50:53+02:00 serg@sergbook.mysql.com +37 -52
      #   handlerton cleanup: remove duplicate fields, add st_mysql_storage_engine,
      #   initialize handlerton run-time to avoid compiler warnings
      
      ChangeSet@2006/06/01 23:59:34+02:00 serg@serg.mylan 
      #   second patch for make distcheck
      ha_innodb.cc: enclose in #ifdef WITH_INNOBASE_STORAGE_ENGINE / #endif
      3412bdf0
  17. 09 Jun, 2006 4 commits
  18. 08 Jun, 2006 1 commit