An error occurred fetching the project authors.
  1. 06 May, 2005 2 commits
    • unknown's avatar
      Bug#6616 · 079910b6
      unknown authored
        MySQL server 100% CPU if FLUSH TABLES WITH READ LOCK + INSERT
        Infinite loop caused by missing update to thd version.
      
      
      sql/sql_base.cc:
        Bug#6616
          thd version needs to be updated before reopening tables
          to prevent an infinite loop.
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      079910b6
    • unknown's avatar
      A fix for Bug#8467. · 72490191
      unknown authored
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      72490191
  2. 05 May, 2005 5 commits
    • unknown's avatar
      Added cp932 character set · b1d7d821
      unknown authored
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      b1d7d821
    • unknown's avatar
      Bug #10245 VC++ compiler error with mysql.cc · 09ca059e
      unknown authored
      Only print the read line version if we are on a platform that supports readline
      
      mysql.cc:
        Add #ifdef to only print readline version if we are on a platform that supports readline
      
      
      client/mysql.cc:
        Add #ifdef to only print readline version if we are on a platform that supports readline
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      09ca059e
    • unknown's avatar
      Bug #9721 net_write_timeout not used on Windows · af5596b3
      unknown authored
      Added an extra parameter to all calls to timeout().  
      1 means we want to set the write timeout
      0 means we wnat to set the read timeout
      
      viossl.c:
        Add which parameter to ssl timeout routine
      vio_priv.h:
        Added which parameter to vio_ignore_timeout and vio_ssl_timeout
      violite.h:
        Add which parameter to vio_timeout sigs
      net_serv.cc:
        Use proper which code in call to vio_timeout to set the proper timeout
      viosocket.c:
        Set the appropriate timeout in vio_timeout
      
      
      vio/viosocket.c:
        Set the appropriate timeout in vio_timeout
      sql/net_serv.cc:
        Use proper which code in call to vio_timeout to set the proper timeout
      include/violite.h:
        Add which parameter to vio_timeout sigs
      vio/vio_priv.h:
        Added which parameter to vio_ignore_timeout and vio_ssl_timeout
      vio/viossl.c:
        Add which parameter to ssl timeout routine
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      af5596b3
    • unknown's avatar
      A lot of fixes to Precision math · 6de14a23
      unknown authored
      Mostly about precision/decimals of the results of the operations
      
      
      include/decimal.h:
        decimal interface changed a little
      sql/field.cc:
        a lot of precision/decimals related changes to the Field_new_decimal
      sql/field.h:
        Field_new_decimal interface changed
      sql/ha_ndbcluster.cc:
        f->precision should be used here
      sql/item.cc:
        precision/decimals counting related changes
      sql/item.h:
        precision/decimals counting related changes
      sql/item_cmpfunc.cc:
        precision/decimals counting related changes
      sql/item_cmpfunc.h:
        precision/decimals counting related changes
      sql/item_func.cc:
        precision/decimals counting related changes
      sql/item_func.h:
        precision/decimals counting related changes
      sql/item_sum.cc:
        precision/decimals counting related changes
      sql/item_sum.h:
        precision/decimals counting related changes
      sql/my_decimal.cc:
        precision/decimals counting related changes
      sql/my_decimal.h:
        precision/decimals counting related changes
      sql/mysqld.cc:
        precision/decimals counting related changes
      sql/set_var.cc:
        precision/decimals counting related changes
      sql/sp_head.cc:
        dbug_decimal_print was replaced with dbug_decimal_as_string
      sql/sql_class.h:
        div_precincrement variable added
      sql/sql_parse.cc:
        precision/decimals counting related changes
      sql/sql_select.cc:
        precision/decimals counting related changes
      sql/sql_show.cc:
        Field::representation_length was removed
      strings/decimal.c:
        decimal_actual_fraction was introduced
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      6de14a23
    • unknown's avatar
      A fix (bug #10179: error in default value setting). · 936c8498
      unknown authored
      include/my_handler.h:
        A fix (bug #10179: error in default value setting).
        Proper masks added: we should not touch extra bits.
      sql/key.cc:
        A fix (bug #10179: error in default value setting).
        Unnecessary code removed.
      sql/unireg.cc:
        A fix (bug #10179: error in default value setting).
        1. we should take into account uneven bits (for bit fields) stored among NULL bits.
        2. changed code which sets NULL bits for fields.
        3. changed code which sets unused bits after NULL bits.
        4. unused variables removed.
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      936c8498
  3. 04 May, 2005 1 commit
    • unknown's avatar
      logging_ok: · 8736d8ac
      unknown authored
        Logging to logging@openlogging.org accepted
      NDBT_ResultRow.cpp, ndb_restore.test, ndb_restore.result:
        BUG#10287
      
      
      mysql-test/r/ndb_restore.result:
        BUG#10287
      mysql-test/t/ndb_restore.test:
        BUG#10287
      ndb/test/src/NDBT_ResultRow.cpp:
        BUG#10287
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      8736d8ac
  4. 29 Apr, 2005 1 commit
  5. 06 Apr, 2005 1 commit
  6. 05 Apr, 2005 1 commit
  7. 01 Apr, 2005 1 commit
    • unknown's avatar
      BUG#6554 Problem Building MySql on Fedora Core 3 · ba51ba86
      unknown authored
       - Remove the local static var
      
      
      sql/ha_berkeley.cc:
        Remove local static var, make it local in file instead.
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      ba51ba86
  8. 31 Mar, 2005 2 commits
    • unknown's avatar
      BUG#8585 ndb_cache2 · df7f4cc5
      unknown authored
       - When deleting from a cursor the m_rows_changed variable was not properly incremented to indicate that m_share->commit_count should be cleared at end of trans.
        
      
      
      sql/ha_ndbcluster.cc:
        Moved increment of m_rows_changed to higher up in the function.
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      df7f4cc5
    • unknown's avatar
      Fix for bug #9344 INFORMATION_SCHEMA, wrong content, numeric columns · 77d56859
      unknown authored
        The columns CHARACTER_MAXIMUM_LENGTH and CHARACTER_OCTET_LENGTH 
        of INFORMATION_SCHEMA.COLUMNS must be NULL for numeric columns
      
      
      mysql-test/r/information_schema.result:
        Fix for bug #9344 INFORMATION_SCHEMA, wrong content, numeric columns
      mysql-test/t/information_schema.test:
        Fix for bug #9344 INFORMATION_SCHEMA, wrong content, numeric columns
      sql/sql_show.cc:
        Fix for bug #9344 INFORMATION_SCHEMA, wrong content, numeric columns
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      77d56859
  9. 30 Mar, 2005 1 commit
    • unknown's avatar
      Do-compile: · 73e5f698
      unknown authored
        Added option --with-big-tables
      
      
      Build-tools/Do-compile:
        Added option --with-big-tables
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      73e5f698
  10. 23 Mar, 2005 1 commit
    • unknown's avatar
      "After Monty's review" changes to the fix for BUG#8325 "Deadlock in... · 6bc324ed
      unknown authored
      "After Monty's review" changes to the fix for BUG#8325 "Deadlock in replication thread stops replication":
      s/sleep/safe_sleep (thread safe); sleep 0/1/2/3/4/5/5/5 (get slave less late);
      no message on error log (deadlock is too common sometimes), a global counter
      instead (SHOW STATUS LIKE 'slave_retried_transactions').
      Plus a fix for libmysql/Makefile.shared
      
      
      libmysql/Makefile.shared:
        When we "make clean" in libmysql/ we remove the symlinks there, so we
        need to mark that they have to be recreated later: this is done by removing
        ../linked_libmysql_sources. If we don't do this, 'make' will fail after 'cd libmysql;make clean'.
        This Makefile.shared is used by libmysql_r too.
        No reason to remove linked_client_sources as we don't remove the links in client/.
      mysql-test/r/rpl_deadlock.result:
        result fix
      mysql-test/t/rpl_deadlock.test:
        small test addition
      sql/mysqld.cc:
        if active_mi could not be alloced, die. New SHOW STATUS LIKE "slave_retried_transactions".
      sql/slave.cc:
        If slave retries automatically a transaction, no message on error log
        (too common situation); sleep 0 secs at first retry, then 1, 2, 3, 4,
        5, 5, 5... Sleeping 0 is to get the least possible late, as deadlocks
        are usually resolved at first try. New global counter rli->retried_trans
        (for SHOW STATUS: total number of times the slave had to retry
        any transaction). safe_sleep() is thread-safe, sleep() was not.
        I change the rli->trans_retries counter to go from 0 to max instead
        of the other way (better for new sleep()).
      sql/slave.h:
        new global counter rli->retried_trans
      sql/sql_show.cc:
        SHOW STATUS LIKE "slave_retried_transactions"; needs replication mutexes.
        Can't be a simple SHOW_LONG, because active_mi is unset (not alloced yet)
        when the static global status_vars is created (active_mi is set
        in init_slave()).
      sql/structs.h:
        new SHOW_SLAVE_RETRIED_TRANS
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      6bc324ed
  11. 22 Mar, 2005 1 commit
    • unknown's avatar
      sql_acl.cc, sql_acl.h, sql_parse.cc · 30a23278
      unknown authored
        New privilege CREATE USER (CREATE_USER_ACL, Create_user_priv) added
      grant2.test:
        new tests (mostly backported from jani's patch)
      system_mysql_db.result, sp.result, grant2.result, grant.result:
        results updated
      
      
      mysql-test/r/grant.result:
        results updated
      mysql-test/r/grant2.result:
        results updated
      mysql-test/r/sp.result:
        results updated
      mysql-test/r/system_mysql_db.result:
        results updated
      mysql-test/t/grant2.test:
        new tests (mostly backported from jani's patch)
      scripts/mysql_create_system_tables.sh:
        Create_user_priv added
      scripts/mysql_fix_privilege_tables.sql:
        Create_user_priv added
      sql/sql_acl.cc:
        Create_user_priv added
      sql/sql_acl.h:
        Create_user_priv added
      sql/sql_parse.cc:
        Create_user_priv added
      sql/sql_show.cc:
        Create_user_priv added
      sql/sql_yacc.yy:
        Create_user_priv added
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      30a23278
  12. 21 Mar, 2005 1 commit
    • unknown's avatar
      Last part of WL#1062: better replication of timezones: no more use · ac46bf77
      unknown authored
      of SET ONE_SHOT; storing tz info directly in event (if this info is needed),
      it's now allowed to have different global tz on master and slave.
      
      
      client/mysqlbinlog.cc:
        we need MAX_TIME_ZONE_NAME_LENGTH when processing log_event.h, and it's declared in mysql_priv.h
      mysql-test/r/rpl_timezone.result:
        result update
      mysql-test/t/rpl_timezone-slave.opt:
        Now that we can have different global value of timezone on master and slave, let's test it.
      mysql-test/t/rpl_timezone.test:
        Tests of the new replication of timezones: checking the output of mysqlbinlog,
        replication of CONVERT_TZ().
      sql/ha_innodb.cc:
        No very fast shutdown on Netware (anyway it's disabled on all platforms,
        but this is so that we don't forget to keep it disabled on Netware in the future).
      sql/log.cc:
        No more need to write SET ONE_SHOT to binlog for character set and timezone
        (as we store this info  directly nin the Query_log_event now).
      sql/log_event.cc:
        Exclude ::write() methods if MYSQL_CLIENT.
        Storing timezone info in the Query_log_event in master. Re-reading it in slave.
        Small code cleanups. I plan to not store the end 0 of catalog in binlog
        events soon.
      sql/log_event.h:
        replication of time zones: a place for tz info in Query_log_event,
        in LAST_EVENT_INFO. Plus if we are compiling a client, we don't need
        the ::write() methods, so keeping them out (of mysqlbinlog.cc;
        keeping them in, resulted in problem that mysqlbinlog does not know Timezone
        structure).
      sql/mysql_priv.h:
        moving this define from tztime.h (tztime.h has things which are
        too much for a client like mysqlbinlog).
      sql/set_var.cc:
        It's now allowed to change global value of charset or timezone even if using binlogging
        or if being a slave.
        Making CONVERT_TZ(,,@@session.time_zone) replicate.
      sql/set_var.h:
        these ::check()s are not needed anymore (changing global charset
        or timezone is now allowed even if binlogging or slave)
      sql/slave.cc:
        No more need to check for same global timezone if master is 5.x
        (ok, strictly speaking if it is > 5.0.3 but this is alpha).
      sql/slave.h:
        a function to wrap settings of charset to default.
      sql/tztime.cc:
        Adaptation of my_tz_find() to the case where it's not called from inside
        a query (i.e. cannot join its tz tables to the query's ones): this variant
        opens the tz tables itself, reads from them, and closes them. This is presently
        only used by the slave SQL thread (when it sets the tz before executing a query).
      sql/tztime.h:
        declaration of new function, plus moving symbol to mysql_priv.h
        for easier usage in mysqlbinlog (Dmitri, pardon me).
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      ac46bf77
  13. 17 Mar, 2005 2 commits
  14. 15 Mar, 2005 2 commits
    • unknown's avatar
      This changeset contains changes approved in code review by · 2b1a8acd
      unknown authored
      Konstja and Georg, change sets 1.1806, 1.1805. These changes has been successfully 
      tested on both my own workstation (Suse 9.0) and production.mysql.com.
      
      
      mysql-test/r/federated.result:
        new test results for error handling tests.
      mysql-test/t/federated.test:
        new error handling tests
      sql/ha_federated.cc:
        - check_foreign_data source added
        - table names now enclosed in '`' to allow for '%' or other characters
        - better error handling
        - mysql_init now checked to see if it returns true/false, error out if false (Georg)
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      2b1a8acd
    • unknown's avatar
      mysql.1.in: · 6d0ec316
      unknown authored
        Fix path that needs no parameterization.
      
      
      man/mysql.1.in:
        Fix path that needs no parameterization.
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      6d0ec316
  15. 14 Mar, 2005 2 commits
    • unknown's avatar
      Bug #6660 mysqldump creates bad pathnames on Windows · 2722a286
      unknown authored
      This really should not happen on Windows and part of the problem not fixed here is why show create table includes data directory when being run on Windows.  However, this patch fixes the bug in mysqldump.c
      
      mysqldump.c:
        Added fixPaths function to convert \ to / in data directory and index directory entries only on Windows
      
      
      client/mysqldump.c:
        Added fixPaths function to convert \ to / in data directory and index directory entries only on Windows
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      2722a286
    • unknown's avatar
      BUG#6554 Problem Building MySql on Fedora Core 3 · 90697f24
      unknown authored
       - Moved static variables defined inside of function to file scope to avoid this linking problem on FC3
      
      
      sql/ha_berkeley.cc:
        Moved list of bdb extension to file scope
      sql/ha_ndbcluster.cc:
        Moved list of ndb extesions to file scope
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      90697f24
  16. 07 Mar, 2005 1 commit
  17. 06 Mar, 2005 1 commit
  18. 05 Mar, 2005 1 commit
    • unknown's avatar
      logging_ok: · f1c81bf6
      unknown authored
        Logging to logging@openlogging.org accepted
      func_group.result, func_group.test:
        Added a test case for bug #8893.
      opt_sum.cc:
        A misplaced initialization for the returned parameter
        prefix_len in the function find_key_for_maxmin caused
        usage of a wrong key prefix by the min/max optimization
        in cases when the matching index was not the first index
        that contained the min/max field.
      
      
      sql/opt_sum.cc:
        A misplaced initialization for the returned parameter
        prefix_len in the function find_key_for_maxmin caused
        usage of a wrong key prefix by the min/max optimization
        in cases when the matching index was not the first index
        that contained the min/max field.
      mysql-test/t/func_group.test:
        Added a test case for bug #8893.
      mysql-test/r/func_group.result:
        Added a test case for bug #8893.
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      f1c81bf6
  19. 23 Feb, 2005 2 commits
    • unknown's avatar
      Changes to allow 5.0.3 to compile on Windows after XA was pushed · 52bba384
      unknown authored
      logging_ok:
        Logging to logging@openlogging.org accepted
      mi_packrec.c:
        Using HAVE_SYS_MMAN_H to protect include of sys/mman.h and replaced calls to mmap and munmap with my_mmap and my_munmap
      mi_extra.c:
        Now using HAVE_SYS_MMAN_H to protect include of sys/mman.h
      my_mmap.c:
        Changed how no mmap message is printed for Windows
      sql_map.cc:
        Changed HAVE_MMAP to HAVE_SYS_MMAN_H and replaced calls to mmap and munmap with my_mmap and my_munmap
      
      
      sql/sql_map.cc:
        Changed HAVE_MMAP to HAVE_SYS_MMAN_H and replaced calls to mmap and munmap with my_mmap and my_munmap
      mysys/my_mmap.c:
        Changed how no mmap message is printed for Windows
      myisam/mi_extra.c:
        Now using HAVE_SYS_MMAN_H to protect include of sys/mman.h
      myisam/mi_packrec.c:
        Using HAVE_SYS_MMAN_H to protect include of sys/mman.h and replaced calls to mmap and munmap with my_mmap and my_munmap
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      52bba384
    • unknown's avatar
      Post review changes · b1b896cf
      unknown authored
      sql/table.cc:
        added comments
        small optimisation
        fixed bug: in case of view based on several views, set_uncestor called only for first
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      b1b896cf
  20. 15 Feb, 2005 1 commit
    • unknown's avatar
      ft_nlq_search.c: · 3be01953
      unknown authored
        Added bounds check to avoid accessing unallocated FT_DOC array.  (BUG #8522)
      
      
      myisam/ft_nlq_search.c:
        Added bounds check to avoid accessing unallocated FT_DOC array.  (BUG #8522)
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      3be01953
  21. 14 Feb, 2005 1 commit
    • unknown's avatar
      Bug#8351 · de3f93c6
      unknown authored
      Fix for crash when using a double quote in boolean fulltext query.
      
      
      mysql-test/r/fulltext.result:
        Added a test case for bug #8351.
      mysql-test/t/fulltext.test:
        Added a test case for bug #8351.
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      de3f93c6
  22. 09 Feb, 2005 1 commit
    • unknown's avatar
      Removed old files · c0768dce
      unknown authored
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      c0768dce
  23. 04 Feb, 2005 2 commits
    • unknown's avatar
      type_float.result.es updated. · 4c695398
      unknown authored
      mysql-test/r/type_float.result.es:
        Updated.
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      4c695398
    • unknown's avatar
      type_float.result.es updated · fa17ed68
      unknown authored
      mysql-test/r/type_float.result.es:
        Updated.
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      fa17ed68
  24. 31 Jan, 2005 1 commit
  25. 29 Jan, 2005 1 commit
  26. 28 Jan, 2005 1 commit
    • unknown's avatar
      ndb_opt_defaults.h: · dde53fbb
      unknown authored
        removed usage of SIGRTMIN temorarilly as it causes problems on some platforms
      
      
      ndb/include/ndbapi/ndb_opt_defaults.h:
        removed usage of SIGRTMIN temorarilly as it causes problems on some platforms
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      dde53fbb
  27. 21 Jan, 2005 1 commit
    • unknown's avatar
      -Added quote_data and needs_quotes (moved from federated handler. · 66b62e05
      unknown authored
      -New tests and results
      
      logging_ok:
        Logging to logging@openlogging.org accepted
      ha_federated.h:
        removed quote_data and type_quote (now in the Field class)
      ha_federated.cc:
        moved quote_data and type_quote to field class
      field.h:
        new methods quote_data and needs_quotes declared
      field.cc:
        new field class methods quote_data and needs_quotes (per Monty's request)
      federated.test:
        more tests, joins, index tests
      have_federated_db.require:
        new name of federated system var
      federated.result:
        new test results for federated handler
      have_federated_db.inc:
        changed name of variable in test due to change in vars
      sql_analyse.cc:
        over-ridden append_escaped to take (String *, char *, uint) per requirements of 'create_where_from_key' method in federated handler.
      mysql_priv.h:
        define over-ridden append_escaped to take arguments from 'create_where_from_key' method in federated handler 
      ha_federated.cc:
        implemented "create_where_from_key" to deal properly with two-byte prefix and multi keys. Initial testing shows it works, but I still need to move quoting to field class and also look at changes per Segei's suggestions.
      
      
      sql/mysql_priv.h:
        define over-ridden append_escaped to take arguments from 'create_where_from_key' method in federated handler
      sql/sql_analyse.cc:
        over-ridden append_escaped to take (String *, char *, uint) per requirements of 'create_where_from_key' method in federated handler.
      mysql-test/include/have_federated_db.inc:
        changed name of variable in test due to change in vars
      mysql-test/r/federated.result:
        new test results for federated handler
      mysql-test/r/have_federated_db.require:
        new name of federated system var
      mysql-test/t/federated.test:
        more tests, joins, index tests
      sql/field.cc:
        new field class methods quote_data and needs_quotes (per Monty's request)
      sql/field.h:
        new methods quote_data and needs_quotes declared
      sql/ha_federated.cc:
        moved quote_data and type_quote to field class
      sql/ha_federated.h:
        removed quote_data and type_quote (now in the Field class)
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      66b62e05
  28. 17 Jan, 2005 1 commit
  29. 16 Jan, 2005 1 commit
    • unknown's avatar
      Bug #7922 prompt \p fails on Windows for shared-memory connections · 31457a62
      unknown authored
      Fixed bug by adding code that displays the contents of mysql.host when \p is added as part of the prompt.
      
      mysql.cc:
        Added code to display mysql.host as prompt when using shared memory
      
      
      client/mysql.cc:
        Added code to display mysql.host as prompt when using shared memory
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      31457a62