1. 28 Jul, 2007 1 commit
    • unknown's avatar
      Fixed bug #29834. · 90c5621d
      unknown authored
      Using view columns by their names during an execution of
      a prepared SELECT statement or a SELECT statement inside
      a SP caused a memory leak.
      
      
      sql/sql_base.cc:
        Fixed bug #29834.
        The find_field_in_view function has been modified to
        use the execution memory root for the Item_direct_view_ref
        objects allocation at non-first executions of
        a PS/SP instead of the statement memory.
      mysql-test/t/sp.test:
        Updated test case for bug #29834.
      mysql-test/r/sp.result:
        Updated test case for bug #29834.
      90c5621d
  2. 13 Jul, 2007 3 commits
  3. 12 Jul, 2007 4 commits
    • unknown's avatar
      Bug#29739: Incorrect time comparison in BETWEEN. · e08e63b1
      unknown authored
      Time values were compared by the BETWEEN function as strings. This led to a
      wrong result in cases when some of arguments are less than 100 hours and other
      are greater.
      
      Now if all 3 arguments of the BETWEEN function are of the TIME type then
      they are compared as integers.
      
      
      mysql-test/t/type_time.test:
        Added a tes tcase for the bug#29739: Incorrect time comparison in BETWEEN.
      mysql-test/r/type_time.result:
        Added a tes tcase for the bug#29739: Incorrect time comparison in BETWEEN.
      sql/item_cmpfunc.cc:
        Bug#29739: Incorrect time comparison in BETWEEN.
        Now if all 3 arguments of the BETWEEN function are of the TIME type then
        they are compared as integers.
      e08e63b1
    • unknown's avatar
      ad492a6d
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 18159958
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug29604
      
      
      18159958
    • unknown's avatar
      Fixed bug #29604. · b1e55680
      unknown authored
      A bug in the restore_prev_nj_state function allowed interleaving 
      inner tables of outer join operations with outer tables. With the
      current implementation of the nested loops algorithm it could lead
      to wrong result sets for queries with nested outer joins.
      Another bug in this procedure effectively blocked evaluation of some
      valid execution plans for queries with nested outer joins. 
      
      
      mysql-test/r/join_nested.result:
        Added a test case for bug #29604.
      mysql-test/t/join_nested.test:
        Added a test case for bug #29604.
      b1e55680
  4. 11 Jul, 2007 11 commits
    • unknown's avatar
      Merge gshchepa@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · db84ffa3
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      db84ffa3
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt · 95a526b8
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt-29360
      
      
      95a526b8
    • unknown's avatar
      field_conv.cc: · b6e01cbb
      unknown authored
        Additional fix for bug #29360.
      
      
      sql/field_conv.cc:
        Additional fix for bug #29360.
      b6e01cbb
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 2b481003
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/29555-bug-5.0-opt-mysql
      
      
      2b481003
    • unknown's avatar
      Bug#29555: Comparing time values as strings may lead to a wrong result. · 25e28d4d
      unknown authored
      Time values were compared as strings. This led to a wrong comparison
      result when comparing values one of which is under 100 hours and another is
      over 100 hours.
      
      Now when the Arg_comparator::set_cmp_func function sees that both items to
      compare are of the TIME type it sets the comparator to the
      Arg_comparator::compare_e_int or the Arg_comparator::compare_int_unsigned
      functions.
      
      
      sql/item_cmpfunc.cc:
        Bug#29555: Comparing time values as strings may lead to a wrong result.
        Now when the Arg_comparator::set_cmp_func function sees that both items to
        compare are of the TIME type it sets the comparator to the
        Arg_comparator::compare_e_int or the Arg_comparator::compare_int_unsigned
        functions.
      mysql-test/r/type_time.result:
        Added a test case for the bug#29555: Comparing time values as strings may
        lead to a wrong result.
      mysql-test/t/type_time.test:
        Added a test case for the bug#29555: Comparing time values as strings may
        lead to a wrong result.
      25e28d4d
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt-29360 · ad1190ec
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      ad1190ec
    • unknown's avatar
      Fixed bug #29360. · 0920c75b
      unknown authored
      The special `zero' enum value was coerced to the normal
      empty string enum value during a field-to-field copy.
      This bug affected CREATE ... SELECT statements and
      SELECT aggregate GROUP BY enum field statements.
      
      Also this bug made unnecessary warnings during
      the execution of CREATE ... SELECT statements:
      Warning       1265    Data truncated for column...
      
      
      sql/field_conv.cc:
        Fixed bug #29360.
        The field_conv function has been modified to properly convert
        the special `zero' enum value between enum fields.
      mysql-test/t/type_enum.test:
        Updated test case for bug #29360.
      mysql-test/r/type_enum.result:
        Updated test case for bug #29360.
      mysql-test/r/type_ranges.result:
        Updated test case for bug #29360.
      0920c75b
    • unknown's avatar
      Addendum to bug 29325: · 2f0e0017
      unknown authored
      test if TRUNCATE TABLE works with keep_files_on_create
      
      
      2f0e0017
    • unknown's avatar
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 2b1fb350
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B29325-5.0-opt
      
      
      include/my_base.h:
        Auto merged
      2b1fb350
    • unknown's avatar
      Bug #29325: · 1abab6c7
      unknown authored
      By default MyISAM overwrites .MYD and .MYI files no 
      DATA DIRECTORY option is used. This can lead to two tables
      using the same .MYD and .MYI files (that can't be dropped).
      
      To prevent CREATE TABLE from overwriting a file a new option
      is introduced : keep_files_on_create
      When this is on the CREATE TABLE throws an error if either
      the .MYD or .MYI exists for a MyISAM table.
      The option is off by default (resulting in compatible behavior).
      
      
      include/my_base.h:
        Bug #29325: introduce keep_files_on_create
      myisam/mi_create.c:
        Bug #29325: introduce keep_files_on_create
      mysql-test/r/create.result:
        Bug #29325: test case
      mysql-test/t/create.test:
        Bug #29325: test case
      sql/ha_myisam.cc:
        Bug #29325: introduce keep_files_on_create
      sql/set_var.cc:
        Bug #29325: introduce keep_files_on_create
      sql/sql_class.h:
        Bug #29325: introduce keep_files_on_create
      sql/sql_table.cc:
        Bug #29325: introduce keep_files_on_create
      sql/unireg.cc:
        Bug #29325: introduce keep_files_on_create
      1abab6c7
  5. 10 Jul, 2007 3 commits
  6. 09 Jul, 2007 11 commits
  7. 08 Jul, 2007 3 commits
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 25cba450
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/29461-bug-5.0-opt-mysql
      
      
      25cba450
    • unknown's avatar
      Bug#29461: Sort order of the collation wasn't used when comparing characters · bfa027e7
      unknown authored
      with the space character.
      
      When the my_strnncollsp_simple function compares two strings and one is a prefix
      of another then this function compares characters in the rest of longer key
      with the space character to find whether the longer key is greater or less.
      But the sort order of the collation isn't used in this comparison. This may
      lead to a wrong comparison result, wrongly created index or wrong order of the
      result set of a query with the ORDER BY clause.
      
      Now the my_strnncollsp_simple function uses collation sort order to compare
      the characters in the rest of longer key with the space character.
      
      
      mysql-test/t/ctype_collate.test:
        Added a test case for the bug#29461: Sort order of the collation wasn't used when
        comparing characters with the space character.
      mysql-test/r/ctype_collate.result:
        Added a test case for the bug#29461: Sort order of the collation wasn't used when
        comparing characters with the space character.
      strings/ctype-simple.c:
        Bug#29461: Sort order of the collation wasn't used when comparing characters
        with the space character.Now the my_strnncollsp_simple function uses collation sort order to compare
        the characters in the rest of longer key with the space character.
      bfa027e7
    • unknown's avatar
      Merge gshchepa@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · f045039d
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      f045039d
  8. 07 Jul, 2007 4 commits
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 3561de50
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug29417
      
      
      mysql-test/r/type_newdecimal.result:
        Manual merge.
      mysql-test/t/type_newdecimal.test:
        Manual merge.
      3561de50
    • unknown's avatar
      Merge gshchepa@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 7ec0820b
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      7ec0820b
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/4.1-opt · 79435f37
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      79435f37
    • unknown's avatar
      Fixed bug #29417. · 0671e30a
      unknown authored
      An assertion abort could occur for some grouping queries that employed 
      decimal user variables with assignments to them.
      
      The problem appeared the constructors of the class Field_new_decimal
      because the function my_decimal_length_to_precision did not guarantee
      returning decimal precision not greater than DECIMAL_MAX_PRECISION.
      
      
      mysql-test/r/type_newdecimal.result:
        Added a test case for bug #29417.
      mysql-test/t/type_newdecimal.test:
        Added a test case for bug #29417.
      sql/field.cc:
        Fixed bug #29417.
        An assertion abort could occur for some grouping queries that employed 
        decimal user variables with assignments to them.
        
        The problem appeared the constructors of the class Field_new_decimal
        because the function my_decimal_length_to_precision did not guarantee
        returning decimal precision not greater than DECIMAL_MAX_PRECISION.
        
        Now if the precision returned by calls to my_decimal_length_to_precision
        in the constructors of the class Field_new_decimal is greater than 
        DECIMAL_MAX_PRECISION the precision is set to this value.
      0671e30a