An error occurred fetching the project authors.
  1. 28 Apr, 2005 1 commit
    • unknown's avatar
      BUG#5964 - 4.1 MERGE tables regression from 4.0 · f0e256ef
      unknown authored
      Changed the creation of the .MRG file so that only the table  name
      is written when the MyISAM table is in the same database as the
      MERGE table, a relative path is used in other cases in mysqld,
      and possibly an absolute path is used in an embedded server.
      No test case is added as the external behaviour is unchanged.
      Only the file names within the .MRG file are changed.
      
      
      include/my_sys.h:
        BUG#5964 - 4.1 MERGE tables regression from 4.0
        Added declaration for a new function.
      myisammrg/myrg_open.c:
        BUG#5964 - 4.1 MERGE tables regression from 4.0
        Changed check for absolute path to check for any path.
      mysys/my_getwd.c:
        BUG#5964 - 4.1 MERGE tables regression from 4.0
        Added a new functions which checks for absolute _or_
        relative paths.
      sql/ha_myisammrg.cc:
        BUG#5964 - 4.1 MERGE tables regression from 4.0
        Changed the creation of the .MRG file so that only the table  name
        is written when the MyISAM table is in the same database as the
        MERGE table, a relative path is used in other cases in mysqld,
        and possibly an absolute path is used in an embedded server.
      f0e256ef
  2. 05 Apr, 2005 1 commit
    • unknown's avatar
      remove the rest of isam/merge references · cd0a50bf
      unknown authored
      fix a race condition in TC_LOG_BINLOG::unlog
      
      
      include/Makefile.am:
        remove the rest of isam/merge references
      include/config-win.h:
        unused and abused macro removed
      include/my_pthread.h:
        unused and abused macro removed
      include/my_sys.h:
        MY_IGNORE_BADFD flag
      include/mysql_embed.h:
        remove the rest of isam/merge references
      mysql-test/r/replace.result:
        remove the rest of isam/merge references
      mysql-test/t/replace.test:
        remove the rest of isam/merge references
      mysql-test/t/xa.test:
        comment
      mysys/my_sync.c:
        MY_IGNORE_BADFD flag
      sql/handler.cc:
        remove the rest of isam/merge references
      sql/log.cc:
        fix a race condition in TC_LOG_BINLOG::unlog
        preparation for binlog group commit
      sql/mysql_priv.h:
        remove duplicates
      sql/mysqld.cc:
        remove the rest of isam/merge references
      sql/opt_range.cc:
        remove the rest of isam/merge references
      sql/set_var.cc:
        hide unused variables. simplify sync_binlog code
      sql/sql_base.cc:
        remove the rest of isam/merge references
      sql/sql_class.h:
        cleanup
      cd0a50bf
  3. 25 Mar, 2005 1 commit
    • unknown's avatar
      A fix for Bug#8226 "Cannot connect via shared memory": · 3fd63949
      unknown authored
      provide created shared memory objects with proper
      access rights to make them usable when client and server
      are running under different accounts. 
      Post review fixes.
      
      
      VC++Files/mysys/mysys.dsp:
        Add my_windac.c to mysys.lib
      include/my_sys.h:
        Declarations for SECURITY_ATTRIBUTES create/destroy functions.
      mysys/Makefile.am:
        Add my_windac.c to the list of compiled files.
      sql-common/client.c:
        Lower requested access rights for events as the server won't 
        provide clients with ALL access in order to prevent denial
        of service attack.
      sql/mysqld.cc:
        Set proper security attributes for the kernel objects to make them
        usable when mysqld is running as a Windows service.
      3fd63949
  4. 17 Mar, 2005 1 commit
    • unknown's avatar
      Field::quote_data(): · b6e29d09
      unknown authored
        don't call escape_string_for_mysql() unnecesary
        don't overwrite local buffer
      escape_string_for_mysql():
        take a length of the destination buffer as an argument
      
      
      include/my_sys.h:
        prototype changed
      libmysql/libmysql.c:
        prototype changed
      mysys/charset.c:
        escape_string_for_mysql():
          take a length of the destination buffer as an argument
      sql/field.cc:
        Field::quote_data():
          don't call escape_string_for_mysql() unnecesary
          don't overwrite local buffer
      sql/item.cc:
        prototype changed
      sql/sql_prepare.cc:
        prototype changed
      b6e29d09
  5. 15 Mar, 2005 1 commit
    • unknown's avatar
      include/my_global.h · b975a872
      unknown authored
          define _XOPEN_SOURCE=500 for solaris
      include/my_sys.h
          remove a cast
      
      
      include/my_global.h:
        define _XOPEN_SOURCE=500 for solaris
      include/my_sys.h:
        remove a cast
      b975a872
  6. 08 Mar, 2005 1 commit
    • unknown's avatar
      Fixed Bug#8922. · 0fdd650f
      unknown authored
      Reverted Jim's patch.
      
      
      client/mysql.cc:
        Fixed Bug#8922, The deilimeter cannot be reset after it is set as word 'delimiter'
      include/my_sys.h:
        Reverted Jim's patch.
      mysys/mf_iocache.c:
        Reverted Jim's patch.
      sql/sql_class.h:
        Reverted Jim's patch.
      0fdd650f
  7. 04 Mar, 2005 1 commit
  8. 03 Mar, 2005 2 commits
    • unknown's avatar
      Prevent a collision with the system's '#define errno ...' by guarding the variable declaration. · 5841c630
      unknown authored
      include/my_sys.h:
        There are platforms which use '#define errno ...' and then cause a collision with
        'extern int errno;', one example is OpenBSD.
        Rather than treat them explicitly by the 'HAVE_ERRNO_AS_DEFINE', we can check for these
        by using '#ifndef errno'.
      5841c630
    • unknown's avatar
      Avoid calls to my_seek() and my_tell() on log files so that · f8826979
      unknown authored
      non-seekable files like FIFOs can be used for logs other
      than the binlog. (Bug #8271)
      
      
      include/my_sys.h:
        Add APPEND_CACHE cache type
      mysys/mf_iocache.c:
        Handle APPEND_CACHE cache type to avoid calling my_seek() and my_tell()
        on logs opened O_APPEND that we never read from (so they can be a
        non-seekable file like a FIFO).
      sql/mysqld.cc:
        Use APPEND_CACHE for log files not set to SEQ_READ_APPEND.
      f8826979
  9. 22 Feb, 2005 1 commit
    • unknown's avatar
      compatibility fixes, crashing tests · 7caef7f4
      unknown authored
      include/my_sys.h:
        sol9x86, sunfire100b, qnx compatibility
      mysql-test/t/rpl_rotate_logs.test:
        fix the test
      sql/ha_innodb.cc:
        don't bother
      sql/handler.cc:
        few more ways to crash mysqld :)
      sql/handler.h:
        gdb/safemalloc workaround
      sql/log.cc:
        rotate a binlog on heuristic recover
      sql/mysqld.cc:
        rotate a binlog on heuristic recover
      7caef7f4
  10. 20 Feb, 2005 1 commit
  11. 19 Feb, 2005 1 commit
  12. 18 Feb, 2005 1 commit
    • unknown's avatar
      made IM to work with --defaults-file smoothly · e2d78b85
      unknown authored
      BitKeeper/deleted/.del-my.cnf~9322f78f12eb2f3c:
        Delete: support-files/my.cnf
      include/my_sys.h:
        fixed prototype to reflect changes in default.c
      mysys/default.c:
        use my_search_option_files instead of process_default_option_files. This is used from the IM.
      server-tools/instance-manager/instance.cc:
        added parameter to complete_initialization(). this ine marks whether we are creating the only instance
        (for instance, when no config file given)
      server-tools/instance-manager/instance.h:
        prototype changed
      server-tools/instance-manager/instance_map.cc:
        Now call my_search_option_files to work smootly with --defaults-file
      server-tools/instance-manager/instance_map.h:
        added first_option member. This is set of mysqlmanager was started with --defaults-file or with
        --extra-defaults-file to be passed to the my_search_option_files
      server-tools/instance-manager/instance_options.cc:
        if we have only one instance, name the pidfile `hostname`.pid for compatibility reasons.
      server-tools/instance-manager/instance_options.h:
        header fixed according to .cc
      server-tools/instance-manager/manager.cc:
        prototype fixed
      server-tools/instance-manager/options.cc:
        save --defaults-file of --defaults-extra-file to pass it to my_search_option_files
      server-tools/instance-manager/options.h:
        added an optin to save --default-file options
      support-files/Makefile.am:
        revert changes
      e2d78b85
  13. 26 Jan, 2005 1 commit
  14. 15 Jan, 2005 1 commit
  15. 03 Jan, 2005 1 commit
    • unknown's avatar
      fix for bug #5920 (embedded-server mysql doesn't handle --defaults-file) · d3be3cbc
      unknown authored
      client/mysql.cc:
        bug #5920 (embedded-server mysql doesn't handle --defaults-file)
        defaults files handled
      include/my_sys.h:
        bug #5920 (embedded-server mysql doesn't handle --defaults-file)
        get_defaults_file interface added
      libmysqld/libmysqld.c:
        just small fix, not related to the bug.
      mysys/default.c:
        bug #5920 (embedded-server mysql doesn't handle --defaults-file)
        get_defaults_files implementation
      d3be3cbc
  16. 23 Dec, 2004 1 commit
    • unknown's avatar
      WL#1895 - Print message to error log in case of detected MyISAM corruption · bec3feaa
      unknown authored
      Changed my_error() to print error messages, which come from
      arbitrary registered ranges of error messages. Messages can
      be unregistered (and should be at end of the program).
      Added registration of handler error messages.
      Added a new mi_print_error() macro and a new 
      mi_report_error() function, which supply error
      messages with a table name.
      Added calls to mi_print_error() or mi_report_error()
      at all places in MyISAM, where table corruption is detected.
      
      
      extra/comp_err.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added prints for ER_ERROR_FIRST and ER_ERROR_LAST.
        Removed print for ER_ERROR_MESSAGES.
      include/errmsg.h:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added declaration for a new function.
        Added first and last error number defines.
      include/my_base.h:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added first and last error number defines.
      include/my_sys.h:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Removed obsolete defines.
        Removed a global variable, which held pointers to the error message arrays.
        Added declarations for new functions.
      include/mysys_err.h:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Removed an obsolete define.
        Changed two defines to use the new defines.
        Added first and last error number defines.
      libmysql/errmsg.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Replaced global array initialization by proper registration
        and unregistration of client error messages.
      libmysql/libmysql.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added a call for unregistration of client error messages.
      myisam/mi_delete.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
        Added a debugging call to pretend MyISAM corruption in case a special
        debug string is set.
        Added a debugging call to test undefined error numbers in case a special
        debug string is set.
      myisam/mi_extra.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
      myisam/mi_info.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added the error logging function.
      myisam/mi_key.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
      myisam/mi_keycache.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
      myisam/mi_locking.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
      myisam/mi_open.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
        Added a debugging call to pretend MyISAM corruption in case a special
        debug string is set.
      myisam/mi_page.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
      myisam/mi_range.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
      myisam/mi_rkey.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
      myisam/mi_search.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
      myisam/mi_update.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
        Added a debugging call to pretend MyISAM corruption in case a special
        debug string is set.
      myisam/mi_write.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
        Added a debugging call to pretend MyISAM corruption in case a special
        debug string is set.
      myisam/myisamdef.h:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added the declaration of the new error logging function
        and a new macro.
      mysql-test/r/merge.result:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Changed test results. These come from the changed error reporting
        in openfrm().
      mysql-test/r/repair.result:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Changed test results. These come from the changed error reporting
        in openfrm().
      mysql-test/t/merge.test:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Changederror numbers. These come from the changed error reporting
        in openfrm().
      mysys/errors.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Dropped the assignment of the global errors to the
        dropped global pointer array.
      mysys/my_error.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Changed my_error() from using a static array of pointers to
        error message arrays to using a linked list of structures
        with pointers to array message arrays.
        Added functions for registering and unregistering error 
        message arrays to the chain.
      sql/derror.cc:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Changed reading of mysqld error messages to using the new
        registering and unregistering functions.
      sql/handler.cc:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added initialization and deinitialization of handler error messages.
        Included more handler error messages in the mapping to
        mysqld error messages.
      sql/mysqld.cc:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Changed deinitialization of error messages to proper
        unregistration.
      sql/table.cc:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Changed error reporting in openfrm() so that error messages from
        handler::ha_open() are reported by handler::print_error(). This
        changed messages from "Can't open 't1.MYI' (errno: 130)" to
        "Incorrect file format 't1'" for example.
      sql/unireg.h:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Changed two defines to use the new defines.
      bec3feaa
  17. 14 Dec, 2004 1 commit
  18. 28 Nov, 2004 1 commit
    • unknown's avatar
      protection: TRASH in delete · 30db8445
      unknown authored
      fixed a bug that it discovered
      
      
      include/my_sys.h:
        move TRASH to my_sys.h from sql_list.h
      sql/field.h:
        use TRASH macro
      sql/item.h:
        TRASH in delete
      sql/item_func.h:
        never delete item's manually!
      sql/opt_range.cc:
        TRASH in delete
      sql/sql_lex.h:
        TRASH in delete
      sql/sql_list.h:
        move TRASH to my_sys.h from sql_list.h
      sql/sql_parse.cc:
        don't use properties of deleted objects (even when it's safe)
      sql/sql_select.cc:
        TRASH in delete
      sql/sql_show.cc:
        TRASH in delete
      sql/sql_string.h:
        TRASH in delete
      30db8445
  19. 10 Nov, 2004 1 commit
    • unknown's avatar
      Added possibility to detect if libmysqld is restarted · 5205078e
      unknown authored
      (Needed to check if memory allocated with mysql_once_init() has been freed)
      
      
      
      include/my_sys.h:
        Added possibility to detect if libmysqld is restarted
      mysys/my_init.c:
        Added possibility to detect if libmysqld is restarted
      sql/handler.cc:
        Detect if libmysqld is restarted
        Simple optimization of ha_known_exts()
      5205078e
  20. 07 Nov, 2004 1 commit
  21. 04 Nov, 2004 1 commit
    • unknown's avatar
      mmap portability layer, mmap for Windows · cce44b14
      unknown authored
      new macro: thread_safe_decrement, thread_safe_dec_and_test, statistic_decrement
      
      
      mysys/my_chsize.c:
        cleanup
      include/config-win.h:
        mmap portability layer, mmap for Windows
      include/my_pthread.h:
        thread_safe_decrement, thread_safe_dec_and_test, statistic_decrement
      include/my_sys.h:
        mmap portability layer, mmap for Windows
      mysys/Makefile.am:
        mmap portability layer, mmap for Windows
      cce44b14
  22. 14 Oct, 2004 1 commit
    • unknown's avatar
      true,false -> TRUE, FALSE · 33073189
      unknown authored
      Simple fixes/optimization of things discovered during review of new pushed code
      
      
      include/my_sys.h:
        Ensure that clear_alloc_root() interacts correctly with alloc_root_inited()
      mysys/hash.c:
        More comments
        Simple optimization (merge identical code)
      mysys/my_bitmap.c:
        Change inline -> static inline
      sql/examples/ha_archive.cc:
        Fixed compiler warning
      sql/ha_ndbcluster.cc:
        true,false -> TRUE, FALSE
        Change if (false) -> #ifdef NOT_USED
      sql/ha_ndbcluster.h:
        true,false -> TRUE, FALSE
      sql/handler.cc:
        More comments
        Remove not needed initializations.
        #ifdef not used code
      sql/item_cmpfunc.h:
        true,false -> TRUE, FALSE
      sql/item_strfunc.cc:
        Move local variables to function beginning
        Remove wrong comments
      sql/log_event.h:
        true,false -> TRUE, FALSE
      sql/sql_base.cc:
        true,false -> TRUE, FALSE
        More comments
      sql/sql_help.cc:
        true,false -> TRUE, FALSE
      sql/sql_lex.cc:
        Simple optimization of new code
      sql/sql_parse.cc:
        true,false -> TRUE, FALSE
      sql/sql_prepare.cc:
        true,false -> TRUE, FALSE
      sql/sql_table.cc:
        true,false -> TRUE, FALSE
      sql/sql_yacc.yy:
        true,false -> TRUE, FALSE
      33073189
  23. 23 Sep, 2004 1 commit
    • unknown's avatar
      Implementation of Monty's idea about clear_alloc_root() optimization and cleanup of work · 7ba5d931
      unknown authored
      with memory roots in THD/Statement/Item_arena.
      Added assertions preventing memory allocation on bzero'ed MEM_ROOT since it is worked by 
      pure luck and was very ineffective.
      
      
      include/my_sys.h:
        Reimplementation of Monty's optimization of clear_alloc_root().
        Now clear_alloc_root() can be used only for detaching memory associated with MEM_ROOT
        (e.g. to avoid its freeing). It can not be used for MEM_ROOT initialization any longer 
        (it was bad idea anyway since memory allocation on such MEM_ROOT was very ineffective 
        and worked by pure luck).
        Introduced ALLOC_ROOT_MIN_BLOCK_SIZE constant.
      mysys/my_alloc.c:
        Added description of init_alloc_root().
        Added assertions to alloc_root() and reset_root_defaults() so now they can only be used
        on previosly initialized MEM_ROOT. (It worked for bzeroed MEM_ROOT before but 
        by pure luck and very inefficiently). Calling free_root() on bzero'ed MEM_ROOT
        is still ok (we can't remove this easily because of static MEM_ROOTs).
        Also now using ALLOC_ROOT_MIN_BLOCK_SIZE constant inside these functions.
      sql/opt_range.cc:
        Fixed get_quick_select_for_ref() function to not use bzero'ed MEM_ROOT for allocation.
        Also QUICK_RANGEs created in this function should be created in memory root of QUICK_SELECT.
      sql/sql_class.cc:
        Implementation of Monty's idea about clear_alloc_root() optimization and cleanup of work 
        with memory roots in THD/Statement/Item_arena.
        Now we are always initing THD::transaction.mem_root and THD::mem_root in THD constructor 
        (without memory allocation and with minimal block size) and then later change their
        parameters in THD::init_for_queries() (this is partially because we can't allocate anything
        on bzero'ed memory roots anymore).
        Item_arena() constructor is now trivial and is used only then Item_arena is created as backup
        storage for other Item_arena (we use Item_arena(bool) now if it is part of Statement).
        Both trivial Item_arena constructor and destructor are now inline.
        Removed unneeded clear_alloc_root from Item_arena::restore_backup_item_arena().
      sql/sql_class.h:
        Both trivial Item_arena constructor and destructor are now inline.
        Commented various Item_arena constructors.
      7ba5d931
  24. 13 Sep, 2004 2 commits
  25. 09 Sep, 2004 1 commit
    • unknown's avatar
      After merge fixes of merge with 4.1 that included the new arena code. · 33efc967
      unknown authored
      Fixed (together with Guilhem) bugs in mysqlbinlog regarding --offset
      Prefix addresses with 0x for easier comparisons of debug logs
      Fixed problem where MySQL choosed index-read even if there would be a much better range on the same index
      This fix changed some 'index' queries to 'range' queries in the test suite
      Don't create 'dummy' WHERE clause for trivial WHERE clauses where we can remove the WHERE clause.
      This fix removed of a lot of 'Using where' notes in the test suite.
      Give NOTE instead of WARNING if table/function doesn't exists when using DROP IF EXISTS
      Give NOTE instead of WARNING for safe field-type conversions
      
      
      Makefile.am:
        Don't automaticly update files from bk
      client/mysqlbinlog.cc:
        Merge with 4.1 (+ apply bug fixes for --offset and --start-position)
      include/my_sys.h:
        Faster clear_alloc_root()
      mysql-test/r/bdb.result:
        Updated results after merge
      mysql-test/r/create.result:
        Updated results after merge
      mysql-test/r/func_group.result:
        Updated results after merge
      mysql-test/r/func_if.result:
        Updated results after merge
      mysql-test/r/heap_btree.result:
        Updated results after merge
      mysql-test/r/index_merge.result:
        Updated results after merge
      mysql-test/r/index_merge_ror.result:
        Updated results after merge
      mysql-test/r/innodb.result:
        Updated results after merge
      mysql-test/r/join_outer.result:
        Updated results after merge
      mysql-test/r/mysqlbinlog2.result:
        Updated results after merge
      mysql-test/r/negation_elimination.result:
        Updated results after merge
      mysql-test/r/null.result:
        Updated results after merge
        Added more tests
      mysql-test/r/null_key.result:
        Updated results after merge
        Added more tests
      mysql-test/r/order_by.result:
        Updated results after merge
      mysql-test/r/range.result:
        Updated results after merge
        Added more tests
      mysql-test/r/rpl_charset.result:
        Updated results after merge
      mysql-test/r/sp-error.result:
        Updated results after merge
      mysql-test/r/sp.result:
        Updated results after merge
        Added delete of some stored procedures in an attempt to be able to re-run test even if it aborts in the middle
      mysql-test/r/type_blob.result:
        Updated results after merge
        (Some warnings are now notes)
      mysql-test/r/user_var.result:
        Updated results after merge
        Added more tests
      mysql-test/r/variables.result:
        Updated results after merge
      mysql-test/r/view.result:
        Updated results after merge
      mysql-test/t/mysqlbinlog2.test:
        Updated tests to use new positions
      mysql-test/t/null.test:
        More tests
      mysql-test/t/null_key.test:
        More tests
      mysql-test/t/range.test:
        More tests
      mysql-test/t/rpl_charset.test:
        Avoid big diffs in the future if tests changes
      mysql-test/t/sp-error.test:
        Updated error numbers
      mysql-test/t/sp-security.test:
        Updated error numbers
      mysql-test/t/sp.test:
        Updated results after merge
        Added delete of some stored procedures in an attempt to be able to re-run test even if it aborts in the middle
      mysql-test/t/user_var.test:
        More tests
      mysql-test/t/view.test:
        Updated error numbers
      mysys/my_alloc.c:
        Write into debug log the address of the allocated area
      sql/ha_isam.cc:
        Prefix addresses with 0x for easier comparisons of debug logs
      sql/ha_myisam.cc:
        Prefix addresses with 0x for easier comparisons of debug logs
      sql/ha_ndbcluster.cc:
        Add missing enum to switch
      sql/handler.cc:
        remove compiler warning
      sql/item.cc:
        More debugging
        Simple cleanup
      sql/item.h:
        Move Item::cleanup() to item.cc
      sql/item_cmpfunc.cc:
        Fix arena code
      sql/item_subselect.cc:
        After merge fixes
      sql/item_subselect.h:
        After merge fixes
      sql/item_sum.cc:
        Updated comment
      sql/log_event.cc:
        Remove wrong test
      sql/mysql_priv.h:
        Indentation fixes
      sql/mysqld.cc:
        After merge fixes
        Added 0x to pointers in debug log
      sql/opt_range.cc:
        Fixed problem where MySQL choosed index-read even if there would be a much better range on the same index
        This fix changed some 'index' queries to 'range' queries in the test suite
      sql/set_var.cc:
        Indentation fixes
      sql/sp_head.cc:
        Set state to INITIALIZED to make SP work with new arena code
      sql/sql_base.cc:
        After merge fixes
      sql/sql_class.cc:
        More debugging
        Use clear_alloc_root() instead of init_alloc_root() as the former is faster
      sql/sql_class.h:
        New method 'only_prepare()'
      sql/sql_lex.cc:
        After merge fixes
      sql/sql_lex.h:
        After merge fixes
      sql/sql_parse.cc:
        Fix for timezone tables. (The old way to add timezone tables to global list in 'create_total_list' doesn't work anymore)
        Give NOTE instead of WARNING if table/function doesn't exists when using DROP IF EXISTS
      sql/sql_prepare.cc:
        After merge fixes
      sql/sql_select.cc:
        Don't create 'dummy' WHERE clause for trivial WHERE clauses where we can remove the WHERE clause.
        This fix removed of a lot of 'Using where' notes in the test suite
      sql/sql_table.cc:
        Give NOTE instead of WARNING if table/function doesn't exists when using DROP IF EXISTS
      sql/sql_union.cc:
        After merge fix
      sql/sql_view.cc:
        After merge fix
      sql/table.cc:
        After merge fix
      sql/tztime.cc:
        Update timezone table handling to use new table lists structure
      sql/tztime.h:
        Update timezone table handling to use new table lists structure
      sql/unireg.cc:
        Use 0x before pointers
      33efc967
  26. 30 Aug, 2004 1 commit
    • unknown's avatar
      Please rewiev. Here added a function to process config. files options. · 824acf6e
      unknown authored
      A lot of the default.c module code was refactored. The patch is needed
      for the IM.
      
      
      include/my_sys.h:
        Definitions added.
      mysys/default.c:
        Added new api call: process_default_option_files. Also some coments
        changed to reflect current state of the code. It takes Basename for
        config file and the function to process options. The function is called
        everytime when we find an option. This way it is possible to get and
        process options from several groups in one file traversal.
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      824acf6e
  27. 19 Aug, 2004 1 commit
    • unknown's avatar
      Bug #4466 Nothing in .err when mysql service ends because of malformed my.ini options · f2ef3d16
      unknown authored
      my_getopt.c:
        Moved the inclusion of my_getopt.h down below the inclusion of my_sys.h so that enum loglevel definition would be available
      my_sys.h, my_getopt.h:
        moved definition of enum loglevel from my_getopt.h to my_sys.h
      
      
      include/my_getopt.h:
        moved definition of enum loglevel from my_getopt.h to my_sys.h
      include/my_sys.h:
        moved definition of enum loglevel from my_getopt.h to my_sys.h
      mysys/my_getopt.c:
        Moved the inclusion of my_getopt.h down below the inclusion of my_sys.h so that enum loglevel definition would be available
      f2ef3d16
  28. 29 May, 2004 1 commit
  29. 24 May, 2004 1 commit
    • unknown's avatar
      Support for character set conversion in binary protocol: another go · 093d6292
      unknown authored
      after Monty's review.
      - Item_param was rewritten.
      - it turns out that we can't convert string data to character set of
        connection on the fly, because they first should be written to the binary
        log.
        To support efficient conversion we need to rewrite prepared statements
        binlogging code first.
      
      
      include/my_global.h:
        Macro swap(a, b, c) was renamed to resolve name conflict with
        String::swap() method.
      include/my_sys.h:
        Added declaration of escape_string_for_mysql()
      include/mysql_com.h:
        Removed and moved back: a macro which is visible to libmysql user but
        has sence only in prepared statement protocol implementation.
      isam/_search.c:
        swap -> swap_variables
      isam/test2.c:
        swap -> swap_variables
      libmysql/libmysql.c:
        - sub_escape_string moved to mysys/charset.c to be visible in sql/
        - few cleanups
      myisam/mi_test2.c:
        swap -> swap_variables
      mysys/charset.c:
        sub_escape_string was moved from libmysql.c to be able to use it in sql/
        code.
      mysys/my_chsize.c:
        rename: swap -> swap_variables
      mysys/my_compress.c:
        swap -> swap_variables
      mysys/my_handler.c:
        swap -> swap_variables
      sql/field.cc:
        Field::store_time refactored to use TIME_to_string function from time.cc
      sql/item.cc:
        New implementation of Item_param class:
        added support for character sets conversion.
      sql/item.h:
        Item_param:
        - 'state' member introduced instead of many boolean variables.
        - put ltime, int_value and real_value into union to save space.
        - remove unimplemented members
        - set_value renamed to set_str
      sql/item_timefunc.cc:
        Refactored to use functions from time.cc
      sql/lock.cc:
        rename: swap -> swap_variables
      sql/mysql_priv.h:
        - added declarations for TIME_to_ulonglong_*, TIME_to_string functions
        - const specifiers for make_date, make_time, make_datetime arguments
      sql/opt_range.cc:
        rename: swap -> swap_variables
      sql/protocol.cc:
        - added character set conversion support to binary protocol.
        - Protocol::convert changed to point at shared buffer in THD.
          This lets us use one convert buffer for binary and simple protocol.
          The same buffer is used for client->server conversions in prepared
          statements code.
        - string conversion code refactored to Protocol::store_string_aux function.
        - few more comments
      sql/protocol.h:
        - Protocol::convert now points at THD::convert_buffer: we want to share one
          buffer between all protocol implementations.
      sql/sql_class.cc:
        - implementation of THD::convert_string using THD::convert_buffer
          (conversion of strings allocated in the system heap).
      sql/sql_class.h:
        - THD::convert_buffer is shared between THD and network Protocols and
          used for character set conversion of strings.
        - new function to convert String object from one charset to another using
          THD::convert_buffer
      sql/sql_insert.cc:
        A little fix in a comment.
      sql/sql_parse.cc:
        Shrink convert buffer in the end of each statement.
      sql/sql_prepare.cc:
          Many changes:
        - static specifier for set_param_* family of functions.
        - FIELD_TYPE -> MYSQL_TYPE
        - added set_param_binary as handler for BLOB types.
        - added character set support
        - added support for param typecode in mysql_stmt_get_longdata
          (mysql_stmt_send_long_data handler)
        - changes in Item_param deployed
        - few cleanups
      sql/sql_select.cc:
        rename: swap -> swap_variables
      sql/sql_string.cc:
        - String::append rewritten to support character set conversion for
        single-byte encodings.
        - added String::swap method to efficiently exchange two string objects.
      sql/sql_string.h:
        Declraration for String::swap().
      sql/time.cc:
        - function TIME_to_string to convert TIME to String in default MySQL format
        - family of functions TIME_to_ulonglong_*
      tests/client_test.c:
        Test for support for character set conversions in prepared statements
        (binary and text data).
      093d6292
  30. 12 May, 2004 1 commit
    • unknown's avatar
      This is first cset for WL#1394 "Optimize index merge when all involved index... · 3600d09a
      unknown authored
      This is first cset for WL#1394 "Optimize index merge when all involved index ranges include only values with equal keys"
      The main idea is to exploit the fact that key scans for "key=const" return ordered sequences of rowids.
      
      
      include/my_base.h:
        Added HA_EXTRA_KEYREAD_PRESERVE_FIELDS flag
      include/my_bitmap.h:
        Added a couple of utility functions
      include/my_sys.h:
        Added my_conunt_bits_ushort function
      innobase/include/row0mysql.h:
        Added support for HA_EXTRA_KEYREAD_PRESERVE_FIELDS
      innobase/row/row0sel.c:
        Added support for HA_EXTRA_KEYREAD_PRESERVE_FIELDS
      mysys/my_bit.c:
        Added my_count_bits_ushort function
      mysys/my_bitmap.c:
        Added a couple of utility functions
      sql/ha_berkeley.cc:
        Added cmp_ref rowid comparison function.
      sql/ha_berkeley.h:
        Added cmp_ref rowid comparison function.
      sql/ha_heap.h:
        Added cmp_ref rowid comparison function.
      sql/ha_innodb.cc:
        Added cmp_ref rowid comparison function and support from HA_EXTRA_KEYREAD_PRESERVE_FIELDS
      sql/ha_innodb.h:
        Added cmp_ref rowid comparison function.
      sql/handler.h:
        Added cmp_ref rowid comparison function.
      sql/opt_range.cc:
        Added QUICK_ROR_{INTERSECT,UNION}_SELECT classes and related optimizer code
      sql/opt_range.h:
        Added QUICK_ROR_{INTERSECT,UNION}_SELECT classes
      sql/sql_delete.cc:
        Changed to use new ROWID comparison function
        also always call quick->reset() for quick selects
      sql/sql_select.cc:
        Account for new quick select types
      sql/sql_select.h:
        New, proper rowid ordering/comparison function to be used with Unique class etc.
      sql/sql_test.cc:
        Account for new quick select types
      sql/sql_update.cc:
        Account for new quick select types
      3600d09a
  31. 11 May, 2004 1 commit
    • unknown's avatar
      file parser for new .frm · e66b7405
      unknown authored
      include/my_sys.h:
        names for get_date format flags
      include/mysqld_error.h:
        error of parser
      libmysqld/Makefile.am:
        parser file added
      mysys/mf_getdate.c:
        function comment for get_date()
        2 new flags added
        names for get_date format flags
      sql/Makefile.am:
        parser file added
      sql/mysql_priv.h:
        parser file added
      sql/share/czech/errmsg.txt:
        file parser errors
      sql/share/danish/errmsg.txt:
        file parser errors
      sql/share/dutch/errmsg.txt:
        file parser errors
      sql/share/english/errmsg.txt:
        file parser errors
      sql/share/estonian/errmsg.txt:
        file parser errors
      sql/share/french/errmsg.txt:
        file parser errors
      sql/share/german/errmsg.txt:
        file parser errors
      sql/share/greek/errmsg.txt:
        file parser errors
      sql/share/hungarian/errmsg.txt:
        file parser errors
      sql/share/italian/errmsg.txt:
        file parser errors
      sql/share/japanese/errmsg.txt:
        file parser errors
      sql/share/korean/errmsg.txt:
        file parser errors
      sql/share/norwegian-ny/errmsg.txt:
        file parser errors
      sql/share/norwegian/errmsg.txt:
        file parser errors
      sql/share/polish/errmsg.txt:
        file parser errors
      sql/share/portuguese/errmsg.txt:
        file parser errors
      sql/share/romanian/errmsg.txt:
        file parser errors
      sql/share/russian/errmsg.txt:
        file parser errors
      sql/share/serbian/errmsg.txt:
        file parser errors
      sql/share/slovak/errmsg.txt:
        file parser errors
      sql/share/spanish/errmsg.txt:
        file parser errors
      sql/share/swedish/errmsg.txt:
        file parser errors
      sql/share/ukrainian/errmsg.txt:
        file parser errors
      BitKeeper/etc/ignore:
        Added libmysqld/parse_file.cc to the ignore list
      e66b7405
  32. 01 Apr, 2004 1 commit
    • unknown's avatar
      WL#775 "Add status variable identifying binlog_cache_size shortage" · a58b351e
      unknown authored
      Added two status variables: 
        binlog_cache_use - counts number of transactions that used somehow
          transaction temporary binary log.
        binlog_cache_disk_use - counts number of transactions that required
          disk I/O for storing info in this this binary log.
      
      
      include/my_sys.h:
        Added disk_writes member to the IO_CACHE structure for counting number
        of times when IO_CACHE was forced to write to disk.
      mysql-test/r/rpl_relayrotate.result:
        Fixed test result since added test for binlog_cache_use and 
        binlog_cache_disk_use status variables.
      mysql-test/t/rpl_relayrotate.test:
        Added test for binlog_cache_use and binlog_cache_disk_use status 
        variables.
        Now dropping t1 table on master too.
      mysys/mf_iocache.c:
        Added disk_writes member to the IO_CACHE structure for counting number
        of times when IO_CACHE was forced to write to disk.
      sql/handler.cc:
        Added support for binlog_cache_use and binlog_cache_disk_use status
        variable. First one is incremented if transaction used somehow 
        transaction temporary binary log (doesn't matter in memory only or 
        with writes to disk), the second one is incremented if this binary 
        log was flushed to disk at some point.
      sql/mysql_priv.h:
        Added declaration of status variables binlog_cache_use and 
        binlog_cache_disk_use.
      sql/mysqld.cc:
        Added status variables binlog_cache_use and binlog_cache_disk_use.
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      a58b351e
  33. 10 Mar, 2004 1 commit
    • unknown's avatar
      Fixed memory leak in DROP DATABASE when using RAID tables (Bug #2882) · 221397cd
      unknown authored
      BUILD/compile-pentium-debug-max:
        Added --with-raid
      configure.in:
        Removed -DFN_NO_CASE_SENCE for Mac OS X as this is not always true
      mysql-test/install_test_db.sh:
        Added --skip-warnings
      mysql-test/mysql-test-run.sh:
        Fixes to get --gdb and --ddd to work
      mysql-test/r/lowercase_table2.result:
        Test for lower_case_table_names=2 and temporary tables
      mysql-test/r/lowercase_table3.result:
        Fixed error message
      mysql-test/r/multi_update.result:
        Test of behaviour of multi-table-delete and alias
      mysql-test/t/lowercase_table2.test:
        Test for lower_case_table_names=2 and temporary tables
      mysql-test/t/lowercase_table3.test:
        Fixed error
      mysql-test/t/multi_update.test:
        Test of behaviour of multi-table-delete and alias (Bug #2940)
      mysys/mf_iocache.c:
        Renamed _flush_io_cache to my_b_flush_io_cache
      sql/ha_myisam.cc:
        Added comment
      sql/lock.cc:
        Extra debugging
      sql/log.cc:
        New parameter to flush_relay_log_info
      sql/log_event.cc:
        New parameter to flush_relay_log_info
      sql/mf_iocache.cc:
        Removed not used header files
      sql/mysqld.cc:
        More debugging info
        Less warnings when run with --skip-warnings
      sql/opt_range.cc:
        More debug information
      sql/repl_failsafe.cc:
        New parameter to flush_relay_log_info
      sql/slave.cc:
        First start SQL thread, then start IO thread. This fixed a raze condition in SLAVE START (Bug #2921)
        Ensure that we have a lock on the IO thread before flushing a relay log file that. The original code could core dump when a relay log rotated.
      sql/slave.h:
        New parameter to flush_relay_log_info
      sql/sql_base.cc:
        Added warning
      sql/sql_handler.cc:
        Indentation fix
      sql/sql_repl.cc:
        New parameter to flush_relay_log_info
      sql/sql_select.cc:
        Fixed problem with deleting temporary tables when using lower_case_table_names=2. (Bug #2858)
      sql/sql_table.cc:
        Fixed comment
      sql/sql_yacc.yy:
        Removed compiler warning
      include/my_sys.h:
        Fixed usage of unpack_filename
      mysys/mf_pack.c:
        Changed unpack_filename() to return length of result string.
      mysys/test_fn.c:
        Fixed usage of unpack_filename
      sql/sql_db.cc:
        Fixed memory leak with raid tables
      sql/table.cc:
        Fixed usage of unpack_filename
      221397cd
  34. 02 Mar, 2004 2 commits
    • unknown's avatar
      my_getsystime() · bbb3d27a
      unknown authored
      bbb3d27a
    • unknown's avatar
      Desperate attempt to push part of prepared statements cleanup which was · 7b68eaaf
      unknown authored
      reviewed in Saint-Petersbourg (including post-review fixes).
      
      
      include/my_sys.h:
        Added clear_alloc_root (reset alloc root without freeing its memory)
      sql/item.h:
        - rename setup_param -> set_parap (function assigns parameter value to item)
      sql/mysql_priv.h:
        - all return values are void, because return value is never checked in
            dispatch_command
        - removed unused declaration of setup_param_functions
      sql/protocol.h:
        - unused declarations of setup_params_data* removed
      sql/sql_class.cc:
        Cleanup:
          - bzero(mem_root) replaced with clear_alloc_root
          - query_id and command members moved back to THD from Statement
        Assignment of mem_root, free_list, query_id and command optimized
        away from set_statement().
      sql/sql_class.h:
        - query_id and command moved back to THD from Statement
      sql/sql_lex.h:
        - better type for param_list
        - param_count is the same thing as param_list.elements
      sql/sql_parse.cc:
        - comments for dispatch_command
      sql/sql_prepare.cc:
        Cleanup:
        - added comments to many functions and removed trailing spaces in many 
          lines, some stale comments removed.
        - it's faster to iterate using pointers, than classes
        - Renames: error_in_prepare renamed to get_longdata_error (because it is set
          when there is an error in mysql_send_longdata, rather than in
          mysql_prepare), embedded versions of placeholder assignement functions
          now have prefix emb_, setup_ functions renamed to set_, because they
          perform assignment, not installation, setup_params_data now doesn't
          call insert_params and was renamed to setup_set_param_functions,
        - find_prepared_statement should not send error if called from no-reply
          calls, like mysql_stmt_reset
        - error reporting is checked up, to always report errors and not report
          errors twice. send_prep_stmt can be done mostly in send_prepare_result, 
          rather than in test_* functions.
        - now we don't need to reinit THD->mem_root/free_list in mysql_stmt_execute,
          because it's not reset there.
      tests/client_test.c:
        - removed second call to test_subqueries
      7b68eaaf
  35. 27 Feb, 2004 1 commit
    • unknown's avatar
      my_gethwaddr() for linux/freebsd · 1e191736
      unknown authored
      UUID() function
      
      
      BitKeeper/etc/ignore:
        Added mysys/test_gethwaddr to the ignore list
      include/my_sys.h:
        my_gethwaddr()
      mysys/Makefile.am:
        my_gethwaddr
      sql/item_create.cc:
        UUID() function
      sql/item_create.h:
        UUID() function
      sql/item_strfunc.cc:
        UUID() function
      sql/item_strfunc.h:
        UUID() function
      sql/lex.h:
        UUID() function
      sql/mysql_priv.h:
        UUID() function
      sql/mysqld.cc:
        UUID() function
      sql/sql_class.cc:
        cleanup
      1e191736
  36. 19 Feb, 2004 1 commit
    • unknown's avatar
      Max open files handling moved to my_set_max_open_files() · ddbb7880
      unknown authored
      This ensures that my_file_info takes this the max number of files into account and one can now use --open-files-limit on windows to increase number of used files up to 2048
      
      
      client/client_priv.h:
        Added --open-files-limit to mysqlbinlog
      client/mysqlbinlog.cc:
        Added --open-files-limit to mysqlbinlog
      include/config-win.h:
        Define that you can have up to 2048 files open on windows
      include/my_global.h:
        Allow override of OS_FILE_LIMIT
      include/my_sys.h:
        Cleanup
        Added prototypes for my_set_max_open_files() and my_free_open_files()
      libmysql/Makefile.shared:
        Added my_file.c
      myisam/myisamlog.c:
        Use my_set_max_open_files()
      mysys/Makefile.am:
        Use my_file.c (for mysqlbinlog)
      mysys/my_alloc.c:
        Remove compiler warning
      mysys/my_div.c:
        MY_NFILE -> my_file_limit
      mysys/my_dup.c:
        MY_NFILE -> my_file_limit
      mysys/my_fopen.c:
        MY_NFILE -> my_file_limit
      mysys/my_open.c:
        MY_NFILE -> my_file_limit
      mysys/my_static.c:
        Allow changing of open files limit
      mysys/my_static.h:
        Allow changing of open files limit
      sql/mysqld.cc:
        Max open files handling moved to my_set_max_open_files()
      ddbb7880
  37. 02 Feb, 2004 1 commit
    • unknown's avatar
      Proposed (version #2) fix for bug #1948: · e0b0ec6b
      unknown authored
      "system variable query_prealloc_size can be only global"
      
      
      include/my_sys.h:
        Fix for bug #1948:
        - added reset_root_defaults function declaration
      mysys/my_alloc.c:
        Fix for bug #1948:
        - implementation and description of reset_root_defaults
      sql/set_var.cc:
        Fix for bug #1948:
        - fix_thd_mem_root and fix_trans_mem_root after update triggers
          implemented for variables query_prealloc_size, query_alloc_block_size,
          trans_prealloc_size, trans_alloc_block_size
      e0b0ec6b