The problem was that THD::row_count_func was zeroed too. It was zeroed
as a fix for bug 4905 "Stored procedure doesn't clear for "Rows affected"
However, the proper solution is not to zero, because THD::row_count_func has
been set to -1 already in mysql_execute_command(), a later fix, which obsoletes
the incorrect fix of #4095

The code that set up data to be passed to user-defined functions was very
old and analyzed the "Type" of the data that was passed into the UDF, when
it really should analyze the "return_type", which is hard-coded for simple
Items and works correctly for complex ones like functions.
---
Added test at Sergei's behest.

It's not possible to flush the global status variables in 5.0
Update test case so it works by recording the value of handle_rollback
before and compare it to the value after

into  shellback.(none):/home/msvensson/mysql/mysql-5.0-maint

into  mysql.com:/usr/home/ram/work/bug22158/my50-bug22158

into  neptunus.(none):/home/msvensson/mysql/mysql-5.0-maint

 - Improve icheck rules in Makefile.am

 - Add two null bytes in  "buff" variable allowing us to call
   get_arg two times also for strings longer than sizeof(buff) 

When executing the init_connect statement, thd->net.vio is set to 0, to         
forbid sending any results to the client. As a side effect we don't log         
possible errors, either.                                                        
                                                                                
Now we write warnings to the error log if an init_connect query                
fails.                                                                          

into  siva.hindu.god:/usr/home/tim/m/bk/50

into  neptunus.(none):/home/msvensson/mysql/mysql-5.0-maint

Remove one warning

Disable warnings around the create table statements, we want to use innodb when possible but they work just fine without.

into  neptunus.(none):/home/msvensson/mysql/mysql-5.0-maint

Update the binlog format parse routine to only be avaliable in 5.1 and allow for any binlog_format to be specified

into  neptunus.(none):/home/msvensson/mysql/mysql-5.0-maint

Fix two memory leaks in mysql_client_test

into  neptunus.(none):/home/msvensson/mysql/mysql-5.0-maint

Add comments
Deperlify

into  neptunus.(none):/home/msvensson/mysql/mysql-5.0-maint

into  siva.hindu.god:/usr/home/tim/m/bk/50

into  neptunus.(none):/home/msvensson/mysql/mysql-5.0-maint

into  neptunus.(none):/home/msvensson/mysql/mysql-4.1-maint

BUG#23427 incompatible ABI change in 5.0.26?
   - Use the icheck tool if avaliable and compare the current mysql.h to a version
controlled reference file 

into  neptunus.(none):/home/msvensson/mysql/mysql-5.0-maint

 - Fix check in mysql_client_test to reflect the change of datatype
   for DEFAULT column

into  neptunus.(none):/home/msvensson/mysql/mysql-5.0-maint

Flush both stdout and stderr before abort'ing mysql_client_test

into  neptunus.(none):/home/msvensson/mysql/mysql-5.0-maint

with error 1 and we are running with --force
The specific "analyze" code is enclosed in a .test file fwich can easily
be modified to be more advanced 

into  neptunus.(none):/home/msvensson/mysql/mysql-5.0-maint

into  neptunus.(none):/home/msvensson/mysql/mysql-5.0-maint