1. 09 Apr, 2008 2 commits
    • unknown's avatar
      Merge zippy.cornsilk.net:/home/cmiller/work/mysql/bug15776/my50-bug15776 · a16a72b6
      unknown authored
      into  zippy.cornsilk.net:/home/cmiller/work/mysql/mysql-5.0-build
      
      
      mysql-test/r/type_blob.result:
        Auto merged
      mysql-test/t/type_blob.test:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/unireg.h:
        Auto merged
      a16a72b6
    • unknown's avatar
      Follow-up to B-g#15776, test failures on 64-bit linux. · 2bc7179d
      unknown authored
      Make maximum blob size to be 2**32-1, regardless of word size.
      
      Fix failure of timestamp with size of 2**31-1.  The method of
      rounding up to the nearest even number would overflow.
      
      
      mysql-test/r/type_blob.result:
        2**32-1 is not a special case for timestamp.
        
        Test 2**32-1 and 2**64 as the reliable test points for both 32-
        and 64-bit machines.  I'd like to test 2**32, but that would make 
        tests that vary between architectures.
        
        I'd like to generalize the tests by pulling the max blob size from
        the server, and then "eval"ing N-1, N, and N+1 instead of all these
        literal numbers, but I have not found a way to get UINT_MAX.
      mysql-test/t/type_blob.test:
        2**32-1 is not a special case for timestamp.
        
        Test 2**32-1 and 2**64 as the reliable test points for both 32-
        and 64-bit machines.  I'd like to test 2**32, but that would make 
        tests that vary between architectures.
        
        I'd like to generalize the tests by pulling the max blob size from
        the server, and then "eval"ing N-1, N, and N+1 instead of all these
        literal numbers, but I have not found a way to get UINT_MAX.
      sql/field.cc:
        Fix a bug where the round-to-even code for TIMESTAMP fields
        failed where the size would overflow the size to zero and then
        fail.
        
        Also, since we silently truncate the size of TIMESTAMP fields, set
        the maximum size we report is allowable to be the largest parsable
        number.
      sql/unireg.h:
        Make BLOB size the maximum that the packed value in 
        field_blob::get_length() allows.
      2bc7179d
  2. 04 Apr, 2008 3 commits
  3. 03 Apr, 2008 4 commits
  4. 02 Apr, 2008 5 commits
  5. 01 Apr, 2008 4 commits
  6. 31 Mar, 2008 3 commits
    • unknown's avatar
      Fix for · 00412389
      unknown authored
         Bug#35335 funcs_1: Some tests fail within load_file during
                            pushbuild runs
         Solution: 1. Move files with input data used in load_file, 
                      load data etc. 
                      from suite/funcs_1/<whatever>
                      to std_data
                   2. Use for testsuite funcs_1 the server option
                      --secure-file-priv=<MYSQLTEST_VARDIR>
                   3. Outfiles have to be stored under MYSQLTEST_VARDIR 
      + changes according to WL#4304 Cleanup in funcs_1 tests
        - backport of fixes/improvements made in 5.1 to 5.0
          The differences between scripts in 5.0 and 5.1 cause
          much additional and annoying work during any upmerge.
        - replace error numbers with names
        - improved comments
        - improved formatting
        - Unify storage engine names so that result files for
          storage engine variants do not differ (some tests)
        - remove a script no more used (tests are done in other scripts)
      
      
      BitKeeper/deleted/.del-triggers_master.test:
        Delete: mysql-test/suite/funcs_1/triggers/triggers_master.test
      mysql-test/std_data/funcs_1/innodb_tb1.txt:
        Rename: mysql-test/suite/funcs_1/data/innodb_tb1.txt -> mysql-test/std_data/funcs_1/innodb_tb1.txt
      mysql-test/std_data/funcs_1/innodb_tb2.txt:
        Rename: mysql-test/suite/funcs_1/data/innodb_tb2.txt -> mysql-test/std_data/funcs_1/innodb_tb2.txt
      mysql-test/std_data/funcs_1/innodb_tb3.txt:
        Rename: mysql-test/suite/funcs_1/data/innodb_tb3.txt -> mysql-test/std_data/funcs_1/innodb_tb3.txt
      mysql-test/std_data/funcs_1/innodb_tb4.txt:
        Rename: mysql-test/suite/funcs_1/data/innodb_tb4.txt -> mysql-test/std_data/funcs_1/innodb_tb4.txt
      mysql-test/std_data/funcs_1/memory_tb1.txt:
        Rename: mysql-test/suite/funcs_1/data/memory_tb1.txt -> mysql-test/std_data/funcs_1/memory_tb1.txt
      mysql-test/std_data/funcs_1/memory_tb2.txt:
        Rename: mysql-test/suite/funcs_1/data/memory_tb2.txt -> mysql-test/std_data/funcs_1/memory_tb2.txt
      mysql-test/std_data/funcs_1/memory_tb3.txt:
        Rename: mysql-test/suite/funcs_1/data/memory_tb3.txt -> mysql-test/std_data/funcs_1/memory_tb3.txt
      mysql-test/std_data/funcs_1/memory_tb4.txt:
        Rename: mysql-test/suite/funcs_1/data/memory_tb4.txt -> mysql-test/std_data/funcs_1/memory_tb4.txt
      mysql-test/std_data/funcs_1/myisam_tb1.txt:
        Rename: mysql-test/suite/funcs_1/data/myisam_tb1.txt -> mysql-test/std_data/funcs_1/myisam_tb1.txt
      mysql-test/std_data/funcs_1/myisam_tb2.txt:
        Rename: mysql-test/suite/funcs_1/data/myisam_tb2.txt -> mysql-test/std_data/funcs_1/myisam_tb2.txt
      mysql-test/std_data/funcs_1/myisam_tb3.txt:
        Rename: mysql-test/suite/funcs_1/data/myisam_tb3.txt -> mysql-test/std_data/funcs_1/myisam_tb3.txt
      mysql-test/std_data/funcs_1/myisam_tb4.txt:
        Rename: mysql-test/suite/funcs_1/data/myisam_tb4.txt -> mysql-test/std_data/funcs_1/myisam_tb4.txt
      mysql-test/std_data/funcs_1/t3.txt:
        Rename: mysql-test/suite/funcs_1/data/t3.txt -> mysql-test/std_data/funcs_1/t3.txt
      mysql-test/std_data/funcs_1/t4.txt:
        Rename: mysql-test/suite/funcs_1/data/t4.txt -> mysql-test/std_data/funcs_1/t4.txt
      mysql-test/std_data/funcs_1/t7.txt:
        Rename: mysql-test/suite/funcs_1/data/t7.txt -> mysql-test/std_data/funcs_1/t7.txt
      mysql-test/std_data/funcs_1/t9.txt:
        Rename: mysql-test/suite/funcs_1/data/t9.txt -> mysql-test/std_data/funcs_1/t9.txt
      mysql-test/Makefile.am:
        Introduce installation of funcs_1 files in std_data.
      mysql-test/mysql-test-run.pl:
        The tests within funcs_1 need a server started with
            --secure-file-priv=<MYSQLTEST_VARDIR>
        like the main regression tests.
      mysql-test/suite/funcs_1/README.txt:
        Extended description
      mysql-test/suite/funcs_1/datadict/datadict_bug_12777.inc:
        Cleanup
      mysql-test/suite/funcs_1/datadict/datadict_load.inc:
        Cleanup
      mysql-test/suite/funcs_1/include/innodb_tb1.inc:
        Adjustment to new storage place of infile.
      mysql-test/suite/funcs_1/include/innodb_tb2.inc:
        Adjustment to new storage place of infile.
      mysql-test/suite/funcs_1/include/innodb_tb3.inc:
        Adjustment to new storage place of infile.
      mysql-test/suite/funcs_1/include/innodb_tb4.inc:
        Adjustment to new storage place of infile.
      mysql-test/suite/funcs_1/include/memory_tb1.inc:
        Adjustment to new storage place of infile.
      mysql-test/suite/funcs_1/include/memory_tb2.inc:
        Adjustment to new storage place of infile.
      mysql-test/suite/funcs_1/include/memory_tb3.inc:
        Adjustment to new storage place of infile.
      mysql-test/suite/funcs_1/include/memory_tb4.inc:
        Adjustment to new storage place of infile.
      mysql-test/suite/funcs_1/include/myisam_tb1.inc:
        Adjustment to new storage place of infile.
      mysql-test/suite/funcs_1/include/myisam_tb2.inc:
        Adjustment to new storage place of infile.
      mysql-test/suite/funcs_1/include/myisam_tb3.inc:
        Adjustment to new storage place of infile.
      mysql-test/suite/funcs_1/include/myisam_tb4.inc:
        Adjustment to new storage place of infile.
      mysql-test/suite/funcs_1/include/sp_tb.inc:
        Adjustment to new storage place of infile.
      mysql-test/suite/funcs_1/r/innodb_func_view.result:
        Updated results
      mysql-test/suite/funcs_1/r/innodb_storedproc_02.result:
        Updated results
      mysql-test/suite/funcs_1/r/innodb_storedproc_03.result:
        Updated results
      mysql-test/suite/funcs_1/r/innodb_storedproc_06.result:
        Updated results
      mysql-test/suite/funcs_1/r/innodb_storedproc_07.result:
        Updated results
      mysql-test/suite/funcs_1/r/innodb_storedproc_08.result:
        Updated results
      mysql-test/suite/funcs_1/r/innodb_storedproc_10.result:
        Updated results
      mysql-test/suite/funcs_1/r/innodb_trig_0102.result:
        Updated results
      mysql-test/suite/funcs_1/r/innodb_trig_03.result:
        Updated results
      mysql-test/suite/funcs_1/r/innodb_trig_0407.result:
        Updated results
      mysql-test/suite/funcs_1/r/innodb_trig_08.result:
        Updated results
      mysql-test/suite/funcs_1/r/innodb_trig_09.result:
        Updated results
      mysql-test/suite/funcs_1/r/innodb_trig_1011ext.result:
        Updated results
      mysql-test/suite/funcs_1/r/innodb_trig_frkey.result:
        Updated results
      mysql-test/suite/funcs_1/r/innodb_views.result:
        Updated results
      mysql-test/suite/funcs_1/r/is_columns_innodb.result:
        Updated results
      mysql-test/suite/funcs_1/r/is_columns_memory.result:
        Updated results
      mysql-test/suite/funcs_1/r/is_columns_myisam.result:
        Updated results
      mysql-test/suite/funcs_1/r/is_columns_ndb.result:
        Updated results
      mysql-test/suite/funcs_1/r/is_tables_innodb.result:
        Updated results
      mysql-test/suite/funcs_1/r/is_tables_memory.result:
        Updated results
      mysql-test/suite/funcs_1/r/is_tables_myisam.result:
        Updated results
      mysql-test/suite/funcs_1/r/is_tables_ndb.result:
        Updated results
      mysql-test/suite/funcs_1/r/memory_func_view.result:
        Updated results
      mysql-test/suite/funcs_1/r/memory_storedproc_02.result:
        Updated results
      mysql-test/suite/funcs_1/r/memory_storedproc_03.result:
        Updated results
      mysql-test/suite/funcs_1/r/memory_storedproc_06.result:
        Updated results
      mysql-test/suite/funcs_1/r/memory_storedproc_07.result:
        Updated results
      mysql-test/suite/funcs_1/r/memory_storedproc_08.result:
        Updated results
      mysql-test/suite/funcs_1/r/memory_storedproc_10.result:
        Updated results
      mysql-test/suite/funcs_1/r/memory_trig_0102.result:
        Updated results
      mysql-test/suite/funcs_1/r/memory_trig_03.result:
        Updated results
      mysql-test/suite/funcs_1/r/memory_trig_0407.result:
        Updated results
      mysql-test/suite/funcs_1/r/memory_trig_08.result:
        Updated results
      mysql-test/suite/funcs_1/r/memory_trig_09.result:
        Updated results
      mysql-test/suite/funcs_1/r/memory_trig_1011ext.result:
        Updated results
      mysql-test/suite/funcs_1/r/memory_views.result:
        Updated results
      mysql-test/suite/funcs_1/r/myisam_func_view.result:
        Updated results
      mysql-test/suite/funcs_1/r/myisam_storedproc_02.result:
        Updated results
      mysql-test/suite/funcs_1/r/myisam_storedproc_03.result:
        Updated results
      mysql-test/suite/funcs_1/r/myisam_storedproc_06.result:
        Updated results
      mysql-test/suite/funcs_1/r/myisam_storedproc_07.result:
        Updated results
      mysql-test/suite/funcs_1/r/myisam_storedproc_08.result:
        Updated results
      mysql-test/suite/funcs_1/r/myisam_storedproc_10.result:
        Updated results
      mysql-test/suite/funcs_1/r/myisam_trig_0102.result:
        Updated results
      mysql-test/suite/funcs_1/r/myisam_trig_03.result:
        Updated results
      mysql-test/suite/funcs_1/r/myisam_trig_0407.result:
        Updated results
      mysql-test/suite/funcs_1/r/myisam_trig_08.result:
        Updated results
      mysql-test/suite/funcs_1/r/myisam_trig_09.result:
        Updated results
      mysql-test/suite/funcs_1/r/myisam_trig_1011ext.result:
        Updated results
      mysql-test/suite/funcs_1/r/myisam_views.result:
        Updated results
      mysql-test/suite/funcs_1/storedproc/cleanup_sp_tb.inc:
        "--echo" instead of SQL command.
      mysql-test/suite/funcs_1/storedproc/load_sp_tb.inc:
        Adjustment to new storage place of infile
        + correct formatting.
      mysql-test/suite/funcs_1/storedproc/storedproc_02.inc:
        Backport from 5.1 + correct formatting.
      mysql-test/suite/funcs_1/storedproc/storedproc_03.inc:
        Minor improvements + correct formatting.
      mysql-test/suite/funcs_1/storedproc/storedproc_06.inc:
        Backport from 5.1 + correct formatting
      mysql-test/suite/funcs_1/storedproc/storedproc_10.inc:
        Backport from 5.1. + correct formatting
      mysql-test/suite/funcs_1/t/innodb_trig_0407.test:
        Cleanup
      mysql-test/suite/funcs_1/t/is_basics_mixed.test:
        Adjustment to new storage place of outfile.
      mysql-test/suite/funcs_1/t/memory_storedproc_02.test:
        Cleanup
      mysql-test/suite/funcs_1/t/memory_storedproc_03.test:
        Cleanup
      mysql-test/suite/funcs_1/t/memory_storedproc_06.test:
        Cleanup
      mysql-test/suite/funcs_1/t/memory_storedproc_07.test:
        Cleanup
      mysql-test/suite/funcs_1/t/memory_storedproc_08.test:
        Cleanup
      mysql-test/suite/funcs_1/t/memory_storedproc_10.test:
        Cleanup
      mysql-test/suite/funcs_1/t/myisam_storedproc_02.test:
        Cleanup
      mysql-test/suite/funcs_1/t/myisam_storedproc_03.test:
        Cleanup
      mysql-test/suite/funcs_1/t/myisam_storedproc_06.test:
        Cleanup
      mysql-test/suite/funcs_1/t/myisam_storedproc_07.test:
        Cleanup
      mysql-test/suite/funcs_1/t/myisam_storedproc_08.test:
        Cleanup
      mysql-test/suite/funcs_1/t/myisam_storedproc_10.test:
        Cleanup
      mysql-test/suite/funcs_1/triggers/trig_frkey2.inc:
        Cleanup
      mysql-test/suite/funcs_1/triggers/triggers_0102.inc:
        Cleanup
      mysql-test/suite/funcs_1/triggers/triggers_03.inc:
        Backport from 5.1
      mysql-test/suite/funcs_1/triggers/triggers_0407.inc:
        Backport from 5.1
      mysql-test/suite/funcs_1/triggers/triggers_08.inc:
        Backport from 5.1
      mysql-test/suite/funcs_1/triggers/triggers_09.inc:
        Backport from 5.1
      mysql-test/suite/funcs_1/triggers/triggers_1011ext.inc:
        Backport from 5.1
      mysql-test/suite/funcs_1/views/func_view.inc:
        Backport from 5.1
      mysql-test/suite/funcs_1/views/views_master.inc:
        Cleanup
      mysql-test/std_data/funcs_1/load_file.txt:
        New BitKeeper file ``mysql-test/std_data/funcs_1/load_file.txt''
      00412389
    • unknown's avatar
      Removing race conditions from rpl_packet causing test to fail. · a49184af
      unknown authored
      
      mysql-test/r/rpl_packet.result:
        Result change.
      mysql-test/t/rpl_packet.test:
        Setting net_buffer_length correctly for the test instead of relying on it
        being set correctly. Waiting for slave to stop after issuing a SLAVE STOP
        and waiting for slave to start when issuing a SLAVE START to prevent race
        conditions causing test failure.
      a49184af
    • unknown's avatar
      Merge mkindahl@bk-internal.mysql.com:/home/bk/mysql-5.0 · d59b8cf0
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.0-rpl-merge
      
      
      d59b8cf0
  7. 30 Mar, 2008 1 commit
  8. 29 Mar, 2008 3 commits
  9. 28 Mar, 2008 12 commits
    • unknown's avatar
      Merge amd64.(none):/src/mysql-5.0-bugteam · 396b24a5
      unknown authored
      into  amd64.(none):/src/bug26243/my50-bug26243
      
      
      396b24a5
    • unknown's avatar
      Fix tree: · 7021064a
      unknown authored
        1. Use 'dat' extension, because it is handled in Makefile.am;
        2. Fix typo: the bug id is 35469, not 35649.
      
      
      mysql-test/std_data/bug35469.dat:
        Rename: mysql-test/std_data/bug35649.data -> mysql-test/std_data/bug35469.dat
      mysql-test/r/loaddata.result:
        Update result file.
      mysql-test/t/loaddata.test:
        1. Use 'dat' extension, because it is handled in Makefile.am;
        2. Fix typo: the bug id is 35469, not 35649.
      7021064a
    • unknown's avatar
      Merge amd64.(none):/src/mysql-5.0-bugteam · 219c7a2a
      unknown authored
      into  amd64.(none):/src/bug26243/my50-bug26243
      
      
      libmysql/libmysql.c:
        Auto merged
      myisam/mi_open.c:
        Auto merged
      sql/ha_federated.cc:
        Auto merged
      sql/ha_myisammrg.cc:
        Auto merged
      sql/slave.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      219c7a2a
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-bugteam · afb4ac45
      unknown authored
      into  quad.opbmk:/mnt/raid/alik/MySQL/devel/5.0-bt
      
      
      afb4ac45
    • unknown's avatar
      Bug#26243 mysql command line crash after control-c · a9089cf4
      unknown authored
      - Backported the 5.1 DBUG to 5.0.
      - Avoid memory cleanup race on Windows client for CTRL-C
      
      
      client/mysql.cc:
        Bug#26243 mysql command line crash after control-c
        - On Windows, the sigint handler shouldn't call mysql_end
        because the main thread will do so automatically.
        - Remove unnecessary signal call from the sigint handler.
        - Call my_end with proper value.
      dbug/dbug.c:
        Bug#26243 mysql command line crash after control-c
        - Backported the 5.1 DBUG library. The old version uses a non-thread 
        safe global variable 'static struct state *stack'.
      dbug/factorial.c:
        Bug#26243 mysql command line crash after control-c
        - Backported the 5.1 DBUG library. The old version uses a non-thread 
        safe global variable 'static struct state *stack'.
      dbug/user.r:
        Bug#26243 mysql command line crash after control-c
        - Backported the 5.1 DBUG library. The old version uses a non-thread 
        safe global variable 'static struct state *stack'.
      include/my_dbug.h:
        Bug#26243 mysql command line crash after control-c
        - Backported the 5.1 DBUG library. The old version uses a non-thread 
        safe global variable 'static struct state *stack'.
      libmysql/libmysql.c:
        Bug#26243 mysql command line crash after control-c
        - Update for new DBUG library.
      myisam/mi_open.c:
        Bug#26243 mysql command line crash after control-c
        - Update for new DBUG library.
      sql/ha_federated.cc:
        Bug#26243 mysql command line crash after control-c
        - Update for new DBUG library.
      sql/ha_innodb.cc:
        Bug#26243 mysql command line crash after control-c
        - Update for new DBUG library.
      sql/ha_myisammrg.cc:
        Bug#26243 mysql command line crash after control-c
        - Update for new DBUG library.
      sql/item_cmpfunc.cc:
        Bug#26243 mysql command line crash after control-c
        - Update for new DBUG library.
      sql/mysqld.cc:
        Bug#26243 mysql command line crash after control-c
        - Update for new DBUG library.
      sql/net_serv.cc:
        Bug#26243 mysql command line crash after control-c
        - Update for new DBUG library.
      sql/opt_range.cc:
        Bug#26243 mysql command line crash after control-c
        - Update for new DBUG library.
      sql/set_var.cc:
        Bug#26243 mysql command line crash after control-c
        - Update for new DBUG library.
      sql/slave.cc:
        Bug#26243 mysql command line crash after control-c
        - Update for new DBUG library.
      sql/sql_cache.cc:
        Bug#26243 mysql command line crash after control-c
        - Update for new DBUG library.
      sql/sql_select.cc:
        Bug#26243 mysql command line crash after control-c
        - Update for new DBUG library.
      tests/mysql_client_test.c:
        Bug#26243 mysql command line crash after control-c
        - Update for new DBUG library.
      a9089cf4
    • unknown's avatar
      Fix for Bug#35469: server crash with LOAD DATA INFILE to a VIEW. · 4ec65151
      unknown authored
      The problem was that LOAD DATA code (sql_load.cc) didn't take into
      account that there may be items, representing references to other
      columns. This is a usual case in views. The crash happened because
      Item_direct_view_ref was casted to Item_user_var_as_out_param,
      which is not a base class.
      
      The fix is to
        1) Handle references properly;
        2) Ensure that an item is treated as a user variable only when
           it is a user variable indeed;
        3) Report an error if LOAD DATA is used to load data into
           non-updatable column.
      
      
      mysql-test/r/loaddata.result:
        Update result file.
      mysql-test/t/loaddata.test:
        Add a test case form Bug#35469: server crash with
        LOAD DATA INFILE to a VIEW.
      sql/share/errmsg.txt:
        Introduce a new error.
      sql/sql_load.cc:
        Handle reference-items properly.
      mysql-test/std_data/bug35649.data:
        Add a data file for the test case.
      4ec65151
    • unknown's avatar
      Merge witty.:/Users/mattiasj/clones/bug21413-50-engines · 0e4dd57a
      unknown authored
      into  witty.:/Users/mattiasj/clones/bug21413-50-bugteam
      
      
      0e4dd57a
    • unknown's avatar
      Merge witty.:/Users/mattiasj/Public/shared-vms/bug21413-41-engines · 32d232ff
      unknown authored
      into  witty.:/Users/mattiasj/clones/bug21413-50-engines
      
      
      sql/sql_insert.cc:
        Manual merge
      32d232ff
    • unknown's avatar
      Bug#21413 - Engine table handler used by multiple threads · fe22ff56
      unknown authored
                  in REPLACE DELAYED
          
      post push patch, removing the optimization for
      copying delayed_insert variables.
      
      
      sql/sql_insert.cc:
        Bug#21413 - Engine table handler used by multiple threads
                    in REPLACE DELAYED
        
        post push patch, removing the optimization for
        copying delayed_insert variables.
        (restored some parts which caused errors)
      fe22ff56
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-bugteam · 7c156537
      unknown authored
      into  moonbone.local:/work/27219-5.0-opt-mysql
      
      
      sql/item.cc:
        Auto merged
      sql/item_subselect.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      7c156537
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0 · ab82016a
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/merge-5.0-bugteam
      
      
      sql/sql_acl.cc:
        Auto merged
      ab82016a
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0 · b6b4202b
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/merge-5.0-bugteam
      
      
      b6b4202b
  10. 27 Mar, 2008 3 commits
    • unknown's avatar
      Merge mysql.com:/misc/mysql/mysql-5.0 · ed1d366a
      unknown authored
      into  mysql.com:/misc/mysql/mysql-5.0-opt
      
      
      CMakeLists.txt:
        Auto merged
      configure.in:
        Auto merged
      include/config-win.h:
        Auto merged
      include/my_global.h:
        Auto merged
      ed1d366a
    • unknown's avatar
      Bug#27219: Aggregate functions in ORDER BY. · 9d661efd
      unknown authored
      Mixing aggregate functions and non-grouping columns is not allowed in the
      ONLY_FULL_GROUP_BY mode. However in some cases the error wasn't thrown because
      of insufficient check.
      
      In order to check more thoroughly the new algorithm employs a list of outer
      fields used in a sum function and a SELECT_LEX::full_group_by_flag.
      Each non-outer field checked to find out whether it's aggregated or not and
      the current select is marked accordingly.
      All outer fields that are used under an aggregate function are added to the
      Item_sum::outer_fields list and later checked by the Item_sum::check_sum_func
      function.
      
      
      mysql-test/t/group_by.test:
        Added a test case for the bug#27219: Aggregate functions in ORDER BY.
      mysql-test/r/group_by.result:
        Added a test case for the bug#27219: Aggregate functions in ORDER BY.
      sql/sql_select.cc:
        Bug#27219: Aggregate functions in ORDER BY.
        Implementation of new check for mixing non aggregated fields and aggregation
        function in the ONLY_FULL_GROUP_BY mode.
      sql/sql_lex.cc:
        Bug#27219: Aggregate functions in ORDER BY.
        Initialization of the full_group_by_flag bitmap.
        SELECT_LEX::test_limit function doesn't reset ORDER BY
        clause anymore.
      sql/sql_lex.h:
        Bug#27219: Aggregate functions in ORDER BY.
        The full_group_by_flag is added to the SELECT_LEX class.
      sql/item_sum.h:
        Bug#27219: Aggregate functions in ORDER BY.
        The outer_fields list is added to the Item_sum class.
      sql/mysql_priv.h:
        Bug#27219: Aggregate functions in ORDER BY.
        Defined a set of constants used in the new check for mixing non aggregated
        fields and sum functions in the ONLY_FULL_GROUP_BY_MODE.
      sql/item_subselect.cc:
        Bug#27219: Aggregate functions in ORDER BY.
        The Item_in_subselect::select_in_like_transformer function now drops
        ORDER BY clause in all selects in a subquery.
      sql/item_sum.cc:
        Bug#27219: Aggregate functions in ORDER BY.
        Now the Item_sum::check_sum_func function now checks whether fields in the
        outer_fields list are aggregated or not and marks selects accordingly.
      sql/item.cc:
        Bug#27219: Aggregate functions in ORDER BY.
        Now the Item_field::fix_fields function checks whether the field is aggregated
        or not and marks its select_lex accordingly.
      9d661efd
    • unknown's avatar
      Merge host.loc:/home/uchum/work/mysql-5.0 · 8e473edd
      unknown authored
      into  host.loc:/home/uchum/work/5.0-opt
      
      
      configure.in:
        Auto merged
      sql/item.cc:
        Auto merged
      8e473edd