1. 14 Sep, 2006 1 commit
  2. 11 Sep, 2006 1 commit
  3. 04 Sep, 2006 1 commit
    • unknown's avatar
      bug#21965 - replication · d2d605e4
      unknown authored
        fix deadlock if master switches log file in parallell with "show master logs"
        
      
      
      sql/log.cc:
        add raw_get_current_log which dont take log mutex
      sql/sql_class.h:
        add raw_get_current_log which dont take log mutex
      sql/sql_repl.cc:
        Fix lock order i.e first log_lock then index_lock
      d2d605e4
  4. 30 Aug, 2006 1 commit
  5. 26 Aug, 2006 1 commit
  6. 24 Aug, 2006 3 commits
    • unknown's avatar
      BUG#16255: Post-review fixes: adjust the testcase. · f895a16c
      unknown authored
      
      mysql-test/r/subselect.result:
        BUG#16255: A proper testcase
      mysql-test/t/subselect.test:
        BUG#16255: A proper testcase
      f895a16c
    • unknown's avatar
      Bug #16255: Subquery in WHERE (the cset by Georgi Kodinov) · c74c8195
      unknown authored
       Must not use Item_direct_ref in HAVING because it points to
       the new value (witch is not yet calculated for the first row).
      
      
      mysql-test/r/subselect.result:
        Bug #16255: Subquery in where
         - test case
      mysql-test/t/subselect.test:
        Bug #16255: Subquery in where
         - test case
      sql/item_subselect.cc:
        Bug #16255: Subquery in where
         Must not use Item_direct_ref in HAVING because it points to
         the new value (witch is not yet calculated for the first row).
      c74c8195
    • unknown's avatar
      ndb - bug#21800 · 5d82bec5
      unknown authored
        read TransactionDeadlockTimeout (for scans) to cater for insane settings
      
      
      ndb/src/ndbapi/NdbScanOperation.cpp:
        read TransactionDeadlockTimeout to cater for insane settings
      5d82bec5
  7. 15 Aug, 2006 1 commit
    • unknown's avatar
      BUG#21077: Possible crash caused by invalid sequence of handler::* calls: ... · 9907e970
      unknown authored
      BUG#21077: Possible crash caused by invalid sequence of handler::* calls:                                                
      The crash was caused by invalid sequence of handler::** calls:                                                           
        ha_smth->index_init();                                                                                                 
        ha_smth->index_next_same(); (2)                                                                                        
      (2) is an invalid call as it was not preceeded by any 'scan setup' call
      like index_first() or index_read(). The cause was that QUICK_SELECT::reset()
      didn't "fully reset" the quick select- current QUICK_RANGE wasn't forgotten,
      and quick select might attempt to continue reading the range, which would
      result in the above mentioned invalid sequence of handler calls.
      
      5.x versions are not affected by the bug - they already have the missing
      "range=NULL" clause.                                                    
                                                             
      
      
      mysql-test/r/innodb_mysql.result:
        Testcase for BUG#21077
      mysql-test/t/innodb_mysql.test:
        Testcase for BUG#21077
      sql/opt_range.h:
        BUG#21077: Possible crash caused by invalid sequence of handler::* calls:                                              
         - Make QUICK_SELECT::reset() really reset the quick select
      9907e970
  8. 10 Aug, 2006 1 commit
    • unknown's avatar
      Fix for bug #20709: Collation not used in group by on 4.1. · bfdbb780
      unknown authored
      myisam/mi_uniue.c:mi_check_unique() should skip trailing spaces comparing 
      TEXT and VARTTEXT key segments.
      
      
      myisam/mi_unique.c:
        Fix for bug #20709: Collation not used in group by on 4.1.    
        
        myisam/mi_uniue.c:mi_check_unique() should skip trailing spaces comparing 
        TEXT and VARTTEXT key segments.
          
        Example: assume, we have a 'char(200) collate utf8_unicode_ci' field,
        there are two records with _utf8"0x65" and _utf8"0xC3A9" characters;
        these values are equal according
        to the utf8_unicode_ci collation, but two 600 byte length corresponding keys:  
        "0x65<0x20 repeats 599 times>" and "0xC3A9<0x20 repeats 598 times>" are not    
        equal if we count trailing spaces and it may cause inconsequent behavior.
        
        So, let's pass 1 as the skip_end_space parameter value to the mi_compare_text()
        function for proper TEXT and VARTTEXT key segments comparison.
      mysql-test/r/ctype_utf8.result:
        Fix for bug #20709: Collation not used in group by on 4.1.    
          - test results.
      mysql-test/t/ctype_utf8.test:
        Fix for bug #20709: Collation not used in group by on 4.1.    
          - test case.
      bfdbb780
  9. 09 Aug, 2006 4 commits
    • unknown's avatar
      Removed iggy's accidentally checked-in test files. · 70269a09
      unknown authored
      
      BitKeeper/deleted/.del-bug20328.test:
        Delete: mysql-test/t/bug20328.test
      BitKeeper/deleted/.del-bug20328.result:
        Delete: mysql-test/r/bug20328.result
      70269a09
    • unknown's avatar
      ndb - bug#21536 · 3d7cb87b
      unknown authored
        Make sure updateNodeInfo is run on master also for temporary tables
      
      
      ndb/src/kernel/blocks/dbdih/DbdihMain.cpp:
        Run update nodeinfo also here to handle
          temprorary tables in some situations
      ndb/src/kernel/blocks/ndbcntr/NdbcntrMain.cpp:
        new error insert
      ndb/test/ndbapi/testSystemRestart.cpp:
        test case
      3d7cb87b
    • unknown's avatar
      Merge svojtovich@bk-internal.mysql.com:/home/bk/mysql-4.1 · 8f88400d
      unknown authored
      into  may.pils.ru:/home/svoj/devel/mysql/BUG20060/mysql-4.1
      
      
      8f88400d
    • unknown's avatar
      BUG#20060 - mysqld option "--flush " doesn't work for update statement · a2a5f2b5
      unknown authored
      Problem described in this bug report affects MyISAM tables only.
      
      Running mysqld --flush instructs mysqld to sync all changes to disk
      after each SQL statement. It worked well for INSERT and DELETE
      statements, but it did sync for UPDATE only in case if there was
      index change (change of colum that has an index). If no updated column
      has an index, data wasn't synced to disk.
      
      This fix makes UPDATE statement to sync data to disk even if there is
      no index change (that is only data change) and mysqld is run with
      --flush option.
      
      
      myisam/mi_update.c:
        Every myisam function that updates myisam table must end with
        call to _mi_writeinfo(). If operation (second param of
        _mi_writeinfo()) is not 0 it sets share->changed to 1, that is
        flags that data has changed. If operation is 0, this function
        equals to no-op in this case.
        
        mi_update() must always pass !0 value as operation, since even if
        there is no index change there could be data change.
      a2a5f2b5
  10. 08 Aug, 2006 1 commit
    • unknown's avatar
      ndb - bug#21213 · 6e5ad691
      unknown authored
        Make sure totSendlenAi is set in case of ACC_ABORTCONF and activeCreate == true
        (only needed when >2 replica)
      
      
      ndb/src/kernel/blocks/dblqh/DblqhMain.cpp:
        Make sure totSendlenAi is set in case of ACC_ABORTCONF and activeCreate == true
      6e5ad691
  11. 07 Aug, 2006 2 commits
  12. 04 Aug, 2006 2 commits
    • unknown's avatar
      ndb - bug#21400 · bb285b44
      unknown authored
        Fix docs for NdbOpertation::sub_reg
      
      
      ndb/include/ndbapi/NdbOperation.hpp:
        Fix docs for sub_reg
      bb285b44
    • unknown's avatar
      ndb - bug#20296 (recommit in 4.1) · f287b4a8
      unknown authored
         Make sure that tupkeyErrorLab is run if interpretedUpdate(fail), so that entry is not inserted into index.
           Yeilding crash on following dml on tupel
      
      
      
      ndb/src/kernel/blocks/dbtup/DbtupExecQuery.cpp:
        Make sure that tupkeyErrorLab is run if interpretedUpdate(fail), so that entry is not inserted into index.
              Yeilding crash on following dml on tupe
      f287b4a8
  13. 03 Aug, 2006 6 commits
    • unknown's avatar
      ndb - bug#20892 · 42fd7e8f
      unknown authored
        Fix bug in tup buddy allocator, which made it make invalid access to cfreepagelist[16] (which is not defined)
      
      
      ndb/src/kernel/blocks/dbtup/DbtupPagMan.cpp:
        loop from firstListToCheck -1 (as firstListToCheck has already been checked), when looking for less than requested pages
        add if-statement for firtListToCheck == 0
      42fd7e8f
    • unknown's avatar
      Merge svojtovich@bk-internal.mysql.com:/home/bk/mysql-4.1 · dba52b53
      unknown authored
      into  may.pils.ru:/home/svoj/devel/mysql/BUG7391/mysql-4.1
      
      
      dba52b53
    • unknown's avatar
      Bug#21419 test case lowercase_fs_off fails on Windows · 842ec233
      unknown authored
       - Backport patch from 5.0
      
      
      sql/mysqld.cc:
        Add else case to set "lower_case_file_system" also when lower_case_table_names are 1
      842ec233
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/my41-bug21218 · 135ffa63
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-4.1
      
      
      mysql-test/t/mysqlbinlog.test:
        Auto merged
      135ffa63
    • unknown's avatar
      Merge svojtovich@bk-internal.mysql.com:/home/bk/mysql-4.1 · 485510a2
      unknown authored
      into  may.pils.ru:/home/svoj/devel/mysql/BUG7391/mysql-4.1
      
      
      485510a2
    • unknown's avatar
      BUG#7391 - Cross-database multi-table UPDATE uses active database · 74465080
      unknown authored
                 privileges
      
      This problem is 4.1 specific. It doesn't affect 4.0 and was fixed
      in 5.x before.
      
      Having any mysql user who is allowed to issue multi table update
      statement and any column/table grants, allows this user to update
      any table on a server (mysql grant tables are not exception).
      
      check_grant() accepts number of tables (in table list) to be checked
      in 5-th param. While checking grants for multi table update, number
      of tables must be 1. It must never be 0 (actually we have
      DBUG_ASSERT(number > 0) in 5.x in grant_check() function).
      
      
      mysql-test/r/grant.result:
        Addition to test case for bug#7391:
        - Added grant statement to trigger this problem in 4.1.
        - Fixed error messages.
      mysql-test/t/grant.test:
        Addition to test case for bug#7391:
        - Added grant statement to trigger this problem in 4.1.
        - Fixed error messages.
      sql/sql_update.cc:
        check_grant() accepts number of tables (in table list) to be checked
        in 5-th param. For this particular check number of tables must be 1.
        It must never be 0 (actually we have DBUG_ASSERT(number > 0) in 5.x
        in grant_check() function).
      74465080
  14. 02 Aug, 2006 8 commits
  15. 01 Aug, 2006 7 commits