1. 19 Mar, 2009 1 commit
  2. 18 Mar, 2009 1 commit
    • Alexey Kopytov's avatar
      Fix for bug#41486: extra character appears in BLOB for every · a3e5737a
      Alexey Kopytov authored
                         ~40Mb after mysqldump/import 
              
      When the input string exceeds the maximum allowed size for the 
      internal buffer, batch_readline() returns a truncated string. 
      Since there was no way for a caller to determine whether the 
      string was truncated or not, the command line client assumed 
      batch_readline() to always return the whole input string and 
      appended a newline character. This resulted in garbled data 
      when importing dumps containing strings longer than the 
      maximum input buffer size. 
        
      Fixed by adding a flag to the batch_readline() interface to 
      signal a truncated string to the caller. 
        
      Other minor problems fixed during patch implementation: 
       
      - The maximum allowed buffer size for batch_readline() was set 
      up depending on the client's max_allowed_packet value. It does 
      not actully make any sense, as those variables are not 
      related. The input buffer size limit is now always set to 1 
      MB. 
        
      - fill_buffer() did not always set the EOF flag. 
       
      - The input buffer could actually grow twice as the specified 
      limit due to insufficient checks in intern_read_line(). 
      a3e5737a
  3. 25 Feb, 2009 2 commits
  4. 24 Feb, 2009 1 commit
    • Georgi Kodinov's avatar
      Bug #31060: MySQL CLI parser bug 2 · 13ec76b0
      Georgi Kodinov authored
            
      There was a problem when a DELIMITER COMMAND is not the first 
      command on the line. I this case an extra line feed was added
      to the glob buffer and this was causing subsequent attempts 
      to enter this delimiter to fail.
      Fixed by not adding a new line to the glob buffer if the 
      command being added is a DELIMITER
      13ec76b0
  5. 25 Feb, 2009 2 commits
  6. 24 Feb, 2009 9 commits
  7. 23 Feb, 2009 4 commits
  8. 20 Feb, 2009 4 commits
  9. 19 Feb, 2009 9 commits
    • Patrick Crews's avatar
      Bug#38831: 11 test cases fail on Windows due to missing commands · ac46e344
      Patrick Crews authored
      Re-enabling mysqlbinlog.test on Windows - removed the use of grep/sed
      ac46e344
    • Patrick Crews's avatar
      Bug#38831: 11 test cases fail on Windows due to missing commands · cc628c61
      Patrick Crews authored
      Replaced Unix calls with mysql-test-run's built-in functions / SQL manipulation where possible.
      Replaced error codes with error names as well.
      Disabled two tests on Windows due to more complex Unix command usage
      See Bug#41307, Bug#41308
      cc628c61
    • Tatiana A. Nurnberg's avatar
      Bug#33550: mysqldump 4.0 compatibility broken · f218f9f2
      Tatiana A. Nurnberg authored
      mysqldump included character_set_client magic
      that is unknown before 4.1 even when asked for
      an appropriate compatibility mode.
      
      In compatibility (3.23, 4.0) mode, we do not
      output charset statements (not even in a
      "comment conditional"), nor do we do magic on
      the server, even if the server is sufficient
      new (4.1+). Table-names will be output converted
      to the charset requested by mysqldump; if such
      a conversion is not possible (Ivrit -> Latin),
      mysqldump will fail.
      f218f9f2
    • Georgi Kodinov's avatar
      merged bug 42419 to 5.0-bugteam · 759edca6
      Georgi Kodinov authored
      759edca6
    • Georgi Kodinov's avatar
      Bug #42419: Server crash with "Pure virtual method called" on two concurrent · b2c161c1
      Georgi Kodinov authored
      connections
      The problem is that tables can enter open table cache for a thread without 
      being properly cleaned up. This can happen if make_join_statistics() fails 
      to read a const table because of e.g. a deadlock. It does set a member of 
      TABLE structure to a value it allocates, but doesn't clean-up this setting 
      on error nor does it set the rest of the members in JOIN to allow for 
      automatic cleanup.
      As a result when such an error occurs and the next statement depends re-uses 
      the table from the open tables cache it will get it with this 
      TABLE::reginfo.join_tab pointing to a memory area that's freed.
      Fixed by making sure make_join_statistics() cleans up TABLE::reginfo.join_tab 
      on error.
      b2c161c1
    • Sergey Glukhov's avatar
      Bug#37601 Cast Is Not Done On Row Comparison · 6a9de01a
      Sergey Glukhov authored
      In case of ROW item each compared pair does not
      check if argumet collations can be aggregated and
      thus appropiriate item conversion does not happen.
      The fix is to add the check and convertion for ROW
      pairs.
      6a9de01a
    • Alexey Kopytov's avatar
      Automerge. · ae9ea041
      Alexey Kopytov authored
      ae9ea041
    • Alexey Kopytov's avatar
      Fix for bug #41078: With CURSOR_TYPE_READ_ONLY mysql_stmt_fetch() · c4f0c2d3
      Alexey Kopytov authored
      returns short string value. 
       
      Multibyte character sets were not taken into account when 
      calculating max_length in Item_param::convert_str_value(). As a 
      result, string parameters of a prepared statement could be 
      truncated later when calculating string length in characters by 
      dividing length in bytes by the charset's mbmaxlen value (e.g. in 
      Field_varstring::store()). 
       
      Fixed by taking charset's mbmaxlen into account when calculating 
      max_length in Item_param::convert_str_value().
      c4f0c2d3
    • Tatiana A. Nurnberg's avatar
      Bug#37400: mysql: Bad help message for charset command · 11ff14d5
      Tatiana A. Nurnberg authored
      Typo existed in help-text for command "charset" in mysql
      client, making the parameter-name different for long and
      short forms of the command for no good reason.
      
      Fixed.
      11ff14d5
  10. 18 Feb, 2009 2 commits
  11. 17 Feb, 2009 1 commit
  12. 16 Feb, 2009 2 commits
  13. 15 Feb, 2009 1 commit
  14. 14 Feb, 2009 1 commit