1. 01 Apr, 2010 40 commits
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot, fixes BUG#51356. · aacb4858
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6790 | jyang | 2010-03-10 13:09:41 +0200 (Wed, 10 Mar 2010) | 7 lines
      branches/zip: Fix bug #51356: "many valgrind errors in error messages
      with concurrent ddl". Null terminate the name string returned
      from innobase_convert_identifier() call when reporting DB_DUPLICATE_KEY
      error in create_table_def().
      rb://266 approved by Marko
      aacb4858
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot, fixes BUG#51378. · 178dccaa
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6789 | jyang | 2010-03-10 11:18:18 +0200 (Wed, 10 Mar 2010) | 10 lines
      branches/zip: If a unique index is on a column prefix, such
      unique index cannot be upgrade to primary index even if there
      is no primary index already defined. Also fix possible corruption
      when initialize "ref_length" value in case there is a mismatch
      between MySQL and InnoDB primary key. Fix bug #51378: "Init
      'ref_length'  to correct value, in case an out of bound MySQL
      primary_key".
      rb://262 approved by Marko.
      178dccaa
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 434cf189
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6787 | marko | 2010-03-10 10:35:06 +0200 (Wed, 10 Mar 2010) | 10 lines
      branches/zip: recv_parse_log_rec(): Remove a bogus assertion about page_no.
      TODO: We might also consider removing recv_max_parsed_page_no, because
      it does not make much sense with *.ibd files.
      
      recv_report_corrupt_log(), recv_scan_log_recs(): Abort when a
      corrupted log record has been found, unless innodb_force_recovery has
      been set.
      
      This fixes Issue #464.
      rb://265 approved by Heikki Tuuri
      434cf189
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · d10b72db
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6786 | vasil | 2010-03-10 09:16:50 +0200 (Wed, 10 Mar 2010) | 4 lines
      branches/zip:
      
      Fix typo in comment
      d10b72db
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · b3370e53
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6782 | marko | 2010-03-09 14:09:26 +0200 (Tue, 09 Mar 2010) | 1 line
      branches/zip: fil0fil.c: Update comments on table->flags as of r6252.
      b3370e53
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · c7280ed8
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6781 | marko | 2010-03-09 09:41:08 +0200 (Tue, 09 Mar 2010) | 4 lines
      branches/zip: Make SHOW ENGINE INNODB MUTEX display SUM(os_waits)
      for block mutexes and blocks.
      
      Designed by Michael and Marko. rb://188, Issue #358
      c7280ed8
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 654b4752
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6779 | marko | 2010-03-08 14:35:42 +0200 (Mon, 08 Mar 2010) | 6 lines
      branches/zip: Fix IMPORT TABLESPACE of compressed tables.  Previously,
      a wrong parameter was passed to buf_flush_init_for_writing().
      
      fil_reset_too_high_lsns(): Set up page_zip and use it if needed.
      
      rb://264, Issue #352
      654b4752
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 9137d3b3
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6777 | marko | 2010-03-04 13:01:25 +0200 (Thu, 04 Mar 2010) | 2 lines
      branches/zip: trx_undo_update_rec_get_update(): Silence a bogus GCC warning
      about a possibly uninitialized variable.
      9137d3b3
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · bbc9a7fe
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6773 | marko | 2010-03-03 15:31:54 +0200 (Wed, 03 Mar 2010) | 2 lines
      branches/zip: row_raw_format(): Silence a GCC 4.4.2 warning
      of possibly uninitialized variable format_in_hex.
      bbc9a7fe
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · d1abc1aa
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6771 | marko | 2010-03-03 14:52:43 +0200 (Wed, 03 Mar 2010) | 1 line
      Document r6770.
      d1abc1aa
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · bb8467ec
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6770 | marko | 2010-03-03 12:52:55 +0200 (Wed, 03 Mar 2010) | 12 lines
      branches/zip: Disallow duplicate index name when creating an index.
      This should fix Mantis Issue #461.
      
      innodb.test, innodb.result, innodb-index.test, innodb-index.result:
      Adjust the test result and mention that the introduced restriction
      has been reported as MySQL Bug #51451.
      
      innobase_check_index_keys(): Add a parameter for the InnoDB table and
      check that no duplicate index name is added.  Report errors by
      my_error() instead of sql_print_error().
      
      rb://260 approved by Sunny Bains
      bb8467ec
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · b8871cd5
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6768 | vasil | 2010-03-02 18:20:48 +0200 (Tue, 02 Mar 2010) | 5 lines
      branches/zip:
      
      Add a NOTE to the comment of btr_node_ptr_get_child_page_no()
      to prevent mysterious bugs.
      b8871cd5
    • Sergey Vojtovich's avatar
      Applying InnoDB snashot, fixes BUG#51587. · b866cdae
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6767 | calvin | 2010-03-01 18:16:10 +0200 (Mon, 01 Mar 2010) | 3 lines
      branches/zip: fix bug#51587
      Non-functional change.
      b866cdae
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 3fb46ab4
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6754 | marko | 2010-02-24 10:56:43 +0200 (Wed, 24 Feb 2010) | 17 lines
      branches/zip: Allocate the merge sort buffers from a heap, not stack.
      
      The merge sort can use up to 48KiB of buffers when merging blocks.
      That can cause a stack overflow, especially on 64-bit systems when not
      building with inlined functions.  This was reported as Issue #462.
      
      row_merge_dup_report(): Allocate buf and offsets from a heap.
      
      row_merge_heap_create(): Allocate space for buf[3] too. Fix bogus
      sizeof arithmetics that happened to work, because
      sizeof(ulint)==sizeof(void*).
      
      row_merge_blocks(), row_merge_blocks_copy(): Allocate buf[3] from heap.
      
      row_merge_insert_index_tuples(): Allocate buf from graph_heap.
      
      rb://258 approved and tested by Sunny Bains
      3fb46ab4
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 9a2b8e9e
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6750 | marko | 2010-02-22 08:57:23 +0200 (Mon, 22 Feb 2010) | 2 lines
      branches/zip: row_fetch_store_uint4(): Remove unused function.
      This was added to trunk in r435.
      9a2b8e9e
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 22f0da5d
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6749 | vasil | 2010-02-20 18:45:41 +0200 (Sat, 20 Feb 2010) | 5 lines
      Non-functional change: update copyright year to 2010 of the files
      that have been modified after 2010-01-01 according to svn.
      
      for f in $(svn log -v -r{2010-01-01}:HEAD |grep "^   M " |cut -b 16- |sort -u) ; do sed -i "" -E 's/(Copyright \(c\) [0-9]{4},) [0-9]{4}, (.*Innobase Oy.+All Rights Reserved)/\1 2010, \2/' $f ; done
      22f0da5d
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · b9a88d94
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6740 | sunny | 2010-02-18 13:44:31 +0200 (Thu, 18 Feb 2010) | 6 lines
      branches/zip: Don't print the entire lock bit set if the block was not
      found in the buffer pool. Only print the bits that are set and that
      information is in the lock and not in the block.
      
      See rb://256 approved by Marko.
      b9a88d94
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 3b6cb06f
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6728 | marko | 2010-02-17 18:54:04 +0200 (Wed, 17 Feb 2010) | 3 lines
      branches/zip: Remove UNIV_BASIC_LOG_DEBUG.
      This fixes the FILE_FLUSH_LSN printouts mentioned in Issue #341.
      Suggested by Heikki.
      3b6cb06f
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 49a27847
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6727 | marko | 2010-02-17 18:50:20 +0200 (Wed, 17 Feb 2010) | 2 lines
      branches/zip: fsp_init_file_page_low(): Declare the page uninitialized
      for Valgrind.
      49a27847
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 622c8c8b
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6726 | marko | 2010-02-17 18:49:21 +0200 (Wed, 17 Feb 2010) | 3 lines
      branches/zip: FIL_PAGE_FILE_FLUSH_LSN: Note that the field is only valid
      for the first page of each ibdata* file, not *.ibd files.
      Suggested by Heikki, in connection with the LSN warning noted in Issue #341.
      622c8c8b
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot, fixes BUG#50691. · 0ee8a7d6
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6724 | marko | 2010-02-17 15:52:05 +0200 (Wed, 17 Feb 2010) | 11 lines
      branches/zip: Merge revisions 6613:6669 from branches/5.1:
        ------------------------------------------------------------------------
        r6669 | jyang | 2010-02-11 12:24:19 +0200 (Thu, 11 Feb 2010) | 7 lines
      
        branches/5.1: Fix bug #50691, AIX implementation of readdir_r
        causes InnoDB errors. readdir_r() returns an non-NULL value
        in the case of reaching the end of a directory. It should
        not be treated as an error return.
      
        rb://238 approved by Marko
        ------------------------------------------------------------------------
      0ee8a7d6
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 2d889eda
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6723 | marko | 2010-02-17 11:48:34 +0200 (Wed, 17 Feb 2010) | 3 lines
      branches/zip: lock_table_other_has_incompatible():
      Return an incompatible lock or NULL instead of TRUE or FALSE.
      Approved by Sunny over IM.
      2d889eda
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · e3239bcf
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6718 | marko | 2010-02-16 15:06:16 +0200 (Tue, 16 Feb 2010) | 1 line
      branches/zip: Fix a comment.
      e3239bcf
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 34799eb5
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6717 | marko | 2010-02-16 14:53:20 +0200 (Tue, 16 Feb 2010) | 2 lines
      branches/zip: log_reserve_and_write_fast(): Correct a race condition
      in UNIV_LOG_LSN_DEBUG.  This could have caused Issue #440.
      34799eb5
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 378f7121
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6715 | sunny | 2010-02-16 10:14:21 +0200 (Tue, 16 Feb 2010) | 1 line
      branches/zip: Fix comment. Non functional change.
      378f7121
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · d0422e5a
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6714 | sunny | 2010-02-16 10:12:25 +0200 (Tue, 16 Feb 2010) | 2 lines
      branches/zip: Update the comments and fix the whitespace issues.
      See rb://255 Approved by: Marko
      d0422e5a
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 1a4de376
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6713 | sunny | 2010-02-16 10:12:17 +0200 (Tue, 16 Feb 2010) | 7 lines
      branches/zip: Change the bit fields back to ulint. Bit fields were causing
      problems with concurrency on SMP systems because of word packing issues.
      The number of trx_t's in a system is not sufficient enough to require that
      we try and save a few bytes in the data structure.
      
      See rb://255 for details.
      1a4de376
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 0c2e8ba3
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6712 | marko | 2010-02-16 10:05:36 +0200 (Tue, 16 Feb 2010) | 2 lines
      branches/zip: trx_lists_init_at_db_start(): Assert that the kernel_mutex
      is held by the caller.
      0c2e8ba3
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 9c27e360
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6707 | inaam | 2010-02-12 19:22:35 +0200 (Fri, 12 Feb 2010) | 4 lines
      branches/zip
      
      ChangeLog entry for r6674.
      9c27e360
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 965b7219
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6675 | marko | 2010-02-11 22:41:11 +0200 (Thu, 11 Feb 2010) | 1 line
      branches/zip: Remove bogus debug assertions introduced in r6660.
      965b7219
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot, fixes BUG#49535. · 67925345
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6674 | inaam | 2010-02-11 17:54:44 +0200 (Thu, 11 Feb 2010) | 16 lines
      branches/zip bug# 49535
      
      This is a backport of r4924.
      mem_heap_get_size() scans all allocated blocks to calculate the total
      size of the heap. This patch introduces a new, total_size, field in
      mem_block_info_struct. This field is valid only for base block 
      (i.e.: the first block allocated for the heap) and is set to
      ULINT_UNDEFINED in other blocks.
      This considerably improves the performance of redo scan during recovery.
      
      rb://108 issue#216
      
      Approved by: Heikki
      67925345
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 50370889
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6673 | marko | 2010-02-11 13:09:48 +0200 (Thu, 11 Feb 2010) | 9 lines
      branches/zip: Relax a debug assertion about a missing BLOB. (Issue #452)
      When rolling back an incomplete transaction in purge, tolerate missing
      BLOBs also in update undo, when undoing an INSERT by updating a delete-marked
      record, and the delete-marked record is no longer needed.
      Previously, we only tolerated missing BLOBs in insert undo.
      This merely fixes a debug assertion; the code performed correctly
      without UNIV_DEBUG.
      
      rb://249 approved by Sunny Bains.
      50370889
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · bc18342a
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6672 | marko | 2010-02-11 13:01:18 +0200 (Thu, 11 Feb 2010) | 1 line
      branches/zip: Introduce thr_is_recv().
      bc18342a
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 9da177c6
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6660 | marko | 2010-02-11 11:21:11 +0200 (Thu, 11 Feb 2010) | 7 lines
      branches/zip: Clarify the rollback of INSERT by UPDATE of delete-marked rec.
      
      row_undo_mod_remove_clust_low(): Augment the function comment.
      
      row_undo_mod_remove_clust_low(), row_undo_mod_del_mark_or_remove_sec_low(),
      row_undo_mod_del_mark_or_remove_sec(), row_undo_mod_upd_del_sec():
      Add ut_ad(node->rec_type == TRX_UNDO_UPD_DEL_REC);
      9da177c6
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · a2c5231e
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6639 | marko | 2010-02-10 13:11:04 +0200 (Wed, 10 Feb 2010) | 1 line
      branches/zip: trx_rseg_create(): Unused function, remove.
      a2c5231e
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 709e5a98
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6635 | marko | 2010-02-10 11:07:05 +0200 (Wed, 10 Feb 2010) | 4 lines
      branches/zip: Clean up after r6559.  Now that
      btr_pcur_open_with_no_init() is a macro, do not mix preprocessor
      directives in the macro invocation, because it is implementation-defined
      whether that is going to work.
      709e5a98
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · bcdd0057
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6633 | marko | 2010-02-10 10:40:55 +0200 (Wed, 10 Feb 2010) | 31 lines
      branches/zip: Merge revisions 6538:6613 from branches/5.1:
      
        ------------------------------------------------------------------------
        r6545 | jyang | 2010-02-03 03:57:32 +0200 (Wed, 03 Feb 2010) | 8 lines
        Changed paths:
           M /branches/5.1/lock/lock0lock.c
      
        branches/5.1: Fix bug #49001, "SHOW INNODB STATUS deadlock info
        incorrect when deadlock detection aborts". Print the correct
        lock owner when recursive function lock_deadlock_recursive()
        exceeds its maximum depth LOCK_MAX_DEPTH_IN_DEADLOCK_CHECK.
      
        rb://217, approved by Marko.
        ------------------------------------------------------------------------
        r6613 | inaam | 2010-02-09 20:23:09 +0200 (Tue, 09 Feb 2010) | 11 lines
        Changed paths:
           M /branches/5.1/buf/buf0buf.c
           M /branches/5.1/buf/buf0rea.c
           M /branches/5.1/include/buf0rea.h
      
        branches/5.1: Fix Bug #38901
        InnoDB logs error repeatedly when trying to load page into buffer pool
      
        In buf_page_get_gen() if we are unable to read a page (because of
        corruption or some other reason) we keep on retrying. This fills up
        error log with millions of entries in no time and we'd eventually run
        out of disk space. This patch limits the number of attempts that we
        make (currently set to 100) and after that we abort with a message.
      
        rb://241 Approved by: Heikki
        ------------------------------------------------------------------------
      bcdd0057
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · e2bf3f2c
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6631 | marko | 2010-02-10 09:19:52 +0200 (Wed, 10 Feb 2010) | 1 line
      branches/zip: Document r6614 in ChangeLog.
      e2bf3f2c
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 6833b977
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6614 | inaam | 2010-02-09 20:26:23 +0200 (Tue, 09 Feb 2010) | 7 lines
      branches/plugin rb://242
      
      Let the master thread sleep if the amount of work to be done is
      calibrated as taking less than a second.
      
      Approved by: Heikki
      6833b977
    • Sergey Vojtovich's avatar
      Applying InnoDB snapshot · 41c82f88
      Sergey Vojtovich authored
      Detailed revision comments:
      
      r6612 | marko | 2010-02-09 14:32:39 +0200 (Tue, 09 Feb 2010) | 3 lines
      branches/zip: recv_recovery_rollback_active():
      Drop the temporary tables and indexes after enabling sync order checks.
      This should not make any difference. This could have been done in r6611.
      41c82f88