1. 31 Jan, 2007 2 commits
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/bk/mysql-4.1-engines · ab3abe12
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/WL3567/mysql-4.1-engines
      
      
      ab3abe12
    • unknown's avatar
      WL#3567 - MERGE engine: a check for underlying table conformance · f7b3c7c5
      unknown authored
      When a merge table is opened compare column and key definition of
      underlying tables against column and key definition of merge table.
      
      If any of underlying tables have different column/key definition
      refuse to open merge table.
      
      
      mysql-test/r/merge.result:
        A test case for WL#3456.
      mysql-test/t/merge.test:
        A test case for WL#3456.
      sql/ha_myisam.cc:
        Moved a part of code that converts TABLE object to MyISAM key and column
        definition to a separate function.
        
        Added check_definition() function that compares MyISAM table definitions.
      sql/ha_myisammrg.cc:
        Check if underlying table definition conforms to merge table definition,
        and in case underlying table definition differs, refuse to open merge
        table.
      f7b3c7c5
  2. 24 Jan, 2007 3 commits
  3. 23 Jan, 2007 1 commit
  4. 22 Jan, 2007 1 commit
    • unknown's avatar
      BUG#24401 - MySQL server crashes if you try to retrieve data from · fde52a2f
      unknown authored
                  corrupted table
      
      Accessing a table with corrupted column definition results in server
      crash.
      
      This is fixed by refusing to open such tables. Affects MyISAM only.
      No test case, since it requires crashed table.
      
      
      myisam/mi_open.c:
        Refuse to open MyISAM table with summary columns length bigger than
        length of the record.
      fde52a2f
  5. 17 Jan, 2007 4 commits
  6. 16 Jan, 2007 1 commit
    • unknown's avatar
      BUG#24855 - Crash mysqld 4.1.21 with corrupted tables · 61a28619
      unknown authored
      Accessing fixed record format table with crashed key definition results
      in server/myisamchk segmentation fault.
      
      This is fixed by refusing to open such tables. Affects MyISAM only.
      No test case, since it requires crashed table.
      
      
      myisam/mi_open.c:
        Refuse to open fixed record format table with key segment that includes
        BLOB part (which is true only for tables with crashed key definition).
      61a28619
  7. 05 Jan, 2007 1 commit
    • unknown's avatar
      Bug#24607 - MyISAM pointer size determined incorrectly · 422d6b35
      unknown authored
      The function mi_get_pointer_length() computed too small
      pointer size for very large tables.
      
      Inserted missing 'else' between the branches for very
      large tables.
      
      
      myisam/mi_create.c:
        Bug#24607 - MyISAM pointer size determined incorrectly
        Inserted missing 'else' between the branches for very
        large tables.
        Harmonized literals "(longlong) 1" and "1L" to "ULL(1)"
        where they are used for "ulonglong file_length".
      mysql-test/r/myisam.result:
        Bug#24607 - MyISAM pointer size determined incorrectly
        Added the test result.
      mysql-test/t/myisam.test:
        Bug#24607 - MyISAM pointer size determined incorrectly
        Added the test.
      422d6b35
  8. 29 Dec, 2006 2 commits
  9. 27 Dec, 2006 2 commits
  10. 20 Dec, 2006 4 commits
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/bk/mysql-4.1-engines · 9d094c56
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG21310/mysql-4.1-engines
      
      
      sql/sql_update.cc:
        Auto merged
      9d094c56
    • unknown's avatar
      BUG#21310 - Trees in SQL causing a "crashed" table with MyISAM storage engine · 9d85b0a6
      unknown authored
      An update that used a join of a table to itself and modified the
      table on one side of the join reported the table as crashed or
      updated wrong rows.
      
      Fixed by creating temporary table for self-joined multi update statement.
      
      
      mysql-test/r/myisam.result:
        A test case for BUG#21310.
      mysql-test/t/myisam.test:
        A test case for BUG#21310.
      sql/lock.cc:
        Exclude 'table' param from check.
      sql/sql_update.cc:
        Disabling record cache for self-joined multi update statement is wrong.
        The join must only see the table as it was at the beginning of the statement.
        safe_update_on_fly check if it is safe to update first table on the fly, that is
        not creating temporary table. It is possible in case a row from this table is
        never read more than once. safe_update_on_fly now detect self-joined table and
        refuse to update this table on the fly.
      9d85b0a6
    • unknown's avatar
      Bug#25213 - Compiler warnings in MyISAM code · fc9642b4
      unknown authored
      Compiler warnings due to non-matching conversion
      specifications in format strings in DBUG_PRINT calls,
      due to non-used parameters (in non-debug mode), and
      due to seemingly uninitialized variables.
      
      Initialized variables, declared parameters unused, and
      casted DBUG_PRINT arguments to get rid of warnings.
      
      
      myisam/mi_range.c:
        Bug#25213 - Compiler warnings in MyISAM code
        Initialized a variable to get rid of a compiler warning.
      myisam/mi_test1.c:
        Bug#25213 - Compiler warnings in MyISAM code
        Declared an parameter unused to get rid of warnings.
      myisam/mi_write.c:
        Bug#25213 - Compiler warnings in MyISAM code
        Initialized a variable to get rid of a compiler warning.
        Casted arguments to DBUG_PRINT to match them with their
        format string conversion specification.
      myisam/rt_split.c:
        Bug#25213 - Compiler warnings in MyISAM code
        Initialized variables to get rid of compiler warnings.
      fc9642b4
    • unknown's avatar
      Bug#25208 - Warnings in mi_packrec.c · 40b23b3b
      unknown authored
      Compiler warnings due to non-matching conversion
      specifications in format strings in DBUG_PRINT calls.
      
      Fixed DBUG_PRINT format specifiactions.
      
      
      myisam/mi_packrec.c:
        Bug#25208 - Warnings in mi_packrec.c
        Fixed DBUG_PRINT format specifiactions.
      40b23b3b
  11. 19 Dec, 2006 1 commit
  12. 15 Dec, 2006 1 commit
    • unknown's avatar
      BUG#24358 - Table access crashes server · e071fdb6
      unknown authored
      Having broken .frm, particulary number of field names does
      not match number of fields, causes server crash.
      
      Refuse to open a table if number of field names in a table
      is not equal to number of fields in a table.
      
      No test case, since it requires broken .frm file.
      
      
      sql/table.cc:
        Refuse to open a table if number of field names in a table
        is not equal to number of fields in a table.
      e071fdb6
  13. 14 Dec, 2006 3 commits
  14. 13 Dec, 2006 1 commit
  15. 11 Dec, 2006 2 commits
  16. 08 Dec, 2006 1 commit
  17. 07 Dec, 2006 3 commits
    • unknown's avatar
      do not autorelease build ids when a child of mysql-test-run.pl dies · 60b3a86a
      unknown authored
      
      mysql-test/lib/mtr_unique.pl:
        do not autorelease build ids when a child dies
      60b3a86a
    • unknown's avatar
      BUG#23404 - ROW_FORMAT=FIXED option is lost is an index is added to the · 1cb8e4e9
      unknown authored
                  table
      
      ROW_FORMAT option is lost during CREATE/DROP INDEX.
      
      This fix forces CREATE/DROP INDEX to retain ROW_FORMAT by instructing
      mysql_alter_table() that ROW_FORMAT is not used during creating/dropping
      indexes.
      
      
      mysql-test/r/alter_table.result:
        A test case for bug#23404.
      mysql-test/t/alter_table.test:
        A test case for bug#23404.
      sql/sql_parse.cc:
        CREATE/DROP INDEX must not change ROW_FORMAT. Setting create_info.row_type
        to ROW_TYPE_NOT_USED informs mysql_alter_table that ROW_FORMAT was not
        used during alteration, and thus must be retained.
      1cb8e4e9
    • unknown's avatar
      BUG#24780 use --sysconfdir in scripts · c29d22c9
      unknown authored
      
      scripts/Makefile.am:
        pass --sysconfdir to scripts
      scripts/mysqlaccess.sh:
        use --sysconfdir instead of hardcoded /etc
      scripts/mysqld_multi.sh:
        use --sysconfdir instead of hardcoded /etc
      c29d22c9
  18. 06 Dec, 2006 2 commits
    • unknown's avatar
      bug #22372 · 63fce3a2
      unknown authored
      datafile added to be used in gis.test
      
      
      mysql-test/std_data/bad_gis_data.dat:
        New BitKeeper file ``mysql-test/std_data/bad_gis_data.dat''
      63fce3a2
    • unknown's avatar
      bug #22372 (LOAD DATA crashes the table with the geometry field) · fa115a0f
      unknown authored
      The problem is that the GEOMETRY NOT NULL can't automatically set
      any value as a default one. We always tried to complete LOAD DATA
      command even if there's not enough data in file. That doesn't work
      for GEOMETRY NOT NULL. Now Field_*::reset() returns an error sign
      and it's checked in mysql_load()
      
      
      mysql-test/r/gis.result:
        test result
      mysql-test/t/gis.test:
        testcase
      sql/field.cc:
        reset() now returns error sign
      sql/field.h:
        Field_*::reset() now returns error sign if the field can't be reset
      sql/sql_load.cc:
        check if field can't be reset and return error if it's so
      fa115a0f
  19. 05 Dec, 2006 5 commits