- 26 Feb, 2006 3 commits
-
-
unknown authored
into mysql.com:/home/dlenev/src/mysql-5.0-bg13525 sql/sql_table.cc: Auto merged
-
unknown authored
after merging fix for it with main tree.
-
unknown authored
into mysql.com:/home/dlenev/src/mysql-5.0-bg13525 sql/sql_table.cc: Auto merged sql/sql_trigger.cc: Auto merged sql/sql_trigger.h: Auto merged sql/sql_yacc.yy: Auto merged mysql-test/r/trigger.result: SCCS merged mysql-test/t/trigger.test: SCCS merged
-
- 24 Feb, 2006 1 commit
-
-
unknown authored
Let us transfer triggers associated with table when we rename it (but only if we are not changing database to which table belongs, in the latter case we will emit error). mysql-test/r/trigger.result: Added test for bug #13525 "Rename table does not keep info of triggers". mysql-test/t/trigger.test: Added test for bug #13525 "Rename table does not keep info of triggers". sql/sql_rename.cc: rename_tables(): Now after renaming table's .FRM file and updating handler data we call Table_triggers_list::change_table_name() which is reponsible for updating .TRG and .TRN files. sql/sql_table.cc: mysql_alter_table(): Now in case when ALTER should rename table we call Table_triggers_list::change_table_name() which is responsible for updating .TRG and .TRN files after renaming table. sql/sql_trigger.cc: Added Table_triggers_list::change_table_name() method and change_table_name_in_triggers()/trignames() methods responsible for updating .TRG and .TRN files for table during its renaming. Two small cleanups - removed versioning for .TRG files (since it was not working before anyway) and emphasized that type of lock specified in tables list is unimportant for DROP TABLE (since this statement uses name-locking). sql/sql_trigger.h: Table_triggers_list: Added on_table_names_list member to store pointers and lenghts of "ON table_name" parts in triggers' definitions to be able easily change them during RENAME TABLE. Added change_table_name() method and change_table_name_in_trignames/triggers() helper methods responsible for updating .TRG and .TRN files. sql/sql_yacc.yy: trigger_tail: To be able properly update triggers' definitions with new table names when renaming tables we need to know where in CREATE TRIGGER statement "ON db_name.table_name" part resides. Small cleanup - let us emphasize that for CREATE TRIGGER statement lock type which is specified in table list is unimportant since name-locking is used.
-
- 23 Feb, 2006 14 commits
-
-
unknown authored
-
unknown authored
into mysql.com:/opt/local/work/mysql-5.0-runtime
-
unknown authored
into mysql.com:/opt/local/work/mysql-5.0-runtime mysql-test/t/heap.test: Auto merged mysql-test/r/heap.result: Manual merge (use local) mysql-test/r/ps.result: Manual merge (use local) mysql-test/t/ps.test: Manual merge. sql/field.cc: Manual merge. sql/field.h: Manual merge. sql/sql_parse.cc: Manual merge. sql/sql_table.cc: Manual merge.
-
unknown authored
fixed in 5.0). A post-review fix (Bug#13134) mysql-test/r/heap.result: Remove 'delayed' to make the test deterministic. mysql-test/r/ps.result: Remove an unneeded drop table (test case for Bug#13134) mysql-test/t/heap.test: Remove 'delayed' to make the test deterministic. mysql-test/t/ps.test: A post-review fix (Bug#13134)
-
unknown authored
Rearrange out of order options in option struct. client/mysqltest.c: Rearrange out of order options in option struct.
-
unknown authored
into snake-hub.snake.net:/src/extern/MySQL/bk/mysql-5.0
-
unknown authored
Fix out of order entries in option struct. sql/mysqld.cc: Fix out of order entries in option struct.
-
unknown authored
client/mysqldump.c: snprintf => my_snprintf
-
unknown authored
sql/sql_base.cc: Cleanup, remove a warning. sql/sql_select.h: Cleanup: remove a warning.
-
unknown authored
client/mysqldump.c: Declare variable in start of function
-
unknown authored
into neptunus.(none):/home/msvensson/mysql/mysql-5.0 mysql-test/r/sp.result: Auto merged mysql-test/t/sp.test: Auto merged
-
unknown authored
client/mysqltest.c: Fix after merge, do_eval has three args Remove extre return in do_block
-
unknown authored
into neptunus.(none):/home/msvensson/mysql/mysql-5.0 client/mysqltest.c: Auto merged mysql-test/r/mysqltest.result: Auto merged mysql-test/t/mysqldump.test: Auto merged mysql-test/t/mysqltest.test: Merge
-
unknown authored
Add new parameter to do_eval so that only unescaped variables in input string is expanded and rest of string is left untouched. client/mysqltest.c: Add new parameter to 'do_eval' that will add any escape chars found in the input string to the output string. This is used in 'do_system' and in 'do_exec' where only unescaped variables will be expanded, rest of the string will be left untouched. mysql-test/r/mysqltest.result: Update test result mysql-test/t/mysqldump.test: Revert previous patch that added extra \\ in "exec" command mysql-test/t/mysqltest.test: Revert previous patch that added extra \\ in exec command
-
- 22 Feb, 2006 4 commits
-
-
unknown authored
into mysql.com:/usr_rh9/home/elkin.rh9/MySQL/FIXES/5.0-bug17265
-
unknown authored
To quote Timour review lines: The actual cause of the bug is that sql_base.cc:setup_wild() sets "select_lex->with_wild = 0" (in the end of the function) once it expands all wild-cards, and wild-card expansion is done during the prepare phase. During this phase we replace all "*" with the corresponding items, which for views happen to be references to references. When we do execute, select_lex->with_wild = 0, and all "*" are already replaced by the corresponding items, which in the case of views need to be dereferenced first. Fixed by refining the assert. Regression test for the bug is rpl_row_view01, as was reported. sql/item.cc: Refined asssert, suggested by Evgen, due to BUG#17265 prepared statement for select with ps-protocol does not hold the former.
-
unknown authored
The problem was that error flag was not reset. mysql-test/r/sp-security.result: Results for test case for BUG#7787. mysql-test/t/sp-security.test: A test case for BUG#7787. sql/sp.cc: Reset errors after sp_find_routine().
-
unknown authored
into neptunus.(none):/home/msvensson/mysql/mysql-5.0
-
- 21 Feb, 2006 16 commits
-
-
unknown authored
into mysql.com:/opt/local/work/mysql-5.0-runtime sql/sql_yacc.yy: Auto merged sql/share/errmsg.txt: SCCS merged
-
unknown authored
column is increasing when table is recreated with PS/SP": make use of create_field::char_length more consistent in the code. Reinit create_field::length from create_field::char_length for every execution of a prepared statement (actually fixes the bug). mysql-test/r/ps.result: Test results fixed (Bug#13134) mysql-test/t/ps.test: A test case for Bug#13134 "Length of VARCHAR() utf8 column is increasing when table is recreated with PS/SP" sql/field.cc: Move initialization of create_field::char_length to the constructor of create_field. sql/field.h: Rename chars_length to char_length (to be consistent with how this term is used throughout the rest of the code). sql/sql_parse.cc: Initialize char_length in add_field_to_list. This function effectively works as another create_field constructor. sql/sql_table.cc: Reinit length from char_length for every field in mysql_prepare_table. This is not needed if we're executing a statement for the first time, however, at subsequent executions length contains the number of bytes, not characters (as it's expected to).
-
unknown authored
into neptunus.(none):/home/msvensson/mysql/mysql-5.0 sql/sp_head.cc: Auto merged mysql-test/r/mysqldump.result: Merge mysql-test/t/mysqldump.test: Merge
-
unknown authored
into neptunus.(none):/home/msvensson/mysql/mysql-5.0 client/mysqldump.c: Auto merged mysql-test/r/mysqldump.result: Auto merged mysql-test/t/mysqldump.test: Auto merged
-
unknown authored
into mysql.com:/home/cps/mysql/devel/im/5.0-im-fix-race server-tools/instance-manager/instance_map.cc: Auto merged
-
unknown authored
duration of the whole 'flush instances'. As a consequence, it was possible to query instance map, while it is in the inconsistent state. The patch was reworked after review. server-tools/instance-manager/guardian.cc: do not lock instance map in Guardian_thread::init() server-tools/instance-manager/instance_map.cc: Eliminate race condition: lock instance map and guardian for the duration of the whole "FLUSH INSTANCES" execution. server-tools/instance-manager/instance_map.h: add new method. cleanup interface. add comments. server-tools/instance-manager/manager.cc: use instance_map.flush_instances instead of instance_map.load() and guardian_thread.init()
-
unknown authored
Bug#14857 Reading dump files with single statement stored routines fails.Bug #14857 Reading dump files with single statement stored routines fails. - Add tests, fixed by patch for 16878 mysql-test/r/mysqldump.result: Update test results mysql-test/t/mysqldump.test: Add tests for bug 14857
-
unknown authored
into mysql.com:/home/cps/mysql/devel/im/5.0-im-add-error-message
-
unknown authored
connections correctly". Recommit with the max timeout value in sync with the comment. server-tools/instance-manager/options.cc: add new option to set wait timeout server-tools/instance-manager/priv.h: add a const for max wait timeout
-
unknown authored
- Add comments with embeded veriosn info around the parts of the view syntax that are only supported by a certain version of MySQL Server client/mysqldump.c: Use information_schema.views to gather information about the view, then replace some parts of the output from "SHOW CREATE VIEW" with comment markers with version, to make thos parts of the view syntax become parsed only of MySQL servers that supports it. Create common function "open_sql_file_for_table" to open the individual .sql file where to dump the table or view. mysql-test/r/mysqldump.result: Update results mysql-test/t/mysqldump.test: Add test to see that views can be deumped and reloaded alos when they contain "SECURITY TYPE", "CHECK OPTION" and "DEFINER"
-
unknown authored
into neptunus.(none):/home/msvensson/mysql/mysql-5.0 mysql-test/r/sp.result: Auto merged mysql-test/t/sp.test: Auto merged client/mysqltest.c: Merge mysql-test/mysql-test-run.pl: Merge, undo removal mysql-test/t/mysqldump.test: Merge mysql-test/t/mysqltest.test: Merge
-
unknown authored
into neptunus.(none):/home/msvensson/mysql/mysql-5.0 client/mysqltest.c: Auto merged
-
unknown authored
into neptunus.(none):/home/msvensson/mysql/mysql-5.0
-
unknown authored
into neptunus.(none):/home/msvensson/mysql/mysql-5.0 client/mysqltest.c: Auto merged mysql-test/r/mysqltest.result: Auto merged mysql-test/t/mysqltest.test: Auto merged
-
unknown authored
into neptunus.(none):/home/msvensson/mysql/mysql-5.0 libmysql/libmysql.c: Auto merged
-
unknown authored
into neptunus.(none):/home/msvensson/mysql/mysql-5.0
-
- 20 Feb, 2006 2 commits