1. 25 Jul, 2007 1 commit
    • unknown's avatar
      Bug#25679 · b42247bc
      unknown authored
        "Federated Denial of Service"
        Federated storage engine used to attempt to open connections within
        the ::create() and ::open() methods which are invoked while LOCK_open
        mutex is being held by mysqld. As a result, no other client sessions
        can open tables while Federated is attempting to open a connection.
        Long DNS lookup times would stall mysqld's operation and a rogue
        connection string which connects to a remote server which simply
        stalls during handshake can stall mysqld for a much longer period of
        time.
        This patch moves the opening of the connection much later, when the
        federated actually issues queries, by which time the LOCK_open mutex is
        no longer being held.
      
      
      mysql-test/r/federated.result:
        change of test/results due to patch for bug25679
      mysql-test/t/federated.test:
        change of test/results due to patch for bug25679
      sql/ha_federated.cc:
        bug25679
          remove function check_foreign_fata_source()
          ha_federated::open() no longer opens the federated connection.
          ha_federated::create() no longer opens and tests connection.
          ha_federated::real_connect() opens connection and tests presence of table.
          ha_federated::real_query() sends query, calling real_connect() if neccessary.
      sql/ha_federated.h:
        bug25679
          new methods real_query() and real_connect()
      b42247bc
  2. 24 Jul, 2007 4 commits
    • unknown's avatar
      fix compile on Windows for bug25714.c · 5415dcc3
      unknown authored
      ---
      fix compile on Windows for bug25714.c
      
      
      tests/bug25714.c:
        fix compile on Windows
      5415dcc3
    • unknown's avatar
      build bug25714 test app on Windows · 4ab0c0cf
      unknown authored
      4ab0c0cf
    • unknown's avatar
      Merge xiphis.org:/anubis/antony/work/p2-bug25714.1 · 594d71a4
      unknown authored
      into  xiphis.org:/anubis/antony/work/p2-bug25714.1.merge-5.0
      
      
      594d71a4
    • unknown's avatar
      Bug#25714 · 0f85ae9f
      unknown authored
        "getGeneratedKeys() does not work with FEDERATED table"
        mysql_insert() expected the storage engine to update the row data
        during the write_row() operation with the value of the new auto-
        increment field. The field must be updated when only one row has
        been inserted as mysql_insert() would ignore the thd->last_insert.
        This patch implements HA_STATUS_AUTO support in ha_federated::info()
        and ensures that ha_federated::write_row() does update the row's
        auto-increment value.
        The test case was written in C as the protocol's 'id' value is
        accessible through libmysqlclient and not via SQL statements.
        mysql-test-run.pl was extended to enable running the test binary.
      
      
      mysql-test/mysql-test-run.pl:
        bug25714
          implement support to run C test for bug25714
      sql/ha_federated.cc:
        bug25714
          The storage engine instance property auto_increment_value was not
          being set.
          mysql_insert() requires that the storage engine updates the row with
          the auto-increment value, especially when only inserting one row.
          Implement support for ha_federated::info(HA_STATUS_AUTO)
      tests/Makefile.am:
        bug25714
          build C test for bug
      mysql-test/include/have_bug25714.inc:
        New BitKeeper file ``mysql-test/include/have_bug25714.inc''
      mysql-test/r/federated_bug_25714.result:
        New BitKeeper file ``mysql-test/r/federated_bug_25714.result''
      mysql-test/r/have_bug25714.require:
        New BitKeeper file ``mysql-test/r/have_bug25714.require''
      mysql-test/t/federated_bug_25714.test:
        New BitKeeper file ``mysql-test/t/federated_bug_25714.test''
      tests/bug25714.c:
        New BitKeeper file ``tests/bug25714.c''
      0f85ae9f
  3. 22 Jul, 2007 1 commit
  4. 20 Jul, 2007 7 commits
  5. 19 Jul, 2007 15 commits
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0 · db31d3c9
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      sql/set_var.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      db31d3c9
    • unknown's avatar
      Merge pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0.44 · 77a0e7f7
      unknown authored
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0.46
      
      
      configure.in:
        Auto merged
      libmysql/libmysql.c:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/field.h:
        Auto merged
      77a0e7f7
    • unknown's avatar
      BUG#20815 Errno 12 on Windows after 197 connections · d9fda1cf
      unknown authored
      
      CMakeLists.txt:
        BUG#20815 Set stack size. This value is really supposed to be the linker's default. I'm not quite sure why we have to specify it manually too.
      d9fda1cf
    • unknown's avatar
      Bug#29898: Item_date_typecast::val_int doesn't reset the null_value flag. · a131428f
      unknown authored
      The Item_date_typecast::val_int function doesn't reset null_value flag.
      This makes all values that follows the first null value to be treated as nulls
      and led to a wrong result.
      
      Now the Item_date_typecast::val_int function correctly sets the null_value flag
      for both null and non-null values.
      
      
      mysql-test/t/cast.test:
        Added a test case for the bug#29898:  Item_date_typecast::val_int doesn't reset
        the null_value flag.
      mysql-test/r/cast.result:
        Added a test case for the bug#29898:  Item_date_typecast::val_int doesn't reset
        the null_value flag.
      sql/item_timefunc.cc:
        Bug#29898: Item_date_typecast::val_int doesn't reset the null_value flag.
        Now the Item_date_typecast::val_int function correctly sets the null_value flag
        for both null and non-null values.
      a131428f
    • unknown's avatar
      Merge trift2.:/MySQL/M50/mysql-5.0 · 92de7b7b
      unknown authored
      into  trift2.:/MySQL/M50/push-5.0
      
      
      92de7b7b
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · d0020607
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/29850-bug-5.0-opt-mysql
      
      
      d0020607
    • unknown's avatar
      Bug#29850: Wrong charset of GROUP_CONCAT result when the select employs · 7f6a8164
      unknown authored
      a temporary table.
      
      The result string of the Item_func_group_concat wasn't initialized in the 
      copying constructor of the Item_func_group_concat class. This led to a
      wrong charset of GROUP_CONCAT result when the select employs a temporary
      table.
      
      The copying constructor of the Item_func_group_concat class now correctly
      initializes the charset of the result string.
      
      
      mysql-test/t/func_gconcat.test:
        Added a test case for the bug#29850: Wrong charset of the GROUP_CONCAT result
        when the select employs a temporary table.
      mysql-test/r/func_gconcat.result:
        Added a test case for the bug#29850: Wrong charset of the GROUP_CONCAT result
        when the select employs a temporary table.
      sql/item_sum.cc:
        Bug#29850: Wrong charset of GROUP_CONCAT result when the select employs
        a temporary table.
        The copying constructor of the Item_func_group_concat class now correctly
        initializes the charset of the result string.
      7f6a8164
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 248c5e24
      unknown authored
      into  mysql.com:/home/hf/work/29687/my50-29687
      
      
      248c5e24
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0-opt · 02999636
      unknown authored
      into  mysql.com:/home/hf/work/29687/my50-29687
      
      
      02999636
    • unknown's avatar
      Merge bk-internal.mysql.com:/data0/bk/mysql-4.1-maint · 8d592e95
      unknown authored
      into  bk-internal.mysql.com:/data0/bk/tsmith-tmp/mysql-5.0-maint
      
      
      8d592e95
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0 · c865b225
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      sql/ha_myisam.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      c865b225
    • unknown's avatar
      Avoid the name conflict between the system-provided "md5.h" and the MySQL one · f4209c71
      unknown authored
      by renaming "include/md5.h" to "include/my_md5.h".
      
      Fixes bug#14151.
      
      
      include/my_md5.h:
        Rename: include/md5.h -> include/my_md5.h
      f4209c71
    • unknown's avatar
      field.cc, field.h: · 9fa66ba4
      unknown authored
        i5 compatibility
      
      
      sql/field.h:
        i5 compatibility
      sql/field.cc:
        i5 compatibility
      9fa66ba4
    • unknown's avatar
      BUG#26325 - TEMPORARY TABLE "corrupt" after first read, according · 2486c23c
      unknown authored
                  to CHECK TABLE
      
      CHECK/REPAIR TABLE reports "File not found" error when issued
      against temporary table.
      
      Fixed by disabling a brunch of code (in case it gets temporary table)
      that is responsible for updating frm version as it is not needed
      for temporary tables.
      
      
      mysql-test/r/check.result:
        A test case for BUG#26325.
      mysql-test/t/check.test:
        A test case for BUG#26325.
      sql/handler.cc:
        No need to update frm version in case table was created or checked
        by server with the same version. This also ensures that we do not
        update frm version for temporary tables as this code doesn't support
        temporary tables.
      2486c23c
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt-28524 · 8b59beae
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      8b59beae
  6. 18 Jul, 2007 5 commits
    • unknown's avatar
      Fixed bug #28524. · 2bfe84d4
      unknown authored
      For each view the mysqldump utility creates a temporary table
      with the same name and the same columns as the view 
      in order to satisfy views that depend on this view.
      After the creation of all tables, mysqldump drops all
      temporary tables and creates actual views.
      However, --skip-add-drop-table and --compact flags disable
      DROP TABLE statements for those temporary tables. Thus, it was
      impossible to create the views because of existence of the
      temporary tables with the same names.
      
      
      client/mysqldump.c:
        Fixed bug #28524.
        The mysqldump utility has been modified to unconditionally drop
        temporary tables before the creation of views.
      mysql-test/t/mysqldump.test:
        Updated test case for bug #28524 and updated result of previous tests.
      mysql-test/r/mysqldump.result:
        Updated test case for bug #28524 and updated result of previous tests.
      2bfe84d4
    • unknown's avatar
      CMakeLists.txt, configure.js: · 73a680a5
      unknown authored
        Allow to set mysqld exe suffix
      
      
      sql/CMakeLists.txt:
        Allow to set mysqld exe suffix
      win/configure.js:
        Allow to set mysqld exe suffix
      73a680a5
    • unknown's avatar
      Bug #29325: create table overwrites .MYD file of other · a266c16d
      unknown authored
      table (datadir)
      Set errno when retunring an error in my_create_with_symlink.
      
      
      mysys/my_symlink2.c:
        Bug #29325: set errno when retunring 
        an error in my_create_with_symlink
      a266c16d
    • unknown's avatar
      BUG#28838 - duplicate external_lock in mysql_alter_table · 035b06b4
      unknown authored
      Removed duplicate call to handler::external_lock() when
      ALTER TABLE that doesn't need to copy a table (quick
      ALTER TABLE) was executed.
      
      Also quick ALTER TABLE doesn't hold LOCK_open anymore when
      it enables/disables indexes.
      
      
      sql/sql_table.cc:
        Do not call handler::external_lock() as table is already locked
        by open_ltable().
        
        Also do not hold LOCK_open mutex for alter_table_manage_keys() as
        this function doesn't require LOCK_open (LOCK_open is required by
        wait_while_table_is_used() only).
      035b06b4
    • unknown's avatar
      Mark deadcode for gcov · 06b446da
      unknown authored
      06b446da
  7. 17 Jul, 2007 7 commits